[openstreetmap/openstreetmap-website] add bulk_upload (#1995)
mmd
notifications at github.com
Fri Oct 26 16:12:07 UTC 2018
> Just to clarify this now replaces the existing upload endpoint rather than adding something in parallel right?
Yes, that's exactly right, it's a drop in replacement for the existing code, only with performance improvements. The results (and error messages) should be exactly the same as in today's version.
> Only I seem to see a lot more added code than removed code?
Bulk operations introduced a lot more complexity due to the additional packaging logic, so this makes sense.
> So don't expect me to be able to do it immediately...
That's perfectly fine, there's no hurry at all. I'm also waiting on @zerebubuth to review the corresponding cgimap implementation.
Overall, this may seem to be doubling efforts. Nevertheless, I still find it useful to also improve the Rails port by using bulk operations (similar to how the cgimap implementation works). cgimap will be faster in the end, but the difference won't be in the 100x range anymore, which is also good news for people who don't use cgimap as acceleration layer.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-433461297
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181026/eb7129b9/attachment-0001.html>
More information about the rails-dev
mailing list