[openstreetmap/openstreetmap-website] Rename diary_entry#view to diary_entry#show (#1973)

Andy Allan notifications at github.com
Wed Sep 5 07:22:16 UTC 2018


This PR renames the `DiaryEntryController#view` method to `show`, to bring it in line with resourceful routing conventions.

@Nikerabbit This PR contains translation key renaming:

* `diary_entry.view.*` becomes `diary_entry.show.*`
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1973

-- Commit Summary --

  * Rename diary_entry#view to diary_entry#show

-- File Changes --

    M app/controllers/diary_entry_controller.rb (24)
    M app/helpers/issues_helper.rb (4)
    M app/models/notifier.rb (12)
    M app/views/diary_entry/_diary_entry.html.erb (6)
    M app/views/diary_entry/comments.html.erb (2)
    M app/views/diary_entry/rss.rss.builder (6)
    R app/views/diary_entry/show.html.erb (0)
    M config/locales/en.yml (2)
    M config/routes.rb (2)
    M test/controllers/diary_entry_controller_test.rb (54)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1973.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1973.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1973
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180905/6691b816/attachment.html>


More information about the rails-dev mailing list