[openstreetmap/openstreetmap-website] Selected rubocop changes (ruby for good) (#1987)

[Andy Allan]

This PR pulls in three of the rubocop-related changes from the Ruby For Good refactoring PR (#1918). One of them was already fixed in the meantime.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1987

-- Commit Summary --

  * Resolve 96 Rubocop Lint/AmbiguousRegexpLiteral conflicts
  * Remove Lint/ShadowingOuterLocalVariable - already fixed
  * Resolve 34 Rubocop Lint/AmbiguousOperator conflicts

-- File Changes --

    M .rubocop_todo.yml (17)
    M app/helpers/notifier_helper.rb (2)
    M test/controllers/amf_controller_test.rb (62)
    M test/controllers/changeset_controller_test.rb (12)
    M test/controllers/diary_entry_controller_test.rb (4)
    M test/controllers/messages_controller_test.rb (4)
    M test/controllers/old_node_controller_test.rb (2)
    M test/controllers/redactions_controller_test.rb (2)
    M test/controllers/swf_controller_test.rb (6)
    M test/controllers/traces_controller_test.rb (2)
    M test/controllers/user_controller_test.rb (46)
    M test/integration/user_creation_test.rb (2)
    M test/lib/bounding_box_test.rb (4)
    M test/lib/country_test.rb (6)
    M test/models/changeset_test.rb (12)
    M test/models/message_test.rb (4)
    M test/models/node_test.rb (38)
    M test/models/old_node_test.rb (4)
    M test/models/relation_test.rb (22)
    M test/models/tracepoint_test.rb (4)
    M test/models/way_test.rb (22)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1987.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1987.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1987
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180909/4801922d/attachment-0001.html>