[openstreetmap/openstreetmap-website] Added /notes/mine url path (#2006)

Jamie Guthrie notifications at github.com
Wed Sep 26 16:14:46 UTC 2018


jguthrie100 commented on this pull request.



>      if params[:display_name]
       if @user = User.active.find_by(:display_name => params[:display_name])
         @params = params.permit(:display_name)
-        @title = t "notes.mine.title", :user => @user.display_name
-        @heading = t "notes.mine.heading", :user => @user.display_name
+
+        # set title/heading
+        if current_user && current_user.display_name == @user.display_name
+          @title = t "user.show.my notes"
+          @heading = t "user.show.my notes"

Just noticed that you referenced the traces page already, but for me I think its a worthwhile addition.
Throughout the whole site there are references to `My Profile` and `My Traces` and `My Settings` etc, so I'd say its only apt to apply the same to the Notes page!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2006#discussion_r220627208
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180926/fbff0f6b/attachment.html>


More information about the rails-dev mailing list