[openstreetmap/openstreetmap-website] Replace jshint with eslint (#2196)

Tom Hughes notifications at github.com
Mon Apr 1 20:41:35 UTC 2019


This PR attempts to replace jshint with eslint - as a first pass it uses a config that tries to replicate the jshint options we had enabled although eslint does seem to have a a few more things that I have cleaned up in a separate commit.

Once this is in we can think about enabling more checks - probably starting with some of those that iD is using.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2196

-- Commit Summary --

  * Replace jshint with eslint
  * Fix issues found by eslint

-- File Changes --

    M .travis.yml (2)
    M Gemfile (4)
    M Gemfile.lock (13)
    M app/assets/javascripts/index.js (12)
    M app/assets/javascripts/index/directions.js (33)
    M app/assets/javascripts/index/note.js (2)
    M app/assets/javascripts/index/search.js (4)
    M app/assets/javascripts/piwik.js (4)
    M app/assets/javascripts/richtext.js (4)
    A config/eslint.json (30)
    D config/jshint.yml (30)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2196.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2196.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2196
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190401/6ce05189/attachment.html>


More information about the rails-dev mailing list