[openstreetmap/openstreetmap-website] Animations for traces (#2132)

Andy Allan notifications at github.com
Wed Apr 3 09:07:16 UTC 2019


This is awesome, great work @mmd-osm! I checked out your branch, [made a couple of stylistic changes](https://github.com/gravitystorm/openstreetmap-website/commit/ab6d657992f89d4578ef02047cd6b43ef4d1dac7) and everything works for me. I can't spot any differences between the animations with your code versus the gpx-importer code, which is great.

However, it looks like there's a problem with the gd2 part of the code, since it fails with a single-point GPX file. We use these in the tests, and running the tests gives an error:

```bash
$ bundle exec ruby -Itest test/models/trace_test.rb 
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
Run options: --seed 30363

# Running:

.........GD Warning: one parameter to a memory allocation multiplication is negative or zero, failing operation gracefully
double free or corruption (top)
Aborted (core dumped)
```

You can see the same thing if you try uploading `test/gpx/fixtures/a.gpx` via the web front end, the webserver dies with the same warning. Could you look into this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2132#issuecomment-479405313
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190403/aa515254/attachment-0001.html>


More information about the rails-dev mailing list