[openstreetmap/openstreetmap-website] Idempotency for API 0.6 (#2201)

[Simon Poole]

> 
> 
> Yes what JOSM does is broken and they should stop doing it.
> 
While the automatic retry is bad, I have to save from an editor POV there is no good solution as invariably the link between template ids in the editor and what has actually been created in the DB is lost.

So it is one of 
- re-uploading - potentially creating duplicates in the DB
- refreshing the data in the editor - creates dupes in the editor which may be or not be noticed by the user, but which will, if uploaded, create dupes in the DB
- replace the data in the editor - potentially (if the upload wasn't actually completed) zapping all the edits by the user (this is what should be done if there was a way to check if the upload was actually successful)

IMHO the a possible minimal impact solution would be to close the changeset automatically after a successful diff upload (which boils down to allowing just one diff upload per changeset), which would allow the editor to query the status of the changeset after a "perhaps failed" upload and check the status by querying if the changeset is open. 

Or other variants of the same theme, for example an upload per changeset counter. It definitely isn't necessary to create additional complexity by adding completely new concepts to solve this.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-480503602
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190406/2529509f/attachment.html>