[openstreetmap/openstreetmap-website] APIChangesetNotSubscribedError has HTTP status code 404 (#1199)

[mmd]

> HTTP status code for APIChangesetAlreadySubscribedError is a 409 - Conflict while the status code for APIChangesetNotSubscribedError is a 404 - Not Found. This seems to be inconsistent.



I'd say this works as documented: https://wiki.openstreetmap.org/wiki/API_v0.6#Subscribe:_POST_.2Fapi.2F0.6.2Fchangeset.2F.23id.2Fsubscribe

> 404 Not Found is also returned if the changeset one wants to subscribe/unsubscribe to/from does not exist at all. This inconsistency makes it harder for clients to report to the user what is the exact problem.

If you're not sure if a changeset exists at all, you could use another API call to rule out non-existing changesets: https://wiki.openstreetmap.org/wiki/API_v0.6#Read:_GET_.2Fapi.2F0.6.2Fchangeset.2F.23id.3Finclude_discussion.3Dtrue





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1199#issuecomment-482834860
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190413/7fc20dec/attachment.html>