[openstreetmap/openstreetmap-website] Idempotency for API 0.6 (#2201)

mmd notifications at github.com
Sun Apr 21 07:11:14 UTC 2019


> my only problem with your approach is that you are rewarding doing the wrong thing and not supplying a solution for devs that don't want to go that route, forcing us to emulate JOSMs broken behaviour.

That would be a strong case for having some kind of separate API call to query the most recent upload status based on some token, or (permitting incompatible changes) allowing a single upload per changeset only, and then query the changeset status using the existing API calls.

A compromise here could be, to provide an additional option in the changeset upload message, to "auto close" a changeset, again allowing devs to decide if they want to opt in here. I'm sure that would work out pretty well for iD, as they allow a single upload per changeset anyway. Querying the changeset status upload right after the fact would be just a very natural thing to do then.

> Do we have an idea of how big this problem actually is? 

I'm with @gravitystorm here: _I'm reasonably keen to see the API become fully idempotent. Network requests / responses / connections are lost for all kinds of reasons, and are more likely to happen the worse your internet connection (mobile, rural, far from OSMF's datacentres etc)._

Maybe it's not obvious, why I'm pushing this topic at all. Changeset uploads bothered me from time to time in the past, be it that the upload took too long, or the network had some intermittent issues. It's also reports like ([this one](https://github.com/openstreetmap/iD/issues/4717#issue-290221092)), that made me think, yes we should probably do something here. 

For a better overall user experience, the overall work is split up in 3 major topics:

* Faster upload (https://github.com/openstreetmap/operations/issues/293)
* Allowing compressed uploads (https://github.com/openstreetmap/operations/issues/193)
* Idempotency (https://github.com/openstreetmap/openstreetmap-website/issues/2201)

The idea is, no matter how bad or broken your internet connectivity is, we want everyone to contribute.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-485230581
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190421/6b1ee060/attachment.html>


More information about the rails-dev mailing list