upon search (#2336) Message-ID: <openstreetmap/openstreetmap-website/issues/2336@github.com> Comparing the browser tab title of 1. https://www.google.com/maps/search/電信局前 1. https://www.openstreetmap.org/search?query=電信局前 OSM should set the HTML '<title>' too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2336 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190802/a60fe324/attachment.html> From notifications at github.com Sat Aug 3 08:25:36 2019 From: notifications at github.com (Legolash2o) Date: Sat, 03 Aug 2019 01:25:36 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) Message-ID: <openstreetmap/openstreetmap-website/issues/2337@github.com> Hi, I've installed the latest Ubuntu release (18.04) and when running the "bundle exec rake test:db", I keep getting thrown the error below for each test. I followed the guide to the letter. I did have to update gems as the "make" commands didn't work. https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md ![OSM Error](https://user-images.githubusercontent.com/34819291/62409511-8c1c4a00-b5d0-11e9-8c20-3f350c809868.png) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/cae00687/attachment.html> From notifications at github.com Sat Aug 3 08:57:10 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 01:57:10 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2337/517907849@github.com> Seems like you have a broken phantomjs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#issuecomment-517907849 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/fdcc83c4/attachment.html> From notifications at github.com Sat Aug 3 08:57:11 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 01:57:11 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2337/issue_event/2531221889@github.com> Closed #2337. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#event-2531221889 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/bc8b7ed7/attachment.html> From notifications at github.com Sat Aug 3 09:40:27 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 02:40:27 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2337/517911089@github.com> What does `phantomjs --version` say? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#issuecomment-517911089 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/d3bdd59f/attachment.html> From notifications at github.com Sat Aug 3 09:40:27 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 02:40:27 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2337/issue_event/2531237361@github.com> Reopened #2337. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#event-2531237361 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/103531a1/attachment.html> From notifications at github.com Sat Aug 3 10:32:54 2019 From: notifications at github.com (Adamant36) Date: Sat, 03 Aug 2019 03:32:54 -0700 Subject: [openstreetmap/openstreetmap-website] Save map note overlay between edits (#2338) Message-ID: <openstreetmap/openstreetmap-website/issues/2338@github.com> Although not necessary, it would save some time and a few clicks if the main site saved the state of the map note overlay when editing things in iD Editor so the overlay would still be open when exiting the editor to browse the overlay on the main page again. Otherwise, it's a hassle to reactive notes repeatedly when doing minor quick edits. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2338 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/57584b9a/attachment-0001.html> From notifications at github.com Sat Aug 3 10:54:04 2019 From: notifications at github.com (Legolash2o) Date: Sat, 03 Aug 2019 03:54:04 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2337/517915680@github.com> It wouldn't display as it could find a screen ("X") to display. I removed phantomjs and then reinstalled after running: sudo apt-get install build-essential chrpath sudo apt-get install libfreetype6 libfreetype6-dev sudo apt-get install libfontconfig1 libfontconfig1-dev phantomjs Now it works apart form a few undefined is not a function jQuery error message. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#issuecomment-517915680 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/d20ba534/attachment.html> From notifications at github.com Sat Aug 3 11:05:24 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:05:24 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2337/517916320@github.com> Ah that's because Ubuntu's phantomjs is a bit broken and is built to require X for some silly reason. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#issuecomment-517916320 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/0584047a/attachment.html> From notifications at github.com Sat Aug 3 11:05:25 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:05:25 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2337/issue_event/2531264200@github.com> Closed #2337. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#event-2531264200 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/64487583/attachment.html> From notifications at github.com Sat Aug 3 11:32:29 2019 From: notifications at github.com (Legolash2o) Date: Sat, 03 Aug 2019 04:32:29 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) Message-ID: <openstreetmap/openstreetmap-website/issues/2339@github.com> Following in from a previous issue which is now resolved. I've just installed everything on Ubuntu 18.04, following the guide. During the test I receive many "undefined is not a function" messages and mentions of jQuery. I can upload a screen later if required when I'm on my laptop. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/c625ccf6/attachment.html> From notifications at github.com Sat Aug 3 11:48:24 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:48:24 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2339/517918648@github.com> Yeah that happens sometimes but I've never managed to figure out why. It's probably a test ordering thing as it doesn't always happen but it doesn't actually seem to cause any problems. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#issuecomment-517918648 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/504ba26d/attachment.html> From notifications at github.com Sat Aug 3 11:48:24 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:48:24 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2339/issue_event/2531277681@github.com> Closed #2339. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#event-2531277681 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/ff5f71ae/attachment.html> From notifications at github.com Sat Aug 3 11:48:58 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:48:58 -0700 Subject: [openstreetmap/openstreetmap-website] Save map note overlay between edits (#2338) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2338@github.com> References: <openstreetmap/openstreetmap-website/issues/2338@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2338/issue_event/2531277819@github.com> Closed #2338. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2338#event-2531277819 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/d3d66437/attachment-0001.html> From notifications at github.com Sat Aug 3 11:48:58 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:48:58 -0700 Subject: [openstreetmap/openstreetmap-website] Save map note overlay between edits (#2338) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2338@github.com> References: <openstreetmap/openstreetmap-website/issues/2338@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2338/517918668@github.com> Issues with iD need to be reported at https://github.com/openstreetmap/iD/issues not here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2338#issuecomment-517918668 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/9ec3c669/attachment.html> From notifications at github.com Sat Aug 3 12:22:27 2019 From: notifications at github.com (Adamant36) Date: Sat, 03 Aug 2019 05:22:27 -0700 Subject: [openstreetmap/openstreetmap-website] Save map note overlay between edits (#2338) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2338@github.com> References: <openstreetmap/openstreetmap-website/issues/2338@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2338/517920682@github.com> My bad. I figured because the note system is activated before entering iD Editor and is reset on the styles side, instead of inside of iD Editor, that it would be a main site thing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2338#issuecomment-517920682 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/782f883e/attachment.html> From notifications at github.com Sat Aug 3 13:19:47 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 06:19:47 -0700 Subject: [openstreetmap/openstreetmap-website] Save map note overlay between edits (#2338) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2338@github.com> References: <openstreetmap/openstreetmap-website/issues/2338@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2338/517924220@github.com> Well maybe I have misunderstood what you mean? Are you talking about the notes layer on the main site? That is normally pretty sticky for me - usually I have the opposite problem and I'm constantly having to turn it off! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2338#issuecomment-517924220 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/1d06aa56/attachment.html> From notifications at github.com Sun Aug 4 05:38:46 2019 From: notifications at github.com (Legolash2o) Date: Sat, 03 Aug 2019 22:38:46 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2339/517975631@github.com> It seems to be from the same file and method. I've attached a screenshot anyway. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#issuecomment-517975631 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/2467edb7/attachment.html> From notifications at github.com Sun Aug 4 14:36:15 2019 From: notifications at github.com (Legolash2o) Date: Sun, 04 Aug 2019 07:36:15 -0700 Subject: [openstreetmap/openstreetmap-website] Pages not loading (#2340) Message-ID: <openstreetmap/openstreetmap-website/issues/2340@github.com> I've finally managed to get it so that is passes the rake tests but when I browse to IPAddress:3000, the console shows that it has received and "rendered" a request but the browser window is spinning. Could this be caused because I have not populated the database yet? It's installed on a Ubuntu 18.04 server. I use: bundle exec rails server -b 0.0.0.0 ![OSM Not loading](https://user-images.githubusercontent.com/34819291/62424936-4ee9b200-b6cd-11e9-973e-123f1a02e868.png) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2340 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/65fa0222/attachment.html> From notifications at github.com Sun Aug 4 14:43:39 2019 From: notifications at github.com (Legolash2o) Date: Sun, 04 Aug 2019 07:43:39 -0700 Subject: [openstreetmap/openstreetmap-website] Pages not loading (#2340) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2340@github.com> References: <openstreetmap/openstreetmap-website/issues/2340@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2340/518009308@github.com> Turns out the first request is very very slow. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2340#issuecomment-518009308 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/88bb2461/attachment.html> From notifications at github.com Sun Aug 4 14:43:40 2019 From: notifications at github.com (Legolash2o) Date: Sun, 04 Aug 2019 07:43:40 -0700 Subject: [openstreetmap/openstreetmap-website] Pages not loading (#2340) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2340@github.com> References: <openstreetmap/openstreetmap-website/issues/2340@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2340/issue_event/2531804511@github.com> Closed #2340. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2340#event-2531804511 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/03ce8926/attachment.html> From notifications at github.com Mon Aug 5 00:36:25 2019 From: notifications at github.com (SuperFlomm) Date: Sun, 04 Aug 2019 17:36:25 -0700 Subject: [openstreetmap/openstreetmap-website] Road with covered tag not rendered as underground (#2341) Message-ID: <openstreetmap/openstreetmap-website/issues/2341@github.com> Greetings, there is a road that has the covered=arcade tag: https://www.openstreetmap.org/way/179451263 https://www.openstreetmap.org/way/702472365 However it does not render as an underground road. I tried to fix this by using the location=underground tag and connecting the road to the grass on top. This didn't work either. It might work if I use tunnel=avalanche_protector instead, but that would technically be wrong as [there is literally a sign that calls it an arcade](https://images.mapillary.com/XmytaDZAb_9jBAB8ufWzlw/thumb-2048.jpg) (Galerie in German) and there are no avalanches to protect from. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2341 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/2ddf1050/attachment.html> From notifications at github.com Mon Aug 5 05:43:42 2019 From: notifications at github.com (mmd) Date: Sun, 04 Aug 2019 22:43:42 -0700 Subject: [openstreetmap/openstreetmap-website] Road with covered tag not rendered as underground (#2341) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2341@github.com> References: <openstreetmap/openstreetmap-website/issues/2341@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2341/518093661@github.com> You're reporting this in the wrong repo. OSM Carto style which is handling the tile rendering rules is being discussed here: https://github.com/gravitystorm/openstreetmap-carto -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2341#issuecomment-518093661 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/c892e6ed/attachment.html> From notifications at github.com Mon Aug 5 06:03:48 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 04 Aug 2019 23:03:48 -0700 Subject: [openstreetmap/openstreetmap-website] Road with covered tag not rendered as underground (#2341) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2341@github.com> References: <openstreetmap/openstreetmap-website/issues/2341@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2341/issue_event/2532391444@github.com> Closed #2341. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2341#event-2532391444 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/30242ac1/attachment-0001.html> From notifications at github.com Mon Aug 5 07:06:51 2019 From: notifications at github.com (Sven Lohrmann) Date: Mon, 05 Aug 2019 00:06:51 -0700 Subject: [openstreetmap/openstreetmap-website] Unfortunate use of screen estate on mobile (#2035) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2035@github.com> References: <openstreetmap/openstreetmap-website/issues/2035@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2035/518113283@github.com> Any plans to make openstreetmap usable on mobile devices? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2035#issuecomment-518113283 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/86575b64/attachment.html> From notifications at github.com Mon Aug 5 08:22:20 2019 From: notifications at github.com (Andy Allan) Date: Mon, 05 Aug 2019 01:22:20 -0700 Subject: [openstreetmap/openstreetmap-website] Unfortunate use of screen estate on mobile (#2035) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2035@github.com> References: <openstreetmap/openstreetmap-website/issues/2035@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2035/518136267@github.com> > Any plans to make openstreetmap usable on mobile devices? @malnvenshorn Please be careful with the way that you phrase your question, since it comes across as a bit rude. The site is already usable on mobile devices, but of course it could be better too. We're a very small group of volunteer developers, and so many issues will wait for a long time. Asking curt questions doesn't make it happen any faster and doesn't help encourage other people to join in. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2035#issuecomment-518136267 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/14dc5ed4/attachment.html> From notifications at github.com Mon Aug 5 08:58:07 2019 From: notifications at github.com (Sven Lohrmann) Date: Mon, 05 Aug 2019 01:58:07 -0700 Subject: [openstreetmap/openstreetmap-website] Unfortunate use of screen estate on mobile (#2035) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2035@github.com> References: <openstreetmap/openstreetmap-website/issues/2035@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2035/518148315@github.com> My question wasn't meant to be rude, but because there was no feedback I took the liberty to ask. Sorry for that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2035#issuecomment-518148315 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/a5d88d56/attachment.html> From notifications at github.com Mon Aug 5 09:03:17 2019 From: notifications at github.com (Andy Allan) Date: Mon, 05 Aug 2019 02:03:17 -0700 Subject: [openstreetmap/openstreetmap-website] Unfortunate use of screen estate on mobile (#2035) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2035@github.com> References: <openstreetmap/openstreetmap-website/issues/2035@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2035/518150237@github.com> @malnvenshorn no worries. If you want to get started with learning how the code base works and potentially even working on this topic yourself, please let us know! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2035#issuecomment-518150237 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/60653160/attachment.html> From notifications at github.com Mon Aug 5 09:33:52 2019 From: notifications at github.com (Sven Lohrmann) Date: Mon, 05 Aug 2019 02:33:52 -0700 Subject: [openstreetmap/openstreetmap-website] Unfortunate use of screen estate on mobile (#2035) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2035@github.com> References: <openstreetmap/openstreetmap-website/issues/2035@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2035/518160881@github.com> I'd like to but I have no experience with Ruby/Rails and to many other projects I'm working on to find time to get familiar with the project and used frameworks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2035#issuecomment-518160881 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/b5145569/attachment.html> From notifications at github.com Mon Aug 5 12:30:59 2019 From: notifications at github.com (dieterdreist) Date: Mon, 05 Aug 2019 05:30:59 -0700 Subject: [openstreetmap/openstreetmap-website] Road with covered tag not rendered as underground (#2341) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2341@github.com> References: <openstreetmap/openstreetmap-website/issues/2341@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2341/518214652@github.com> sent from a phone > On 5. Aug 2019, at 02:36, SuperFlomm <notifications at github.com> wrote: > > there is literally a sign that calls it an arcade (Galerie in German) regardless this is the wrong place for the question, it is also factually wrong, an arcade in German is called Arkade or Bogengang and should generally have “arcs” (Bögen), i.e. its typically vaulted (gewölbt) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2341#issuecomment-518214652 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/5ee84438/attachment.html> From notifications at github.com Mon Aug 5 19:11:43 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 05 Aug 2019 12:11:43 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2339/issue_event/2534509671@github.com> Reopened #2339. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#event-2534509671 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/f1a89da5/attachment.html> From notifications at github.com Mon Aug 5 19:20:17 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 05 Aug 2019 12:20:17 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2339/518364389@github.com> I think what has happened is that a recent update to the bowser gem has changed the feature detection in some way... so it is causing noise when an ES6 method is used because phantomjs doesn't support it but we haven't loaded the polyfill. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#issuecomment-518364389 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/a4fa0276/attachment.html> From notifications at github.com Mon Aug 5 19:45:34 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 05 Aug 2019 12:45:34 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2339/issue_event/2534589667@github.com> Closed #2339 via 754e566f454f8083e6baebdcc9eebc06e7cda333. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#event-2534589667 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/43127496/attachment.html> From notifications at github.com Tue Aug 6 08:19:15 2019 From: notifications at github.com (Frederik Ramm) Date: Tue, 06 Aug 2019 01:19:15 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) Message-ID: <openstreetmap/openstreetmap-website/issues/2342@github.com> It regularly happens that people - usually, but not always new signups - upload hundreds of thousands of objects to OSM before someone notices and tells them to stop. Then we have to delete those hundreds of thousands of objects again. (Case in point from recent past, https://www.openstreetmap.org/user/maxiangying.) This is undesirable: * it skews statistics ("wow, today was the day with the most edits since OSM started!!!" etc) * it wastes processing time and bandwidth on the thousands of servers world wide that are configured to consume updates from OSM * it wastes the time of volunteers who have to remove the edits * it embarrasses the person who uploaded the data (at least I hope it does) While editors can, and should, inform their users about potential issues, I think it would also be worth contemplating to have some sort of rate limit on the API. It could be something that users can override but not accidentally - for example, you could be normally limited to X edits per day (exact numbers t.b.d.) and then you could click a button in your user preferences that says "I have read the data import and mechanical edit guidelines and I want to lift the limitation for one week" or so. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/aed03524/attachment.html> From notifications at github.com Tue Aug 6 08:34:29 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 06 Aug 2019 01:34:29 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518569316@github.com> The production API is in the cgimap repository, not here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518569316 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/51a52c08/attachment-0001.html> From notifications at github.com Tue Aug 6 08:39:50 2019 From: notifications at github.com (Frederik Ramm) Date: Tue, 06 Aug 2019 01:39:50 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518571346@github.com> Closed in favour of https://github.com/zerebubuth/openstreetmap-cgimap/issues/207 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518571346 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/4180a0fb/attachment.html> From notifications at github.com Tue Aug 6 08:39:50 2019 From: notifications at github.com (Frederik Ramm) Date: Tue, 06 Aug 2019 01:39:50 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2342/issue_event/2535943308@github.com> Closed #2342. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#event-2535943308 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/2b4ff5f1/attachment.html> From notifications at github.com Tue Aug 6 08:40:43 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 06 Aug 2019 01:40:43 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518571712@github.com> >From a practical point of view you need to define "edit" somehow - the obvious answer is changesets but that can be easily gamed so it will presumably need to be the number of objects added/changed/deleted. Doing it per day is probably excessively expensive from an implementation standpoint because it requires resetting counters at some point, or keeping say hourly counts and expiring those over a day old. A token bucket type algorithm like the download limit probably makes more sense. >From a personal point of view I dread dealing with the resulting complaints... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518571712 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/e4239678/attachment.html> From notifications at github.com Tue Aug 6 08:47:20 2019 From: notifications at github.com (Simon Poole) Date: Tue, 06 Aug 2019 01:47:20 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518574401@github.com> Actually I think the issue should remain here :-). At least the obvious, how stupid me would do it, implementation would involve automatically creating a block once the limit has been exceeded (because all the bits and pieces are already there and we don't want to create a slightly different implementation of the same thing). I believe this would address @tomhughes concerns to as the messaging can be clear what to do to be unblocked (OK I believe we still have the issue with iD borking when an account has been blocked but iD users are unlikely to run in to this anyway). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518574401 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/45f1fc06/attachment.html> From notifications at github.com Tue Aug 6 09:01:50 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 06 Aug 2019 02:01:50 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518580151@github.com> It doesn't matter how clear you make the messaging, you will get people pleading for themselves to be special cased because, you know, PEOPLE MIGHT DIE. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518580151 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/6eca9ad6/attachment.html> From notifications at github.com Tue Aug 6 13:13:05 2019 From: notifications at github.com (mmd) Date: Tue, 06 Aug 2019 06:13:05 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518663368@github.com> Just to add a bit of detail here, we already have rate limiting on the changeset upload call on cgimap, which is currently based on the number of bytes returnes by the call (like it is done for the /map call). Once you hit the limit, the upload would be rejected via HTTP 509 Bandwidth Limit Exceeded. It's not a permanent block either, so it wouldn't place too much of a burden on sysadmins. Admittedly, looking at the number of bytes is not effective by any means to stop the users mentioned here (main reason being that the diffResult message usually comes with a rather tiny amount of bytes compared to a /map call). ;aybe we could evolve this approach by defining some more meaningful criteria. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518663368 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/48049443/attachment.html> From notifications at github.com Tue Aug 6 13:33:14 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 06 Aug 2019 06:33:14 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518671169@github.com> What I was proposing was some sort of equivalent limit on the upload side, whether that's just bytes uploaded, or number of objects changed. But implemented in basically the same way. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518671169 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/c73fea67/attachment.html> From notifications at github.com Tue Aug 6 13:39:37 2019 From: notifications at github.com (Andy Allan) Date: Tue, 06 Aug 2019 06:39:37 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518673673@github.com> > we already have rate limiting on the changeset upload call on cgimap Where does cgimap store the rate limit status? Is it in the database somewhere, or does each instance of cgimap (i.e. on different backend servers) keep track of the rates separately? > The production API is in the cgimap repository, not here. I think it's worth discussing it here too, particularly if we want to ensure clear messaging to the user when they go over any quota. > From a personal point of view I dread dealing with the resulting complaints... So let's make sure the complaints go to someone else! I think it would be something for DWG to deal with, rather than the sysadmin group. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518673673 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/7f8d0d9f/attachment.html> From notifications at github.com Tue Aug 6 13:41:25 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 06 Aug 2019 06:41:25 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518674403@github.com> They're stored in memcache, so shared across instances but can be lost if a memcache server restarts. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518674403 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/696b712c/attachment.html> From notifications at github.com Tue Aug 6 20:01:37 2019 From: notifications at github.com (mmd) Date: Tue, 06 Aug 2019 13:01:37 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518821706@github.com> > I think it's worth discussing it here too, particularly if we want to ensure clear messaging to the user when they go over any quota. For a clear messaging we'd need something better than _You have downloaded too much data. Please try again later._ with comes with an _HTTP 509 Bandwidth Limit Exceeded_ error response. Also, both downloads and uploads currently share the same user-based key in memcache. A user downloading lots of data might be impacted when trying to upload some changes (and vice versa). I don't know if this is good idea. On the other hand, if memcache memory permits, we might as well introduce a dedicated key only used for changeset upload tracking. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518821706 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/ac7584b4/attachment.html> From notifications at github.com Tue Aug 6 20:16:23 2019 From: notifications at github.com (mmd) Date: Tue, 06 Aug 2019 13:16:23 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518826863@github.com> > It could be something that users can override but not accidentally - for example, you could be normally limited to X edits per day (exact numbers t.b.d.) and then you could click a button in your user preferences that says "I have read the data import and mechanical edit guidelines and I want to lift the limitation for one week" or so. I still don't have a clear picture what makes sense here. Checking the users table for some timestamp when rate limiting restrictions would be back to normal, isn't impossible to implement. Pretty much the same applies to the user registration date or number of changesets as additional decision criteria. It's mostly a matter of how a meaningful policy could look like, and also this requires some consensus building in the community. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518826863 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/3b7103a2/attachment-0001.html> From notifications at github.com Tue Aug 6 21:05:12 2019 From: notifications at github.com (Frederik Ramm) Date: Tue, 06 Aug 2019 14:05:12 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518843797@github.com> It is certainly good to air the idea with the community a bit, though when it comes to it, I would prefer to implement a technologically viable mechanism (that doesn't make the source more complex than necessary and doesn't waste to many resources when executed) and then have the community participate in parametrising that, rather than attempt to find consensus on how exactly something should be implemented. We're not writing a bill of rights here; I think it will be easy to find consensus on the bare outline that I specified initially (make it so that we can't have someone sign up and upload 200k buildings in two days before anybody even notices), and anything more detailed could well be entrusted to those who actually write code ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518843797 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/5bdce6ea/attachment.html> From notifications at github.com Wed Aug 7 14:58:18 2019 From: notifications at github.com (YuriiNskyi) Date: Wed, 07 Aug 2019 07:58:18 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) Message-ID: <openstreetmap/openstreetmap-website/issues/2343@github.com> I'm trying to run my own `openstreetmap-website` on `Ubuntu 18.04 LTS` system. Here are the commands to reproduce an issue: ``` sudo apt-get update sudo apt-get -y install git sudo apt-get -y install virtualbox sudo apt-get -y install vagrant git clone https://github.com/openstreetmap/openstreetmap-website.git cd openstreetmap-website/ vagrant up ``` A problem with `example.application.yml` file occurs here - it is required while it is not provided. This is OK and file from [here](https://github.com/SEL-Columbia/osm-devops/blob/master/example.application.yml) is perfectly valid. Let's again try `vagrant up`. Here's the new error: ``` default: /srv/openstreetmap-website /home/vagrant default: rake aborted! default: Gem::LoadError: You have already activated rake 12.3.3, but your Gemfile requires rake 12.3.2. Prepending `bundle exec` to your command may solve this. default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:313:in `check_for_activated_spec!' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:31:in `block in setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:26:in `map' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:26:in `setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler.rb:107:in `setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/setup.rb:20:in `<top (required)>' default: /srv/openstreetmap-website/config/boot.rb:3:in `<top (required)>' default: /srv/openstreetmap-website/config/application.rb:1:in `require_relative' default: /srv/openstreetmap-website/config/application.rb:1:in `<top (required)>' default: /srv/openstreetmap-website/Rakefile:4:in `require_relative' default: /srv/openstreetmap-website/Rakefile:4:in `<top (required)>' default: /var/lib/gems/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>' default: default: Caused by: default: LoadError: cannot load such file -- bundler/setup default: /srv/openstreetmap-website/config/boot.rb:3:in `<top (required)>' default: /srv/openstreetmap-website/config/application.rb:1:in `require_relative' default: /srv/openstreetmap-website/config/application.rb:1:in `<top (required)>' default: /srv/openstreetmap-website/Rakefile:4:in `require_relative' default: /srv/openstreetmap-website/Rakefile:4:in `<top (required)>' default: /var/lib/gems/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>' default: (See full trace by running task with --trace) ``` I did nothing to activate rake 12.3.3 previously and I don't even bother what is it, but it is OK, we can successfully enter Vagrant virtual machine with the help of `vagrant ssh` command. Finally, we are executing `bundler exec rails server` using SSH and get the following error: ``` Traceback (most recent call last): 52: from bin/rails:4:in `<main>' 51: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require' 50: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency' 49: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require' 48: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require' 47: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi' 46: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register' 45: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi' 44: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require' 43: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/commands.rb:18:in `<top (required)>' 42: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/command.rb:46:in `invoke' 41: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/command/base.rb:65:in `perform' 40: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch' 39: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command' 38: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run' 37: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/commands/server/server_command.rb:142:in `perform' 36: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/commands/server/server_command.rb:142:in `tap' 35: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/commands/server/server_command.rb:145:in `block in perform' 34: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require' 33: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency' 32: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require' 31: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require' 30: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi' 29: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register' 28: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi' 27: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require' 26: from /srv/openstreetmap-website/config/application.rb:19:in `<top (required)>' 25: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler.rb:114:in `require' 24: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:65:in `require' 23: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:65:in `each' 22: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:76:in `block in require' 21: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:76:in `each' 20: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:81:in `block (2 levels) in require' 19: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require' 18: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi' 17: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register' 16: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi' 15: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require' 14: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-libarchive-0.4.10/lib/ffi-libarchive.rb:55:in `<top (required)>' 13: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require' 12: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency' 11: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require' 10: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require' 9: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi' 8: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register' 7: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi' 6: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require' 5: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-libarchive-0.4.10/lib/ffi-libarchive/archive.rb:3:in `<top (required)>' 4: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-libarchive-0.4.10/lib/ffi-libarchive/archive.rb:4:in `<module:Archive>' 3: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-libarchive-0.4.10/lib/ffi-libarchive/archive.rb:11:in `<module:C>' 2: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-1.11.1/lib/ffi/library.rb:99:in `ffi_lib' 1: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-1.11.1/lib/ffi/library.rb:99:in `map' /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-1.11.1/lib/ffi/library.rb:145:in `block in ffi_lib': Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (LoadError) Could not open library 'libarchive.13': libarchive.13: cannot open shared object file: No such file or directory. Could not open library 'libarchive.13.so': libarchive.13.so: cannot open shared object file: No such file or directory. Could not open library 'libarchive-13': libarchive-13: cannot open shared object file: No such file or directory. Could not open library 'libarchive-13.so': libarchive-13.so: cannot open shared object file: No such file or directory. Could not open library 'libarchive.so': libarchive.so: cannot open shared object file: No such file or directory. Could not open library 'libarchive': libarchive: cannot open shared object file: No such file or directory. Could not open library 'archive': archive: cannot open shared object file: No such file or directory ``` I have only two questions. 1. Why it is so hard to simply run my own `openstreetmap-website` ? 2. How can I solve this error? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/a4a99427/attachment.html> From notifications at github.com Wed Aug 7 15:25:28 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 08:25:28 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519146893@github.com> It's hard because you've tried to use vagrant and that is not maintained at all and is well out of date. Just follow the instructions in INSTALL.md instead. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519146893 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/5a2c9c75/attachment-0001.html> From notifications at github.com Wed Aug 7 15:25:29 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 08:25:29 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2343/issue_event/2540489773@github.com> Closed #2343. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#event-2540489773 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/f72cf2e6/attachment.html> From notifications at github.com Wed Aug 7 15:47:57 2019 From: notifications at github.com (Andy Allan) Date: Wed, 07 Aug 2019 08:47:57 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519156187@github.com> @tomhughes could you please try to be a bit more welcoming when new developers try to get started with our project! Also, we agreed before that we will provide support to developers who try to get the codebase up and running, up to the point that the tests pass on their system (but excluding non-standard db configurations). You don't need to provide this support, I volunteered to do so and I'm still happy to do so. Feel free to tag such issues with the "support" tag and let other people deal with them. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519156187 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/0cbf97fa/attachment.html> From notifications at github.com Wed Aug 7 15:47:58 2019 From: notifications at github.com (Andy Allan) Date: Wed, 07 Aug 2019 08:47:58 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2343/issue_event/2540564532@github.com> Reopened #2343. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#event-2540564532 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/62df7f15/attachment.html> From notifications at github.com Wed Aug 7 15:50:16 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 08:50:16 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519157122@github.com> Well there is no useful support to give here other than not to use the vagrant method - there is no support we can give which will make it work. Now a bug ticket asking for the Vagrantfile to be fixed would be reasonable except that we will fix it and it will just get broken again next week - while it is not being actively used or tested on a weekly basis it is just going to continuously bitrot. The same goes for the Dockerfile. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519157122 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/f0e49012/attachment.html> From notifications at github.com Wed Aug 7 16:07:34 2019 From: notifications at github.com (Andy Allan) Date: Wed, 07 Aug 2019 09:07:34 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519164044@github.com> > Well there is no useful support to give here other than not to use the vagrant method - there is no support we can give which will make it work. This is simply not true. We can provide support by fixing the obvious problems with the vagrant setup scripts. If one person has reported them broken, I'm sure others have tried and given up without alerting us. > Now a bug ticket asking for the Vagrantfile to be fixed would be reasonable You could consider this as such a bug, since it's obvious to you and me what needs to be changed in the vagrant scripts to get it working again. But you just closed the ticket, and I'm glad that I spotted the notification and reopened it since it's an issue where something is broken and needs fixing. > it will just get broken again next week It's not outwith the realms of the possible to deal with this, as I know you know. So please don't declare everything as hopeless. I'm no big fan of the vagrant scripts, but if it helps new developers get started then I'll put in the effort to make it work. But like I said before, if you don't want to do this stuff that's fine, just please leave the support issues alone for other people to deal with. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519164044 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/a84ff0e0/attachment.html> From notifications at github.com Wed Aug 7 16:13:56 2019 From: notifications at github.com (Andy Allan) Date: Wed, 07 Aug 2019 09:13:56 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519166452@github.com> @YuriiNskyi thanks for the bug report and sorry that you've been having these problems. As you might have gathered from the previous comments in this thread, the vagrant scripts are not yet part of our CI system, so when we make substantial changes to the setup or dependencies, they are sometimes broken without us noticing. The `example.application.yml` is a case in point, we changed the way our settings work and this file no longer exists. We'll updated the vagrant scripts accordingly. I don't know exactly why the libarchive errors are occuring, but I can investigate further for you in a few days. In the meantime I would guess that `apt install libarchive13` could be worth trying. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519166452 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/e8f0f469/attachment-0001.html> From notifications at github.com Wed Aug 7 16:17:30 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:17:30 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519167850@github.com> So I think we have different definitions of support which is leading to confusion. I view support as providing advice on how to fix something and anything which requires making a change to the repository as being a bug report. Unfortunately while that is generally possible for manual installations, by providing instructions on how to workaround anything that is missing from the instructions, it isn't generally possible for vagrant or docker because there is no way to manually intervene to workaround any errors. I was genuinely attempting to provide support here by advising not to use the vagrant method, which is why I closed it, but I should probably have turned the ticket into a bug report instead. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519167850 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/2aa22793/attachment.html> From notifications at github.com Wed Aug 7 16:18:26 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:18:26 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519168217@github.com> The libarchive will be because the vagrant script hasn't installed `libarchive-dev` I imagine. There's probably other dependencies missing as well as I don't think it's been touched for some time. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519168217 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/eca3da38/attachment.html> From notifications at github.com Wed Aug 7 16:21:28 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:21:28 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installtions are unmaintained (#2344) Message-ID: <openstreetmap/openstreetmap-website/issues/2344@github.com> Bother vagrant and docker installations suffer from constant bitrot where we add new dependencies or change configuration files but don't update the relevant setup scripts. Unfortunately we have no way of detecting this until some unfortunate end user tries to use them because none of the main developers uses them. We either need to find a way of testing them (is that even possible in travis? or is there some other way) or we need to admit defeat and remove them. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/35df15c7/attachment.html> From notifications at github.com Wed Aug 7 16:22:18 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:22:18 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519169677@github.com> I've opened #2344 to discuss how we can better maintain vagrant and docker support. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519169677 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/cbdbc2d9/attachment.html> From notifications at github.com Wed Aug 7 16:28:10 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:28:10 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2343/issue_event/2540686593@github.com> Closed #2343 via 4efe7cdc109013fa77d3e5356454d305a3726335. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#event-2540686593 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/b6148b8c/attachment.html> From notifications at github.com Wed Aug 7 16:28:35 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:28:35 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519172123@github.com> Hopefully 4efe7cdc109013fa77d3e5356454d305a3726335 will have fixed this although I don't have a working vagrant setup to test it at the moment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519172123 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/4dcf0750/attachment-0001.html> From notifications at github.com Wed Aug 7 16:30:55 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:30:55 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installations are unmaintained (#2344) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2344@github.com> References: <openstreetmap/openstreetmap-website/issues/2344@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2344/519172981@github.com> So vagrant can't be done in travis apparently (https://github.com/travis-ci/travis-ci/issues/6060) so we can forget that at least. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomment-519172981 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/5bb1ccfd/attachment.html> From notifications at github.com Thu Aug 8 06:53:59 2019 From: notifications at github.com (YuriiNskyi) Date: Wed, 07 Aug 2019 23:53:59 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519392092@github.com> @tomhughes @gravitystorm First of all, I really appreciate your help! After executing `apt install libarchive13` and `bundle exec rake test:db`, meanwhile solving this error: > The config/application.yml file is no longer supported. Default settings are now found in config/settings.yml and you can override these in config/settings.local.yml. To prevent unexpected behaviour, please copy any custom settings to config/settings.local.yml and then remove your config/application.yml file. it's finally works while executing `bundle exec rails server`. Hurray! Honestly, I did setup with Vagrantfile half a year ago, so I thought that everything should works as usual today. But unfortunately, times have changed. It is absolutely normal that Vagrantfile doesn't have support, what is really confusing, is that I can't find any clear mention about that in [INSTALL.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md) or [VAGRANT.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/VAGRANT.md). If I knew that Vagrantfile is not supported, I would not even try to use it! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519392092 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/38e231dc/attachment.html> From notifications at github.com Thu Aug 8 07:28:48 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 00:28:48 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519402582@github.com> I'd be interested to know if a `vagrant up` from a clean start now works as I never did manage to get my vagrant environment working last night... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519402582 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/9e85d0da/attachment.html> From notifications at github.com Thu Aug 8 07:58:05 2019 From: notifications at github.com (mmd) Date: Thu, 08 Aug 2019 00:58:05 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519411866@github.com> > then you could click a button in your user preferences that says "I have read the data import and mechanical edit guidelines and I want to lift the limitation for one week" or so. You could argue that large scale imports come with some kind of responsibility, perhaps even require a commitment to the project. Instead of people clicking on a button, you might be thinking about whether this is something where an OSMF membership status could come into play. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519411866 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/081b66da/attachment.html> From notifications at github.com Thu Aug 8 08:22:06 2019 From: notifications at github.com (YuriiNskyi) Date: Thu, 08 Aug 2019 01:22:06 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519419880@github.com> @tomhughes It works now, but unfortunately not perfect at all. After executing `vagrant up`, it is still the same error: >default: rake aborted! default: Gem::LoadError: You have already activated rake 12.3.3, but your Gemfile requires rake 12.3.2. Prepending `bundle exec` to your command may solve this. default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:313:in `check_for_activated_spec!' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:31:in `block in setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:26:in `map' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:26:in `setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler.rb:107:in `setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/setup.rb:20:in `<top (required)>' default: /srv/openstreetmap-website/config/boot.rb:3:in `<top (required)>' default: /srv/openstreetmap-website/config/application.rb:1:in `require_relative' default: /srv/openstreetmap-website/config/application.rb:1:in `<top (required)>' default: /srv/openstreetmap-website/Rakefile:4:in `require_relative' default: /srv/openstreetmap-website/Rakefile:4:in `<top (required)>' default: /var/lib/gems/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>' default: default: Caused by: default: LoadError: cannot load such file -- bundler/setup default: /srv/openstreetmap-website/config/boot.rb:3:in `<top (required)>' default: /srv/openstreetmap-website/config/application.rb:1:in `require_relative' default: /srv/openstreetmap-website/config/application.rb:1:in `<top (required)>' default: /srv/openstreetmap-website/Rakefile:4:in `require_relative' default: /srv/openstreetmap-website/Rakefile:4:in `<top (required)>' default: /var/lib/gems/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>' default: (See full trace by running task with --trace) #<Thread:0x00005651cfc02ca0@/usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/batch_action.rb:71 run> terminated with exception (report_on_exception is true): Traceback (most recent call last): 92: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/batch_action.rb:82:in `block (2 levels) in run' 91: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/machine.rb:188:in `action' 90: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/machine.rb:188:in `call' 89: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/environment.rb:592:in `lock' 88: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/machine.rb:202:in `block in action' 87: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/machine.rb:227:in `action_raw' 86: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 85: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 84: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 83: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 82: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 81: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/check_virtualbox.rb:17:in `call' 80: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 79: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/call.rb:53:in `call' 78: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 77: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 76: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 75: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 74: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 73: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 72: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 71: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 70: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 69: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/config_validate.rb:25:in `call' 68: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 67: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/call.rb:53:in `call' 66: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 65: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 64: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 63: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 62: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 61: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 60: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 59: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 58: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 57: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/check_virtualbox.rb:17:in `call' 56: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 55: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/config_validate.rb:25:in `call' 54: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 53: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/box_check_outdated.rb:79:in `call' 52: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 51: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/call.rb:53:in `call' 50: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 49: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 48: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 47: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 46: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 45: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 44: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 43: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/call.rb:53:in `call' 42: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 41: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 40: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 39: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 38: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 37: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 36: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 35: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/call.rb:53:in `call' 34: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 33: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 32: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 31: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 30: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 29: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 28: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 27: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/check_accessible.rb:18:in `call' 26: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 25: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/clean_machine_folder.rb:17:in `call' 24: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 23: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/set_name.rb:19:in `call' 22: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 21: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/clear_forwarded_ports.rb:15:in `call' 20: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 19: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/provision.rb:103:in `call' 18: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/provision.rb:103:in `each' 17: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/provision.rb:126:in `block in call' 16: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/provision.rb:126:in `call' 15: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/environment.rb:504:in `hook' 14: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 13: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 12: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 11: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 10: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 9: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 8: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `call' 7: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/provision.rb:138:in `run_provisioner' 6: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:27:in `provision' 5: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:61:in `provision_ssh' 4: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:287:in `with_script_file' 3: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:63:in `block in provision_ssh' 2: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:63:in `tap' 1: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:89:in `block (2 levels) in provision_ssh' /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/communicators/ssh/communicator.rb:257:in `execute': The SSH command responded with a non-zero exit status. Vagrant (Vagrant::Errors::VagrantError) assumes that this means the command failed. The output for this command should be in the log above. Please read the output to determine what went wrong. The SSH command responded with a non-zero exit status. Vagrant assumes that this means the command failed. The output for this command should be in the log above. Please read the output to determine what went wrong. It is non-critical and after executing `vagrant ssh` in separate terminal, migrating database and starting the server, here's the new error: >couldn't find file 'settings.local.yml' This is non-critical too and could be simply resolved with `cp config/settings.yml config/settings.local.yml` command. Finally, the site works. So yes, partially `vagrant up` from a clean start works. There are still some specific errors trying to confuse a user. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519419880 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/ed7e85c2/attachment-0001.html> From notifications at github.com Thu Aug 8 08:51:14 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 01:51:14 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519430142@github.com> Ah yes that's a known issue... It shouldn't really be needed but sprockets doesn't support conditional dependencies :-( I think dc5cdebc29927933a815a9c65cc8dd2116f87b31 should fix it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519430142 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/e14b5cd5/attachment.html> From notifications at github.com Thu Aug 8 09:04:29 2019 From: notifications at github.com (YuriiNskyi) Date: Thu, 08 Aug 2019 02:04:29 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) Message-ID: <openstreetmap/openstreetmap-website/issues/2345@github.com> I'm trying to install `openstreetmap-website` on clean `Ubuntu 18.04 LTS`. After spending some time on solving [this issue](https://github.com/openstreetmap/openstreetmap-website/issues/2295), by executing these commands: ``` sudo apt-get -y install npm sudo npm install yarn -g ``` here are the new problems: First has occurred when executing `bundle install`: >Traceback (most recent call last): 1: from /usr/local/bin/bundle:23:in `<main>' /usr/local/bin/bundle:23:in `load': cannot load such file -- /usr/share/rubygems-integration/all/gems/bundler-1.16.1/exe/bundle (LoadError) After googling, this problem is simply resolves: ``` sudo gem update --system sudo gem uninstall bundler sudo gem install bundle ``` The next steps works as needed, until we stops at `bundle exec rails server`: > couldn't find file 'settings.local.yml' This is happily resolved by executing `cp config/settings.yml config/settings.local.yml`. Finally, the site works. There are multiple proposed solutions: 1. Add section with Yarn installation into [INSTALL.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md). 2. Do something with bundler (it's up to you, I'm not a professional Ruby developer) 3. Do not require `settings.local.yml` file as, I think, it is only needed to override `settings.yml`. What if I don't need any overrides and totally agreed with default one? 4. Do something with these errors, while running the server: >pngcrush worker: `pngcrush` not found; please provide proper binary or disable this worker (--no-pngcrush argument or `:pngcrush => false` through options) advpng worker: `advpng` not found; please provide proper binary or disable this worker (--no-advpng argument or `:advpng => false` through options) optipng worker: `optipng` not found; please provide proper binary or disable this worker (--no-optipng argument or `:optipng => false` through options) pngquant worker: `pngquant` not found; please provide proper binary or disable this worker (--no-pngquant argument or `:pngquant => false` through options) jhead worker: `jhead` not found, `jpegtran` not found; please provide proper binary or disable this worker (--no-jhead argument or `:jhead => false` through options) jpegoptim worker: `jpegoptim` not found; please provide proper binary or disable this worker (--no-jpegoptim argument or `:jpegoptim => false` through options) jpegtran worker: `jpegtran` not found; please provide proper binary or disable this worker (--no-jpegtran argument or `:jpegtran => false` through options) gifsicle worker: `gifsicle` not found; please provide proper binary or disable this worker (--no-gifsicle argument or `:gifsicle => false` through options) svgo worker: `svgo` not found; please provide proper binary or disable this worker (--no-svgo argument or `:svgo => false` through options) Seems that they are just warnings, anyway, they looks scary. After all, it is really not so hard to install `openstreetmap-website`, except those quirks which are quite confusing for those who didn't professionally work with Linux or Ruby. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/23af51ff/attachment.html> From notifications at github.com Thu Aug 8 10:52:57 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 03:52:57 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2345/519469763@github.com> Note that I don't think you actually need yarn at the moment unless you want to run the eslint tasks? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#issuecomment-519469763 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/57baec16/attachment.html> From notifications at github.com Thu Aug 8 10:52:15 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 03:52:15 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2345/519469564@github.com> To answer your points: * We haven't documented yarn yet because we don't have a good solution for Ubuntu but what you did is probably the least worst approach for now. * I don't think you needed that bundle stuff at all and I wouldn't advise it - the real error there was the settings thing I think. It's a bad idea to overwrite the apt installed bundler with a gem installed one like that anyway - we should either use one of the other. * As I said, the settings thing is known about - there's a ticket somewhere I think though I couldn't find it - it's not clear what is best to do but copying is certainly not required or advisable as it will stop you getting any updates to defaults. An empty file is better. * Yes the image optimiser things are warnings but there is no way to get rid of them. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#issuecomment-519469564 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/5f133ac5/attachment.html> From notifications at github.com Thu Aug 8 10:54:12 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 03:54:12 -0700 Subject: [openstreetmap/openstreetmap-website] Document yarn installation in install notes (#2295) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2295@github.com> References: <openstreetmap/openstreetmap-website/issues/2295@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2295/519470136@github.com> Even if we bump the requirement documenting how to install and use the apt repo is an awful lot of complication that I would prefer to avoid having to document :-( The alternative is just to suggest npm installation of yarn? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2295#issuecomment-519470136 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/372f4dc6/attachment-0001.html> From notifications at github.com Thu Aug 8 11:10:59 2019 From: notifications at github.com (YuriiNskyi) Date: Thu, 08 Aug 2019 04:10:59 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2345/519474742@github.com> @tomhughes So, why not document it? People will search and find similar solution, there is unnecessary complication here. So, the error was because of the `settings.local.yml` file? It's not obvious at all. What should we do with [Ruby gems](https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md#ruby-gems) then? Yes, I don't want to run eslint tasks, but without installing Yarn, I can't pass [Node.js modules](https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md#nodejs-modules) step. Am I right that this step is don't even needed, when you have no goal to run eslint tasks? Ok, let's ignore those warnings! IMHO, section FAQ in [INSTALL.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md) with such quirks, will be a great support for those who want to install `openstreetmap-website` from scratch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#issuecomment-519474742 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/58214e7b/attachment.html> From notifications at github.com Thu Aug 8 11:27:05 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 04:27:05 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2345/519479179@github.com> I'm not saying there aren't problems that we should fix, just that it's hard to come up with good instructions that won't run the risk of breaking people's systems. We can certainly document the settings thing, but the whole idea is that you shouldn't need that file unless you want to override a setting - the problem is that we wanted the assets to rebuild if it changed so we added a dependency on it which causes the error. Ideally we want a dependency that is optional so that if the file exists and is changed the assets are rebuilt. Yes I realise the instructions advise running yarn, and it's likely to be more important at some point, but sadly Ubuntu has not packaged yarn yet which makes it tricky. That's quite new and we're still working out the best solution. Maybe we should just document that step as optional for now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#issuecomment-519479179 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/70a58fdd/attachment.html> From notifications at github.com Thu Aug 8 12:49:51 2019 From: notifications at github.com (Ilya Zverev) Date: Thu, 08 Aug 2019 05:49:51 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519504171@github.com> 2012: your plugin for preventing people spending all their time on mapping is harmful. 2019: okay we need to limit mappers' activity. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519504171 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/cd07358a/attachment.html> From notifications at github.com Thu Aug 8 13:20:59 2019 From: notifications at github.com (mmd) Date: Thu, 08 Aug 2019 06:20:59 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519514982@github.com> @Zverik : your "no more mapping" plugin was a prank to kill JOSM altogether. I don't see how this relates to this discussion. Seems rather off topic to me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519514982 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/f3b54902/attachment.html> From notifications at github.com Thu Aug 8 13:46:19 2019 From: notifications at github.com (Ilya Zverev) Date: Thu, 08 Aug 2019 06:46:19 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519524783@github.com> It was as much of a prank as "delete the repository" button in github. And it relates to the discussion: instead of questioning why should we make arbitrary limits on uploading and why DWG cannot process or even find these super-productive users, we are discussing how to block people from uploading data to OSM automatically. First by number of changesets, then by user-agent, then by geoip and so on — temporary measures completely opaque and puzzling users, with no warnings, unlike that plugin. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519524783 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/8bc279ac/attachment.html> From notifications at github.com Thu Aug 8 13:55:00 2019 From: notifications at github.com (dieterdreist) Date: Thu, 08 Aug 2019 06:55:00 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519528286@github.com> couldn’t you just create another account if you were to hit an upload limit? IP addresses are often dynamically assigned, user agents can be customized at will, VPNs are cheap, what would prevent someone from circumventing arbitrary limits anyway? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519528286 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/2ba2901b/attachment.html> From notifications at github.com Thu Aug 8 14:03:14 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 07:03:14 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519531768@github.com> Yes obviously it's not going to stop somebody that is aware what they're doing is wrong but is determined to go ahead, but that's not the goal, because no technical solution could. The goal is make the well intentioned but over enthusiastic people stop, think, and learn about the community rules around imports and automated edits. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519531768 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/51fc1233/attachment.html> From notifications at github.com Thu Aug 8 14:10:32 2019 From: notifications at github.com (Frederik Ramm) Date: Thu, 08 Aug 2019 07:10:32 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519534691@github.com> > The goal is make the well intentioned but over enthusiastic people stop, think, and learn about the community rules around imports and automated edits. Or, turning this around, today if someone uploads 200,000 buildings in one day without any prior consultation then it could have been an accident. I want to come to a point where if someone does this, it is obvious that it was done with ill intent. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519534691 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/ab0c108b/attachment-0001.html> From notifications at github.com Thu Aug 8 18:09:08 2019 From: notifications at github.com (mmd) Date: Thu, 08 Aug 2019 11:09:08 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519628443@github.com> Come to think of it, we should probably focus a bit more on UX and discuss ways on how to guide (new) users without patronizing them too much. In particular, large scale uploads, or massive moving around of nodes (based on some well meaning clean up effort) could be easily detected in JOSM and combined with other user metrics like number of changesets or day or date of registration. Also, JOSM knows how much time a user spent in an editing session and can figure out, if it's a simply Overpass download, search and replace and upload within 1 minute kind of mechanical upload, which the API would never be able to figure out. On top, we can present fully localized messages to the user, along with a nice graphical step-by-step guide to go through some checklist or similar, rather than some technical HTTP error message the API would return. So again, let's focus on the user experience first, think how the user interaction could look like, and what kind of guidance would be reasonable and acceptable. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519628443 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/b02eb723/attachment.html> From notifications at github.com Fri Aug 9 10:01:32 2019 From: notifications at github.com (=?UTF-8?B?TWFydGluIENvbnN0YW50aW5v4oCTQm9kaW4=?=) Date: Fri, 09 Aug 2019 03:01:32 -0700 Subject: [openstreetmap/openstreetmap-website] Strange tiles appearing with squashed streets (#2346) Message-ID: <openstreetmap/openstreetmap-website/issues/2346@github.com> Some tiles are currently strangely generated: ![osm-bug](https://user-images.githubusercontent.com/1829786/62771210-9b017180-ba94-11e9-8c63-ed2d46d06d8c.png) It seems that all streets of the neighbourhood are squashed into a single tile, then additional features like bike parking are added on top of this. The position of the streets in the strangely generated tiles do not correspond to the actual position of the streets in the database. I have experienced this issue both in openstreetmap.org and OSM-contributor, both in London and Vienna. It seems to be a recent bug: I first noticed it about two days ago. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2346 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/7f7f6e27/attachment.html> From notifications at github.com Fri Aug 9 10:04:33 2019 From: notifications at github.com (=?UTF-8?B?TWFydGluIENvbnN0YW50aW5v4oCTQm9kaW4=?=) Date: Fri, 09 Aug 2019 03:04:33 -0700 Subject: [openstreetmap/openstreetmap-website] Strange tiles appearing with squashed streets (#2346) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2346@github.com> References: <openstreetmap/openstreetmap-website/issues/2346@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2346/519862140@github.com> It only seems to happen at this particular level of zoom, by the way: zooming in makes the more precise tiles to be fetched, and these tiles are fine. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2346#issuecomment-519862140 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/fe2ccaec/attachment.html> From simon at poole.ch Fri Aug 9 10:13:00 2019 From: simon at poole.ch (Simon Poole) Date: Fri, 9 Aug 2019 12:13:00 +0200 Subject: [openstreetmap/openstreetmap-website] Strange tiles appearing with squashed streets (#2346) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2346@github.com> References: <openstreetmap/openstreetmap-website/issues/2346@github.com> Message-ID: <04c37692-6049-66c6-945a-81f56866e2c4@poole.ch> Those are tiles that you still have in your cache (as I believe they have all been re-rendered) from the incident last week: https://lists.openstreetmap.org/pipermail/talk-gb/2019-August/023327.html Am 09.08.2019 um 12:01 schrieb Martin Constantino–Bodin: > > Some tiles are currently strangely generated: > osm-bug > <https://user-images.githubusercontent.com/1829786/62771210-9b017180-ba94-11e9-8c63-ed2d46d06d8c.png> > It seems that all streets of the neighbourhood are squashed into a > single tile, then additional features like bike parking are added on > top of this. The position of the streets in the strangely generated > tiles do not correspond to the actual position of the streets in the > database. > I have experienced this issue both in openstreetmap.org and > OSM-contributor, both in London and Vienna. It seems to be a recent > bug: I first noticed it about two days ago. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/openstreetmap/openstreetmap-website/issues/2346?email_source=notifications&email_token=AAK2OLKRANROBJEJKGMB7GLQDU57ZA5CNFSM4IKSQVSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HELQS6Q>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAK2OLLFP2NP7SSY5KT2373QDU57ZANCNFSM4IKSQVSA>. > > > _______________________________________________ > rails-dev mailing list > rails-dev at openstreetmap.org > https://lists.openstreetmap.org/listinfo/rails-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/8b1f02e8/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/8b1f02e8/attachment.sig> From notifications at github.com Fri Aug 9 17:12:04 2019 From: notifications at github.com (Tim Waters) Date: Fri, 09 Aug 2019 10:12:04 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519995283@github.com> I also gave it a go, in case others are trying, I also edited the end of the provision.sh script to copy the storage config file (if it's needed) and use also use "bundle exec" to call the rake tasks ``` if [ ! -f config/storage.yml ]; then cp config/example.storage.yml config/storage.yml fi touch config/settings.local.yml # migrate the database to the latest version sudo -u vagrant bundle exec rake db:migrate popd ``` Running the tests, there were errors related to `failed to detect theversion of the executable at '/usr/bin/phantomjs' ` This was solved by changing the environment variable from "phantom" to "offscreen" in the application_system_testcase.rb `ENV["QT_QPA_PLATFORM"] = "offscreen" if IO.popen(["phantomjs", "--version"], :err => :close).read.empty?` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519995283 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/6ec97ac3/attachment.html> From notifications at github.com Fri Aug 9 17:13:21 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 09 Aug 2019 10:13:21 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519995662@github.com> Yeah that's a result of the silly way Debian/Unbuntu build phantomjs, so that it requires a graphical display evening if running headless. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519995662 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/eaabdc39/attachment.html> From notifications at github.com Sat Aug 10 23:10:31 2019 From: notifications at github.com (Sam Jenkins) Date: Sat, 10 Aug 2019 16:10:31 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) Message-ID: <openstreetmap/openstreetmap-website/pull/2347@github.com> This is a response to issue: [#2336](https://github.com/openstreetmap/openstreetmap-website/issues/2336) Add search query to <title> You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2347 -- Commit Summary -- * set <title> upon search -- File Changes -- M app/views/geocoder/search.html.erb (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2347.patch https://github.com/openstreetmap/openstreetmap-website/pull/2347.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190810/f92354c8/attachment.html> From notifications at github.com Sat Aug 10 23:23:36 2019 From: notifications at github.com (Sam Jenkins) Date: Sat, 10 Aug 2019 16:23:36 -0700 Subject: [openstreetmap/openstreetmap-website] Set <title> upon search (#2336) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2336@github.com> References: <openstreetmap/openstreetmap-website/issues/2336@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2336/520187139@github.com> @jidanni I have created PR #2347 for this issue -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2336#issuecomment-520187139 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190810/780d455f/attachment.html> From notifications at github.com Sun Aug 11 07:37:52 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 11 Aug 2019 00:37:52 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520207329@github.com> Can you give an example of what the resulting title looks like? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520207329 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/dae6875e/attachment.html> From notifications at github.com Sun Aug 11 07:40:35 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 11 Aug 2019 00:40:35 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520207471@github.com> In fact have you checked that this works? Only I wouldn't have thought setting it there would work in most cases - it will work if you load a URL with a search query in it, but it won't update when you do a search in an already loaded page. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520207471 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/69709f93/attachment.html> From notifications at github.com Sun Aug 11 11:07:03 2019 From: notifications at github.com (Sam Jenkins) Date: Sun, 11 Aug 2019 04:07:03 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520219345@github.com> Hi @tomhughes! Have updated initial comment with an example. I have checked that it works in local dev environment. As you say, it certainly works when the URL is loaded with a query string. It also works with XHR requests. The `set_title` function (see `title_helper.rb`) takes a string argument and assigns it to `@title`. It also runs the following line: ``` response.headers["X-Page-Title"] = ERB::Util.u(@title + " | " + t("layouts.project_name.title")) ``` which attaches the updated title to the XHR response. In the browser, `index.js` lines 70-71 use `"X-Page-Title"` to set `document.title`. Would be very grateful if you could flag any unexpected behaviour! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520219345 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/cda517aa/attachment.html> From notifications at github.com Sun Aug 11 11:24:56 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 11 Aug 2019 04:24:56 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520220410@github.com> Yes I know it sets `X-Page-Title` but I didn't think `search.html` would be rendered for an XHR request. I might be wrong though - will have a look later. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520220410 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/5049f930/attachment.html> From notifications at github.com Sun Aug 11 12:17:35 2019 From: notifications at github.com (Sam Jenkins) Date: Sun, 11 Aug 2019 05:17:35 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520223546@github.com> Yes. Took a little bit of unthreading on my part. For XHR, the `#search` action renders `xhr.html.erb` layout through the `#map_layout` method inherited from `application_controller`. The layout yields to `search.html.erb` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520223546 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/16eb9a9a/attachment.html> From notifications at github.com Sun Aug 11 12:18:56 2019 From: notifications at github.com (Sam Jenkins) Date: Sun, 11 Aug 2019 05:18:56 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520223628@github.com> Do give it a look in local dev and let me know any thoughts 👍 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520223628 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/48d139c6/attachment.html> From notifications at github.com Sun Aug 11 13:31:19 2019 From: notifications at github.com (Sam Jenkins) Date: Sun, 11 Aug 2019 06:31:19 -0700 Subject: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen. (#2273) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2273@github.com> References: <openstreetmap/openstreetmap-website/issues/2273@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2273/520228772@github.com> Does anybody know if `reporting_user` is currently stored against `Issue`? Or will this change require migrations? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2273#issuecomment-520228772 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/00833d31/attachment.html> From notifications at github.com Sun Aug 11 14:00:42 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 11 Aug 2019 07:00:42 -0700 Subject: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen. (#2273) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2273@github.com> References: <openstreetmap/openstreetmap-website/issues/2273@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2273/520230789@github.com> Well it will be on the report, not the issue. It can't be on the issue because an issue can have multiple reports. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2273#issuecomment-520230789 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/fcc61ed9/attachment-0001.html> From notifications at github.com Sun Aug 11 14:01:48 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 11 Aug 2019 07:01:48 -0700 Subject: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen. (#2273) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2273@github.com> References: <openstreetmap/openstreetmap-website/issues/2273@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2273/520230867@github.com> So to be clear you want `issue.reports[n].user` but the real problem is that `n` because this is a one-many relationship so there is no single reporting user that can be shown. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2273#issuecomment-520230867 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/e1e22d92/attachment.html> From notifications at github.com Sun Aug 11 20:52:59 2019 From: notifications at github.com (Frederik Ramm) Date: Sun, 11 Aug 2019 13:52:59 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520259411@github.com> https://www.openstreetmap.org/note/808072 recent example of the kind of garbage we have to deal with from anonymous note commenters. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520259411 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/0da761a1/attachment.html> From notifications at github.com Mon Aug 12 05:31:46 2019 From: notifications at github.com (Ilya Zverev) Date: Sun, 11 Aug 2019 22:31:46 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520303007@github.com> I see a kind of double standards regarding this website. When I suggested we give maps.me users a simpler access to the website by implementing the same oauth access as for google and microsoft, it was almost unanimously blocked, 'cause it might hurt the map (I guess — isn't that the only argument we can have?). When dozens of active members ask for closing anonymous comments that visibly hurt the mappers' experience, it is still blocked, because even a slightest contribution matters. It can be either the first or the second. If a slightest contribution matters, then we should open to all, including the dreaded maps.me (although the moment is obviously lost). If mappers matter, then at least anonymous comments should be closed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520303007 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/16f42195/attachment.html> From notifications at github.com Mon Aug 12 08:41:23 2019 From: notifications at github.com (Yaron Shahrabani) Date: Mon, 12 Aug 2019 01:41:23 -0700 Subject: [openstreetmap/openstreetmap-website] Email notifications should be RTLed (#2297) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2297@github.com> References: <openstreetmap/openstreetmap-website/issues/2297@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2297/520341942@github.com> Merged? We're all good? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2297#issuecomment-520341942 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/809ce3d8/attachment.html> From notifications at github.com Mon Aug 12 09:17:58 2019 From: notifications at github.com (YuriiNskyi) Date: Mon, 12 Aug 2019 02:17:58 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2345/520352376@github.com> Ok, your point of view is clear, except that I can't understand where is the risk of breaking people's systems, if provided installation instructions are for new people, they don't have any systems. I'm closing this issue, it is all clear now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#issuecomment-520352376 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/abfdbc44/attachment-0001.html> From notifications at github.com Mon Aug 12 09:17:59 2019 From: notifications at github.com (YuriiNskyi) Date: Mon, 12 Aug 2019 02:17:59 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2345/issue_event/2549567739@github.com> Closed #2345. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#event-2549567739 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/2c2ff986/attachment-0001.html> From notifications at github.com Mon Aug 12 13:46:05 2019 From: notifications at github.com (Simon Poole) Date: Mon, 12 Aug 2019 06:46:05 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520431146@github.com> Just so that everybody can read what the problem with @Zverik PR was at the time I offer https://github.com/openstreetmap/openstreetmap-website/pull/1433 (note no mention of 'cause it might hurt the map). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520431146 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/73b83163/attachment.html> From notifications at github.com Mon Aug 12 14:09:34 2019 From: notifications at github.com (Ilya Zverev) Date: Mon, 12 Aug 2019 07:09:34 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520440560@github.com> Yeah, there were very vague reasons which boiled down to "This issue is blocked because it requires a policy decision". Then I made the policy (https://github.com/openstreetmap/operations/issues/162), and everyone basically ignored it, because accepting or rejecting the policy would mean people would need to do something. But you're derailing the discussion. Why #1926 which closes this issue has not been merged yet? Could people in power please give an answer people could act on? Do we need another policy? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520440560 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/e89ada01/attachment.html> From notifications at github.com Mon Aug 12 16:51:56 2019 From: notifications at github.com (Bryan Housel) Date: Mon, 12 Aug 2019 09:51:56 -0700 Subject: [openstreetmap/openstreetmap-website] Multi Fetch GET with /full option? (#2348) Message-ID: <openstreetmap/openstreetmap-website/issues/2348@github.com> Per https://github.com/openstreetmap/iD/issues/6668#issuecomment-520489274 iD is using the [Multi Fetch GET](https://wiki.openstreetmap.org/wiki/API_v0.6#Multi_fetch:_GET_.2Fapi.2F0.6.2F.5Bnodes.7Cways.7Crelations.5D.3F.23parameters) API call in a few situations to fetch ways and relations: - downloading additional member ways for correct handling of multipolygons, routes, etc. - checking and dealing with error 409 conflicts at save time Unfortunately we need to still perform more calls after this to get all the related nodes (and this can be a lot of nodes). It would be really great if we could have a version of this call that works like the [`/full` Single Fetch GET call](https://wiki.openstreetmap.org/wiki/API_v0.6#Full:_GET_.2Fapi.2F0.6.2F.5Bway.7Crelation.5D.2F.23id.2Ffull) that returns all the related nodes in the response. cc @mmd-osm -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2348 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/55e16836/attachment.html> From notifications at github.com Tue Aug 13 07:53:10 2019 From: notifications at github.com (Richlv) Date: Tue, 13 Aug 2019 00:53:10 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520729483@github.com> All anonymous comments I recall are spam or people forgetting to log in. As a community, we waste tons of time on these that is not offset by one-off useful anonymous comment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520729483 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190813/e0434b7b/attachment.html> From notifications at github.com Tue Aug 13 11:57:48 2019 From: notifications at github.com (Andy Allan) Date: Tue, 13 Aug 2019 04:57:48 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/c520804968@github.com> @mmd-osm just checking in on this - what are your thoughts for/against my previous suggestions? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229#issuecomment-520804968 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190813/aecb84ab/attachment.html> From notifications at github.com Tue Aug 13 12:13:06 2019 From: notifications at github.com (Andy Allan) Date: Tue, 13 Aug 2019 05:13:06 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520809320@github.com> > Why #1926 which closes this issue has not been merged yet? Could people in power please give an answer people could act on? I don't think you'll like my answer, but here goes. I can't speak for anyone else and I don't know what the other maintainer thinks on this topic. But for me, it simply hasn't got to the top of my own priority list. There's only so many days in a week that I can spend on this project. I've even stepped down from OWG in order to spend more time here. But with so many open pull requests, so many open issues, my own priorities for the project (in particular, support for multiple API versions, and making it easier for new developers to get started) and all the other stuff, not everything gets done as fast as I would like, nor as fast as everyone else would like. It doesn't help that, behind the scenes, notes are implemented in a decidedly sub-optimal fashion, so any time I go near them I want to ignore the topic and work on other things! > Do we need another policy? Policies can help with certain things, but not e.g. making me work harder :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520809320 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190813/626da6de/attachment.html> From notifications at github.com Tue Aug 13 16:53:45 2019 From: notifications at github.com (mmd) Date: Tue, 13 Aug 2019 09:53:45 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/c520917099@github.com> I don't have a strong opinion on the first point, as we're only using this tool part part of the CI chain, and it doesn't introduce any new runtime dependencies. I'm also using tools like coverity for cgimap to check for issues in c++ code, even though they're not open source. Regarding the second point, I haven't really seen anything in the config settings like a rubocop style exception definition to disable checks on file/method level. This seems a bit unfortunate as we would skip some checks globally, even for newly introduced issues. Maybe I'm missing something here in the documentation and more fine grained control is possible somehow. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229#issuecomment-520917099 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190813/7aa1b83c/attachment.html> From notifications at github.com Wed Aug 14 08:30:16 2019 From: notifications at github.com (Ilya Zverev) Date: Wed, 14 Aug 2019 01:30:16 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/521153672@github.com> Andy, I appreciate you working on the website, and I'm happy to see quite a lot of progress in its internal implementation. I don't require you or anybody to _do_ anything with the matter. All I want is a clear decision that this — restricting anonymous notes — needs to be done and will be done in near future. Maybe not by coding, but by commenting on the ready-made pull request. I'd prefer not to see more discussion topics like how do we identify anonymous users or should we improve moderation. This issue is as of yesterday the most commented and the one with the most reactions on this issue tracker. If that doesn't mark it as the most important from a user side, I don't know what does. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-521153672 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190814/5b889e24/attachment.html> From notifications at github.com Wed Aug 14 17:18:59 2019 From: notifications at github.com (Mateusz Konieczny) Date: Wed, 14 Aug 2019 10:18:59 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/521337670@github.com> > I don't require you or anybody to do anything with the matter. All I want is a clear decision that this — restricting anonymous notes Reviewing PR and making decision is something that needs to be *done*. And especially with such policy decision - dealing with following complaints that are likely no matter what the decision will be made. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-521337670 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190814/7353de2d/attachment.html> From notifications at github.com Wed Aug 14 17:48:41 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 14 Aug 2019 10:48:41 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/review/275048591@github.com> tomhughes approved this pull request. This looks OK from a technical point of view so I think the only question that remains is the policy one of whether we want to do this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#pullrequestreview-275048591 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190814/e3e81214/attachment.html> From notifications at github.com Wed Aug 14 18:19:54 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 14 Aug 2019 11:19:54 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/issue_event/2557490025@github.com> Closed #2347 via 42345cb9b7ff32e477d69047a1b87dea6e649433. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#event-2557490025 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190814/b74e1d54/attachment.html> From notifications at github.com Wed Aug 14 18:19:54 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 14 Aug 2019 11:19:54 -0700 Subject: [openstreetmap/openstreetmap-website] Set <title> upon search (#2336) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2336@github.com> References: <openstreetmap/openstreetmap-website/issues/2336@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2336/issue_event/2557490012@github.com> Closed #2336 via 42345cb9b7ff32e477d69047a1b87dea6e649433. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2336#event-2557490012 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190814/b39ed021/attachment.html> From notifications at github.com Fri Aug 16 17:10:08 2019 From: notifications at github.com (Richlv) Date: Fri, 16 Aug 2019 10:10:08 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/522082694@github.com> Here's a valid anonymous comment... no wait, another user who got logged out :) https://www.openstreetmap.org/note/1729759 As for complaints, a few options: a) Send them all to me. I'll try to reply to all with a polite, canned response. b) Auto-suggest people complaining that they should survey and fix all anonymous notes first. Anonymous notes seem to have been of low value from the very beginning - https://help.openstreetmap.org/questions/23106/removing-anonymous-notes-from-map . -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-522082694 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190816/582ebfd3/attachment.html> From notifications at github.com Fri Aug 16 21:21:13 2019 From: notifications at github.com (Mateusz Konieczny) Date: Fri, 16 Aug 2019 14:21:13 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/522155239@github.com> > Anonymous notes seem to have been of low value from the very beginning Poland has many useful anonymous notes (with strong evidence that majority is really from people without accounts) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-522155239 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190816/4d980a1a/attachment.html> From notifications at github.com Fri Aug 16 21:25:11 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 16 Aug 2019 14:25:11 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/522156343@github.com> We're not talking about anonymous notes here, only about additional anonymous comments on existing notes. So the first comment can still be anonymous, just not later ones. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-522156343 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190816/eada484d/attachment.html> From notifications at github.com Sat Aug 17 08:30:22 2019 From: notifications at github.com (Carsten Hagemann) Date: Sat, 17 Aug 2019 01:30:22 -0700 Subject: [openstreetmap/openstreetmap-website] Tiles not loading properly when opening notes link on phone (#2349) Message-ID: <openstreetmap/openstreetmap-website/issues/2349@github.com> Hey, usually I do not have issues with the website, but the tiles, *never* load as they should on my phone. On my Mac, they loas fine. Using Chrome Beta on a One Plus 5 with Android 9. When loading the page, only the tiles at the left load. The right stays gray. Panning around the map does not load tiles. When going to another tab in chrome and then revisiting the OSM tab, all tiles load properly. Example: https://www.openstreetmap.org/note/1885992#map=14/38.5414/-0.1020 ![Screenshot_20190817-102808](https://user-images.githubusercontent.com/3776997/63208848-bba37a00-c0d9-11e9-9377-7797ba5e1320.jpg) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2349 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/ae8702bb/attachment.html> From notifications at github.com Sat Aug 17 08:34:42 2019 From: notifications at github.com (Carsten Hagemann) Date: Sat, 17 Aug 2019 01:34:42 -0700 Subject: [openstreetmap/openstreetmap-website] Email notification about closed notes should contain initial text (#2036) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2036@github.com> References: <openstreetmap/openstreetmap-website/issues/2036@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2036/522217343@github.com> Sounds pretty good. Is there any activity on this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2036#issuecomment-522217343 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/966942ea/attachment.html> From notifications at github.com Sat Aug 17 08:36:36 2019 From: notifications at github.com (Carsten Hagemann) Date: Sat, 17 Aug 2019 01:36:36 -0700 Subject: [openstreetmap/openstreetmap-website] "thank you" feature (#875) In-Reply-To: <openstreetmap/openstreetmap-website/issues/875@github.com> References: <openstreetmap/openstreetmap-website/issues/875@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/875/522217524@github.com> I'd also really like this and it's always missing (again and again I want to say thanks, but as the note is closed there's no way)! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/875#issuecomment-522217524 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/bd6b0928/attachment-0001.html> From notifications at github.com Sat Aug 17 08:37:38 2019 From: notifications at github.com (Carsten Hagemann) Date: Sat, 17 Aug 2019 01:37:38 -0700 Subject: [openstreetmap/openstreetmap-website] "notes" notification w/o https (#757) In-Reply-To: <openstreetmap/openstreetmap-website/issues/757@github.com> References: <openstreetmap/openstreetmap-website/issues/757@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/757/522217599@github.com> Can be closed as https mails are sent -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/757#issuecomment-522217599 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/c9a410fe/attachment.html> From notifications at github.com Sat Aug 17 10:15:57 2019 From: notifications at github.com (ltog) Date: Sat, 17 Aug 2019 03:15:57 -0700 Subject: [openstreetmap/openstreetmap-website] Email notification about closed notes should contain initial text (#2036) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2036@github.com> References: <openstreetmap/openstreetmap-website/issues/2036@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2036/522224707@github.com> @carstenhag : I don't have any knowledge of someone being working on it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2036#issuecomment-522224707 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/57664689/attachment.html> From notifications at github.com Sat Aug 17 10:44:36 2019 From: notifications at github.com (mmd) Date: Sat, 17 Aug 2019 03:44:36 -0700 Subject: [openstreetmap/openstreetmap-website] Tiles not loading properly when opening notes link on phone (#2349) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2349@github.com> References: <openstreetmap/openstreetmap-website/issues/2349@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2349/522226535@github.com> That's really duplicate of #2035. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2349#issuecomment-522226535 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/df8b2594/attachment.html> From notifications at github.com Sat Aug 17 11:54:30 2019 From: notifications at github.com (Frederik Ramm) Date: Sat, 17 Aug 2019 04:54:30 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/522230583@github.com> Are you sure this is the right place to design the JOSM user interface? Is that not something that should be left to the JOSM developers? There's a relationship of course, but I think that we should do this like we did it with the limitation of changeset sizes: The OSM API decides what is acceptable and rejects anything unacceptable with an error message, and it is then the duty of the editors to ideally guide their users so that this error condition is never triggered, or to deal with the error in a suitable fashion should it occur. Since I'm a JOSM user myself I could certainly sketch a number of possible JOSM UI approaches to get this right, but they would not necessarily apply to other editors that have different UIs - I think that approaching this from a UI perspective is the wrong approach for us in this repository. We should build a mechanism that lets us reject uploads of "too much in too short time", and we could initially set these limits very high and give editor writes the chance to experiment and adapt their UI if necessary, and then tighten the limits to something sensible. I think that trying to design good UIs for all editors is out of scope here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-522230583 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/aab052f0/attachment.html> From notifications at github.com Sat Aug 17 12:10:33 2019 From: notifications at github.com (dieterdreist) Date: Sat, 17 Aug 2019 05:10:33 -0700 Subject: [openstreetmap/openstreetmap-website] Highlighting objects on mobile (#1663) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1663@github.com> References: <openstreetmap/openstreetmap-website/issues/1663@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1663/522231564@github.com> Checking now, it works for notes on iOS (all tiles displayed). There is still an issue if you look at a specific object (/way/123) and close the details the whole map pans approximately one screen width to the left, so that the object you were looking at is off screen -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1663#issuecomment-522231564 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/f0f8643e/attachment.html> From notifications at github.com Sat Aug 17 13:40:02 2019 From: notifications at github.com (Adamant36) Date: Sat, 17 Aug 2019 06:40:02 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/522237793@github.com> I've gotten some useful anonymous responses before when asking what the name of some is or if a road goes through. That said, I'm not sure it balances out the bad. Maybe a way to do it would be to limit anonymous responses to two messages or something. Then the person could leave the intial message, respond if need be, but not spam the note system. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-522237793 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/61877569/attachment.html> From notifications at github.com Sat Aug 17 16:21:40 2019 From: notifications at github.com (Carsten Hagemann) Date: Sat, 17 Aug 2019 09:21:40 -0700 Subject: [openstreetmap/openstreetmap-website] Highlighting objects on mobile (#1663) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1663@github.com> References: <openstreetmap/openstreetmap-website/issues/1663@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1663/522250947@github.com> Broken on chrome beta 77 @ android. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1663#issuecomment-522250947 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/dc35e3ef/attachment.html> From notifications at github.com Sun Aug 18 03:15:41 2019 From: notifications at github.com (blackboxlogic) Date: Sat, 17 Aug 2019 20:15:41 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) Message-ID: <openstreetmap/openstreetmap-website/issues/2350@github.com> When calling Get /api/0.6/trackpoints?bbox=left,bottom,right,top&page=pageNumber The result `<?xml version="1.0" encoding="UTF-8"?> <gpx version="1.0" creator="OpenStreetMap.org" xmlns="http://www.topografix.com/GPX/1/0"> <trk>...` Is gpx version 1.0 which is "old" as of 2004. See https://www.topografix.com/gpx.asp Could the call take another optional parameter specifying the gpx version to return? (either 1.0 or 1.1 which is current) For backward compatibility, default to current behavior (1.0) if the value is ommited. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/6c395630/attachment.html> From notifications at github.com Sun Aug 18 07:31:42 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 18 Aug 2019 00:31:42 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522298663@github.com> I see no reason to make it configurable, but equally if we don't use any 1.1 features then I don't see any great reason to change it. Are there are incompatible differences between the two, or does 1.1 essentially just declare that that there are extra elements/attributes we might use? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522298663 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/067cc51a/attachment-0001.html> From notifications at github.com Sun Aug 18 07:32:58 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 18 Aug 2019 00:32:58 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522298746@github.com> Sadly the official site apparently only documents the current version so there is no way to tell what the changes are. I suspect most things never even look at the version to be honest. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522298746 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/44815dc4/attachment.html> From notifications at github.com Sun Aug 18 08:15:31 2019 From: notifications at github.com (mmd) Date: Sun, 18 Aug 2019 01:15:31 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522301272@github.com> Download both https://www.topografix.com/GPX/1/0/gpx.xsd and https://www.topografix.com/GPX/1/1/gpx.xsd and paste them one at a time into http://xsd2xml.com/ to generate a sample file for each version. Most of the elements are optional anyway, but here's a full blown sample for each version: ## Version 1.0 ```XML <?xml version="1.0" encoding="utf-8"?> <gpx version="1.0" creator="str1234"> <name>str1234</name> <desc>str1234</desc> <author>str1234</author> <email>str1234</email> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <time>2012-12-13T12:12:12</time> <keywords>str1234</keywords> <bounds minlat="123.45" minlon="123.45" maxlat="123.45" maxlon="123.45" /> <wpt lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> </wpt> <rte> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <number>33</number> <rtept lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> </rtept> </rte> <trk> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <number>33</number> <trkseg> <trkpt lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <course>123.45</course> <speed>123.45</speed> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> </trkpt> </trkseg> </trk> </gpx> ``` ## Version 1.1 ```XML <?xml version="1.0" encoding="utf-8"?> <gpx version="1.1" creator="str1234"> <metadata> <name>str1234</name> <desc>str1234</desc> <author> <name>str1234</name> <email id="str1234" domain="str1234" /> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> </author> <copyright author="str1234"> <year>1999</year> <license>http://www.xsd2xml.com</license> </copyright> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <time>2012-12-13T12:12:12</time> <keywords>str1234</keywords> <bounds minlat="123.45" minlon="123.45" maxlat="123.45" maxlon="123.45" /> <extensions /> </metadata> <wpt lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> <extensions /> </wpt> <rte> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <number>33</number> <type>str1234</type> <extensions /> <rtept lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> <extensions /> </rtept> </rte> <trk> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <number>33</number> <type>str1234</type> <extensions /> <trkseg> <trkpt lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> <extensions /> </trkpt> <extensions /> </trkseg> </trk> <extensions /> </gpx> ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522301272 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/45d5fcce/attachment-0001.html> From notifications at github.com Sun Aug 18 08:20:56 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 18 Aug 2019 01:20:56 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522301595@github.com> So there are a few metadata elements which have changed to be structured containers but I don't think we use any of those so 1.0 would appear to offer the greatest compatibiilty? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522301595 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/d84ee6e2/attachment.html> From notifications at github.com Sun Aug 18 08:26:36 2019 From: notifications at github.com (mmd) Date: Sun, 18 Aug 2019 01:26:36 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522301988@github.com> Right, we don't use the header fields in https://api.openstreetmap.org/api/0.6/trackpoints?bbox=0,51.5,0.25,51.75&page=0 I see a small incompatibility on the <trk> element: The previous <url> element has moved to a link element: ``` <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> ``` ```XML <trk> <name>2019_06_22.gpx.gz</name> <desc>Bike ride</desc> <url>https://api.openstreetmap.org/user/TomH/traces/3026889</url> <trkseg> <trkpt lat="51.7443750" lon="0.0000117"> <time>2019-06-22T14:56:39Z</time> </trkpt> <trkpt lat="51.7443833" lon="0.0000500"> ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522301988 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/b3c6aa27/attachment.html> From notifications at github.com Sun Aug 18 11:47:21 2019 From: notifications at github.com (blackboxlogic) Date: Sun, 18 Aug 2019 04:47:21 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2350/issue_event/2564417853@github.com> Closed #2350. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#event-2564417853 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/679afc44/attachment.html> From notifications at github.com Sun Aug 18 11:47:21 2019 From: notifications at github.com (blackboxlogic) Date: Sun, 18 Aug 2019 04:47:21 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522314679@github.com> The compatibility problem I hit was a gpx parsing tool which checks that xlms is the 1/1 version and refuses to parse it otherwise. I will pursue the issues with them or find a different tool. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522314679 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/552f21b4/attachment.html> From notifications at github.com Sun Aug 18 14:18:34 2019 From: notifications at github.com (Harel M) Date: Sun, 18 Aug 2019 07:18:34 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522326049@github.com> I still think using an outdated format is less than ideal, even if the new format doesn't provide any new capabilities that fact that OSM API returns and outdated GPX version causes other tools that relay on OSM to keep supporting this old format and keeping old code which is useless otherwise... +1 on moving to the new format. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522326049 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/87425662/attachment.html> From notifications at github.com Mon Aug 19 14:20:28 2019 From: notifications at github.com (Andy Allan) Date: Mon, 19 Aug 2019 07:20:28 -0700 Subject: [openstreetmap/openstreetmap-website] "notes" notification w/o https (#757) In-Reply-To: <openstreetmap/openstreetmap-website/issues/757@github.com> References: <openstreetmap/openstreetmap-website/issues/757@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/757/issue_event/2566488282@github.com> Closed #757. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/757#event-2566488282 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190819/305c4414/attachment.html> From notifications at github.com Mon Aug 19 17:29:38 2019 From: notifications at github.com (Paolo Benvenuto) Date: Mon, 19 Aug 2019 10:29:38 -0700 Subject: [openstreetmap/openstreetmap-website] imperfect route (#2351) Message-ID: <openstreetmap/openstreetmap-website/issues/2351@github.com> https://www.openstreetmap.org/directions?engine=fossgis_osrm_car&route=44.41202%2C8.90013%3B44.41662%2C8.85427#map=15/44.4140/8.8773 makes me pass through roads with a lot of traffic. The correct route should use the "via Guido Rossa" (below), which is a highway, like in https://www.openstreetmap.org/directions?engine=fossgis_osrm_car&route=44.40836%2C8.90264%3B44.41524%2C8.85077#map=15/44.4122/8.8767 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2351 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190819/3de8fd5b/attachment.html> From notifications at github.com Mon Aug 19 18:26:23 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 19 Aug 2019 11:26:23 -0700 Subject: [openstreetmap/openstreetmap-website] highway not used for route (#2351) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2351@github.com> References: <openstreetmap/openstreetmap-website/issues/2351@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2351/issue_event/2567252197@github.com> Closed #2351. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2351#event-2567252197 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190819/61c0aa2c/attachment.html> From notifications at github.com Mon Aug 19 18:26:23 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 19 Aug 2019 11:26:23 -0700 Subject: [openstreetmap/openstreetmap-website] highway not used for route (#2351) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2351@github.com> References: <openstreetmap/openstreetmap-website/issues/2351@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2351/522698148@github.com> We don't run the routing engine so you would need to report this to the people that do (in this case hat appears to be https://routing.openstreetmap.de/). Most likely it's just an error in the data somewhere in which case sign up to edit the map and you can help fix it! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2351#issuecomment-522698148 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190819/0934dd9f/attachment.html> From notifications at github.com Wed Aug 21 08:40:29 2019 From: notifications at github.com (Andy Allan) Date: Wed, 21 Aug 2019 01:40:29 -0700 Subject: [openstreetmap/openstreetmap-website] Upgrade to Rails 6 (#2352) Message-ID: <openstreetmap/openstreetmap-website/issues/2352@github.com> Rails 6.0 [has been released](https://weblog.rubyonrails.org/2019/8/15/Rails-6-0-final-release/), and it contains some things that will be of interest to us: * Parallel testing - we have a lot of tests! * Multiple databases - this will allow us to split database read requests into their own connection, and route them to the database replicas. This is something cgimap already does and it will be great to have this here too. * Action Mailbox - this would be a lower priority, but it will allow us to use standard methods for processing incoming emails. It would be of most use to secondary deployments, who might have less control over receiving their emails than OSMF does. The major blocker for the upgrade is, as ever, the [`composite_primary_keys`](https://github.com/composite-primary-keys/composite_primary_keys) gem, which needs a 12.x release to support rails 6. We can wait on that, for now. I've looked through the rest of the [release notes](https://edgeguides.rubyonrails.org/6_0_release_notes.html) and the [upgrade guide](https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-5-2-to-rails-6-0), and nothing particularly sticks out to me. If there's anything else that will block our upgrade, or any other new feature that we should also take advantage of, add your comment here! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2352 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/bea912c1/attachment.html> From notifications at github.com Wed Aug 21 09:11:35 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 21 Aug 2019 02:11:35 -0700 Subject: [openstreetmap/openstreetmap-website] Upgrade to Rails 6 (#2352) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2352@github.com> References: <openstreetmap/openstreetmap-website/issues/2352@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2352/523370523@github.com> I started work on this last night ;-) First signs are good and I got to the point where the majority of tests pass - obviously the big blocker there is CPK as you say but also https://github.com/rails/actionpack-page_caching (believed to be ready but needs a release, https://github.com/rails/actionpack-page_caching/issues/58) and https://github.com/rails/record_tag_helper (also believed to be ready but needs a release, https://github.com/rails/record_tag_helper/pull/10#issuecomment-523135585). I think CPK is also reasonable shape - there have been a number rc releases during rails 6 devleopment so it probably just needs finishing off. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2352#issuecomment-523370523 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/991c8ccb/attachment.html> From notifications at github.com Wed Aug 21 14:48:23 2019 From: notifications at github.com (Andy Allan) Date: Wed, 21 Aug 2019 07:48:23 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) Message-ID: <openstreetmap/openstreetmap-website/pull/2353@github.com> I'd like to support multiple API versions, so that we can deploy API 0.7 in parallel to API 0.6. It's not something we've ever done before, but I think it's the only reasonable way to handle API version changes these days! I'm opening this PR just to receive any initial feedback on this proposed approach to the code changes. So far this approach demonstrates the basic concepts, including: * Supporting different scenarios, e.g. dropping old api calls, adding new api calls, api calls that are the same in each version, api calls that are similar but return different results (e.g. different response codes) * Optimised for the assumption that almost all api calls are the same between different versions. * Being able to choose which versions are deployed. This allows the codebase to support multiple API versions during development and when running the tests, and so it avoids long-running branches. * Only code that is different between api versions is in any way duplicated. Otherwise the same code is used for each api version. * Establishes a naming convention for controllers that behave differently in different API versions. The general idea is that old code lives in specific controllers, e.g. `API::V06::CapabilitiesController`, and new code lives in the normal place e.g. `API::CapabilitiesController`. This makes future upgrades easier, since the assumption is that new code will be used in version N+1 too. * It's all designed to allow multiple, non-contiguous versions. For example, if we yank a future version 0.8, it'll cope fine with e.g. deployed_versions = ["0.6", "0.7", "0.9"] If you are interested in seeing how it works, then the changes to "config/routes.rb" along with the output from "bundle exec rake routes" are the best way to see the overall idea. The biggest drawbacks so far are around the tests. First, I think it makes sense that every API version that the codebase knows about is fully tested, i.e. even if the result is expected to be the same, a given api test should run once for each api version. This leads to the indentation of all the tests changing, since we need to add a "all_api_versions" loop around almost every test. So the diffs and git blame are horrible. Secondly, the controller methods involve lots of changes like this: ```diff - get :show + get :show, :params => { :api_version => version } ``` It leads to a lot of extra `params => ...` to skim read, which isn't ideal. I've tried working around this but [the workarounds have their own drawbacks](https://github.com/gravitystorm/openstreetmap-website/issues/28#issuecomment-523427402). The tests don't all pass yet, so this is not yet in shape to be committed, but I hope to get it there soon. In the meantime, and before I make any further changes that you might not be happy with, any feedback is very welcome! You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2353 -- Commit Summary -- * Remove use of Settings.api_version in tests * Allow callers to set the api_version for xml document creation * Initial sketch for multiple API version support * Different capabilities responses for 0.6 and 0.7 * WIP changesets for all api versions and refactor tests * Allow diffReader callers to set the api version of the returned XML -- File Changes -- M app/assets/javascripts/osm.js.erb (2) M app/controllers/api/capabilities_controller.rb (5) M app/controllers/api/changesets_controller.rb (4) A app/controllers/api/v06/capabilities_controller.rb (13) M app/controllers/api/versions_controller.rb (4) M app/controllers/api_controller.rb (5) M app/views/api/capabilities/show.builder (3) M app/views/api/changesets/changeset.builder (2) M app/views/api/changesets/changesets.builder (2) M app/views/api/permissions/show.builder (2) A app/views/api/v06/capabilities/show.builder (22) A config/initializers/api_versions.rb (9) M config/initializers/config.rb (2) M config/routes.rb (69) M config/settings.yml (4) M config/settings/test.yml (2) M lib/diff_reader.rb (6) M lib/osm.rb (7) M test/controllers/api/capabilities_controller_test.rb (55) M test/controllers/api/changes_controller_test.rb (6) M test/controllers/api/changesets_controller_test.rb (3157) M test/controllers/api/map_controller_test.rb (8) M test/controllers/api/permissions_controller_test.rb (64) M test/controllers/api/relations_controller_test.rb (2) M test/controllers/api/versions_controller_test.rb (2) M test/integration/user_blocks_test.rb (10) M test/integration/user_terms_seen_test.rb (4) M test/test_helper.rb (8) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2353.patch https://github.com/openstreetmap/openstreetmap-website/pull/2353.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/44608c39/attachment.html> From notifications at github.com Wed Aug 21 15:26:49 2019 From: notifications at github.com (Andy Allan) Date: Wed, 21 Aug 2019 08:26:49 -0700 Subject: [openstreetmap/openstreetmap-website] Multi Fetch GET with /full option? (#2348) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2348@github.com> References: <openstreetmap/openstreetmap-website/issues/2348@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2348/523508442@github.com> Seems reasonable to me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2348#issuecomment-523508442 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/b69a1e8f/attachment.html> From notifications at github.com Wed Aug 21 16:36:46 2019 From: notifications at github.com (mmd) Date: Wed, 21 Aug 2019 09:36:46 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523541747@github.com> I haven't looked through all the details yet, so please bear with me. I was wondering a bit how you would handle evolutionary or even revolutionary changes to the data model. Typically this is one of the most troubling and complicated aspects of new API versions, and I think it would be good to have some basic concept in place as well here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523541747 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/8fc9c673/attachment.html> From notifications at github.com Wed Aug 21 19:05:09 2019 From: notifications at github.com (mmd) Date: Wed, 21 Aug 2019 12:05:09 -0700 Subject: [openstreetmap/openstreetmap-website] Overpass query bbox to use map precision (#2354) Message-ID: <openstreetmap/openstreetmap-website/pull/2354@github.com> 15 decimal places for bbox lat/lon values seemed a bit excessive. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2354 -- Commit Summary -- * Overpass query to use map precision -- File Changes -- M app/assets/javascripts/index/query.js (6) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2354.patch https://github.com/openstreetmap/openstreetmap-website/pull/2354.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2354 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/9312a78c/attachment-0001.html> From notifications at github.com Thu Aug 22 02:00:00 2019 From: notifications at github.com (whoisutsav) Date: Wed, 21 Aug 2019 19:00:00 -0700 Subject: [openstreetmap/openstreetmap-website] Numericality validation typo - should be `only_integer` instead of `integer_only` (#2355) Message-ID: <openstreetmap/openstreetmap-website/issues/2355@github.com> Hi, There are a number of fields in the models which are validated for numericality, using the flag `integer_only`: ``` [openstreetmap-website] $ grep -rin "integer_only" . ./app/models/old_node.rb:41: :numericality => { :integer_only => true } ./app/models/old_node.rb:43: :numericality => { :integer_only => true } ./app/models/note.rb:27: :numericality => { :on => :update, :integer_only => true } ./app/models/changeset_comment.rb:27: :numericality => { :on => :update, :integer_only => true } ./app/models/node.rb:50: :numericality => { :on => :update, :integer_only => true } ./app/models/node.rb:52: :numericality => { :integer_only => true } ./app/models/node.rb:54: :numericality => { :integer_only => true } ./app/models/node.rb:56: :numericality => { :integer_only => true } ./app/models/node.rb:58: :numericality => { :integer_only => true } ./app/models/way.rb:42: :numericality => { :on => :update, :integer_only => true } ./app/models/way.rb:44: :numericality => { :integer_only => true } ./app/models/way.rb:46: :numericality => { :integer_only => true } ./app/models/changeset.rb:46: :numericality => { :on => :update, :integer_only => true } ./app/models/changeset.rb:48: :numericality => { :integer_only => true } ./app/models/changeset.rb:50: :numericality => { :integer_only => true, ./app/models/changeset.rb:54: :numericality => { :integer_only => true } ./app/models/note_comment.rb:31: :numericality => { :on => :update, :integer_only => true } ./app/models/relation.rb:40: :numericality => { :on => :update, :integer_only => true } ./app/models/relation.rb:42: :numericality => { :integer_only => true } ./app/models/relation.rb:44: :numericality => { :integer_only => true } ``` However I believe the flag accepted by the Rails numericality API is `only_integer`, _not_ `integer_only`. See [here](https://github.com/rails/rails/blob/b9ca94caea2ca6a6cc09abaffaad67b447134079/activemodel/lib/active_model/validations/numericality.rb#L12). Perhaps the flag has changed since previous Rails versions? Nevertheless, the code linked above is from the app version of Rails (5.2.3), so it seems these numericality validations may now be silently ignored. Found this while analyzing the app as part of a research project. Happy to create a pull request if that's helpful (and others agree this is an issue). Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2355 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/cd722481/attachment.html> From notifications at github.com Thu Aug 22 05:02:13 2019 From: notifications at github.com (docljn) Date: Wed, 21 Aug 2019 22:02:13 -0700 Subject: [openstreetmap/openstreetmap-website] Edit dropdown is hard to use on touch devices. (#271) In-Reply-To: <openstreetmap/openstreetmap-website/issues/271@github.com> References: <openstreetmap/openstreetmap-website/issues/271@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/271/523748705@github.com> Hello the team. This is a particularly old issue (!) and I wondered if it was still open for a reason, or had been missed? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/271#issuecomment-523748705 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/6c13a9be/attachment.html> From notifications at github.com Thu Aug 22 09:10:07 2019 From: notifications at github.com (Andy Allan) Date: Thu, 22 Aug 2019 02:10:07 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523820493@github.com> > I was wondering a bit how you would handle evolutionary or even revolutionary changes to the data model. I can sum this up with the phrase "it depends"! * Different versions of the API can use different views, so if we added something to a future api (for example "node coordinate precision" or somesuch) it can be shown in the latest version and ignored in previous versions, or shown in a different way (e.g. as tags). * Different api versions can use different controllers too, as already demoed in this PR for the capabilities controller. This allows more subtantial changes in behaviour between api versions, and changes like fixing response codes. * We could use different models too. I'm not sure why we'd want to, but e.g. api/0.7/node/1 could call a node_controller that fetches data from the ShinyNewNode model. But it all really depends. I think the underlying question might be "how do we handle drastically non-backwards-compatible changes, like converting all closed ways into an area type (or if we introduce an area type into API N+1, how does that work with API N clients); or how would a change like removing segments work with two api versions running in parallel. I don't have an answer for these major structural changes, except to say that if it's logically possible at all to access the data between versions, the code approach in this PR will be able to handle it. And perhaps there'll be some change to the datastructure that prevents parallel API versions and it'll trigger a hard cutover between versions. But lets not get stuck on the biggest problem, and one that's not yet in hand. In the meantime, there's a ton of backwards-compatible but needs-API-bump changes that have been stuck for years, so we can at least sort out those ones :smile: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523820493 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/ae7e9023/attachment.html> From notifications at github.com Thu Aug 22 09:29:13 2019 From: notifications at github.com (Andy Allan) Date: Thu, 22 Aug 2019 02:29:13 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523827006@github.com> I should have said, if there's specific API changes that you're thinking about, even if they are just to illustrate a point, let me know and I'll see how they fit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523827006 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/4b0de6b5/attachment.html> From notifications at github.com Thu Aug 22 09:30:23 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 22 Aug 2019 02:30:23 -0700 Subject: [openstreetmap/openstreetmap-website] Edit dropdown is hard to use on touch devices. (#271) In-Reply-To: <openstreetmap/openstreetmap-website/issues/271@github.com> References: <openstreetmap/openstreetmap-website/issues/271@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/271/523827380@github.com> Because nobody has volunteered a fix. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/271#issuecomment-523827380 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/9cd014fa/attachment-0001.html> From notifications at github.com Thu Aug 22 09:32:45 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 22 Aug 2019 02:32:45 -0700 Subject: [openstreetmap/openstreetmap-website] Overpass query bbox to use map precision (#2354) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2354@github.com> References: <openstreetmap/openstreetmap-website/pull/2354@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2354/c523828245@github.com> Well sure there may not be any good reason to send 15 but is there any good reason not to? Does adding this extra code solve some technical issue? I don't believe that URL is visible anywhere so I don't think there's any UX concern here is there? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2354#issuecomment-523828245 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/1defda7c/attachment.html> From notifications at github.com Thu Aug 22 11:22:31 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 22 Aug 2019 04:22:31 -0700 Subject: [openstreetmap/openstreetmap-website] Numericality validation typo - should be `only_integer` instead of `integer_only` (#2355) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2355@github.com> References: <openstreetmap/openstreetmap-website/issues/2355@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2355/issue_event/2576114464@github.com> Closed #2355 via 135ec35a91bcca15637b6436dd7e546468c49690. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2355#event-2576114464 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/a4e36b0d/attachment.html> From notifications at github.com Thu Aug 22 11:43:51 2019 From: notifications at github.com (Simon Poole) Date: Thu, 22 Aug 2019 04:43:51 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523869662@github.com> > But lets not get stuck on the biggest problem, and one that's not yet in hand. In the meantime, there's a ton of backwards-compatible but needs-API-bump changes that have been stuck for years, so we can at least sort out those ones 😄 Likely making myself very unpopular: - where are all these "backward-compatible but needs-API-bump changes that have been stuck for years changes" documented? - in general I oppose all of this on the grounds that the GDPR related changes need to be implemented first and I'm actually surprised that "nice to have" API changes are even being given a seconds thought in the current situation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523869662 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/edbe66b4/attachment.html> From notifications at github.com Thu Aug 22 11:47:35 2019 From: notifications at github.com (mmd) Date: Thu, 22 Aug 2019 04:47:35 -0700 Subject: [openstreetmap/openstreetmap-website] Overpass query bbox to use map precision (#2354) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2354@github.com> References: <openstreetmap/openstreetmap-website/pull/2354@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2354/c523870774@github.com> It's really a matter of consistency, as we're already using a limited number of digits for `(around:xx,lat,lon)` in the same query. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2354#issuecomment-523870774 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/6068f004/attachment.html> From notifications at github.com Thu Aug 22 12:02:44 2019 From: notifications at github.com (Andy Allan) Date: Thu, 22 Aug 2019 05:02:44 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523875346@github.com> > * where are all these "backward-compatible but needs-API-bump changes that have been stuck for years changes" documented? Find your favourite API-0.7 wishlist, ignore the stuff about areas, and there's your list. :smile: Different people have created different lists over the years. I'm not intending to implement many changes, just the ones that I've been personally complaining about since API 0.6 was released over a decade ago (like incorrect http status codes, and plain-text responses, and stuff like that). > in general I oppose all of this on the grounds that the GDPR related changes need to be implemented first I know that you **want** them first, but that doesn't mean that they **need** to be done first. In particular, if the GDPR-related changes can be made without changing the API version then they can be implemented in parallel to this work, and so they are not interdependent. If they need to break API compatibility, then this work will need to come first anyway. So either way, they don't need to come first. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523875346 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/fe373697/attachment.html> From notifications at github.com Thu Aug 22 13:26:22 2019 From: notifications at github.com (Bryan Housel) Date: Thu, 22 Aug 2019 06:26:22 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523905450@github.com> > I should have said, if there's specific API changes that you're thinking about, even if they are just to illustrate a point, let me know and I'll see how they fit. Just off the top of my head, we'd see some immediate performance improvement on the iD side from: - JSON API (#2221) - Multi-fetch GET with /full (#2348) (these require some coordination from the CGImap side too, but I don't think that's a blocker) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523905450 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/83ff014b/attachment.html> From notifications at github.com Thu Aug 22 15:03:56 2019 From: notifications at github.com (Simon Poole) Date: Thu, 22 Aug 2019 08:03:56 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523945326@github.com> Except, naturally, that neither of #2221 and #2348 depend on this PR. Without it (this PR) we would have simply added them as a 0.6 feature, as we have done so many times before and not doing that raises the whole question of versioning of the OSM API in general which is a rabbit hole of its own , -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523945326 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/7adebe33/attachment-0001.html> From notifications at github.com Thu Aug 22 15:27:05 2019 From: notifications at github.com (mmd) Date: Thu, 22 Aug 2019 08:27:05 -0700 Subject: [openstreetmap/openstreetmap-website] Multi Fetch GET with /full option? (#2348) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2348@github.com> References: <openstreetmap/openstreetmap-website/issues/2348@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2348/523954804@github.com> As I mentioned in the linked issue, we still need to sort out, how the new "multi fetch with full option" is exposed via the API. Should we extend the existing endpoint (if so, how exactly should that look like?), or would it make more sense to define a new endpoint? That's more or less the same level of detail you would need to update the OSM API documentation in the WIki. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2348#issuecomment-523954804 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/84cd6688/attachment.html> From notifications at github.com Thu Aug 22 16:37:45 2019 From: notifications at github.com (docljn) Date: Thu, 22 Aug 2019 09:37:45 -0700 Subject: [openstreetmap/openstreetmap-website] Edit dropdown is hard to use on touch devices. (#271) In-Reply-To: <openstreetmap/openstreetmap-website/issues/271@github.com> References: <openstreetmap/openstreetmap-website/issues/271@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/271/523982192@github.com> Thanks @tomhughes : I wanted to make sure it was still a relevant issue that the team would like help with... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/271#issuecomment-523982192 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/8dce1e67/attachment.html> From notifications at github.com Thu Aug 22 18:11:27 2019 From: notifications at github.com (mmd) Date: Thu, 22 Aug 2019 11:11:27 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/524016999@github.com> I don't to go into details about the differences between UX and UI design, as it would be a bit beyond the scope of this issue. I'm 100% positive that you need to think this issue end-to-end starting from the editing app to the API to get some meaningful results, rather than just annoy users with arbitrary limits. This is mainly a JOSM issue. I clearly don't see any of the other editors anywhere close to creating a similar amount of data to upload (ignoring command line tools for a second). >From the API side, we can rather easily calculate both the number of changesets a user created during the last "n" hours, as well as as well as the total number of changes via some database statement. Number of changes would include any kind of operation (creating/updating/deleting) without knowing any further details. Those figures should be checked at the time when a new changeset is being created, rather than during the upload itself (I think the reasons are clear). A meaningful response should of course include the estimated waiting time, otherwise the error message won't make much sense to a user. I would consider anything that requires any sort of domain knowledge (e.g. counting "number of houses") to be out of scope for the API. If a user uploads tons of objects with rather uncommon tags, the editor app should take care of that. Still, the overall approach as it stands has a massive negative impact on people trying to clean up failed imports from other mappers or simply revert vandalism. I want to see a bit more discussion how those negative effects can be minimized, if not completely avoided. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-524016999 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/1aee79ce/attachment.html> From notifications at github.com Thu Aug 22 18:40:30 2019 From: notifications at github.com (Frederik Ramm) Date: Thu, 22 Aug 2019 11:40:30 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/524027394@github.com> I suggested in my initial message that there could be a mechanism whereby people could - perhaps temporarily - lift the limit in a self-service fashion. That would go a long way to ensure that if someone knows what they're doing they will not be hindered, but if someone does *not* know what they're doing they will be. I agree that all the API can do is count the number of modifications, not what exactly something is, and I never intended it to; I mentioned houses just as an example. If someone uploads a hundred thousand trees (or, also a popular option, a hundred thousand untagged objects), or *deletes* a hundred thousand houses, that's just as bad. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-524027394 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/7b3b41e0/attachment.html> From notifications at github.com Fri Aug 23 01:55:29 2019 From: notifications at github.com (Eliot Blennerhassett) Date: Thu, 22 Aug 2019 18:55:29 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) Message-ID: <openstreetmap/openstreetmap-website/issues/2356@github.com> In my experience, neither Search nor Directions prioritise nearby places. ## Search Example: I start here Christchurch City, New Zealand. https://www.openstreetmap.org/#map=12/-43.5315/172.5830 Search for "cashmere high school", which is in the view. The map jumps to Washington, USA. Desired result: Select the closest, order by distance. ## Directions Then select the correct (2nd) entry, click Directions arrow button, and put pin on the school.christchurch Enter "airport" into the destination box, click GO. Result: Destination filled in with "Airport, Access to Metro 'Aeroporto', Olivais, Santa Maria de Olivais, Lisbon, Grande Lisboa, Área Metropolitana de Lisboa, 1700-008, Portugal" Routing displays:"Couldn't find a route between those two places." Change destination to "Christchurch Airport", Result: Destination="Spence, B4234, Lydbrook, Forest of Dean, Gloucestershire, South West England, England, GL17 9NS, United Kingdom". Routing displays:"Couldn't find a route between those two places." Unlike the Search results, there is no list of found places to select from, the first one is always used. Desired result: Closest reachable destination used(?) or at least a selection of found places to choose from. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/9439bcff/attachment-0001.html> From notifications at github.com Fri Aug 23 06:07:15 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 22 Aug 2019 23:07:15 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2356/issue_event/2578624722@github.com> Closed #2356. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#event-2578624722 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/ea9f468d/attachment.html> From notifications at github.com Fri Aug 23 06:07:15 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 22 Aug 2019 23:07:15 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2356/524185284@github.com> Search bugs need to be reported to https://github.com/openstreetmap/Nominatim/issues which is the tracker for our geocoding engine. We do prioritise nearby places though, or at least we pass the search engine the current viewport so that it can do so. I believe it doubles the size of that box and considers anything in that area as "near" rather than doing a full global sort by distance which may be the issue you are seeing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#issuecomment-524185284 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/6c51abe6/attachment.html> From notifications at github.com Fri Aug 23 08:07:49 2019 From: notifications at github.com (Eliot Blennerhassett) Date: Fri, 23 Aug 2019 01:07:49 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2356/524217771@github.com> OK, it is hard to tell whether the problem is with the front or back end. The 2nd part of my issue, about directions (always get first item, don't see other search results) could be a front-end (enhancement or bug, if you like) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#issuecomment-524217771 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/5df0a44d/attachment.html> From notifications at github.com Fri Aug 23 13:43:56 2019 From: notifications at github.com (=?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?=) Date: Fri, 23 Aug 2019 06:43:56 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) Message-ID: <openstreetmap/openstreetmap-website/issues/2357@github.com> One sees "Zoom in to query features." However often those features one wants to query disappear when one zooms in! Therefore consider always allowing the user to query any item he can see. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/83c4b097/attachment.html> From notifications at github.com Fri Aug 23 14:30:27 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 23 Aug 2019 07:30:27 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2357@github.com> References: <openstreetmap/openstreetmap-website/issues/2357@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2357/524337469@github.com> That limitation is not there for fun, it's there because too many things would be found, or more likely the overpass query that drives it would just time out. You need to be zoomed in far enough that there are likely to only be a relatively small number of features within the search radius. Sorry if that is sometimes annoying, but it's the best we can do I'm afraid. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357#issuecomment-524337469 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/dd36e12d/attachment.html> From notifications at github.com Fri Aug 23 14:30:27 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 23 Aug 2019 07:30:27 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2357@github.com> References: <openstreetmap/openstreetmap-website/issues/2357@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2357/issue_event/2579890766@github.com> Closed #2357. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357#event-2579890766 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/a0a78ec2/attachment.html> From notifications at github.com Sat Aug 24 01:51:36 2019 From: notifications at github.com (Brian DeRocher) Date: Fri, 23 Aug 2019 18:51:36 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) Message-ID: <openstreetmap/openstreetmap-website/pull/2358@github.com> If your database already has this user you'll need to promote the user to superuser. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2358 -- Commit Summary -- * promote yourself to superuser -- File Changes -- M INSTALL.md (11) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2358.patch https://github.com/openstreetmap/openstreetmap-website/pull/2358.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/686f7bfd/attachment.html> From notifications at github.com Sat Aug 24 06:37:09 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 23 Aug 2019 23:37:09 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/issue_event/2581266814@github.com> Closed #2358. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#event-2581266814 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/56e22ec6/attachment.html> From notifications at github.com Sat Aug 24 06:37:09 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 23 Aug 2019 23:37:09 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524525724@github.com> No, deciding whether to promote your main development user to a database user is a personal decision that should be made with an understanding of the issues involved and not one we should encourage people to make unthinkingly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524525724 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/abfa93d7/attachment-0001.html> From notifications at github.com Sat Aug 24 16:34:55 2019 From: notifications at github.com (Frederik Ramm) Date: Sat, 24 Aug 2019 09:34:55 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524564125@github.com> Perhaps we should then at least write something like "note, some automated tests that try to execute CREATE EXTENSION commands on the database will fail when not run as a privileged database user"? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524564125 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190824/ad7c5f39/attachment.html> From notifications at github.com Sat Aug 24 16:36:03 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 24 Aug 2019 09:36:03 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524564209@github.com> Well we need to quantify the actual problem before we can formulate a solution - in other words under what circumstances in the permission required. There probably aren't any good solutions sadly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524564209 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190824/dde83044/attachment.html> From notifications at github.com Sun Aug 25 08:00:35 2019 From: notifications at github.com (Will White) Date: Sun, 25 Aug 2019 01:00:35 -0700 Subject: [openstreetmap/openstreetmap-website] No search button visible on mobile site (#1271) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1271@github.com> References: <openstreetmap/openstreetmap-website/issues/1271@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1271/524609864@github.com> I think search should have at least the same visibility as say, sharing the map. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1271#issuecomment-524609864 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/645d1736/attachment.html> From notifications at github.com Sun Aug 25 11:29:11 2019 From: notifications at github.com (=?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?=) Date: Sun, 25 Aug 2019 04:29:11 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2357@github.com> References: <openstreetmap/openstreetmap-website/issues/2357@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2357/524622516@github.com> Actually one would think a workaround would be just a select a different layer . However different layers , other than the standard layer, don't have those features in the first place. Example: https://www.openstreetmap.org/#map=9/24.2932/121.1177 Anyway, sometimes one really does want to find out what is causing a certain item to appear at lower Zoom values, but there's no way to find out. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357#issuecomment-524622516 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/fea12895/attachment.html> From notifications at github.com Sun Aug 25 15:43:45 2019 From: notifications at github.com (Brian DeRocher) Date: Sun, 25 Aug 2019 08:43:45 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524640102@github.com> Before I take a second stab at this can you tell me what you mean by "your current user". For me that's brian at localhost on a debian system. The problem was when I ran automated tests, they failed with the CREATE EXTENSION command. Perhaps the issue is with these words "your current user". Instead it should be "a newly created user that will own the openstreetmap database". Thoughts? Side note, you don't need superuser "so that we can create more databases". That can be granted to a user. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524640102 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/d8ba883d/attachment.html> From notifications at github.com Sun Aug 25 15:46:43 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 25 Aug 2019 08:46:43 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524640344@github.com> Well the general point is that you shouldn't be throwing around postgres superuser privileges without understanding what you are doing. Ideally there would be a single step that you could execute as the postgres user but as I say I'm not sure if that's actually possible. It may be that we should recommend an initial run of `rake test:db` as a database superuser to populate the test database but as I say it needs some research to see if that is good enough or under what circumstances rails may try and recreate the test database from scratch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524640344 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/ccfad700/attachment.html> From notifications at github.com Sun Aug 25 16:35:46 2019 From: notifications at github.com (Brian DeRocher) Date: Sun, 25 Aug 2019 09:35:46 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524644074@github.com> I found a way around this issue. It's to use a template database. PG 9.5 add the IS_TEMPLATE option to CREATE DATABASE. If true, anyone with CREATEDB privilege can clone it. If the template has the btree_gist extension, the new database will also have it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524644074 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/23958cd3/attachment.html> From notifications at github.com Sun Aug 25 16:51:48 2019 From: notifications at github.com (Brian DeRocher) Date: Sun, 25 Aug 2019 09:51:48 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524645290@github.com> I've done just a little research and found that rails does have some support for this. See activerecord-5.2.3/lib/active_record/connection_adapters/postgresql/schema_statements.rb, line 30. Though I'm not sure how easy this is to use. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524645290 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/dd227055/attachment.html> From notifications at github.com Sun Aug 25 16:58:35 2019 From: notifications at github.com (Brian DeRocher) Date: Sun, 25 Aug 2019 09:58:35 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installations are unmaintained (#2344) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2344@github.com> References: <openstreetmap/openstreetmap-website/issues/2344@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2344/524645738@github.com> I'd prefer to develop in a docker environment. I can work on creating a new Dockerfile. Do you have any requirements? My plan is to create 2 images, one for db and one for rails. For me this may have to wait until after SotM US. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomment-524645738 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/e9922e2e/attachment-0001.html> From notifications at github.com Sun Aug 25 17:32:17 2019 From: notifications at github.com (Holger Jeromin) Date: Sun, 25 Aug 2019 10:32:17 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2357@github.com> References: <openstreetmap/openstreetmap-website/issues/2357@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2357/524648160@github.com> > Anyway, sometimes one really does want to find out what is causing a certain item to appear at lower Zoom values, but there's no way to find out. This is a problem, but that could be a large osm landuse which is nowhere near the label point you want to analyse. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357#issuecomment-524648160 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/a4295745/attachment.html> From notifications at github.com Mon Aug 26 09:22:13 2019 From: notifications at github.com (mmd) Date: Mon, 26 Aug 2019 02:22:13 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installations are unmaintained (#2344) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2344@github.com> References: <openstreetmap/openstreetmap-website/issues/2344@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2344/524788726@github.com> @openbrian : see https://github.com/openstreetmap/openstreetmap-website/pull/2272 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomment-524788726 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/0eb83307/attachment.html> From notifications at github.com Mon Aug 26 09:26:21 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 26 Aug 2019 02:26:21 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installations are unmaintained (#2344) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2344@github.com> References: <openstreetmap/openstreetmap-website/issues/2344@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2344/524790024@github.com> Yes this ticket is probably a bit confusing because I opened it thinking we already had a docker config but apparently my memory was faulty... Though it's definitely true that it would be good to have it tested to stop it breaking. That's something that I think travis can do, unlike vagrant. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomment-524790024 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/08eba276/attachment.html> From notifications at github.com Mon Aug 26 10:32:55 2019 From: notifications at github.com (Richard Fairhurst) Date: Mon, 26 Aug 2019 03:32:55 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2356/524810039@github.com> The intention (certainly from my POV when I did the initial coding on the directions feature) was ultimately for the JS client to call the geocoding sources directly, rather than having geocoder_controller.rb call and agglomerate them. This would then enable refactoring so that the directions could use the same code as the standard placename search. It'd be a good project for a JS developer to work on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#issuecomment-524810039 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/2769cf63/attachment.html> From notifications at github.com Mon Aug 26 10:34:48 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 26 Aug 2019 03:34:48 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2356/524810543@github.com> I was looking to move the geocoding search to the client side but @gravitystorm was against it I think. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#issuecomment-524810543 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/80d210bf/attachment.html> From notifications at github.com Mon Aug 26 12:40:09 2019 From: notifications at github.com (=?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?=) Date: Mon, 26 Aug 2019 05:40:09 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2357@github.com> References: <openstreetmap/openstreetmap-website/issues/2357@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2357/524844187@github.com> OK. https://help.openstreetmap.org/questions/70512/how-to-query-features-without-zooming has some workarounds. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357#issuecomment-524844187 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/05d47298/attachment.html> From notifications at github.com Mon Aug 26 18:19:23 2019 From: notifications at github.com (Bryan Housel) Date: Mon, 26 Aug 2019 11:19:23 -0700 Subject: [openstreetmap/openstreetmap-website] Update to iD v2.15.5 (#2359) Message-ID: <openstreetmap/openstreetmap-website/pull/2359@github.com> # 2.15.5 ##### 2019-Aug-26 #### :boom: Breaking Changes * Remove support for Node 6 (Node 8 or higher is now required) * :warning: If you are building the iD project, you will need to upgrade your node version. #### :sparkles: Usability * Make the UI more navigable by tabbing ([#6701], thanks [@Abbe98]) * Render Sidewalks in a different color than Foot Paths ([#6522]) * List the user's language and common nearby languages first in the Multilingual Name language list ([#6712]) * Add more language options to the Multilingual Name list * Enable searching fields by tag and keyword ([#5763]) * Accept relation IDs in the "Choose a parent relation" dropdown ([#3487]) * Highlight relations in the map when hovering over them in the "Choose a parent relation" dropdown ([#2946]) * Show addable presets specified by the `presets` URL parameter in the default preset list ([#6703]) * Interpret the `º` and `˚` characters as degrees when searching coordinates * Make the post-upload changeset number clickable ([#6644]) * Allow selecting and copying tags from Custom Map Data ([#6710]) * Select points after dragging them ([#5747]) [#2946]: https://github.com/openstreetmap/iD/issues/2946 [#3487]: https://github.com/openstreetmap/iD/issues/3487 [#5747]: https://github.com/openstreetmap/iD/issues/5747 [#5763]: https://github.com/openstreetmap/iD/issues/5763 [#6522]: https://github.com/openstreetmap/iD/issues/6522 [#6644]: https://github.com/openstreetmap/iD/issues/6644 [#6701]: https://github.com/openstreetmap/iD/issues/6701 [#6703]: https://github.com/openstreetmap/iD/issues/6703 [#6710]: https://github.com/openstreetmap/iD/issues/6710 [#6712]: https://github.com/openstreetmap/iD/issues/6712 [@Abbe98]: https://github.com/Abbe98 #### :white_check_mark: Validation * Don't flag known brands for having generic names ([#6761], [#6754], thanks [@SilentSpike]) * Clarify that connecting a waterway crossing a highway will add a ford ([#6734]) * Lock the Name field of features with a `name:etymology:wikidata` tag ([#6683]) * Don't offer to add `highway=service` to demolished roads with `service` tags ([#6775]) * Upgrade `crossing=island` to `crossing:island=yes` ([#6748]) * Upgrade `diaper` to `changing_table` ([#6529]) * Upgrade `access=public` to `access=yes` ([#6716]) * Deprecate `tower:type=anchor` and `tower:type=suspension` ([#6762]) * Deprecate `landuse=garden` ([#6758]) * Deprecate `roof:shape=half_hipped` ([#6704]) [#6529]: https://github.com/openstreetmap/iD/issues/6529 [#6683]: https://github.com/openstreetmap/iD/issues/6683 [#6704]: https://github.com/openstreetmap/iD/issues/6704 [#6716]: https://github.com/openstreetmap/iD/issues/6716 [#6734]: https://github.com/openstreetmap/iD/issues/6734 [#6748]: https://github.com/openstreetmap/iD/issues/6748 [#6754]: https://github.com/openstreetmap/iD/issues/6754 [#6758]: https://github.com/openstreetmap/iD/issues/6758 [#6761]: https://github.com/openstreetmap/iD/issues/6761 [#6762]: https://github.com/openstreetmap/iD/issues/6762 [#6775]: https://github.com/openstreetmap/iD/issues/6775 [@SilentSpike]: https://github.com/SilentSpike #### :bug: Bugfixes * Boost preset matching score if match occurs in addTags ([#6802]) * Fix error upon changing the Unsquare Building threshold ([#6690]) * Don't hide all multilingual names upon deleting one ([#6491]) * Correctly populate the Bike Lanes field with existing values ([#6141]) * Show the correct location for coordinates in the `N DD° MM.MMM' W DD° MM.MMM'` format without a commma separator ([#6582]) * Don't treat platforms with a `kerb` tag as primarily curbs ([#6742]) * Remove deleted features from the map immediately when undoing or redoing ([#6480]) * Properly resize Mapillary and Bing Streetside photos when resizing the viewer ([#6286]) * Fix issue where the Background Offset field could not be focused ([#6698]) [#6141]: https://github.com/openstreetmap/iD/issues/6141 [#6286]: https://github.com/openstreetmap/iD/issues/6286 [#6480]: https://github.com/openstreetmap/iD/issues/6480 [#6491]: https://github.com/openstreetmap/iD/issues/6491 [#6582]: https://github.com/openstreetmap/iD/issues/6582 [#6690]: https://github.com/openstreetmap/iD/issues/6690 [#6698]: https://github.com/openstreetmap/iD/issues/6698 [#6742]: https://github.com/openstreetmap/iD/issues/6742 [#6802]: https://github.com/openstreetmap/iD/issues/6802 #### :earth_asia: Localization * Display the languages for the Multilingual Name field in the user's language, if available ([#2457], [#6702]) * Translate language names in the post-upload community list ([#4990]) [#2457]: https://github.com/openstreetmap/iD/issues/2457 [#4990]: https://github.com/openstreetmap/iD/issues/4990 [#6702]: https://github.com/openstreetmap/iD/issues/6702 #### :rocket: Presets * Add Rental Shop preset * Remove standalone Tactile Paving preset ([#6490], [#6791]) * Add Bottle Return Machine preset ([#6725], thanks [@ENT8R]) * Add Letter Box preset with Delivery Address field ([#6718]) * Add Post Sorting Office preset ([#6773]) * Add E-Waste Container preset ([#6777]) * Add Obelisk preset ([#6790]) * Add Flowerbed and Green Waste Container presets * Add Line Attachment field to Power Pole and Power Tower ([#6762]) * Add Species Wikidata field to Animal Enclosure and Tree ([#6652]) * Add Fee Amount an Toll Amount fields ([#6722]) * Add Stroller Access field ([#6739]) * Add Refuge Island field to crossings ([#6748]) * Add Incorrect Names field for common naming mistakes ([#6411]) * Update icons for Power Pole, Power Tower, and Power Line ([#6786]) * Update icon for cycle paths, crossings, and tracks * Only allow `power=transformer` on nodes ([#6779]) [#6411]: https://github.com/openstreetmap/iD/issues/6411 [#6490]: https://github.com/openstreetmap/iD/issues/6490 [#6652]: https://github.com/openstreetmap/iD/issues/6652 [#6718]: https://github.com/openstreetmap/iD/issues/6718 [#6722]: https://github.com/openstreetmap/iD/issues/6722 [#6725]: https://github.com/openstreetmap/iD/issues/6725 [#6739]: https://github.com/openstreetmap/iD/issues/6739 [#6748]: https://github.com/openstreetmap/iD/issues/6748 [#6762]: https://github.com/openstreetmap/iD/issues/6762 [#6773]: https://github.com/openstreetmap/iD/issues/6773 [#6777]: https://github.com/openstreetmap/iD/issues/6777 [#6779]: https://github.com/openstreetmap/iD/issues/6779 [#6786]: https://github.com/openstreetmap/iD/issues/6786 [#6790]: https://github.com/openstreetmap/iD/issues/6790 [#6791]: https://github.com/openstreetmap/iD/issues/6791 [@ENT8R]: https://github.com/ENT8R You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2359 -- Commit Summary -- * Update to iD v2.15.5 -- File Changes -- M vendor/assets/iD/iD.css.erb (31) M vendor/assets/iD/iD.js (1332) M vendor/assets/iD/iD/img/fa-sprite.svg (2) M vendor/assets/iD/iD/img/temaki-sprite.svg (2) M vendor/assets/iD/iD/locales/ar.json (25) M vendor/assets/iD/iD/locales/ast.json (6) M vendor/assets/iD/iD/locales/be.json (22) M vendor/assets/iD/iD/locales/bg.json (3) M vendor/assets/iD/iD/locales/bn.json (3) M vendor/assets/iD/iD/locales/bs.json (4) M vendor/assets/iD/iD/locales/ca.json (7) M vendor/assets/iD/iD/locales/ckb.json (170) M vendor/assets/iD/iD/locales/cs.json (19) M vendor/assets/iD/iD/locales/da.json (25) M vendor/assets/iD/iD/locales/de.json (506) M vendor/assets/iD/iD/locales/el.json (41) M vendor/assets/iD/iD/locales/en-AU.json (3) M vendor/assets/iD/iD/locales/en-GB.json (6) M vendor/assets/iD/iD/locales/en.json (1089) M vendor/assets/iD/iD/locales/eo.json (52) M vendor/assets/iD/iD/locales/es.json (488) M vendor/assets/iD/iD/locales/et.json (8) M vendor/assets/iD/iD/locales/eu.json (3) M vendor/assets/iD/iD/locales/fa.json (32) M vendor/assets/iD/iD/locales/fi.json (314) M vendor/assets/iD/iD/locales/fr.json (94) M vendor/assets/iD/iD/locales/gl.json (18) M vendor/assets/iD/iD/locales/he.json (137) M vendor/assets/iD/iD/locales/hr.json (60) M vendor/assets/iD/iD/locales/hu.json (1521) M vendor/assets/iD/iD/locales/id.json (3) M vendor/assets/iD/iD/locales/is.json (6) M vendor/assets/iD/iD/locales/it.json (128) M vendor/assets/iD/iD/locales/ja.json (476) M vendor/assets/iD/iD/locales/ko.json (14) M vendor/assets/iD/iD/locales/lt.json (7) M vendor/assets/iD/iD/locales/lv.json (7) A vendor/assets/iD/iD/locales/mi.json (35) M vendor/assets/iD/iD/locales/mk.json (447) M vendor/assets/iD/iD/locales/ms.json (6) M vendor/assets/iD/iD/locales/nl.json (15) M vendor/assets/iD/iD/locales/nn.json (593) M vendor/assets/iD/iD/locales/no.json (3) M vendor/assets/iD/iD/locales/pl.json (648) M vendor/assets/iD/iD/locales/pt-BR.json (163) M vendor/assets/iD/iD/locales/pt.json (22) M vendor/assets/iD/iD/locales/ro.json (3) M vendor/assets/iD/iD/locales/ru.json (177) M vendor/assets/iD/iD/locales/sk.json (7) M vendor/assets/iD/iD/locales/sl.json (7) M vendor/assets/iD/iD/locales/sr.json (6) M vendor/assets/iD/iD/locales/sv.json (492) M vendor/assets/iD/iD/locales/ta.json (3) M vendor/assets/iD/iD/locales/tr.json (7) M vendor/assets/iD/iD/locales/uk.json (162) M vendor/assets/iD/iD/locales/vi.json (13) M vendor/assets/iD/iD/locales/yue.json (7) M vendor/assets/iD/iD/locales/zh-CN.json (107) M vendor/assets/iD/iD/locales/zh-HK.json (7) M vendor/assets/iD/iD/locales/zh-TW.json (191) M vendor/assets/iD/iD/locales/zh.json (11) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2359.patch https://github.com/openstreetmap/openstreetmap-website/pull/2359.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2359 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/d0ed8796/attachment-0001.html> From notifications at github.com Mon Aug 26 22:57:08 2019 From: notifications at github.com (Eliot Blennerhassett) Date: Mon, 26 Aug 2019 15:57:08 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2356/525064805@github.com> Any chance of opening this issue again. Change title to "Directions doesn't allow choosing from search results" or something. I think this is a web UI issue rather than Nominatim. I've opened a separate Nominatim issue about the actual search results. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#issuecomment-525064805 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/124f91e5/attachment.html> From notifications at github.com Tue Aug 27 02:19:26 2019 From: notifications at github.com (dependabot[bot]) Date: Mon, 26 Aug 2019 19:19:26 -0700 Subject: [openstreetmap/openstreetmap-website] Bump eslint-utils from 1.3.1 to 1.4.2 (#2360) Message-ID: <openstreetmap/openstreetmap-website/pull/2360@github.com> Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.2. <details> <summary>Commits</summary> - [`4e1bc07`](https://github.com/mysticatea/eslint-utils/commit/4e1bc077c2a6bb00538d66b69a63c24de3463bed) 1.4.2 - [`e4cb014`](https://github.com/mysticatea/eslint-utils/commit/e4cb01498df6096b66edb0c78965ee6f47d3ac77) 🐛 add null test - [`230a4e2`](https://github.com/mysticatea/eslint-utils/commit/230a4e2275cde169cbfbb95cd2e4de2152fae0a2) 1.4.1 - [`08158db`](https://github.com/mysticatea/eslint-utils/commit/08158db1c98fd71cf0f32ddefbc147e2620e724c) 🐛 fix getStaticValue security issue - [`587cca2`](https://github.com/mysticatea/eslint-utils/commit/587cca2f82c245f5fc4a8b9fb2cf6b35c0d02552) 🐛 fix getStringIfConstant to handle literals correctly - [`c119e83`](https://github.com/mysticatea/eslint-utils/commit/c119e832952c8c653bd4f21e39eb9f7ce48e5947) 🐛 fix getStaticValue to handle bigint correctly - [`531b16f`](https://github.com/mysticatea/eslint-utils/commit/531b16fa686b80a8cc450eb87525115233ce6064) 🔖 1.4.0 - [`276303d`](https://github.com/mysticatea/eslint-utils/commit/276303d826bf94b9e6d6cdf5697cb1feb54c89ca) ⚒ upgrade rollup - [`cb518c7`](https://github.com/mysticatea/eslint-utils/commit/cb518c70ee037722f802d808bbbe93da83f07fb3) 🐛 fix hasSideEffect false negative - [`aac472e`](https://github.com/mysticatea/eslint-utils/commit/aac472e815551688d23cc8fd88f9044dbf276804) 🐛 fix isParenthesized had false positive on ImportExpression (fixes [#1](https://github-redirect.dependabot.com/mysticatea/eslint-utils/issues/1)) - Additional commits viewable in [compare view](https://github.com/mysticatea/eslint-utils/compare/v1.3.1...v1.4.2) </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eslint-utils&package-manager=npm_and_yarn&previous-version=1.3.1&new-version=1.4.2)](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/openstreetmap/openstreetmap-website/network/alerts). </details> You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2360 -- Commit Summary -- * Bump eslint-utils from 1.3.1 to 1.4.2 -- File Changes -- M yarn.lock (14) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2360.patch https://github.com/openstreetmap/openstreetmap-website/pull/2360.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2360 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/196fe3c3/attachment.html> From notifications at github.com Tue Aug 27 05:02:39 2019 From: notifications at github.com (Noctis Lucis Sora (Qais)) Date: Mon, 26 Aug 2019 22:02:39 -0700 Subject: [openstreetmap/openstreetmap-website] [Feature Request] Progressive Web App Support (#2361) Message-ID: <openstreetmap/openstreetmap-website/issues/2361@github.com> Please Add PWA Support In OpenStreetMap Web Site -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2361 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/b35d6e9b/attachment.html> From notifications at github.com Tue Aug 27 06:07:21 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 26 Aug 2019 23:07:21 -0700 Subject: [openstreetmap/openstreetmap-website] Progressive Web App Support (#2361) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2361@github.com> References: <openstreetmap/openstreetmap-website/issues/2361@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2361/525152913@github.com> Well it might be more likely if you explained what "PWA support" is exactly... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2361#issuecomment-525152913 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/67d62aec/attachment.html> From notifications at github.com Tue Aug 27 06:07:41 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 26 Aug 2019 23:07:41 -0700 Subject: [openstreetmap/openstreetmap-website] Bump eslint-utils from 1.3.1 to 1.4.2 (#2360) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2360@github.com> References: <openstreetmap/openstreetmap-website/pull/2360@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2360/issue_event/2585848834@github.com> Closed #2360. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2360#event-2585848834 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/dde3642e/attachment-0001.html> From notifications at github.com Tue Aug 27 06:07:43 2019 From: notifications at github.com (dependabot[bot]) Date: Mon, 26 Aug 2019 23:07:43 -0700 Subject: [openstreetmap/openstreetmap-website] Bump eslint-utils from 1.3.1 to 1.4.2 (#2360) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2360@github.com> References: <openstreetmap/openstreetmap-website/pull/2360@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2360/c525152997@github.com> OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2360#issuecomment-525152997 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/a067afea/attachment.html> From notifications at github.com Tue Aug 27 07:00:24 2019 From: notifications at github.com (Noctis Lucis Sora (Qais)) Date: Tue, 27 Aug 2019 00:00:24 -0700 Subject: [openstreetmap/openstreetmap-website] Progressive Web App Support (#2361) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2361@github.com> References: <openstreetmap/openstreetmap-website/issues/2361@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2361/525168012@github.com> Progressive web applications (PWAs) are a type of mobile app delivered through the web, built using common web technologies including HTML, CSS and JavaScript. They are intended to work on any platform that uses a standards-compliant browser. Functionality includes working offline, push notifications, and device hardware access, enabling creating user experiences similar to native applications on mobile devices. Since they are a type of webpage or website known as a web application, there is no requirement for developers or users to install the web apps via digital distribution systems like Apple App Store or Google Play. While web applications have been available for mobile devices for as long as mobile devices have existed, they generally lag behind native apps in terms of speed, features, and user adoption, especially on mobile devices. Among other features, the ability to work offline, previously only available to native apps, allows PWAs to perform much faster and to provide more features to help close the gap with native apps. PWAs do not require separate bundling or distribution. Publication of a progressive web app is as it would be for any other web page. PWAs work in any browser, but "app-like" features such as being independent of connectivity, install to home screen and push messaging depend on browser support. As of April 2018, those features are supported to varying degrees by the Microsoft Edge, Google Chrome, Mozilla Firefox and Apple Safari browsers, but more browsers may support the features needed in the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2361#issuecomment-525168012 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190827/5c5ccb6f/attachment.html> From notifications at github.com Tue Aug 27 07:28:28 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 27 Aug 2019 00:28:28 -0700 Subject: [openstreetmap/openstreetmap-website] Progressive Web App Support (#2361) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2361@github.com> References: <openstreetmap/openstreetmap-website/issues/2361@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2361/525176890@github.com> Right, but that's a pretty vague description - marketing hype for the most part. Is there some concrete change you are looking for? I mean taking the broad list of functionality there we have: * Works on any platform that uses a standards-compliant browser, which is already pretty much the case. * Works offline, which doesn't make much sense in the case of OpenStreetMap. * Push notifications, which are extremely contentious in any case, but we can certainly look at that if you have a concrete proposal for where they would be useful. * Device hardware access, which we do where it makes sense, like accessing device location on request, but again if you have concrete suggestions for changes we can consider them. I think in summary this ticket is too vague to be useful, but if you have concrete suggestions for specific changes then please do raise them. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2361#issuecomment-525176890 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190827/b4747a9f/attachment.html> From notifications at github.com Tue Aug 27 07:28:29 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 27 Aug 2019 00:28:29 -0700 Subject: [openstreetmap/openstreetmap-website] Progressive Web App Support (#2361) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2361@github.com> References: <openstreetmap/openstreetmap-website/issues/2361@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2361/issue_event/2586037578@github.com> Closed #2361. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2361#event-2586037578 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190827/198d6f45/attachment.html> From notifications at github.com Tue Aug 27 14:29:27 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 27 Aug 2019 07:29:27 -0700 Subject: [openstreetmap/openstreetmap-website] Update to iD v2.15.5 (#2359) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2359@github.com> References: <openstreetmap/openstreetmap-website/pull/2359@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2359/issue_event/2587305554@github.com> Merged #2359 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2359#event-2587305554 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190827/c451e301/attachment.html> From notifications at github.com Wed Aug 28 09:06:39 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 02:06:39 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/push/3970879915@github.com> @gravitystorm pushed 4 commits. 821ec5b5a3f1d22e3c9aea1130a5515d12d08788 Back out changes to changeset_comments routes for now 6ddad60a3e2a5f59f0a1432c9a82244d037156f8 Add a latest_api_version and use it on the browse pages 9622f1609ee872c91515d681652f37eb20690491 Hardcode some links to the 0.6 api, for now 841c75429fb0cf31193542fe03a75a4c2665170a Rework some relations tests that rely on creating changesets -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353/files/f1d91c8aa910792fad84bde770076b87b4c4e609..841c75429fb0cf31193542fe03a75a4c2665170a -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/43efb8f2/attachment.html> From notifications at github.com Wed Aug 28 09:19:00 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 02:19:00 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/push/3970929703@github.com> @gravitystorm pushed 1 commit. b8c3944f2c8aa5340c83799180685a8d0175e47d Ignore block length in tests -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353/files/841c75429fb0cf31193542fe03a75a4c2665170a..b8c3944f2c8aa5340c83799180685a8d0175e47d -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/03cf564c/attachment.html> From notifications at github.com Wed Aug 28 09:29:10 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 02:29:10 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c525662489@github.com> I've updated this PR so that the test suite passes, and it's now ready for review. Currently only a few routes have been adapted for multiple API version support, namely: * capabilities * permissions * changesets I intend to work on the rest of the routes in subsequent PRs. The settings in this PR ensure that only 0.6 is deployed by default, so it can be merged without any side effects. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-525662489 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/869a1346/attachment.html> From notifications at github.com Wed Aug 28 09:33:31 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 02:33:31 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c525664048@github.com> > I think the only question that remains is the policy one of whether we want to do this. I think it should be merged. The evidence presented is convincing to me. It's also a reversible change - if worst comes to worst and there's a compelling reason later on to allow anonymous comments again, we can easily do that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-525664048 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/bfc6104b/attachment.html> From notifications at github.com Wed Aug 28 09:51:42 2019 From: notifications at github.com (Simon Poole) Date: Wed, 28 Aug 2019 02:51:42 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c525670609@github.com> Could we get it on the sandbox first? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-525670609 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/3c630975/attachment-0001.html> From notifications at github.com Wed Aug 28 10:03:00 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 03:03:00 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c525674875@github.com> > Could we get it on the sandbox first? First? Do you mean before code review? Or if you want it before merging, to what end? So far this PR is just internal code refactoring, there's no changes to the API (other than dropping one line from the api/0.7/capabilities response) and even if this is merged there will still be no changes since 0.7 is disabled. So we can ask Tom to set up a sandbox "first", but I'm not sure what you would want to do with it? Of course, it'll be worth having a sandbox available later on, but I don't think it's worthwhile effort at this stage. If you still have concerns, let me know what I can do to help. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-525674875 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/e8d0913a/attachment.html> From notifications at github.com Wed Aug 28 10:32:53 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 03:32:53 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/push/3971223671@github.com> @gravitystorm pushed 169 commits. 17e6e69c39072d8e6cb316b75b311e89c92cca45 Move generation of gpx_file XML from model to builder 363155a2a86796d27ee9161f1ee9b74d6fa307e5 Move xml gen. into view for (old) nodes, ways, relations, map 2142ff02c2442d28580ff99080bc1219c2bfe59f Allow moderators to hide diary entries and comments 26cbdcf71a68d5515c91bf9cb4ec958ce90c2647 Fix importing of GPX traces with a leading byte order marker 7f61fc22de8d46bfcdcce44edcfdc912d951070e Allow indexing of diary entries again 7a91da329dca7b7338384a4d738ae56d16812ab7 Allow indexing of diary entries again 42269d91fee778f28af4c8fb60bba5dcd6a886b3 Localisation updates from https://translatewiki.net. 7ee554ed64d67cee025e3a5c80ba9404b01b407f Update to iD v2.15.2 7fb85f1ca6417f4f0e20b8e33ed92d5d531897e9 Pass through `photo_overlay` parameter 657ed03d8b2e262bc965cc38e8af190624c3295b Update bundle 31edc7dff6f4305366d0f93d35ba3fb1956bb71f Merge remote-tracking branch 'upstream/pull/2226' 74af87d9d1006a5c664398de19da31ad9c29776c Add translations for distance_in_time_ago 1cf8fec58d2e32d431aaee51213d738241e39e66 Rename Friend model to Friendship 2169c503efbbeb45c3842e9fa5eef6cc01e8e27b Rename user.friend_users to user.friends d33b1f6b29651c7e8a021ab37f8659054df4881f Pass the models, not the ids, when dealing with friendships cbb3c2bdf0843ad1fb0095cb5c4cefd83eb5507a Use user models, not ids, in assertions 1298d80549e428d4907a474a176805a11c969714 Use the distance_in_words_ago scope for trace display df560bd71dea9c222fcb233a36a906c2e08ebe30 Use the distance_in_words_ago scope for diary comments pages 50d469a74a95a26645fc0f8dbe2ad71b0de24e29 Use distance_in_words_ago scope for issues display 47e653ffe021339ff19b767cfa0c87a508687781 Use scope for time_ago when viewing users 00f75c175e432e51c7c80eff02384dc35294d760 Use scope for common details and changeset display in browse pages 54e0c7afb2b380a869097a3df826bb860248bb47 Use distance_in_words_ago scope for user blocks f284d57c6236327b50c8d4a2ac0545105d1d03cc Add a friendly_date_ago helper cd5e28406b93439465ef43ad0413720a60398f15 Use friendy_date_ago helper for notes 5e068152143a27fbf34ed6c90773f46b59039c70 Use friendly_date_ago helper for user_blocks 3167e6b4bbbf01c2b69d9e67117a734ff0544b6a Use friendly_date_ago helper for chnagesets 75bf96c4f3472a21163032a25ff7700d3c692225 Use friendly_date_ago helper for changeset comments e5d8bd539f045db1870a4722290f75b11cf4d2e0 Use friendly_date_ago for user blocks 220ad927662dcc3e93a7cee337ddc385e19cd386 Use friendly_date_ago for notes display 23dfc4d3bde49ef907de08ee2efbece0d4ce261d Update note comments to use friendly_date_ago helper 6b6345ecdba2589df96489b259651adb4c764362 Merge remote-tracking branch 'upstream/pull/2269' 80427b3e5e5ebeecbc0a57a1549a2a33e0c92199 Merge remote-tracking branch 'upstream/pull/2270' 16cbc2eb798ed3de360574c874049225641b3d76 Merge remote-tracking branch 'upstream/pull/2267' 81d6d6a6a353e1ba8cc448f40fba17a03cf2620f Localisation updates from https://translatewiki.net. dd281a19c48f0324ac617f490275dcbd52a6dd60 Update Potlatch 2 to 2.5-83-g28c84372 build fc67e63589536b0d8fa3a92aa7eff57ebeceb3a6 Block indexing of diary entries d2d5d48f2993f2ffca415362a40b8a02127bd4a8 Allow signups to be blocked by MX host 4440730c9b1014d81688655f4c3fca92b5a3225c Localisation updates from https://translatewiki.net. 1817032c87bf960fedbd8136fb2a974e56af9c4c Update bundle 5b4636d5213de2e699769821031c37663ab71557 Fix text direction for traditional chinese 16c3c533022d90cbfafecd17349d09fcbb7abed9 Merge remote-tracking branch 'upstream/pull/2271' c24b0e93997bcd6bcad475d9ba0adfe86fa01ea6 Rework to ensure views are named after the controller method name 3914050fcc24c8727c485412a69b12292bbf213d Simplify partial rendering when the partial is named after the model 0211141c085da26cd26001ae4ba0e0446b6ddd4e Simplify render calls for changesets f280dcb2d798b3dfd4aad345a1ab7efa10d8bbe4 Merge remote-tracking branch 'upstream/pull/2278' f77d4dc4f71b15af58ee6e5b5d63c436482e7b19 Avoid stating the action to render when it just matches the current action 899fc66a62b036adcfd59f5da80c7fc6f30cd3a8 Merge remote-tracking branch 'upstream/pull/2279' cbea796ef412840af9a3ec2fd26bf08657fc4cd3 Merge remote-tracking branch 'upstream/pull/2207' 2398614349e3ff5605868fea82e013d2a9a16ef9 Add support for an unversioned 'versions' API call 0dbb33016f77eef7d150044f06fc7ce86cde4d59 Rename @edits variable to @changesets, for clarity fd61706e4cc2d6909d424a1d0b147fc688ebd005 Split some extremely long strings over multiple lines using squiggly heredocs 89f8f7af3539588c234496dd769f9042199bd248 Merge remote-tracking branch 'upstream/pull/2281' b25f10eb56b1b2864d3a9eeff535caea119e55cc Merge remote-tracking branch 'upstream/pull/2282' a66c34991acfff398fbc83c921dfce18a835ee26 Merge remote-tracking branch 'upstream/pull/2280' 45e7c9a32e08446fd087580d84b2e11eadc1683d Avoid using @variables in partials d0de9967b9bd21c8e7c03e060626c4486b149fb2 Simplify partial rendering cf3cf5216fa3697ad2e3c060fced6a7bbb16f4a4 Avoid unnecessary arrays c1c277186ef0c519bed5b07e1b67ab8681010f15 Localisation updates from https://translatewiki.net. b9ae40d9784725b75e5b52f55659c80326656d8f Remove non functioning changeset_cache, user_display_name_cache 8ad1ce97983a5d4fb86ccb8ee4cd640a76f95255 Refactoring 11cc4a5e601dd288d601e6e35a72d159062f18b5 Merge branch 'master' into patch/view_migration 4e3527f5197449da89a78ac502d02cea6dec9f33 Fix text direction for traditional chinese 2bfb976b8e42f6ab0e87c053e91b2bc88538dba6 Revert XML default for routes fb953006a1a8fe2949f376e167dda963dfd784bd Replace respond_to with render xml format 84faaaf7950e61b5f87019398aeda0ead8d41c2c Rubocop 78ecc76067e434856358e609fa883619d316ffc4 Update list of dependencies to install 390c7d762429539627734dbd6142746a2ad9ca18 Fix spellings from aggree to agree b75cf73a5480600b2d53cceec2a230122f61b8fa Merge remote-tracking branch 'upstream/pull/2293' 12cdc58688e372b69abaea98cdc0090716ff0d36 Update to iD v2.15.3 55844044128d1ca8350884877ec822bb251cdd7e Merge remote-tracking branch 'upstream/pull/2294' a0660c009c554b19c77297aa1afb38291485adef Localisation updates from https://translatewiki.net. ea2c790a42cbb4ed6582646b8f45af5050ba472c Fix text direction for traditional chinese 37966859da6fe8419f2d80d05d259cd2c751099d Revert "Block indexing of diary entries" ee8ed3c682699e78fa5952b1ad554a09db546638 Add missing space f9109b7a75f91c208a7b5f68cc64ba253a9041c5 Fix styling of email notifications in RTL languages e8e44dbb9f9ed0fbd058f017cf6b5d668282cd37 More tweaks for RTL email 9299f8ca23d7cd7a1cb2f080bf6bd440140d3637 Include bundler in packages to install on Ubuntu f39ea70083b8556c7bf6e9a4b682ebb2cab9eb01 Ubuntu 18.04 is now required. Add apt-get update f2ceda52963491156d94e45f430cc5b626c35b0c Localisation updates from https://translatewiki.net. d021bdf5cf57f6020279043ac276f96f5bf6352c Merge remote-tracking branch 'upstream/pull/2223' d7f92e163e332036b7af195e4d1d2030bdcde250 Update bundle 6f9b0c2f6b187a1787e195cd0d768c5fca1cd839 Fix rubocop warnings d0201f4487fbf4a81abfb9206a25c27b4be9dec6 Update wiki page data cec5e4999c1529d0716d83639ac4f23b0c84dd26 Localisation updates from https://translatewiki.net. ba627420a3e183fcee7ce38b2f68a0ff7663c647 Add support for Active Storage attachments 6c202448ade514cd5ecca7175555011c851735e9 Move user images to Active Storage with paperclip as a fallback 77026ee0398dfb5d049dbc0d3359b2c7b3d9309e Add support for using S3 as the object store 77ee8c1a53f4124e36012b01801ab801f36dd58d Monkey patch Active Storage to set content type when uploading to S3 75e60acf661e39f3ab01d486ed17616bab036f73 Allow configuration of storage server URL for security policy 8c1a5d62f8b2f5491f7d476cdcbd0d4121903079 Ignore the class length of test files 4111388674b1278d768ea2b251475f37c7eece05 Localisation updates from https://translatewiki.net. d63beb80805bec2155c961f15a4e45ef3bf7921d make link in documentation clickable 64f70a7cb0f13cf9adf552051dc2dd9db111fd46 Merge remote-tracking branch 'upstream/pull/2305' 27078aa7803c0e38a83805f80d3660608190084d Update eslint 807750023aa02896117a1d5d67a750eccd31d90b Fix eslint warning c4c0e8105a8edc35205add749f461ec7be689aef Enforce consistent indentation in javascript code 492a6405306092c39c26b4f6cc8b2e793ee22d43 Enable a few more eslint checks c162c065c6f6db5dc584599f5639b296b627a165 Merge remote-tracking branch 'upstream/pull/2296' 550fa0c8e46c9d4e09e30f7940bcb63f84f0ac41 It's to_sym not to_symbol cd4ac6ac2dfaea3f2c7419d8b6d5e0a9490e286a Revert accidental schema changes a47c0a4411825f48e447641094678b15df3b2f74 Update querystring references 6da536e5c8870cb30594a7397e074803080e2708 Add a rake task to move user avatars to Active Storage 11c4aa7d73f212d1dfba920e3853b9b6d6cbd197 Skip uploading images for users that have a new style avatar cc5688a6ded7913e1956326e2b40333e99962048 Localisation updates from https://translatewiki.net. 6dd451c7ee48663d6b0753bfe8b4da2060c4cf60 Stop creating a shared global querystring variable d2d3f2c9fdb76eb8193eaa079868504b8b9906c5 Fix rubocop warning 5cb96cd1a2964463dfcb6083da95badecccb7f98 Send trace import result notification immediately c5fc9f0e7e93088c599ae0d8540ee0117f277d6d Run any Active Storage jobs in the storage queue e3f37bb30cc77f0ffa1e8132f99ed59854641ca0 Allow BMP images to be transformed f5977808222bacf30ad56dfd7ccf764bcc46aa11 Increase expiry for Active Storage URLs 905a7eadb622761b3c752a113ca878faa316a37a Defer deletion of avatars to a background job cea0ba51377a1ac356a58df591092e7b28825f2d Merge remote-tracking branch 'upstream/pull/2313' b911b45961165d64fba577d4cb87740d89ec6784 Return absolute URLs for user images 3cfffc2258621558e1147ceaf63980a7f6ed414b Update gravatar methods to check for Active Storage images 91a37235ac748df7dc241b215790d6cbecd652f3 Remove support for old style user images 40ac2aa5280f46c0c8cf3676596334269ec2f696 Use the configured host name for user image URLs 0444187cb6eccee4f77596c1a575d32e6c96192d Update annotations after 91a37235ac748df7dc241b215790d6cbecd652f3 6ebb21b66020ba845abd9fda408bb204d326e0de Avoid using live models in old migrations d130db9fa84da832a6a0cb0333982725fdc480c7 Avoid more models in old migrations a254efb5ec6b30601aeb82cf6380ace02d71c4e8 Set server_url to test.host in test environments add6f9643b8c14ec29c607b8ca3adfa83ff8754c Rework help page text 43b0d4236300e65c5fa9f9c49f348e95f96bcc16 Merge remote-tracking branch 'upstream/pull/2322' 8750405bf7cc44ef53ea2387c5315925175de169 Merge remote-tracking branch 'upstream/pull/2320' 227c402ad10059ec35394f2a960a620e5cda73af Don't try and add fingerprints for user images 826b70fdc5f44ab2f6bde94b8ab67bf98ee43981 Replace migrations that rely on models with rake tasks 8a39c6b4a223160d47b293bc07d57d4e77685746 Drop old user image columns 5a54cb52f8b46283ddb6059e53f0d49886983ccf Drop paperclip bc37f1d8518bf1b4c892c53355c7b71e32ec1346 Localisation updates from https://translatewiki.net. 0af8b95b7d8b1c633bb3d021f099c90d65df69c6 Update bundle 1f880528bd834bd59465b51ea8eccfe9fbd1715a Fix new rubocop warnings 64b605a8208d267752c37227cceb8af93a1d67dd Localisation updates from https://translatewiki.net. 4ff60670339b7d9191d20876aaf54ac78a62f597 Fix text direction for Japanese 81f1e7982a4fd9904ef709ef2a4822ce5de031e4 Localisation updates from https://translatewiki.net. 61faea262a5b75ddca7035daa68239a1f0c54d05 Pass viewbox to Nominatim when geocoding routing endpoints 241f12df40a5c2c536cbd15177bd39e55d4fb75c Update to iD v2.15.4 cfb9d537a69df486f9fd4e7d5532a69c2990bf62 Remove file unrelated to iD 2.15.4 release 02e5a93dc529c491afafa76b281238463ac0afc5 Merge remote-tracking branch 'upstream/pull/2330' 9581fc24f8141fc50bcb450fc910d64faf98db73 Localisation updates from https://translatewiki.net. 1addc078c0809ef591057980a7ab6cdab9891e44 Avoid trying to resize non-resizable images 44839bee8b869e24292cd8705177d7597828e2ea Localisation updates from https://translatewiki.net. f32baeceb478a714c0490d90bffb3b411655b8d9 Localisation updates from https://translatewiki.net. 083375b3c33f6aae6d81b17f12318e80e5c992db Update polyfills bc883cb9269c12cd9ccad0707e498daa2863ae27 Patch broken polyfill feature test 754e566f454f8083e6baebdcc9eebc06e7cda333 Exclude phantomjs from generic webkit as it's ancient 4efe7cdc109013fa77d3e5356454d305a3726335 Fix vagrant provisioning script 2a9346adb0477e895dca1083c0f675f690dcdf75 Make sure phantomjs is installed dc5cdebc29927933a815a9c65cc8dd2116f87b31 Create config/settings.local.yml in Vagrant provisioning script 21a3a69d1006247abd27ea404559a964a8ddba84 Localisation updates from https://translatewiki.net. cdae792e36effd22d05bfd579c9822f27fb4c9a7 Localisation updates from https://translatewiki.net. 42345cb9b7ff32e477d69047a1b87dea6e649433 Include any current search terms in the page title 389fee0151d4b7f3b4a77e38143e6990a00d2362 Revert "Always look to the global scope for the GPX module" 18f5f1d499178bfbeaceb450a4a8e0a2863b3d96 Explicitly require gpx in the trace model tests dcea5c68838d89761ba8510e76acbcabbe1de61c Update bundle 4b646e17a8c8246d1638bcece5d59369d78424e1 Fix rubocop warnings 0264b865e36c6ed25cb48e833653461aab3e5a00 Update rubocop todo 34c9d9cc6b5008886218e9e6154cb84bc87aeba7 Increase poltergeist timeout 06957c3479a752c7f94ed33729c5030ed3de4033 Localisation updates from https://translatewiki.net. de973d08cacda5a78707c6c24c44d1efe1f1f798 Localisation updates from https://translatewiki.net. 135ec35a91bcca15637b6436dd7e546468c49690 Fix numericality validation to use correct integer only constraint a973ca794f3f54395bcc758b4316d09c5014ebab Localisation updates from https://translatewiki.net. 94033b3a088e3871f55fe6dad4e030b8af8b885a Localisation updates from https://translatewiki.net. 39896c76f8b4d4b80cca29980a54b4061f848d4a Update to iD v2.15.5 e1f2390d282a153422eaed2bcc12d43b9186bc97 Merge remote-tracking branch 'upstream/pull/2359' bfd4f4993a35e0ef73a33291aacc3096580fb463 Update yarn bundle d515e1b0e4b60c486cb1ed0b4e94607dfb365805 Update bundle 8d102e2dc5827ecc497ad51c4396ad92a83a8f47 Drop ancient imported daemon generator bf1b9a9b6038c9e906133e9a981cc91b9512237d Exclude all vendored code from rubocop checking 0cebec000081f8a779bcd244222af6162096d256 Merge branch 'patch/secscan' of https://github.com/mmd-osm/openstreetmap-website into mmd-osm-patch/secscan 2343ca8dde7b03d4db8c6d869ae6ba1adcc24a17 Ignore current Brakeman warnings -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229/files/759d1a1a5245854d524cd64056d8ef02de36975a..2343ca8dde7b03d4db8c6d869ae6ba1adcc24a17 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/f78b3354/attachment-0001.html> From notifications at github.com Wed Aug 28 10:43:05 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 03:43:05 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/push/3971260524@github.com> @gravitystorm pushed 1 commit. 4d5818abe493fba21eef320970ac3750b3b09895 Ignore current Brakeman warnings -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229/files/b18b490e81428f0a77b50e5151692fb09f6564ef..4d5818abe493fba21eef320970ac3750b3b09895 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/ec584c09/attachment.html> From notifications at github.com Wed Aug 28 10:55:57 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 03:55:57 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/c525692662@github.com> OK, lets stick with Brakeman. I've also figured out how to ignore the current issues using a config file, so I believe this is now ready to merge. (Sorry for the force-pushing, I was aiming to preserve the original commit while also resolving conflicts and adding the new config file to this existing PR.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229#issuecomment-525692662 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/206be056/attachment.html> From notifications at github.com Wed Aug 28 11:16:21 2019 From: notifications at github.com (Simon Poole) Date: Wed, 28 Aug 2019 04:16:21 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c525699136@github.com> > > > > Could we get it on the sandbox first? > > First? Do you mean before code review? Before deployment, which in our case implies before merger. > > Or if you want it before merging, to what end? So far this PR is just internal code refactoring, there's no changes to the API (other than dropping one line from the api/0.7/capabilities response) and even if this is merged there will still be no changes since 0.7 is disabled. Famous last words. In reality there are always things that might break, for example as when the authorisation refactoring was deployed. Being to test against a deployment, while not a panacea, at least gives us a fighting chance to ferret out any assumptions that no longer hold true and so on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-525699136 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/5874b349/attachment.html> From notifications at github.com Wed Aug 28 12:30:44 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 05:30:44 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installations are unmaintained (#2344) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2344@github.com> References: <openstreetmap/openstreetmap-website/issues/2344@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2344/525723559@github.com> So I don't think we really need the vagrant/virtualbox bit tested, so much as the rest of the setup script i.e the contents of [/script/vagrant/setup/provision.sh](https://github.com/openstreetmap/openstreetmap-website/blob/master/script/vagrant/setup/provision.sh). Could that be tested on travis? Of course, both the travis config and the vagrant setup (and the Docker setup) cover a lot of the same ground - installing postgres, bundle install, etc. So if there's a way to refactor things to share some code, that would be great too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomment-525723559 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/7fddf188/attachment.html> From notifications at github.com Wed Aug 28 13:20:24 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 06:20:24 -0700 Subject: [openstreetmap/openstreetmap-website] Add user_<uid> class to diary entry div (#2266) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2266@github.com> References: <openstreetmap/openstreetmap-website/pull/2266@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2266/issue_event/2590508661@github.com> Merged #2266 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2266#event-2590508661 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/a8ca0cea/attachment.html> From notifications at github.com Wed Aug 28 13:24:14 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 06:24:14 -0700 Subject: [openstreetmap/openstreetmap-website] Add user_<uid> class to diary entry div (#2266) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2266@github.com> References: <openstreetmap/openstreetmap-website/pull/2266@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2266/c525743518@github.com> I've ummed and aahhhed about this for weeks, since I both object to it ([for the same reasons as @tomhughes](https://github.com/openstreetmap/openstreetmap-website/pull/2266#issuecomment-502678401)) and also support it since it's pretty trivial and [nobody's going to mind if we break it in future](https://github.com/openstreetmap/openstreetmap-website/pull/2266#issuecomment-502684786). But it's not worth me considering it for any longer. So it just comes down to having a slight bias for change. But if this gets stripped out again in a future refactoring, so be it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2266#issuecomment-525743518 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/031ba488/attachment.html> From notifications at github.com Wed Aug 28 13:38:02 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 06:38:02 -0700 Subject: [openstreetmap/openstreetmap-website] Update Austrian copyright statement (EN). (#1480) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1480@github.com> References: <openstreetmap/openstreetmap-website/pull/1480@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1480/c525749046@github.com> I've checked the status of this particular dataset, and it appears that the attribution is complete on the wiki page, and the waiver stored there states the wiki as sufficient. Given the wishes expressed in this PR to avoid expanding the list at /copyright, then I think it's best to leave this PR unmerged. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1480#issuecomment-525749046 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/566007e9/attachment.html> From notifications at github.com Wed Aug 28 13:38:04 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 06:38:04 -0700 Subject: [openstreetmap/openstreetmap-website] Update Austrian copyright statement (EN). (#1480) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1480@github.com> References: <openstreetmap/openstreetmap-website/pull/1480@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1480/issue_event/2590570773@github.com> Closed #1480. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1480#event-2590570773 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/23612abe/attachment-0001.html> From notifications at github.com Wed Aug 28 14:12:16 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 07:12:16 -0700 Subject: [openstreetmap/openstreetmap-website] Make the logo on the error pages clickable (#2362) Message-ID: <openstreetmap/openstreetmap-website/pull/2362@github.com> When reviewing #1550 I realised that the logo isn't clickable, whereas elsewhere on this site the logo in the top left links to the front page. It's a reasonable convention so one I that I feel is worth implementing. I've used the same srcset/picture code as in the main header. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2362 -- Commit Summary -- * Make the logo on the error page clickable -- File Changes -- M app/views/layouts/error.html.erb (7) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2362.patch https://github.com/openstreetmap/openstreetmap-website/pull/2362.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2362 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/0d22f549/attachment.html> From notifications at github.com Wed Aug 28 14:17:18 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 07:17:18 -0700 Subject: [openstreetmap/openstreetmap-website] Beautify 404 page (#1550) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1550@github.com> References: <openstreetmap/openstreetmap-website/pull/1550@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1550/issue_event/2590712311@github.com> Closed #1550. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1550#event-2590712311 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/cd74edb8/attachment.html> From notifications at github.com Wed Aug 28 14:17:17 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 07:17:17 -0700 Subject: [openstreetmap/openstreetmap-website] Beautify 404 page (#1550) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1550@github.com> References: <openstreetmap/openstreetmap-website/pull/1550@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1550/c525766131@github.com> I like in particular the idea that you should be able to click from the error page and get back to the home page. I've extracted this idea into [a separate PR](#2362), which just makes the logo clickable, rather than adding more words, and avoids hardcoding the URL. There's a few other things that I would suggest changing on this PR, in particular the ASCII smiley, which is unlikely to translate well into other languages, and the CSS too. However I think that would mean there's not much left here to work with. So I'm going to close this in favour of the other PR. Thanks for the proposals, in particular the concept of linking back to the home page, which I agree would be an improvement. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1550#issuecomment-525766131 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/a7878e4c/attachment.html> From notifications at github.com Wed Aug 28 14:19:20 2019 From: notifications at github.com (blackboxlogic) Date: Wed, 28 Aug 2019 07:19:20 -0700 Subject: [openstreetmap/openstreetmap-website] GET User's current ratelimit quota (#2363) Message-ID: <openstreetmap/openstreetmap-website/issues/2363@github.com> Just a nice to have... There is no way to know how much is left in your API rate-limit quota. There could be an endpoint /user/quota or every response from the API could have a quota header. Would be nice to know: - if the quota is by account or by IP - how much has been used - how much is remaining - rate that the quota regenerates -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2363 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/c7d6a3e7/attachment.html> From notifications at github.com Wed Aug 28 14:23:02 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 07:23:02 -0700 Subject: [openstreetmap/openstreetmap-website] Moving wiki to a more accessible position (#1397) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1397@github.com> References: <openstreetmap/openstreetmap-website/pull/1397@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1397/issue_event/2590733482@github.com> Closed #1397. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1397#event-2590733482 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/280ee9d8/attachment.html> From notifications at github.com Wed Aug 28 14:23:02 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 07:23:02 -0700 Subject: [openstreetmap/openstreetmap-website] Moving wiki to a more accessible position (#1397) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1397@github.com> References: <openstreetmap/openstreetmap-website/pull/1397@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1397/c525768634@github.com> Thanks for the suggestion to rearrange these links. However, I don't agree that it's "hidden", and I'm happy with the current order of the links. There's certainly room for more substantial changes to that page though! See e.g. #2321 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1397#issuecomment-525768634 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/6afed443/attachment-0001.html> From notifications at github.com Wed Aug 28 14:30:02 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 07:30:02 -0700 Subject: [openstreetmap/openstreetmap-website] GET User's current ratelimit quota (#2363) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2363@github.com> References: <openstreetmap/openstreetmap-website/issues/2363@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2363/issue_event/2590759932@github.com> Closed #2363. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2363#event-2590759932 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/781867fe/attachment.html> From notifications at github.com Wed Aug 28 14:30:00 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 07:30:00 -0700 Subject: [openstreetmap/openstreetmap-website] GET User's current ratelimit quota (#2363) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2363@github.com> References: <openstreetmap/openstreetmap-website/issues/2363@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2363/525771893@github.com> With one exception there is no quota - that exception is the download of existing data. The quota is set at a level where nobody is expected to hit it in normal use, and we don't like to advertise the details too much because it will just encourage people to find ways to game it. It's nothing to do with this repository anyway - the quota is implemented in [cgimap](https://github.com/zerebubuth/openstreetmap-cgimap) and configured by our [chef](https://github.com/openstreetmap/chef/) recipes. The rails implementation of the API doesn't actually enforce any quotas at all. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2363#issuecomment-525771893 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/772360a8/attachment.html> From notifications at github.com Wed Aug 28 14:32:36 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 07:32:36 -0700 Subject: [openstreetmap/openstreetmap-website] GET User's current ratelimit quota (#2363) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2363@github.com> References: <openstreetmap/openstreetmap-website/issues/2363@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2363/525773040@github.com> Oh to answer one of your questions it is by account if you authenticate the request (which is optional when fetching map data) and by IP if you do not. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2363#issuecomment-525773040 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/89b69e47/attachment.html> From notifications at github.com Wed Aug 28 15:25:43 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 08:25:43 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/c525796005@github.com> I've been reviewing this PR today, and despite my [unresolved objections](https://github.com/gravitystorm) I'm willing to go ahead and accept this PR. However, in the intervening time the PR has bit-rotted and now has conflicts, mainly due to the [split of browse_helper and browse_tags_helper](https://github.com/openstreetmap/openstreetmap-website/commit/74d2c4336bab2efe44c6bdadf688d26b18e320b3) last year. @stefanb if you're willing to rebase this onto a recent master, that would be helpful. If not, no worries, I can do that in a few weeks time. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779#issuecomment-525796005 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/db599906/attachment.html> From notifications at github.com Wed Aug 28 16:48:17 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 09:48:17 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/issue_event/2591230421@github.com> Merged #1926 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#event-2591230421 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/6b846260/attachment.html> From notifications at github.com Wed Aug 28 16:58:37 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 09:58:37 -0700 Subject: [openstreetmap/openstreetmap-website] Make the logo on the error pages clickable (#2362) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2362@github.com> References: <openstreetmap/openstreetmap-website/pull/2362@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2362/issue_event/2591262025@github.com> Merged #2362 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2362#event-2591262025 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/13a3cc40/attachment-0001.html> From notifications at github.com Wed Aug 28 17:02:21 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 10:02:21 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/c525833803@github.com> Is there no better way of suppressing warnings than that monstrosity of a JSON file that lists each one in excruciating detail? I mean ideally we want to suppress whole classes of warning until we decide what we want to do about that rather than suppressing specific examples, which means that new code will still trigger complaints about things that we may well not be interested in fixing. In other words we want something more like the way rubocop works... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229#issuecomment-525833803 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/6d3c89a3/attachment.html> From notifications at github.com Wed Aug 28 17:52:29 2019 From: notifications at github.com (Simon Poole) Date: Wed, 28 Aug 2019 10:52:29 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c525852878@github.com> And ..... what about announcing a significant behaviour change of the website? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-525852878 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/8195a074/attachment.html> From notifications at github.com Wed Aug 28 17:54:14 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 10:54:14 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c525853671@github.com> It's not live yet. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-525853671 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/41aae121/attachment.html> From notifications at github.com Wed Aug 28 18:04:38 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 11:04:38 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c525857752@github.com> That said we will obviously want to put it live soon so if people feel a communication strategy is necessary then now is the time to arrange it. I'm not sure how many of the people impacted such a strategy might reach though - in reality I doubt many people other than deliberate abusers are going to be impacted at all. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-525857752 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/840f63bb/attachment.html> From notifications at github.com Wed Aug 28 18:26:30 2019 From: notifications at github.com (Simon Poole) Date: Wed, 28 Aug 2019 11:26:30 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c525866228@github.com> I was more considering the "normal" OSM contributors as an audience for an announcement @harry-wood -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-525866228 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/49ea0dbb/attachment.html> From notifications at github.com Thu Aug 29 07:52:46 2019 From: notifications at github.com (Ilya Zverev) Date: Thu, 29 Aug 2019 00:52:46 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c526070371@github.com> Awesome, thank you Andy and Tom! I will announce the change to the Russian part of the community at least :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-526070371 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/3b20d39b/attachment.html> From notifications at github.com Thu Aug 29 18:24:32 2019 From: notifications at github.com (mmd) Date: Thu, 29 Aug 2019 11:24:32 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/526305108@github.com> (adding https://github.com/bryceco/GoMap/issues/113#issuecomment-384604159 as an example of an app creating 800 empty changesets in 3 minutes). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-526305108 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/14063370/attachment.html> From notifications at github.com Thu Aug 29 18:32:22 2019 From: notifications at github.com (Tobias Zwick) Date: Thu, 29 Aug 2019 11:32:22 -0700 Subject: [openstreetmap/openstreetmap-website] Hide header image on registration form on mobile (#2288) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2288@github.com> References: <openstreetmap/openstreetmap-website/issues/2288@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2288/526308034@github.com> I have a Sony Xperia Z1 Compact and it looks like this on my phone (Firefox) **Landscape** <img height="300px" src="https://user-images.githubusercontent.com/4661658/63966563-d42d7000-ca9b-11e9-8fb7-70028af206aa.png"/> **Portrait** <img width="300px" src="https://user-images.githubusercontent.com/4661658/63966570-d7c0f700-ca9b-11e9-96e4-7f9de8ab2552.png"/> -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2288#issuecomment-526308034 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/ee1b5064/attachment.html> From notifications at github.com Thu Aug 29 18:33:16 2019 From: notifications at github.com (Richlv) Date: Thu, 29 Aug 2019 11:33:16 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/526308373@github.com> @mmd-osm, thank you for the link. This emphasises the need to have the limits in the API - even if we could get all editors to implement internal limits (plenty hard), a simple bug (perhaps in the limiting code itself...) could still cause a changeset storm. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-526308373 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/5164d082/attachment.html> From notifications at github.com Thu Aug 29 20:24:28 2019 From: notifications at github.com (Grant) Date: Thu, 29 Aug 2019 13:24:28 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/1543/issue_event/2595234414@github.com> Closed #1543. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#event-2595234414 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/44b4c88a/attachment.html> From notifications at github.com Thu Aug 29 20:59:33 2019 From: notifications at github.com (blackboxlogic) Date: Thu, 29 Aug 2019 13:59:33 -0700 Subject: [openstreetmap/openstreetmap-website] Merge remote-tracking branch 'upstream/pull/1926' (783b5e3) In-Reply-To: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906@github.com> References: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906@github.com> Message-ID: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906/34888034@github.com> Was there a reason/discussion for requiring authentication when commenting on a note? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906#commitcomment-34888034 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/c3fcca26/attachment.html> From notifications at github.com Thu Aug 29 21:15:29 2019 From: notifications at github.com (mmd) Date: Thu, 29 Aug 2019 14:15:29 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c526364959@github.com> Should we add a small one liner explanation that "you need to log on to comment on this note"? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-526364959 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/bb187ebe/attachment-0001.html> From notifications at github.com Thu Aug 29 21:34:55 2019 From: notifications at github.com (Frederik Ramm) Date: Thu, 29 Aug 2019 14:34:55 -0700 Subject: [openstreetmap/openstreetmap-website] Merge remote-tracking branch 'upstream/pull/1926' (783b5e3) In-Reply-To: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906@github.com> References: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906@github.com> Message-ID: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906/34888385@github.com> Discussion in https://github.com/openstreetmap/openstreetmap-website/issues/1543 and https://github.com/openstreetmap/openstreetmap-website/pull/1926 - documentation update in https://wiki.openstreetmap.org/w/index.php?title=API_v0.6&type=revision&diff=1896312&oldid=1893630 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906#commitcomment-34888385 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/608954aa/attachment.html> From notifications at github.com Thu Aug 29 21:36:11 2019 From: notifications at github.com (Mateusz Konieczny) Date: Thu, 29 Aug 2019 14:36:11 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c526371782@github.com> With "log on" being a link? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-526371782 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/58b70873/attachment.html> From notifications at github.com Thu Aug 29 23:02:54 2019 From: notifications at github.com (Igmu) Date: Thu, 29 Aug 2019 16:02:54 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/526393006@github.com> First, the irony of having to login and discuss whether the bed to log in to make a comment. Imagining for anonymous participation: Political restriction to access current information. "Open" should be open to all and errors should be reduced by population of contributors. Save on storage? More contributors vs user info? Against anonymous without a Turing Test nor logging with credentials: Trolls. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-526393006 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/e1494540/attachment.html> From notifications at github.com Fri Aug 30 09:45:56 2019 From: notifications at github.com (mmd) Date: Fri, 30 Aug 2019 02:45:56 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526538362@github.com> > I'm not intending to implement many changes, just the ones that I've been personally complaining about since API 0.6 was released over a decade ago (like incorrect http status codes, and plain-text responses, and stuff like that). That's the bit I least like about the current multiple API version idea: it seems to focus on something I would describe as _cosmetic changes_ only. That's ok, except for it only adds work to consumers of the API while offering no real value to them at all. Since they already have a working API integration, they would need to spend extra development time and effort to get back to a status quo. Isn't there anything more compelling to do that would give API consumers more of an incentive to move to the latest and greatest version? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526538362 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/c7886c87/attachment.html> From notifications at github.com Fri Aug 30 09:50:40 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Fri, 30 Aug 2019 02:50:40 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/c526539947@github.com> @gravitystorm thanks for picking this up, I can check it once i restore my OSM dev environment on a rainy day :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779#issuecomment-526539947 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/7f312025/attachment.html> From notifications at github.com Fri Aug 30 10:05:45 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 03:05:45 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526544681@github.com> > adds work to consumers of the API *existing* consumers of the API. Some of these headaches and quirks need to be solved by every API consumer, and the total number of future API consumers yet to be written vastly exceeds the ones written so far. So the sooner we fix them, the better, and it's a shame they've been known about and unfixed for so long already. > Isn't there anything more compelling to do that would give API consumers more of an incentive to move to the latest and greatest version? Maybe we will want to put some of the more compelling things in v0.8, or v0.9, or something. But I'm determined to avoid getting into the same situation as has happened over, and over, and over again, where the scope of v0.7 expands inexorably until it collapses under its own weight! I'd rather break up the logjam and work on smaller, more frequent improvements (e.g. every 18-36 months, rather than 10+ years and counting) to the API. And I'd rather keep the API changes small so that a developer can upgrade their app with a small amount of code changes that's feasible in a weekend of hacking, rather than some significant API upgrade that puts them off doing any of it and leaves them stuck on v0.6. And making life easier for the developers is the whole point of adding multiple version support, so that they can upgrade when it suits them best. Anyway, let's talk about this further in a future issue, since we're burying the point of this PR ("is this the best code approach to multiple version support? Can you see a better way of coding the tests?") in wider discussions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526544681 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/fb71039b/attachment-0001.html> From notifications at github.com Fri Aug 30 10:33:36 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 03:33:36 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526552554@github.com> @gravitystorm you might want to consider making a statement as to versioning of the API (for example if it follow semver semantics going forward), or will we have to continue to assume that every version change is breaking as it is now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526552554 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/5b46d23a/attachment.html> From notifications at github.com Fri Aug 30 10:39:28 2019 From: notifications at github.com (mmd) Date: Fri, 30 Aug 2019 03:39:28 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281953476@github.com> mmd-osm commented on this pull request. > @@ -7,27 +7,54 @@ class CapabilitiesControllerTest < ActionController::TestCase def test_routes assert_routing( { :path => "/api/capabilities", :method => :get }, - { :controller => "api/capabilities", :action => "show" } + { :controller => "api/v06/capabilities", :action => "show", :api_version => "0.6" } Say we want to use semantic versioning like 1.2.0, how would this be reflected specifically in directory names like `v06`? > @@ -10,7 +10,7 @@ OSM = { MAX_REQUEST_AREA: <%= Settings.max_request_area.to_json %>, SERVER_PROTOCOL: <%= Settings.server_protocol.to_json %>, SERVER_URL: <%= Settings.server_url.to_json %>, - API_VERSION: <%= Settings.api_version.to_json %>, + API_VERSION: <%= Settings.api_versions.min_by(&:to_f).to_json %>, Why is this value set to "min_by", and what are the implications of it? Does `&:to_f` play nice with semver (e.g. 1.2.0)? > @@ -1,24 +1,58 @@ OpenStreetMap::Application.routes.draw do + # Our api versions are decimals, but controllers cannot start with a number + # or contain punctuation + def v_string(version) + "v#{version.delete('.')}" Thinking of semver again, would it be better to replace "." by "_" maybe, so it's `v0_7 ` and `v1_2 `? How about patch version number? Ignore or include? > - <member type='relation' role='some' ref='#{relation.id}'/> - </relation> - </create> - </osmChange> + all_api_versions.each do |api_version| + user = create(:user) + changeset = create(:changeset, :user => user) + node = create(:node) + way = create(:way_with_nodes, :nodes_count => 2) + relation = create(:relation) + + basic_authorization user.email, "test" + + # simple diff to create a node way and relation using placeholders + diff = <<CHANGESET.strip_heredoc + <osmChange> At one point we'd also need to include a version number in `<osmChange>` (maybe not now) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#pullrequestreview-281953476 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/a0928c07/attachment.html> From notifications at github.com Fri Aug 30 10:43:00 2019 From: notifications at github.com (mmd) Date: Fri, 30 Aug 2019 03:43:00 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526554989@github.com> > I'd rather break up the logjam and work on smaller, more frequent improvements (e.g. every 18-36 months, rather than 10+ years and counting) to the API. This brings up the topic how long you want to support previous API versions. Effectively, we need a Versioning Policy and a clear messaging to API consumers about EOL dates for each version well ahead of time. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526554989 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/e6948b3d/attachment.html> From notifications at github.com Fri Aug 30 10:56:07 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 03:56:07 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281964563@github.com> simonpoole commented on this pull request. > @@ -7,27 +7,54 @@ class CapabilitiesControllerTest < ActionController::TestCase def test_routes assert_routing( { :path => "/api/capabilities", :method => :get }, - { :controller => "api/capabilities", :action => "show" } + { :controller => "api/v06/capabilities", :action => "show", :api_version => "0.6" } @mmd-osm a reasonable assumption IMHO would be to only actually have different "directory" names for major versions (aka breaking changes), the client can then determine from the capabilities which minor version is actually supported and from that determine which backwards compatible features are present. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319461616 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/766aed5d/attachment.html> From notifications at github.com Fri Aug 30 11:05:19 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 04:05:19 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526560669@github.com> > every version change is breaking as it is now That will always be the case. If it's not breaking, then there's no need to change the API version in the first place. I'm sure you're aware that the current abilities of API 0.6 are quite expanded from the initial version back in 2009, but so far it's had to be backwards compatible to avoid breaking clients (with some minor exceptions, like the swf endpoint). Because we've only (been able to|chosen to) deploy backwards-compatible changes, we haven't incremented the version number. https://stackoverflow.com/questions/27901549/semantic-versioning-of-rest-apis explains it clearly - if we moved to semantic versioning, then only the major number is of interest to API consumers. So that's what we'd use in the URLs. If we wanted to move to semantic versioning for the next version of the API, then I would suggest calling it "API v7". We'd never need to have an endpoint like `/api/v7.1.0/node/1` since, by the definition of semantic versioning, any call to that would be backwards-compatible with any other API 7.x endpoint. If it wasn't compatible, we'd be on API v8, not v7.1. I'd be happy to move to using integers instead of what we have now, but I suggest we park this for the release-after-next. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526560669 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/2d8c7a85/attachment.html> From notifications at github.com Fri Aug 30 11:08:24 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 04:08:24 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281969386@github.com> gravitystorm commented on this pull request. > @@ -10,7 +10,7 @@ OSM = { MAX_REQUEST_AREA: <%= Settings.max_request_area.to_json %>, SERVER_PROTOCOL: <%= Settings.server_protocol.to_json %>, SERVER_URL: <%= Settings.server_url.to_json %>, - API_VERSION: <%= Settings.api_version.to_json %>, + API_VERSION: <%= Settings.api_versions.min_by(&:to_f).to_json %>, It's mainly just min_by to keep everything working for now, since it will pick 0.6 unless the site operator chooses to only deploy 0.7. It's used for the bits of the website that talk to the API, like notes and changeset comments. Since there's no changes yet, it's more of a "pick either" situation. On a wider point, I'd rather work on refactoring those bits of the site to just be regular webpages like diary entry comments, but that's a different project! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319465144 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/26c21d10/attachment.html> From notifications at github.com Fri Aug 30 11:09:19 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 04:09:19 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281969719@github.com> gravitystorm commented on this pull request. > @@ -1,24 +1,58 @@ OpenStreetMap::Application.routes.draw do + # Our api versions are decimals, but controllers cannot start with a number + # or contain punctuation + def v_string(version) + "v#{version.delete('.')}" As discussed in the comments, semver would only use major version numbers here. So e.g. `v7` or `v124`. But it's a great point to raise, thank you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319465393 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/fec20f6b/attachment.html> From notifications at github.com Fri Aug 30 11:10:10 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 04:10:10 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281970010@github.com> gravitystorm commented on this pull request. > - <member type='relation' role='some' ref='#{relation.id}'/> - </relation> - </create> - </osmChange> + all_api_versions.each do |api_version| + user = create(:user) + changeset = create(:changeset, :user => user) + node = create(:node) + way = create(:way_with_nodes, :nodes_count => 2) + relation = create(:relation) + + basic_authorization user.email, "test" + + # simple diff to create a node way and relation using placeholders + diff = <<CHANGESET.strip_heredoc + <osmChange> Yeah, I noticed that during the refactoring, but lets leave that for now since we're not planning any changes to the osmchange format (afaik). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319465644 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/00bc2590/attachment.html> From notifications at github.com Fri Aug 30 11:13:10 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 04:13:10 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526562660@github.com> @mmd-osm Thanks for looking at the code! That's really helpful and I appreciate it. If you have any suggestions or more feedback I'd love to hear it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526562660 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/a7323531/attachment-0001.html> From notifications at github.com Fri Aug 30 11:26:09 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 04:26:09 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526565899@github.com> > > > > every version change is breaking as it is now > > That will always be the case. If it's not breaking, then there's no need to change the API version in the first place. > > I'm sure you're aware that the current abilities of API 0.6 are quite expanded from the initial version back in 2009, but so far it's had to be backwards compatible to avoid breaking clients (with some minor exceptions, like the swf endpoint). Because we've only (been able to|chosen to) deploy backwards-compatible changes, we haven't incremented the version number. > > https://stackoverflow.com/questions/27901549/semantic-versioning-of-rest-apis explains it clearly - if we moved to semantic versioning, then only the major number is of interest to API consumers. So that's what we'd use in the URLs. If we wanted to move to semantic versioning for the next version of the API, then I would suggest calling it "API v7". > Neither the original semver definition nor the SO article say that. We agree that in the calls, only the major version needs to be used, but, because semver allows backwards compatible additions you still need some way of determining what version you -exactly- have in front of you to know if a specific minor version addition is present or not. In the case of the OSM API that is easily achieved by returning the actual semver (so if I want to use feature X any minor version higher than the one it was introduced in are OK). That we can't do that currently with 0.6 is the major issue with all the additions that have happened over the years. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526565899 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/9d83f084/attachment.html> From notifications at github.com Fri Aug 30 11:27:58 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 04:27:58 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281976751@github.com> simonpoole commented on this pull request. > - <member type='relation' role='some' ref='#{relation.id}'/> - </relation> - </create> - </osmChange> + all_api_versions.each do |api_version| + user = create(:user) + changeset = create(:changeset, :user => user) + node = create(:node) + way = create(:way_with_nodes, :nodes_count => 2) + relation = create(:relation) + + basic_authorization user.email, "test" + + # simple diff to create a node way and relation using placeholders + diff = <<CHANGESET.strip_heredoc + <osmChange> As I pointed out above, we return the data model version in all kinds of places, not just in OSC format. That needs to be decoupled from the API version. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319470752 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/fe3feb9c/attachment.html> From notifications at github.com Fri Aug 30 11:34:27 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 04:34:27 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281979252@github.com> simonpoole commented on this pull request. This will change the data model version in sync with the API version. Which a) normally wouldn't be the case, b) will lead to all kind of breakage in the XML parsers. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#pullrequestreview-281979252 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/17728318/attachment.html> From notifications at github.com Fri Aug 30 12:56:26 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 05:56:26 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526591337@github.com> > you still need some way of determining what version you -exactly- have in front of you So let's take a feature like "notes" which was added in during the 0.6 era. I think your use-case is along the lines of "I'm an editor developer, and I want to know if notes are available on this endpoint, which might be osm.org or might be some other deployment that is running an older codebase that doesn't have notes yet, so that I can show/hide the relevant UI". If I've misunderstood let me know. You're suggesting that we should therefore introduce the minor API version in responses. I suspect you don't need to know the minor version in every response (e.g. `/api/X/ways/1` -> `<osm version="7.9" ...`), but you need a response from the server to let you know what the server is capable of doing. So maybe just in the `/api/X/capabilities` call? And then you can show/hide notes functionality depending on whether X.Y is greater than the version number where notes were introduced. But then, why bother with lists of features and their corresponding minor version numbers? That's a bit indirect, since we could just put the additional features into the `capabilities` response e.g. `<feature name="notes" />` to indicate that the endpoint now supports notes. Would that work? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526591337 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/f48dbd83/attachment.html> From notifications at github.com Fri Aug 30 12:56:59 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 05:56:59 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526591537@github.com> > This will change the data model version in sync with the API version. Which a) normally wouldn't be the case, b) will lead to all kind of breakage in the XML parsers. I've read this a few times, but I don't understand what you mean. Could you give an example? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526591537 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/ce09a618/attachment-0001.html> From notifications at github.com Fri Aug 30 13:39:01 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 06:39:01 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526605238@github.com> Consider for example the output of https://api.openstreetmap.org/api/0.6/map?bbox=-122.083819,37.4217991,-122.0834335,37.4222209 Which starts with `<osm version="0.6" generator="CGImap 0.7.5 (14135 thorn-03.openstreetmap.org)" copyright="OpenStreetMap and contributors" attribution="http://www.openstreetmap.org/copyright" license="http://opendatacommons.org/licenses/odbl/1-0/"> <bounds minlat="37.4217991" minlon="-122.0838190" maxlat="37.4222209" maxlon="-122.0834335"/> ` Giving the version of the OSM XML document as 0.6, as this is the only indication of the format in use and OSM does not refer to any external schema docs, you will find that a lot of stuff will bork if you change that 0.6 to 0.7 or whatever. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526605238 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/7ff43493/attachment.html> From notifications at github.com Fri Aug 30 17:02:46 2019 From: notifications at github.com (mmd) Date: Fri, 30 Aug 2019 10:02:46 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526675818@github.com> I tend to agree that we have multiple lifecycles/versioning depending on what you look at. One the one hand, we add features over time to the API in an incremental/non breaking way by either extending existing endpoints or adding new ones. The downside of the current approach is that we have no mechanism to communicate those changes to the outside world. I think this would be a good ft for some semantic versioning, and now would be a good time to seriously think about it, rather than introducing some 0.7 version with some fuzzy requirements. Now, regarding the XML documents: everything that has been done in the recent years mostly left those unchanged. Some minor tweaks like adding an `if-unused` attribute in the OsmChange message happened on a message that isn't versioned anyway. For the OSM XML format, I think we never did any changes (?!), and any proposed changes (apart from introducing an area model) don't seem to force us to create a new version of the OSM XML format. Re. the future OSM JSON format (which will be using the Overpass API JSON format), I'm not sure what the best approach would be. Technically, it's still using the same OSM API 0.6 data model underneath, so we might just call that 0.6 as well? I think it would be good to establish an independent versioning for the different parts. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526675818 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/32c68218/attachment.html> From notifications at github.com Fri Aug 30 17:09:13 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 10:09:13 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526677721@github.com> @mmd-osm well the only data model change that is in a stage of serious consideration (changing way geometry representation), would require a complete switch over (as a backwards compatibility would be very very difficult to provide), so IMHO not worth considering in the context of this PR. With other words the version in the documents could just as well be hardwired to 0.6 for now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526677721 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/0c220acb/attachment.html> From notifications at github.com Fri Aug 30 17:09:54 2019 From: notifications at github.com (Bryan Housel) Date: Fri, 30 Aug 2019 10:09:54 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526677923@github.com> Probably worth mentioning that semantic versioning guidelines [explicitly allow a 0.x major version](https://semver.org/#spec-item-5) as a signal that anything can change at any time. > Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable. So we are, in a sense, already doing semver the way it's intended. If the OSM API ever gets to v1 then we need to start thinking more about backward compatibility and breakage. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526677923 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/b7af9b1b/attachment.html> From notifications at github.com Fri Aug 30 17:12:46 2019 From: notifications at github.com (Philippe Verdy) Date: Fri, 30 Aug 2019 10:12:46 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/526678838@github.com> classic bahesian spam detection can help: if the bahesian score is too low, discard it directly from anonymous users. If it's in a middle range (possibly frequent, but also in comments sent by logged in users), consider using a captcha to confirm it (and inform the user that he could avoid the captcha by creating an account and logging in). If the comment is long enough (giving details, or a non intrusive link e.g. to a photo site where users must be logged in, or to wellknown peer-reviewed data sources, consider adding it reasonnably so that these details can be reevaluated, or explaining a situation like local changes not currently visible in the aerial, or recent works/damages, or a press article) it can be kept (as long as the link itself is not in a banned spamming domain) Bahesian score filters work quite well for emails, why couldn't they be used for comments ? There are already good datasources for evaluating mail contents if we don't want to host out own local database for Bahesian evaluation (e.g. Wikimedia uses several parsers to autodetect and evaluate edits in articles, plus some whitelists and blacklists, and other sources like DNSBL providers) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-526678838 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/b5cecf1b/attachment-0001.html> From notifications at github.com Fri Aug 30 17:17:41 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 10:17:41 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526680346@github.com> At the time the 0.6 api was released semver was still two years away. Trying to retroactively apply senver semantics doesn't really work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526680346 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/034c9078/attachment.html> From notifications at github.com Fri Aug 30 17:18:55 2019 From: notifications at github.com (Bryan Housel) Date: Fri, 30 Aug 2019 10:18:55 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526680769@github.com> > trying to retroactively apply senver semantics doesn't really work. It's a number. it either works or it doesn't. (in this case, it does) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526680769 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/df5ff7aa/attachment.html> From notifications at github.com Fri Aug 30 17:25:15 2019 From: notifications at github.com (Philippe Verdy) Date: Fri, 30 Aug 2019 10:25:15 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/526682655@github.com> Another way would also be to limit the frequency of comments by "anon" IP (e.g. 1 per hour, then a captcha will be presented). If the IP is known to be in an open proxy, the threshold could be adjusted to 1 per 4 hours before the captcha is presented). Open proxies are not always bad, they are sometimes the only way to connect (from shared internet accesses in developing countries) and to help preserving users's privacy (or avoid local political/social/religious troubles for some mapped topics), or when people are traveling abroad and cannot use their regular ISP without excessive costs. There are also open wifi hotspots in hotels, restaurants, cafés, transportations, whose IP is always changing and reused by many unrelated users, sometimes from very different locations, and some mobile ISPs that never provide any stable IPv4 address but connect them with non routable temporary IPv4 that changes at each request, they are proxies by the ISP (not every mobile ISP provide IPv6 connectivity to allow unique and stable IPv6 instead of an unstable proxied IPv4). Let's not cut the route for the exploding number of mobile users. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-526682655 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/7e6768e8/attachment.html> From notifications at github.com Fri Aug 30 17:56:03 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 10:56:03 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526692533@github.com> > > > > trying to retroactively apply senver semantics doesn't really work. > > It's a number. it either works or it doesn't. (in this case, it does) You were implying to that the *number" gives us licence to break everything at will, not only is that not supported by the facts (as said the "number" predates the concept of semver), it relveals a very hostile attitude toward other developers, -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526692533 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/3bc4f45a/attachment.html> From notifications at github.com Fri Aug 30 18:19:05 2019 From: notifications at github.com (mmd) Date: Fri, 30 Aug 2019 11:19:05 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526699774@github.com> > You were implying to that the *number" gives us licence to break everything at will, It may be a red flag to other developers that things _may_ change, and we _could_ break things at our own discretion. In fact our Terms of Usage even support that approach. _IX Disclaimer_ says: > We may add, change, replace, remove, or discontinue the features and functions of the Services, including APIs. It is your responsibility to ensure that calls or requests you make to the Services are compatible with then-current APIs and authentication methods, and that you handle responses properly. Of course, we're trying to be nice, but we're in no way _obliged_ to do so. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526699774 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/f5104bc0/attachment.html> From notifications at github.com Fri Aug 30 20:29:39 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 13:29:39 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526739148@github.com> @mmd-osm given that I'm one of the authors of that text, I can assure you that it simply is designed to limit the liability of the OSMF if we or somebody else screws up. It is completely orthogonal to any ethical, moral and professional obligation to behave reasonably. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526739148 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/18194033/attachment-0001.html> From notifications at github.com Sat Aug 31 08:37:57 2019 From: notifications at github.com (RicoElectrico) Date: Sat, 31 Aug 2019 01:37:57 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c526812545@github.com> > Should we add a small one liner explanation that "you need to log on to comment on this note"? As well as "log in to receive notifications about note status" if creating a note. While we're at it, it'd be nice to link to the https://wiki.openstreetmap.org/wiki/Notes pages in the note creation view as well Something like: "Learn more about Notes". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-526812545 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/d11d6587/attachment.html> From notifications at github.com Sat Aug 31 09:45:49 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Sat, 31 Aug 2019 02:45:49 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/push/3983270114@github.com> @stefanb pushed 2 commits. e731dd71a77ad4ad1e9db22535e89444bb98e5d9 Merge branch 'master' into tag-colour-preview-rebase fe2bd1ee1a4e2cf7cf3cadf6a5314979f6414ba3 Colour preview moved into new browse_tags_helper -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779/files/26b47fdd188d126bef2e5829d5cc460bad530e2a..fe2bd1ee1a4e2cf7cf3cadf6a5314979f6414ba3 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/592e117d/attachment.html> From notifications at github.com Sat Aug 31 09:59:57 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Sat, 31 Aug 2019 02:59:57 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/push/3983285755@github.com> @stefanb pushed 1 commit. e968ad038a4b08960283735fcd191b937dde6d44 Fixed 2 new eslint errors -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779/files/fe2bd1ee1a4e2cf7cf3cadf6a5314979f6414ba3..e968ad038a4b08960283735fcd191b937dde6d44 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/d50a19a0/attachment.html> From notifications at github.com Sat Aug 31 10:10:44 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Sat, 31 Aug 2019 03:10:44 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/push/3983298013@github.com> @stefanb pushed 1 commit. c47bd173ff655bbcdb97c269b421d93b601c7b0a fixed some rubocop violations -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779/files/e968ad038a4b08960283735fcd191b937dde6d44..c47bd173ff655bbcdb97c269b421d93b601c7b0a -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/33c2af15/attachment.html> From notifications at github.com Sat Aug 31 11:27:38 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Sat, 31 Aug 2019 04:27:38 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/push/3983377594@github.com> @stefanb pushed 1 commit. 379401d76ccf9125240a030390d51983f9530f59 fixed line lengths -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779/files/c47bd173ff655bbcdb97c269b421d93b601c7b0a..379401d76ccf9125240a030390d51983f9530f59 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/df71f49f/attachment.html> From notifications at github.com Sat Aug 31 11:44:07 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Sat, 31 Aug 2019 04:44:07 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/c526823906@github.com> @gravitystorm, I have resolved the conflicts and fixed the code style problem that appeared wit more strict linting during the building process. Please review and test it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779#issuecomment-526823906 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/76efe427/attachment.html>

From notifications at github.com Fri Aug 2 08:57:12 2019 From: notifications at github.com (mmd) Date: Fri, 02 Aug 2019 01:57:12 -0700 Subject: [openstreetmap/openstreetmap-website] Atom feed on user's edit history is broken (#2331) In-Reply-To: References: Message-ID: You can also use https://www.openstreetmap.org/user/hs4rtu/history/feed for the time being. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2331#issuecomment-517620763 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Aug 2 14:15:57 2019 From: notifications at github.com (=?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?=) Date: Fri, 02 Aug 2019 07:15:57 -0700 Subject: [openstreetmap/openstreetmap-website] Set upon search (#2336) Message-ID: <openstreetmap/openstreetmap-website/issues/2336@github.com> Comparing the browser tab title of 1. https://www.google.com/maps/search/電信局前 1. https://www.openstreetmap.org/search?query=電信局前 OSM should set the HTML '<title>' too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2336 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190802/a60fe324/attachment.html> From notifications at github.com Sat Aug 3 08:25:36 2019 From: notifications at github.com (Legolash2o) Date: Sat, 03 Aug 2019 01:25:36 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) Message-ID: <openstreetmap/openstreetmap-website/issues/2337@github.com> Hi, I've installed the latest Ubuntu release (18.04) and when running the "bundle exec rake test:db", I keep getting thrown the error below for each test. I followed the guide to the letter. I did have to update gems as the "make" commands didn't work. https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md ![OSM Error](https://user-images.githubusercontent.com/34819291/62409511-8c1c4a00-b5d0-11e9-8c20-3f350c809868.png) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/cae00687/attachment.html> From notifications at github.com Sat Aug 3 08:57:10 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 01:57:10 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2337/517907849@github.com> Seems like you have a broken phantomjs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#issuecomment-517907849 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/fdcc83c4/attachment.html> From notifications at github.com Sat Aug 3 08:57:11 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 01:57:11 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2337/issue_event/2531221889@github.com> Closed #2337. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#event-2531221889 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/bc8b7ed7/attachment.html> From notifications at github.com Sat Aug 3 09:40:27 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 02:40:27 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2337/517911089@github.com> What does `phantomjs --version` say? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#issuecomment-517911089 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/d3bdd59f/attachment.html> From notifications at github.com Sat Aug 3 09:40:27 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 02:40:27 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2337/issue_event/2531237361@github.com> Reopened #2337. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#event-2531237361 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/103531a1/attachment.html> From notifications at github.com Sat Aug 3 10:32:54 2019 From: notifications at github.com (Adamant36) Date: Sat, 03 Aug 2019 03:32:54 -0700 Subject: [openstreetmap/openstreetmap-website] Save map note overlay between edits (#2338) Message-ID: <openstreetmap/openstreetmap-website/issues/2338@github.com> Although not necessary, it would save some time and a few clicks if the main site saved the state of the map note overlay when editing things in iD Editor so the overlay would still be open when exiting the editor to browse the overlay on the main page again. Otherwise, it's a hassle to reactive notes repeatedly when doing minor quick edits. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2338 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/57584b9a/attachment-0001.html> From notifications at github.com Sat Aug 3 10:54:04 2019 From: notifications at github.com (Legolash2o) Date: Sat, 03 Aug 2019 03:54:04 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2337/517915680@github.com> It wouldn't display as it could find a screen ("X") to display. I removed phantomjs and then reinstalled after running: sudo apt-get install build-essential chrpath sudo apt-get install libfreetype6 libfreetype6-dev sudo apt-get install libfontconfig1 libfontconfig1-dev phantomjs Now it works apart form a few undefined is not a function jQuery error message. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#issuecomment-517915680 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/d20ba534/attachment.html> From notifications at github.com Sat Aug 3 11:05:24 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:05:24 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2337/517916320@github.com> Ah that's because Ubuntu's phantomjs is a bit broken and is built to require X for some silly reason. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#issuecomment-517916320 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/0584047a/attachment.html> From notifications at github.com Sat Aug 3 11:05:25 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:05:25 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" failure (#2337) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2337@github.com> References: <openstreetmap/openstreetmap-website/issues/2337@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2337/issue_event/2531264200@github.com> Closed #2337. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2337#event-2531264200 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/64487583/attachment.html> From notifications at github.com Sat Aug 3 11:32:29 2019 From: notifications at github.com (Legolash2o) Date: Sat, 03 Aug 2019 04:32:29 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) Message-ID: <openstreetmap/openstreetmap-website/issues/2339@github.com> Following in from a previous issue which is now resolved. I've just installed everything on Ubuntu 18.04, following the guide. During the test I receive many "undefined is not a function" messages and mentions of jQuery. I can upload a screen later if required when I'm on my laptop. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/c625ccf6/attachment.html> From notifications at github.com Sat Aug 3 11:48:24 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:48:24 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2339/517918648@github.com> Yeah that happens sometimes but I've never managed to figure out why. It's probably a test ordering thing as it doesn't always happen but it doesn't actually seem to cause any problems. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#issuecomment-517918648 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/504ba26d/attachment.html> From notifications at github.com Sat Aug 3 11:48:24 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:48:24 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2339/issue_event/2531277681@github.com> Closed #2339. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#event-2531277681 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/ff5f71ae/attachment.html> From notifications at github.com Sat Aug 3 11:48:58 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:48:58 -0700 Subject: [openstreetmap/openstreetmap-website] Save map note overlay between edits (#2338) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2338@github.com> References: <openstreetmap/openstreetmap-website/issues/2338@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2338/issue_event/2531277819@github.com> Closed #2338. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2338#event-2531277819 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/d3d66437/attachment-0001.html> From notifications at github.com Sat Aug 3 11:48:58 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 04:48:58 -0700 Subject: [openstreetmap/openstreetmap-website] Save map note overlay between edits (#2338) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2338@github.com> References: <openstreetmap/openstreetmap-website/issues/2338@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2338/517918668@github.com> Issues with iD need to be reported at https://github.com/openstreetmap/iD/issues not here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2338#issuecomment-517918668 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/9ec3c669/attachment.html> From notifications at github.com Sat Aug 3 12:22:27 2019 From: notifications at github.com (Adamant36) Date: Sat, 03 Aug 2019 05:22:27 -0700 Subject: [openstreetmap/openstreetmap-website] Save map note overlay between edits (#2338) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2338@github.com> References: <openstreetmap/openstreetmap-website/issues/2338@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2338/517920682@github.com> My bad. I figured because the note system is activated before entering iD Editor and is reset on the styles side, instead of inside of iD Editor, that it would be a main site thing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2338#issuecomment-517920682 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/782f883e/attachment.html> From notifications at github.com Sat Aug 3 13:19:47 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 03 Aug 2019 06:19:47 -0700 Subject: [openstreetmap/openstreetmap-website] Save map note overlay between edits (#2338) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2338@github.com> References: <openstreetmap/openstreetmap-website/issues/2338@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2338/517924220@github.com> Well maybe I have misunderstood what you mean? Are you talking about the notes layer on the main site? That is normally pretty sticky for me - usually I have the opposite problem and I'm constantly having to turn it off! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2338#issuecomment-517924220 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/1d06aa56/attachment.html> From notifications at github.com Sun Aug 4 05:38:46 2019 From: notifications at github.com (Legolash2o) Date: Sat, 03 Aug 2019 22:38:46 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2339/517975631@github.com> It seems to be from the same file and method. I've attached a screenshot anyway. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#issuecomment-517975631 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190803/2467edb7/attachment.html> From notifications at github.com Sun Aug 4 14:36:15 2019 From: notifications at github.com (Legolash2o) Date: Sun, 04 Aug 2019 07:36:15 -0700 Subject: [openstreetmap/openstreetmap-website] Pages not loading (#2340) Message-ID: <openstreetmap/openstreetmap-website/issues/2340@github.com> I've finally managed to get it so that is passes the rake tests but when I browse to IPAddress:3000, the console shows that it has received and "rendered" a request but the browser window is spinning. Could this be caused because I have not populated the database yet? It's installed on a Ubuntu 18.04 server. I use: bundle exec rails server -b 0.0.0.0 ![OSM Not loading](https://user-images.githubusercontent.com/34819291/62424936-4ee9b200-b6cd-11e9-973e-123f1a02e868.png) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2340 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/65fa0222/attachment.html> From notifications at github.com Sun Aug 4 14:43:39 2019 From: notifications at github.com (Legolash2o) Date: Sun, 04 Aug 2019 07:43:39 -0700 Subject: [openstreetmap/openstreetmap-website] Pages not loading (#2340) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2340@github.com> References: <openstreetmap/openstreetmap-website/issues/2340@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2340/518009308@github.com> Turns out the first request is very very slow. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2340#issuecomment-518009308 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/88bb2461/attachment.html> From notifications at github.com Sun Aug 4 14:43:40 2019 From: notifications at github.com (Legolash2o) Date: Sun, 04 Aug 2019 07:43:40 -0700 Subject: [openstreetmap/openstreetmap-website] Pages not loading (#2340) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2340@github.com> References: <openstreetmap/openstreetmap-website/issues/2340@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2340/issue_event/2531804511@github.com> Closed #2340. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2340#event-2531804511 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/03ce8926/attachment.html> From notifications at github.com Mon Aug 5 00:36:25 2019 From: notifications at github.com (SuperFlomm) Date: Sun, 04 Aug 2019 17:36:25 -0700 Subject: [openstreetmap/openstreetmap-website] Road with covered tag not rendered as underground (#2341) Message-ID: <openstreetmap/openstreetmap-website/issues/2341@github.com> Greetings, there is a road that has the covered=arcade tag: https://www.openstreetmap.org/way/179451263 https://www.openstreetmap.org/way/702472365 However it does not render as an underground road. I tried to fix this by using the location=underground tag and connecting the road to the grass on top. This didn't work either. It might work if I use tunnel=avalanche_protector instead, but that would technically be wrong as [there is literally a sign that calls it an arcade](https://images.mapillary.com/XmytaDZAb_9jBAB8ufWzlw/thumb-2048.jpg) (Galerie in German) and there are no avalanches to protect from. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2341 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/2ddf1050/attachment.html> From notifications at github.com Mon Aug 5 05:43:42 2019 From: notifications at github.com (mmd) Date: Sun, 04 Aug 2019 22:43:42 -0700 Subject: [openstreetmap/openstreetmap-website] Road with covered tag not rendered as underground (#2341) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2341@github.com> References: <openstreetmap/openstreetmap-website/issues/2341@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2341/518093661@github.com> You're reporting this in the wrong repo. OSM Carto style which is handling the tile rendering rules is being discussed here: https://github.com/gravitystorm/openstreetmap-carto -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2341#issuecomment-518093661 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/c892e6ed/attachment.html> From notifications at github.com Mon Aug 5 06:03:48 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 04 Aug 2019 23:03:48 -0700 Subject: [openstreetmap/openstreetmap-website] Road with covered tag not rendered as underground (#2341) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2341@github.com> References: <openstreetmap/openstreetmap-website/issues/2341@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2341/issue_event/2532391444@github.com> Closed #2341. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2341#event-2532391444 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190804/30242ac1/attachment-0001.html> From notifications at github.com Mon Aug 5 07:06:51 2019 From: notifications at github.com (Sven Lohrmann) Date: Mon, 05 Aug 2019 00:06:51 -0700 Subject: [openstreetmap/openstreetmap-website] Unfortunate use of screen estate on mobile (#2035) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2035@github.com> References: <openstreetmap/openstreetmap-website/issues/2035@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2035/518113283@github.com> Any plans to make openstreetmap usable on mobile devices? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2035#issuecomment-518113283 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/86575b64/attachment.html> From notifications at github.com Mon Aug 5 08:22:20 2019 From: notifications at github.com (Andy Allan) Date: Mon, 05 Aug 2019 01:22:20 -0700 Subject: [openstreetmap/openstreetmap-website] Unfortunate use of screen estate on mobile (#2035) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2035@github.com> References: <openstreetmap/openstreetmap-website/issues/2035@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2035/518136267@github.com> > Any plans to make openstreetmap usable on mobile devices? @malnvenshorn Please be careful with the way that you phrase your question, since it comes across as a bit rude. The site is already usable on mobile devices, but of course it could be better too. We're a very small group of volunteer developers, and so many issues will wait for a long time. Asking curt questions doesn't make it happen any faster and doesn't help encourage other people to join in. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2035#issuecomment-518136267 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/14dc5ed4/attachment.html> From notifications at github.com Mon Aug 5 08:58:07 2019 From: notifications at github.com (Sven Lohrmann) Date: Mon, 05 Aug 2019 01:58:07 -0700 Subject: [openstreetmap/openstreetmap-website] Unfortunate use of screen estate on mobile (#2035) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2035@github.com> References: <openstreetmap/openstreetmap-website/issues/2035@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2035/518148315@github.com> My question wasn't meant to be rude, but because there was no feedback I took the liberty to ask. Sorry for that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2035#issuecomment-518148315 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/a5d88d56/attachment.html> From notifications at github.com Mon Aug 5 09:03:17 2019 From: notifications at github.com (Andy Allan) Date: Mon, 05 Aug 2019 02:03:17 -0700 Subject: [openstreetmap/openstreetmap-website] Unfortunate use of screen estate on mobile (#2035) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2035@github.com> References: <openstreetmap/openstreetmap-website/issues/2035@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2035/518150237@github.com> @malnvenshorn no worries. If you want to get started with learning how the code base works and potentially even working on this topic yourself, please let us know! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2035#issuecomment-518150237 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/60653160/attachment.html> From notifications at github.com Mon Aug 5 09:33:52 2019 From: notifications at github.com (Sven Lohrmann) Date: Mon, 05 Aug 2019 02:33:52 -0700 Subject: [openstreetmap/openstreetmap-website] Unfortunate use of screen estate on mobile (#2035) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2035@github.com> References: <openstreetmap/openstreetmap-website/issues/2035@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2035/518160881@github.com> I'd like to but I have no experience with Ruby/Rails and to many other projects I'm working on to find time to get familiar with the project and used frameworks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2035#issuecomment-518160881 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/b5145569/attachment.html> From notifications at github.com Mon Aug 5 12:30:59 2019 From: notifications at github.com (dieterdreist) Date: Mon, 05 Aug 2019 05:30:59 -0700 Subject: [openstreetmap/openstreetmap-website] Road with covered tag not rendered as underground (#2341) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2341@github.com> References: <openstreetmap/openstreetmap-website/issues/2341@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2341/518214652@github.com> sent from a phone > On 5. Aug 2019, at 02:36, SuperFlomm <notifications at github.com> wrote: > > there is literally a sign that calls it an arcade (Galerie in German) regardless this is the wrong place for the question, it is also factually wrong, an arcade in German is called Arkade or Bogengang and should generally have “arcs” (Bögen), i.e. its typically vaulted (gewölbt) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2341#issuecomment-518214652 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/5ee84438/attachment.html> From notifications at github.com Mon Aug 5 19:11:43 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 05 Aug 2019 12:11:43 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2339/issue_event/2534509671@github.com> Reopened #2339. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#event-2534509671 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/f1a89da5/attachment.html> From notifications at github.com Mon Aug 5 19:20:17 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 05 Aug 2019 12:20:17 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2339/518364389@github.com> I think what has happened is that a recent update to the bowser gem has changed the feature detection in some way... so it is causing noise when an ES6 method is used because phantomjs doesn't support it but we haven't loaded the polyfill. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#issuecomment-518364389 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/a4fa0276/attachment.html> From notifications at github.com Mon Aug 5 19:45:34 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 05 Aug 2019 12:45:34 -0700 Subject: [openstreetmap/openstreetmap-website] "bundle exec rake test:db" warnings (#2339) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2339@github.com> References: <openstreetmap/openstreetmap-website/issues/2339@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2339/issue_event/2534589667@github.com> Closed #2339 via 754e566f454f8083e6baebdcc9eebc06e7cda333. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2339#event-2534589667 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190805/43127496/attachment.html> From notifications at github.com Tue Aug 6 08:19:15 2019 From: notifications at github.com (Frederik Ramm) Date: Tue, 06 Aug 2019 01:19:15 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) Message-ID: <openstreetmap/openstreetmap-website/issues/2342@github.com> It regularly happens that people - usually, but not always new signups - upload hundreds of thousands of objects to OSM before someone notices and tells them to stop. Then we have to delete those hundreds of thousands of objects again. (Case in point from recent past, https://www.openstreetmap.org/user/maxiangying.) This is undesirable: * it skews statistics ("wow, today was the day with the most edits since OSM started!!!" etc) * it wastes processing time and bandwidth on the thousands of servers world wide that are configured to consume updates from OSM * it wastes the time of volunteers who have to remove the edits * it embarrasses the person who uploaded the data (at least I hope it does) While editors can, and should, inform their users about potential issues, I think it would also be worth contemplating to have some sort of rate limit on the API. It could be something that users can override but not accidentally - for example, you could be normally limited to X edits per day (exact numbers t.b.d.) and then you could click a button in your user preferences that says "I have read the data import and mechanical edit guidelines and I want to lift the limitation for one week" or so. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/aed03524/attachment.html> From notifications at github.com Tue Aug 6 08:34:29 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 06 Aug 2019 01:34:29 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518569316@github.com> The production API is in the cgimap repository, not here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518569316 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/51a52c08/attachment-0001.html> From notifications at github.com Tue Aug 6 08:39:50 2019 From: notifications at github.com (Frederik Ramm) Date: Tue, 06 Aug 2019 01:39:50 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518571346@github.com> Closed in favour of https://github.com/zerebubuth/openstreetmap-cgimap/issues/207 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518571346 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/4180a0fb/attachment.html> From notifications at github.com Tue Aug 6 08:39:50 2019 From: notifications at github.com (Frederik Ramm) Date: Tue, 06 Aug 2019 01:39:50 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2342/issue_event/2535943308@github.com> Closed #2342. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#event-2535943308 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/2b4ff5f1/attachment.html> From notifications at github.com Tue Aug 6 08:40:43 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 06 Aug 2019 01:40:43 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518571712@github.com> >From a practical point of view you need to define "edit" somehow - the obvious answer is changesets but that can be easily gamed so it will presumably need to be the number of objects added/changed/deleted. Doing it per day is probably excessively expensive from an implementation standpoint because it requires resetting counters at some point, or keeping say hourly counts and expiring those over a day old. A token bucket type algorithm like the download limit probably makes more sense. >From a personal point of view I dread dealing with the resulting complaints... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518571712 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/e4239678/attachment.html> From notifications at github.com Tue Aug 6 08:47:20 2019 From: notifications at github.com (Simon Poole) Date: Tue, 06 Aug 2019 01:47:20 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518574401@github.com> Actually I think the issue should remain here :-). At least the obvious, how stupid me would do it, implementation would involve automatically creating a block once the limit has been exceeded (because all the bits and pieces are already there and we don't want to create a slightly different implementation of the same thing). I believe this would address @tomhughes concerns to as the messaging can be clear what to do to be unblocked (OK I believe we still have the issue with iD borking when an account has been blocked but iD users are unlikely to run in to this anyway). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518574401 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/45f1fc06/attachment.html> From notifications at github.com Tue Aug 6 09:01:50 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 06 Aug 2019 02:01:50 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518580151@github.com> It doesn't matter how clear you make the messaging, you will get people pleading for themselves to be special cased because, you know, PEOPLE MIGHT DIE. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518580151 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/6eca9ad6/attachment.html> From notifications at github.com Tue Aug 6 13:13:05 2019 From: notifications at github.com (mmd) Date: Tue, 06 Aug 2019 06:13:05 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518663368@github.com> Just to add a bit of detail here, we already have rate limiting on the changeset upload call on cgimap, which is currently based on the number of bytes returnes by the call (like it is done for the /map call). Once you hit the limit, the upload would be rejected via HTTP 509 Bandwidth Limit Exceeded. It's not a permanent block either, so it wouldn't place too much of a burden on sysadmins. Admittedly, looking at the number of bytes is not effective by any means to stop the users mentioned here (main reason being that the diffResult message usually comes with a rather tiny amount of bytes compared to a /map call). ;aybe we could evolve this approach by defining some more meaningful criteria. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518663368 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/48049443/attachment.html> From notifications at github.com Tue Aug 6 13:33:14 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 06 Aug 2019 06:33:14 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518671169@github.com> What I was proposing was some sort of equivalent limit on the upload side, whether that's just bytes uploaded, or number of objects changed. But implemented in basically the same way. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518671169 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/c73fea67/attachment.html> From notifications at github.com Tue Aug 6 13:39:37 2019 From: notifications at github.com (Andy Allan) Date: Tue, 06 Aug 2019 06:39:37 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518673673@github.com> > we already have rate limiting on the changeset upload call on cgimap Where does cgimap store the rate limit status? Is it in the database somewhere, or does each instance of cgimap (i.e. on different backend servers) keep track of the rates separately? > The production API is in the cgimap repository, not here. I think it's worth discussing it here too, particularly if we want to ensure clear messaging to the user when they go over any quota. > From a personal point of view I dread dealing with the resulting complaints... So let's make sure the complaints go to someone else! I think it would be something for DWG to deal with, rather than the sysadmin group. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518673673 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/7f8d0d9f/attachment.html> From notifications at github.com Tue Aug 6 13:41:25 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 06 Aug 2019 06:41:25 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518674403@github.com> They're stored in memcache, so shared across instances but can be lost if a memcache server restarts. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518674403 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/696b712c/attachment.html> From notifications at github.com Tue Aug 6 20:01:37 2019 From: notifications at github.com (mmd) Date: Tue, 06 Aug 2019 13:01:37 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518821706@github.com> > I think it's worth discussing it here too, particularly if we want to ensure clear messaging to the user when they go over any quota. For a clear messaging we'd need something better than _You have downloaded too much data. Please try again later._ with comes with an _HTTP 509 Bandwidth Limit Exceeded_ error response. Also, both downloads and uploads currently share the same user-based key in memcache. A user downloading lots of data might be impacted when trying to upload some changes (and vice versa). I don't know if this is good idea. On the other hand, if memcache memory permits, we might as well introduce a dedicated key only used for changeset upload tracking. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518821706 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/ac7584b4/attachment.html> From notifications at github.com Tue Aug 6 20:16:23 2019 From: notifications at github.com (mmd) Date: Tue, 06 Aug 2019 13:16:23 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518826863@github.com> > It could be something that users can override but not accidentally - for example, you could be normally limited to X edits per day (exact numbers t.b.d.) and then you could click a button in your user preferences that says "I have read the data import and mechanical edit guidelines and I want to lift the limitation for one week" or so. I still don't have a clear picture what makes sense here. Checking the users table for some timestamp when rate limiting restrictions would be back to normal, isn't impossible to implement. Pretty much the same applies to the user registration date or number of changesets as additional decision criteria. It's mostly a matter of how a meaningful policy could look like, and also this requires some consensus building in the community. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518826863 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/3b7103a2/attachment-0001.html> From notifications at github.com Tue Aug 6 21:05:12 2019 From: notifications at github.com (Frederik Ramm) Date: Tue, 06 Aug 2019 14:05:12 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/518843797@github.com> It is certainly good to air the idea with the community a bit, though when it comes to it, I would prefer to implement a technologically viable mechanism (that doesn't make the source more complex than necessary and doesn't waste to many resources when executed) and then have the community participate in parametrising that, rather than attempt to find consensus on how exactly something should be implemented. We're not writing a bill of rights here; I think it will be easy to find consensus on the bare outline that I specified initially (make it so that we can't have someone sign up and upload 200k buildings in two days before anybody even notices), and anything more detailed could well be entrusted to those who actually write code ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-518843797 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190806/5bdce6ea/attachment.html> From notifications at github.com Wed Aug 7 14:58:18 2019 From: notifications at github.com (YuriiNskyi) Date: Wed, 07 Aug 2019 07:58:18 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) Message-ID: <openstreetmap/openstreetmap-website/issues/2343@github.com> I'm trying to run my own `openstreetmap-website` on `Ubuntu 18.04 LTS` system. Here are the commands to reproduce an issue: ``` sudo apt-get update sudo apt-get -y install git sudo apt-get -y install virtualbox sudo apt-get -y install vagrant git clone https://github.com/openstreetmap/openstreetmap-website.git cd openstreetmap-website/ vagrant up ``` A problem with `example.application.yml` file occurs here - it is required while it is not provided. This is OK and file from [here](https://github.com/SEL-Columbia/osm-devops/blob/master/example.application.yml) is perfectly valid. Let's again try `vagrant up`. Here's the new error: ``` default: /srv/openstreetmap-website /home/vagrant default: rake aborted! default: Gem::LoadError: You have already activated rake 12.3.3, but your Gemfile requires rake 12.3.2. Prepending `bundle exec` to your command may solve this. default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:313:in `check_for_activated_spec!' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:31:in `block in setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:26:in `map' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:26:in `setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler.rb:107:in `setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/setup.rb:20:in `<top (required)>' default: /srv/openstreetmap-website/config/boot.rb:3:in `<top (required)>' default: /srv/openstreetmap-website/config/application.rb:1:in `require_relative' default: /srv/openstreetmap-website/config/application.rb:1:in `<top (required)>' default: /srv/openstreetmap-website/Rakefile:4:in `require_relative' default: /srv/openstreetmap-website/Rakefile:4:in `<top (required)>' default: /var/lib/gems/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>' default: default: Caused by: default: LoadError: cannot load such file -- bundler/setup default: /srv/openstreetmap-website/config/boot.rb:3:in `<top (required)>' default: /srv/openstreetmap-website/config/application.rb:1:in `require_relative' default: /srv/openstreetmap-website/config/application.rb:1:in `<top (required)>' default: /srv/openstreetmap-website/Rakefile:4:in `require_relative' default: /srv/openstreetmap-website/Rakefile:4:in `<top (required)>' default: /var/lib/gems/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>' default: (See full trace by running task with --trace) ``` I did nothing to activate rake 12.3.3 previously and I don't even bother what is it, but it is OK, we can successfully enter Vagrant virtual machine with the help of `vagrant ssh` command. Finally, we are executing `bundler exec rails server` using SSH and get the following error: ``` Traceback (most recent call last): 52: from bin/rails:4:in `<main>' 51: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require' 50: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency' 49: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require' 48: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require' 47: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi' 46: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register' 45: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi' 44: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require' 43: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/commands.rb:18:in `<top (required)>' 42: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/command.rb:46:in `invoke' 41: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/command/base.rb:65:in `perform' 40: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch' 39: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command' 38: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run' 37: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/commands/server/server_command.rb:142:in `perform' 36: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/commands/server/server_command.rb:142:in `tap' 35: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/railties-5.2.3/lib/rails/commands/server/server_command.rb:145:in `block in perform' 34: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require' 33: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency' 32: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require' 31: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require' 30: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi' 29: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register' 28: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi' 27: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require' 26: from /srv/openstreetmap-website/config/application.rb:19:in `<top (required)>' 25: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler.rb:114:in `require' 24: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:65:in `require' 23: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:65:in `each' 22: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:76:in `block in require' 21: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:76:in `each' 20: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:81:in `block (2 levels) in require' 19: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require' 18: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi' 17: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register' 16: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi' 15: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require' 14: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-libarchive-0.4.10/lib/ffi-libarchive.rb:55:in `<top (required)>' 13: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require' 12: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency' 11: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require' 10: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require' 9: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi' 8: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register' 7: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi' 6: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require' 5: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-libarchive-0.4.10/lib/ffi-libarchive/archive.rb:3:in `<top (required)>' 4: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-libarchive-0.4.10/lib/ffi-libarchive/archive.rb:4:in `<module:Archive>' 3: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-libarchive-0.4.10/lib/ffi-libarchive/archive.rb:11:in `<module:C>' 2: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-1.11.1/lib/ffi/library.rb:99:in `ffi_lib' 1: from /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-1.11.1/lib/ffi/library.rb:99:in `map' /srv/openstreetmap-website/vendor/cache/ruby/2.5.0/gems/ffi-1.11.1/lib/ffi/library.rb:145:in `block in ffi_lib': Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (LoadError) Could not open library 'libarchive.13': libarchive.13: cannot open shared object file: No such file or directory. Could not open library 'libarchive.13.so': libarchive.13.so: cannot open shared object file: No such file or directory. Could not open library 'libarchive-13': libarchive-13: cannot open shared object file: No such file or directory. Could not open library 'libarchive-13.so': libarchive-13.so: cannot open shared object file: No such file or directory. Could not open library 'libarchive.so': libarchive.so: cannot open shared object file: No such file or directory. Could not open library 'libarchive': libarchive: cannot open shared object file: No such file or directory. Could not open library 'archive': archive: cannot open shared object file: No such file or directory ``` I have only two questions. 1. Why it is so hard to simply run my own `openstreetmap-website` ? 2. How can I solve this error? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/a4a99427/attachment.html> From notifications at github.com Wed Aug 7 15:25:28 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 08:25:28 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519146893@github.com> It's hard because you've tried to use vagrant and that is not maintained at all and is well out of date. Just follow the instructions in INSTALL.md instead. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519146893 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/5a2c9c75/attachment-0001.html> From notifications at github.com Wed Aug 7 15:25:29 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 08:25:29 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2343/issue_event/2540489773@github.com> Closed #2343. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#event-2540489773 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/f72cf2e6/attachment.html> From notifications at github.com Wed Aug 7 15:47:57 2019 From: notifications at github.com (Andy Allan) Date: Wed, 07 Aug 2019 08:47:57 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519156187@github.com> @tomhughes could you please try to be a bit more welcoming when new developers try to get started with our project! Also, we agreed before that we will provide support to developers who try to get the codebase up and running, up to the point that the tests pass on their system (but excluding non-standard db configurations). You don't need to provide this support, I volunteered to do so and I'm still happy to do so. Feel free to tag such issues with the "support" tag and let other people deal with them. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519156187 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/0cbf97fa/attachment.html> From notifications at github.com Wed Aug 7 15:47:58 2019 From: notifications at github.com (Andy Allan) Date: Wed, 07 Aug 2019 08:47:58 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2343/issue_event/2540564532@github.com> Reopened #2343. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#event-2540564532 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/62df7f15/attachment.html> From notifications at github.com Wed Aug 7 15:50:16 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 08:50:16 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519157122@github.com> Well there is no useful support to give here other than not to use the vagrant method - there is no support we can give which will make it work. Now a bug ticket asking for the Vagrantfile to be fixed would be reasonable except that we will fix it and it will just get broken again next week - while it is not being actively used or tested on a weekly basis it is just going to continuously bitrot. The same goes for the Dockerfile. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519157122 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/f0e49012/attachment.html> From notifications at github.com Wed Aug 7 16:07:34 2019 From: notifications at github.com (Andy Allan) Date: Wed, 07 Aug 2019 09:07:34 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519164044@github.com> > Well there is no useful support to give here other than not to use the vagrant method - there is no support we can give which will make it work. This is simply not true. We can provide support by fixing the obvious problems with the vagrant setup scripts. If one person has reported them broken, I'm sure others have tried and given up without alerting us. > Now a bug ticket asking for the Vagrantfile to be fixed would be reasonable You could consider this as such a bug, since it's obvious to you and me what needs to be changed in the vagrant scripts to get it working again. But you just closed the ticket, and I'm glad that I spotted the notification and reopened it since it's an issue where something is broken and needs fixing. > it will just get broken again next week It's not outwith the realms of the possible to deal with this, as I know you know. So please don't declare everything as hopeless. I'm no big fan of the vagrant scripts, but if it helps new developers get started then I'll put in the effort to make it work. But like I said before, if you don't want to do this stuff that's fine, just please leave the support issues alone for other people to deal with. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519164044 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/a84ff0e0/attachment.html> From notifications at github.com Wed Aug 7 16:13:56 2019 From: notifications at github.com (Andy Allan) Date: Wed, 07 Aug 2019 09:13:56 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519166452@github.com> @YuriiNskyi thanks for the bug report and sorry that you've been having these problems. As you might have gathered from the previous comments in this thread, the vagrant scripts are not yet part of our CI system, so when we make substantial changes to the setup or dependencies, they are sometimes broken without us noticing. The `example.application.yml` is a case in point, we changed the way our settings work and this file no longer exists. We'll updated the vagrant scripts accordingly. I don't know exactly why the libarchive errors are occuring, but I can investigate further for you in a few days. In the meantime I would guess that `apt install libarchive13` could be worth trying. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519166452 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/e8f0f469/attachment-0001.html> From notifications at github.com Wed Aug 7 16:17:30 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:17:30 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519167850@github.com> So I think we have different definitions of support which is leading to confusion. I view support as providing advice on how to fix something and anything which requires making a change to the repository as being a bug report. Unfortunately while that is generally possible for manual installations, by providing instructions on how to workaround anything that is missing from the instructions, it isn't generally possible for vagrant or docker because there is no way to manually intervene to workaround any errors. I was genuinely attempting to provide support here by advising not to use the vagrant method, which is why I closed it, but I should probably have turned the ticket into a bug report instead. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519167850 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/2aa22793/attachment.html> From notifications at github.com Wed Aug 7 16:18:26 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:18:26 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519168217@github.com> The libarchive will be because the vagrant script hasn't installed `libarchive-dev` I imagine. There's probably other dependencies missing as well as I don't think it's been touched for some time. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519168217 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/eca3da38/attachment.html> From notifications at github.com Wed Aug 7 16:21:28 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:21:28 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installtions are unmaintained (#2344) Message-ID: <openstreetmap/openstreetmap-website/issues/2344@github.com> Bother vagrant and docker installations suffer from constant bitrot where we add new dependencies or change configuration files but don't update the relevant setup scripts. Unfortunately we have no way of detecting this until some unfortunate end user tries to use them because none of the main developers uses them. We either need to find a way of testing them (is that even possible in travis? or is there some other way) or we need to admit defeat and remove them. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/35df15c7/attachment.html> From notifications at github.com Wed Aug 7 16:22:18 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:22:18 -0700 Subject: [openstreetmap/openstreetmap-website] Could not open library 'libarchive.so.13': libarchive.so.13: cannot open shared object file: No such file or directory. (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519169677@github.com> I've opened #2344 to discuss how we can better maintain vagrant and docker support. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519169677 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/cbdbc2d9/attachment.html> From notifications at github.com Wed Aug 7 16:28:10 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:28:10 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2343/issue_event/2540686593@github.com> Closed #2343 via 4efe7cdc109013fa77d3e5356454d305a3726335. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#event-2540686593 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/b6148b8c/attachment.html> From notifications at github.com Wed Aug 7 16:28:35 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:28:35 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519172123@github.com> Hopefully 4efe7cdc109013fa77d3e5356454d305a3726335 will have fixed this although I don't have a working vagrant setup to test it at the moment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519172123 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/4dcf0750/attachment-0001.html> From notifications at github.com Wed Aug 7 16:30:55 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 07 Aug 2019 09:30:55 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installations are unmaintained (#2344) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2344@github.com> References: <openstreetmap/openstreetmap-website/issues/2344@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2344/519172981@github.com> So vagrant can't be done in travis apparently (https://github.com/travis-ci/travis-ci/issues/6060) so we can forget that at least. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomment-519172981 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/5bb1ccfd/attachment.html> From notifications at github.com Thu Aug 8 06:53:59 2019 From: notifications at github.com (YuriiNskyi) Date: Wed, 07 Aug 2019 23:53:59 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519392092@github.com> @tomhughes @gravitystorm First of all, I really appreciate your help! After executing `apt install libarchive13` and `bundle exec rake test:db`, meanwhile solving this error: > The config/application.yml file is no longer supported. Default settings are now found in config/settings.yml and you can override these in config/settings.local.yml. To prevent unexpected behaviour, please copy any custom settings to config/settings.local.yml and then remove your config/application.yml file. it's finally works while executing `bundle exec rails server`. Hurray! Honestly, I did setup with Vagrantfile half a year ago, so I thought that everything should works as usual today. But unfortunately, times have changed. It is absolutely normal that Vagrantfile doesn't have support, what is really confusing, is that I can't find any clear mention about that in [INSTALL.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md) or [VAGRANT.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/VAGRANT.md). If I knew that Vagrantfile is not supported, I would not even try to use it! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519392092 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190807/38e231dc/attachment.html> From notifications at github.com Thu Aug 8 07:28:48 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 00:28:48 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519402582@github.com> I'd be interested to know if a `vagrant up` from a clean start now works as I never did manage to get my vagrant environment working last night... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519402582 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/9e85d0da/attachment.html> From notifications at github.com Thu Aug 8 07:58:05 2019 From: notifications at github.com (mmd) Date: Thu, 08 Aug 2019 00:58:05 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519411866@github.com> > then you could click a button in your user preferences that says "I have read the data import and mechanical edit guidelines and I want to lift the limitation for one week" or so. You could argue that large scale imports come with some kind of responsibility, perhaps even require a commitment to the project. Instead of people clicking on a button, you might be thinking about whether this is something where an OSMF membership status could come into play. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519411866 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/081b66da/attachment.html> From notifications at github.com Thu Aug 8 08:22:06 2019 From: notifications at github.com (YuriiNskyi) Date: Thu, 08 Aug 2019 01:22:06 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519419880@github.com> @tomhughes It works now, but unfortunately not perfect at all. After executing `vagrant up`, it is still the same error: >default: rake aborted! default: Gem::LoadError: You have already activated rake 12.3.3, but your Gemfile requires rake 12.3.2. Prepending `bundle exec` to your command may solve this. default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:313:in `check_for_activated_spec!' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:31:in `block in setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:26:in `map' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:26:in `setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler.rb:107:in `setup' default: /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/setup.rb:20:in `<top (required)>' default: /srv/openstreetmap-website/config/boot.rb:3:in `<top (required)>' default: /srv/openstreetmap-website/config/application.rb:1:in `require_relative' default: /srv/openstreetmap-website/config/application.rb:1:in `<top (required)>' default: /srv/openstreetmap-website/Rakefile:4:in `require_relative' default: /srv/openstreetmap-website/Rakefile:4:in `<top (required)>' default: /var/lib/gems/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>' default: default: Caused by: default: LoadError: cannot load such file -- bundler/setup default: /srv/openstreetmap-website/config/boot.rb:3:in `<top (required)>' default: /srv/openstreetmap-website/config/application.rb:1:in `require_relative' default: /srv/openstreetmap-website/config/application.rb:1:in `<top (required)>' default: /srv/openstreetmap-website/Rakefile:4:in `require_relative' default: /srv/openstreetmap-website/Rakefile:4:in `<top (required)>' default: /var/lib/gems/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>' default: (See full trace by running task with --trace) #<Thread:0x00005651cfc02ca0@/usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/batch_action.rb:71 run> terminated with exception (report_on_exception is true): Traceback (most recent call last): 92: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/batch_action.rb:82:in `block (2 levels) in run' 91: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/machine.rb:188:in `action' 90: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/machine.rb:188:in `call' 89: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/environment.rb:592:in `lock' 88: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/machine.rb:202:in `block in action' 87: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/machine.rb:227:in `action_raw' 86: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 85: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 84: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 83: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 82: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 81: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/check_virtualbox.rb:17:in `call' 80: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 79: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/call.rb:53:in `call' 78: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 77: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 76: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 75: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 74: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 73: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 72: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 71: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 70: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 69: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/config_validate.rb:25:in `call' 68: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 67: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/call.rb:53:in `call' 66: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 65: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 64: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 63: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 62: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 61: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 60: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 59: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 58: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 57: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/check_virtualbox.rb:17:in `call' 56: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 55: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/config_validate.rb:25:in `call' 54: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 53: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/box_check_outdated.rb:79:in `call' 52: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 51: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/call.rb:53:in `call' 50: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 49: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 48: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 47: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 46: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 45: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 44: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 43: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/call.rb:53:in `call' 42: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 41: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 40: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 39: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 38: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 37: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 36: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 35: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/call.rb:53:in `call' 34: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 33: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 32: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 31: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 30: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 29: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 28: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 27: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/check_accessible.rb:18:in `call' 26: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 25: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/clean_machine_folder.rb:17:in `call' 24: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 23: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/set_name.rb:19:in `call' 22: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 21: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/providers/virtualbox/action/clear_forwarded_ports.rb:15:in `call' 20: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 19: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/provision.rb:103:in `call' 18: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/provision.rb:103:in `each' 17: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/provision.rb:126:in `block in call' 16: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/provision.rb:126:in `call' 15: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/environment.rb:504:in `hook' 14: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `run' 13: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/util/busy.rb:19:in `busy' 12: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/runner.rb:66:in `block in run' 11: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builder.rb:116:in `call' 10: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:34:in `call' 9: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `block in finalize_action' 8: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/warden.rb:95:in `call' 7: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/lib/vagrant/action/builtin/provision.rb:138:in `run_provisioner' 6: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:27:in `provision' 5: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:61:in `provision_ssh' 4: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:287:in `with_script_file' 3: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:63:in `block in provision_ssh' 2: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:63:in `tap' 1: from /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/provisioners/shell/provisioner.rb:89:in `block (2 levels) in provision_ssh' /usr/share/rubygems-integration/all/gems/vagrant-2.0.2/plugins/communicators/ssh/communicator.rb:257:in `execute': The SSH command responded with a non-zero exit status. Vagrant (Vagrant::Errors::VagrantError) assumes that this means the command failed. The output for this command should be in the log above. Please read the output to determine what went wrong. The SSH command responded with a non-zero exit status. Vagrant assumes that this means the command failed. The output for this command should be in the log above. Please read the output to determine what went wrong. It is non-critical and after executing `vagrant ssh` in separate terminal, migrating database and starting the server, here's the new error: >couldn't find file 'settings.local.yml' This is non-critical too and could be simply resolved with `cp config/settings.yml config/settings.local.yml` command. Finally, the site works. So yes, partially `vagrant up` from a clean start works. There are still some specific errors trying to confuse a user. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519419880 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/ed7e85c2/attachment-0001.html> From notifications at github.com Thu Aug 8 08:51:14 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 01:51:14 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519430142@github.com> Ah yes that's a known issue... It shouldn't really be needed but sprockets doesn't support conditional dependencies :-( I think dc5cdebc29927933a815a9c65cc8dd2116f87b31 should fix it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519430142 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/e14b5cd5/attachment.html> From notifications at github.com Thu Aug 8 09:04:29 2019 From: notifications at github.com (YuriiNskyi) Date: Thu, 08 Aug 2019 02:04:29 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) Message-ID: <openstreetmap/openstreetmap-website/issues/2345@github.com> I'm trying to install `openstreetmap-website` on clean `Ubuntu 18.04 LTS`. After spending some time on solving [this issue](https://github.com/openstreetmap/openstreetmap-website/issues/2295), by executing these commands: ``` sudo apt-get -y install npm sudo npm install yarn -g ``` here are the new problems: First has occurred when executing `bundle install`: >Traceback (most recent call last): 1: from /usr/local/bin/bundle:23:in `<main>' /usr/local/bin/bundle:23:in `load': cannot load such file -- /usr/share/rubygems-integration/all/gems/bundler-1.16.1/exe/bundle (LoadError) After googling, this problem is simply resolves: ``` sudo gem update --system sudo gem uninstall bundler sudo gem install bundle ``` The next steps works as needed, until we stops at `bundle exec rails server`: > couldn't find file 'settings.local.yml' This is happily resolved by executing `cp config/settings.yml config/settings.local.yml`. Finally, the site works. There are multiple proposed solutions: 1. Add section with Yarn installation into [INSTALL.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md). 2. Do something with bundler (it's up to you, I'm not a professional Ruby developer) 3. Do not require `settings.local.yml` file as, I think, it is only needed to override `settings.yml`. What if I don't need any overrides and totally agreed with default one? 4. Do something with these errors, while running the server: >pngcrush worker: `pngcrush` not found; please provide proper binary or disable this worker (--no-pngcrush argument or `:pngcrush => false` through options) advpng worker: `advpng` not found; please provide proper binary or disable this worker (--no-advpng argument or `:advpng => false` through options) optipng worker: `optipng` not found; please provide proper binary or disable this worker (--no-optipng argument or `:optipng => false` through options) pngquant worker: `pngquant` not found; please provide proper binary or disable this worker (--no-pngquant argument or `:pngquant => false` through options) jhead worker: `jhead` not found, `jpegtran` not found; please provide proper binary or disable this worker (--no-jhead argument or `:jhead => false` through options) jpegoptim worker: `jpegoptim` not found; please provide proper binary or disable this worker (--no-jpegoptim argument or `:jpegoptim => false` through options) jpegtran worker: `jpegtran` not found; please provide proper binary or disable this worker (--no-jpegtran argument or `:jpegtran => false` through options) gifsicle worker: `gifsicle` not found; please provide proper binary or disable this worker (--no-gifsicle argument or `:gifsicle => false` through options) svgo worker: `svgo` not found; please provide proper binary or disable this worker (--no-svgo argument or `:svgo => false` through options) Seems that they are just warnings, anyway, they looks scary. After all, it is really not so hard to install `openstreetmap-website`, except those quirks which are quite confusing for those who didn't professionally work with Linux or Ruby. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/23af51ff/attachment.html> From notifications at github.com Thu Aug 8 10:52:57 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 03:52:57 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2345/519469763@github.com> Note that I don't think you actually need yarn at the moment unless you want to run the eslint tasks? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#issuecomment-519469763 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/57baec16/attachment.html> From notifications at github.com Thu Aug 8 10:52:15 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 03:52:15 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2345/519469564@github.com> To answer your points: * We haven't documented yarn yet because we don't have a good solution for Ubuntu but what you did is probably the least worst approach for now. * I don't think you needed that bundle stuff at all and I wouldn't advise it - the real error there was the settings thing I think. It's a bad idea to overwrite the apt installed bundler with a gem installed one like that anyway - we should either use one of the other. * As I said, the settings thing is known about - there's a ticket somewhere I think though I couldn't find it - it's not clear what is best to do but copying is certainly not required or advisable as it will stop you getting any updates to defaults. An empty file is better. * Yes the image optimiser things are warnings but there is no way to get rid of them. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#issuecomment-519469564 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/5f133ac5/attachment.html> From notifications at github.com Thu Aug 8 10:54:12 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 03:54:12 -0700 Subject: [openstreetmap/openstreetmap-website] Document yarn installation in install notes (#2295) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2295@github.com> References: <openstreetmap/openstreetmap-website/issues/2295@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2295/519470136@github.com> Even if we bump the requirement documenting how to install and use the apt repo is an awful lot of complication that I would prefer to avoid having to document :-( The alternative is just to suggest npm installation of yarn? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2295#issuecomment-519470136 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/372f4dc6/attachment-0001.html> From notifications at github.com Thu Aug 8 11:10:59 2019 From: notifications at github.com (YuriiNskyi) Date: Thu, 08 Aug 2019 04:10:59 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2345/519474742@github.com> @tomhughes So, why not document it? People will search and find similar solution, there is unnecessary complication here. So, the error was because of the `settings.local.yml` file? It's not obvious at all. What should we do with [Ruby gems](https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md#ruby-gems) then? Yes, I don't want to run eslint tasks, but without installing Yarn, I can't pass [Node.js modules](https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md#nodejs-modules) step. Am I right that this step is don't even needed, when you have no goal to run eslint tasks? Ok, let's ignore those warnings! IMHO, section FAQ in [INSTALL.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md) with such quirks, will be a great support for those who want to install `openstreetmap-website` from scratch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#issuecomment-519474742 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/58214e7b/attachment.html> From notifications at github.com Thu Aug 8 11:27:05 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 04:27:05 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2345/519479179@github.com> I'm not saying there aren't problems that we should fix, just that it's hard to come up with good instructions that won't run the risk of breaking people's systems. We can certainly document the settings thing, but the whole idea is that you shouldn't need that file unless you want to override a setting - the problem is that we wanted the assets to rebuild if it changed so we added a dependency on it which causes the error. Ideally we want a dependency that is optional so that if the file exists and is changed the assets are rebuilt. Yes I realise the instructions advise running yarn, and it's likely to be more important at some point, but sadly Ubuntu has not packaged yarn yet which makes it tricky. That's quite new and we're still working out the best solution. Maybe we should just document that step as optional for now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#issuecomment-519479179 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/70a58fdd/attachment.html> From notifications at github.com Thu Aug 8 12:49:51 2019 From: notifications at github.com (Ilya Zverev) Date: Thu, 08 Aug 2019 05:49:51 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519504171@github.com> 2012: your plugin for preventing people spending all their time on mapping is harmful. 2019: okay we need to limit mappers' activity. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519504171 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/cd07358a/attachment.html> From notifications at github.com Thu Aug 8 13:20:59 2019 From: notifications at github.com (mmd) Date: Thu, 08 Aug 2019 06:20:59 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519514982@github.com> @Zverik : your "no more mapping" plugin was a prank to kill JOSM altogether. I don't see how this relates to this discussion. Seems rather off topic to me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519514982 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/f3b54902/attachment.html> From notifications at github.com Thu Aug 8 13:46:19 2019 From: notifications at github.com (Ilya Zverev) Date: Thu, 08 Aug 2019 06:46:19 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519524783@github.com> It was as much of a prank as "delete the repository" button in github. And it relates to the discussion: instead of questioning why should we make arbitrary limits on uploading and why DWG cannot process or even find these super-productive users, we are discussing how to block people from uploading data to OSM automatically. First by number of changesets, then by user-agent, then by geoip and so on — temporary measures completely opaque and puzzling users, with no warnings, unlike that plugin. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519524783 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/8bc279ac/attachment.html> From notifications at github.com Thu Aug 8 13:55:00 2019 From: notifications at github.com (dieterdreist) Date: Thu, 08 Aug 2019 06:55:00 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519528286@github.com> couldn’t you just create another account if you were to hit an upload limit? IP addresses are often dynamically assigned, user agents can be customized at will, VPNs are cheap, what would prevent someone from circumventing arbitrary limits anyway? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519528286 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/2ba2901b/attachment.html> From notifications at github.com Thu Aug 8 14:03:14 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 08 Aug 2019 07:03:14 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519531768@github.com> Yes obviously it's not going to stop somebody that is aware what they're doing is wrong but is determined to go ahead, but that's not the goal, because no technical solution could. The goal is make the well intentioned but over enthusiastic people stop, think, and learn about the community rules around imports and automated edits. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519531768 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/51fc1233/attachment.html> From notifications at github.com Thu Aug 8 14:10:32 2019 From: notifications at github.com (Frederik Ramm) Date: Thu, 08 Aug 2019 07:10:32 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519534691@github.com> > The goal is make the well intentioned but over enthusiastic people stop, think, and learn about the community rules around imports and automated edits. Or, turning this around, today if someone uploads 200,000 buildings in one day without any prior consultation then it could have been an accident. I want to come to a point where if someone does this, it is obvious that it was done with ill intent. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519534691 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/ab0c108b/attachment-0001.html> From notifications at github.com Thu Aug 8 18:09:08 2019 From: notifications at github.com (mmd) Date: Thu, 08 Aug 2019 11:09:08 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/519628443@github.com> Come to think of it, we should probably focus a bit more on UX and discuss ways on how to guide (new) users without patronizing them too much. In particular, large scale uploads, or massive moving around of nodes (based on some well meaning clean up effort) could be easily detected in JOSM and combined with other user metrics like number of changesets or day or date of registration. Also, JOSM knows how much time a user spent in an editing session and can figure out, if it's a simply Overpass download, search and replace and upload within 1 minute kind of mechanical upload, which the API would never be able to figure out. On top, we can present fully localized messages to the user, along with a nice graphical step-by-step guide to go through some checklist or similar, rather than some technical HTTP error message the API would return. So again, let's focus on the user experience first, think how the user interaction could look like, and what kind of guidance would be reasonable and acceptable. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-519628443 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190808/b02eb723/attachment.html> From notifications at github.com Fri Aug 9 10:01:32 2019 From: notifications at github.com (=?UTF-8?B?TWFydGluIENvbnN0YW50aW5v4oCTQm9kaW4=?=) Date: Fri, 09 Aug 2019 03:01:32 -0700 Subject: [openstreetmap/openstreetmap-website] Strange tiles appearing with squashed streets (#2346) Message-ID: <openstreetmap/openstreetmap-website/issues/2346@github.com> Some tiles are currently strangely generated: ![osm-bug](https://user-images.githubusercontent.com/1829786/62771210-9b017180-ba94-11e9-8c63-ed2d46d06d8c.png) It seems that all streets of the neighbourhood are squashed into a single tile, then additional features like bike parking are added on top of this. The position of the streets in the strangely generated tiles do not correspond to the actual position of the streets in the database. I have experienced this issue both in openstreetmap.org and OSM-contributor, both in London and Vienna. It seems to be a recent bug: I first noticed it about two days ago. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2346 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/7f7f6e27/attachment.html> From notifications at github.com Fri Aug 9 10:04:33 2019 From: notifications at github.com (=?UTF-8?B?TWFydGluIENvbnN0YW50aW5v4oCTQm9kaW4=?=) Date: Fri, 09 Aug 2019 03:04:33 -0700 Subject: [openstreetmap/openstreetmap-website] Strange tiles appearing with squashed streets (#2346) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2346@github.com> References: <openstreetmap/openstreetmap-website/issues/2346@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2346/519862140@github.com> It only seems to happen at this particular level of zoom, by the way: zooming in makes the more precise tiles to be fetched, and these tiles are fine. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2346#issuecomment-519862140 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/fe2ccaec/attachment.html> From simon at poole.ch Fri Aug 9 10:13:00 2019 From: simon at poole.ch (Simon Poole) Date: Fri, 9 Aug 2019 12:13:00 +0200 Subject: [openstreetmap/openstreetmap-website] Strange tiles appearing with squashed streets (#2346) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2346@github.com> References: <openstreetmap/openstreetmap-website/issues/2346@github.com> Message-ID: <04c37692-6049-66c6-945a-81f56866e2c4@poole.ch> Those are tiles that you still have in your cache (as I believe they have all been re-rendered) from the incident last week: https://lists.openstreetmap.org/pipermail/talk-gb/2019-August/023327.html Am 09.08.2019 um 12:01 schrieb Martin Constantino–Bodin: > > Some tiles are currently strangely generated: > osm-bug > <https://user-images.githubusercontent.com/1829786/62771210-9b017180-ba94-11e9-8c63-ed2d46d06d8c.png> > It seems that all streets of the neighbourhood are squashed into a > single tile, then additional features like bike parking are added on > top of this. The position of the streets in the strangely generated > tiles do not correspond to the actual position of the streets in the > database. > I have experienced this issue both in openstreetmap.org and > OSM-contributor, both in London and Vienna. It seems to be a recent > bug: I first noticed it about two days ago. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/openstreetmap/openstreetmap-website/issues/2346?email_source=notifications&email_token=AAK2OLKRANROBJEJKGMB7GLQDU57ZA5CNFSM4IKSQVSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HELQS6Q>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAK2OLLFP2NP7SSY5KT2373QDU57ZANCNFSM4IKSQVSA>. > > > _______________________________________________ > rails-dev mailing list > rails-dev at openstreetmap.org > https://lists.openstreetmap.org/listinfo/rails-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/8b1f02e8/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/8b1f02e8/attachment.sig> From notifications at github.com Fri Aug 9 17:12:04 2019 From: notifications at github.com (Tim Waters) Date: Fri, 09 Aug 2019 10:12:04 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519995283@github.com> I also gave it a go, in case others are trying, I also edited the end of the provision.sh script to copy the storage config file (if it's needed) and use also use "bundle exec" to call the rake tasks ``` if [ ! -f config/storage.yml ]; then cp config/example.storage.yml config/storage.yml fi touch config/settings.local.yml # migrate the database to the latest version sudo -u vagrant bundle exec rake db:migrate popd ``` Running the tests, there were errors related to `failed to detect theversion of the executable at '/usr/bin/phantomjs' ` This was solved by changing the environment variable from "phantom" to "offscreen" in the application_system_testcase.rb `ENV["QT_QPA_PLATFORM"] = "offscreen" if IO.popen(["phantomjs", "--version"], :err => :close).read.empty?` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519995283 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/6ec97ac3/attachment.html> From notifications at github.com Fri Aug 9 17:13:21 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 09 Aug 2019 10:13:21 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant installation script is out of date (#2343) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2343@github.com> References: <openstreetmap/openstreetmap-website/issues/2343@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2343/519995662@github.com> Yeah that's a result of the silly way Debian/Unbuntu build phantomjs, so that it requires a graphical display evening if running headless. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2343#issuecomment-519995662 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190809/eaabdc39/attachment.html> From notifications at github.com Sat Aug 10 23:10:31 2019 From: notifications at github.com (Sam Jenkins) Date: Sat, 10 Aug 2019 16:10:31 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) Message-ID: <openstreetmap/openstreetmap-website/pull/2347@github.com> This is a response to issue: [#2336](https://github.com/openstreetmap/openstreetmap-website/issues/2336) Add search query to <title> You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2347 -- Commit Summary -- * set <title> upon search -- File Changes -- M app/views/geocoder/search.html.erb (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2347.patch https://github.com/openstreetmap/openstreetmap-website/pull/2347.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190810/f92354c8/attachment.html> From notifications at github.com Sat Aug 10 23:23:36 2019 From: notifications at github.com (Sam Jenkins) Date: Sat, 10 Aug 2019 16:23:36 -0700 Subject: [openstreetmap/openstreetmap-website] Set <title> upon search (#2336) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2336@github.com> References: <openstreetmap/openstreetmap-website/issues/2336@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2336/520187139@github.com> @jidanni I have created PR #2347 for this issue -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2336#issuecomment-520187139 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190810/780d455f/attachment.html> From notifications at github.com Sun Aug 11 07:37:52 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 11 Aug 2019 00:37:52 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520207329@github.com> Can you give an example of what the resulting title looks like? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520207329 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/dae6875e/attachment.html> From notifications at github.com Sun Aug 11 07:40:35 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 11 Aug 2019 00:40:35 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520207471@github.com> In fact have you checked that this works? Only I wouldn't have thought setting it there would work in most cases - it will work if you load a URL with a search query in it, but it won't update when you do a search in an already loaded page. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520207471 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/69709f93/attachment.html> From notifications at github.com Sun Aug 11 11:07:03 2019 From: notifications at github.com (Sam Jenkins) Date: Sun, 11 Aug 2019 04:07:03 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520219345@github.com> Hi @tomhughes! Have updated initial comment with an example. I have checked that it works in local dev environment. As you say, it certainly works when the URL is loaded with a query string. It also works with XHR requests. The `set_title` function (see `title_helper.rb`) takes a string argument and assigns it to `@title`. It also runs the following line: ``` response.headers["X-Page-Title"] = ERB::Util.u(@title + " | " + t("layouts.project_name.title")) ``` which attaches the updated title to the XHR response. In the browser, `index.js` lines 70-71 use `"X-Page-Title"` to set `document.title`. Would be very grateful if you could flag any unexpected behaviour! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520219345 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/cda517aa/attachment.html> From notifications at github.com Sun Aug 11 11:24:56 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 11 Aug 2019 04:24:56 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520220410@github.com> Yes I know it sets `X-Page-Title` but I didn't think `search.html` would be rendered for an XHR request. I might be wrong though - will have a look later. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520220410 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/5049f930/attachment.html> From notifications at github.com Sun Aug 11 12:17:35 2019 From: notifications at github.com (Sam Jenkins) Date: Sun, 11 Aug 2019 05:17:35 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520223546@github.com> Yes. Took a little bit of unthreading on my part. For XHR, the `#search` action renders `xhr.html.erb` layout through the `#map_layout` method inherited from `application_controller`. The layout yields to `search.html.erb` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520223546 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/16eb9a9a/attachment.html> From notifications at github.com Sun Aug 11 12:18:56 2019 From: notifications at github.com (Sam Jenkins) Date: Sun, 11 Aug 2019 05:18:56 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/c520223628@github.com> Do give it a look in local dev and let me know any thoughts 👍 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#issuecomment-520223628 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/48d139c6/attachment.html> From notifications at github.com Sun Aug 11 13:31:19 2019 From: notifications at github.com (Sam Jenkins) Date: Sun, 11 Aug 2019 06:31:19 -0700 Subject: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen. (#2273) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2273@github.com> References: <openstreetmap/openstreetmap-website/issues/2273@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2273/520228772@github.com> Does anybody know if `reporting_user` is currently stored against `Issue`? Or will this change require migrations? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2273#issuecomment-520228772 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/00833d31/attachment.html> From notifications at github.com Sun Aug 11 14:00:42 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 11 Aug 2019 07:00:42 -0700 Subject: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen. (#2273) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2273@github.com> References: <openstreetmap/openstreetmap-website/issues/2273@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2273/520230789@github.com> Well it will be on the report, not the issue. It can't be on the issue because an issue can have multiple reports. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2273#issuecomment-520230789 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/fcc61ed9/attachment-0001.html> From notifications at github.com Sun Aug 11 14:01:48 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 11 Aug 2019 07:01:48 -0700 Subject: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen. (#2273) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2273@github.com> References: <openstreetmap/openstreetmap-website/issues/2273@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2273/520230867@github.com> So to be clear you want `issue.reports[n].user` but the real problem is that `n` because this is a one-many relationship so there is no single reporting user that can be shown. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2273#issuecomment-520230867 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/e1e22d92/attachment.html> From notifications at github.com Sun Aug 11 20:52:59 2019 From: notifications at github.com (Frederik Ramm) Date: Sun, 11 Aug 2019 13:52:59 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520259411@github.com> https://www.openstreetmap.org/note/808072 recent example of the kind of garbage we have to deal with from anonymous note commenters. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520259411 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/0da761a1/attachment.html> From notifications at github.com Mon Aug 12 05:31:46 2019 From: notifications at github.com (Ilya Zverev) Date: Sun, 11 Aug 2019 22:31:46 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520303007@github.com> I see a kind of double standards regarding this website. When I suggested we give maps.me users a simpler access to the website by implementing the same oauth access as for google and microsoft, it was almost unanimously blocked, 'cause it might hurt the map (I guess — isn't that the only argument we can have?). When dozens of active members ask for closing anonymous comments that visibly hurt the mappers' experience, it is still blocked, because even a slightest contribution matters. It can be either the first or the second. If a slightest contribution matters, then we should open to all, including the dreaded maps.me (although the moment is obviously lost). If mappers matter, then at least anonymous comments should be closed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520303007 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190811/16f42195/attachment.html> From notifications at github.com Mon Aug 12 08:41:23 2019 From: notifications at github.com (Yaron Shahrabani) Date: Mon, 12 Aug 2019 01:41:23 -0700 Subject: [openstreetmap/openstreetmap-website] Email notifications should be RTLed (#2297) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2297@github.com> References: <openstreetmap/openstreetmap-website/issues/2297@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2297/520341942@github.com> Merged? We're all good? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2297#issuecomment-520341942 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/809ce3d8/attachment.html> From notifications at github.com Mon Aug 12 09:17:58 2019 From: notifications at github.com (YuriiNskyi) Date: Mon, 12 Aug 2019 02:17:58 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2345/520352376@github.com> Ok, your point of view is clear, except that I can't understand where is the risk of breaking people's systems, if provided installation instructions are for new people, they don't have any systems. I'm closing this issue, it is all clear now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#issuecomment-520352376 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/abfdbc44/attachment-0001.html> From notifications at github.com Mon Aug 12 09:17:59 2019 From: notifications at github.com (YuriiNskyi) Date: Mon, 12 Aug 2019 02:17:59 -0700 Subject: [openstreetmap/openstreetmap-website] INSTALL.md has minor quirks (#2345) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2345@github.com> References: <openstreetmap/openstreetmap-website/issues/2345@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2345/issue_event/2549567739@github.com> Closed #2345. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2345#event-2549567739 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/2c2ff986/attachment-0001.html> From notifications at github.com Mon Aug 12 13:46:05 2019 From: notifications at github.com (Simon Poole) Date: Mon, 12 Aug 2019 06:46:05 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520431146@github.com> Just so that everybody can read what the problem with @Zverik PR was at the time I offer https://github.com/openstreetmap/openstreetmap-website/pull/1433 (note no mention of 'cause it might hurt the map). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520431146 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/73b83163/attachment.html> From notifications at github.com Mon Aug 12 14:09:34 2019 From: notifications at github.com (Ilya Zverev) Date: Mon, 12 Aug 2019 07:09:34 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520440560@github.com> Yeah, there were very vague reasons which boiled down to "This issue is blocked because it requires a policy decision". Then I made the policy (https://github.com/openstreetmap/operations/issues/162), and everyone basically ignored it, because accepting or rejecting the policy would mean people would need to do something. But you're derailing the discussion. Why #1926 which closes this issue has not been merged yet? Could people in power please give an answer people could act on? Do we need another policy? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520440560 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/e89ada01/attachment.html> From notifications at github.com Mon Aug 12 16:51:56 2019 From: notifications at github.com (Bryan Housel) Date: Mon, 12 Aug 2019 09:51:56 -0700 Subject: [openstreetmap/openstreetmap-website] Multi Fetch GET with /full option? (#2348) Message-ID: <openstreetmap/openstreetmap-website/issues/2348@github.com> Per https://github.com/openstreetmap/iD/issues/6668#issuecomment-520489274 iD is using the [Multi Fetch GET](https://wiki.openstreetmap.org/wiki/API_v0.6#Multi_fetch:_GET_.2Fapi.2F0.6.2F.5Bnodes.7Cways.7Crelations.5D.3F.23parameters) API call in a few situations to fetch ways and relations: - downloading additional member ways for correct handling of multipolygons, routes, etc. - checking and dealing with error 409 conflicts at save time Unfortunately we need to still perform more calls after this to get all the related nodes (and this can be a lot of nodes). It would be really great if we could have a version of this call that works like the [`/full` Single Fetch GET call](https://wiki.openstreetmap.org/wiki/API_v0.6#Full:_GET_.2Fapi.2F0.6.2F.5Bway.7Crelation.5D.2F.23id.2Ffull) that returns all the related nodes in the response. cc @mmd-osm -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2348 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190812/55e16836/attachment.html> From notifications at github.com Tue Aug 13 07:53:10 2019 From: notifications at github.com (Richlv) Date: Tue, 13 Aug 2019 00:53:10 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520729483@github.com> All anonymous comments I recall are spam or people forgetting to log in. As a community, we waste tons of time on these that is not offset by one-off useful anonymous comment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520729483 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190813/e0434b7b/attachment.html> From notifications at github.com Tue Aug 13 11:57:48 2019 From: notifications at github.com (Andy Allan) Date: Tue, 13 Aug 2019 04:57:48 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/c520804968@github.com> @mmd-osm just checking in on this - what are your thoughts for/against my previous suggestions? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229#issuecomment-520804968 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190813/aecb84ab/attachment.html> From notifications at github.com Tue Aug 13 12:13:06 2019 From: notifications at github.com (Andy Allan) Date: Tue, 13 Aug 2019 05:13:06 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/520809320@github.com> > Why #1926 which closes this issue has not been merged yet? Could people in power please give an answer people could act on? I don't think you'll like my answer, but here goes. I can't speak for anyone else and I don't know what the other maintainer thinks on this topic. But for me, it simply hasn't got to the top of my own priority list. There's only so many days in a week that I can spend on this project. I've even stepped down from OWG in order to spend more time here. But with so many open pull requests, so many open issues, my own priorities for the project (in particular, support for multiple API versions, and making it easier for new developers to get started) and all the other stuff, not everything gets done as fast as I would like, nor as fast as everyone else would like. It doesn't help that, behind the scenes, notes are implemented in a decidedly sub-optimal fashion, so any time I go near them I want to ignore the topic and work on other things! > Do we need another policy? Policies can help with certain things, but not e.g. making me work harder :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-520809320 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190813/626da6de/attachment.html> From notifications at github.com Tue Aug 13 16:53:45 2019 From: notifications at github.com (mmd) Date: Tue, 13 Aug 2019 09:53:45 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/c520917099@github.com> I don't have a strong opinion on the first point, as we're only using this tool part part of the CI chain, and it doesn't introduce any new runtime dependencies. I'm also using tools like coverity for cgimap to check for issues in c++ code, even though they're not open source. Regarding the second point, I haven't really seen anything in the config settings like a rubocop style exception definition to disable checks on file/method level. This seems a bit unfortunate as we would skip some checks globally, even for newly introduced issues. Maybe I'm missing something here in the documentation and more fine grained control is possible somehow. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229#issuecomment-520917099 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190813/7aa1b83c/attachment.html> From notifications at github.com Wed Aug 14 08:30:16 2019 From: notifications at github.com (Ilya Zverev) Date: Wed, 14 Aug 2019 01:30:16 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/521153672@github.com> Andy, I appreciate you working on the website, and I'm happy to see quite a lot of progress in its internal implementation. I don't require you or anybody to _do_ anything with the matter. All I want is a clear decision that this — restricting anonymous notes — needs to be done and will be done in near future. Maybe not by coding, but by commenting on the ready-made pull request. I'd prefer not to see more discussion topics like how do we identify anonymous users or should we improve moderation. This issue is as of yesterday the most commented and the one with the most reactions on this issue tracker. If that doesn't mark it as the most important from a user side, I don't know what does. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-521153672 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190814/5b889e24/attachment.html> From notifications at github.com Wed Aug 14 17:18:59 2019 From: notifications at github.com (Mateusz Konieczny) Date: Wed, 14 Aug 2019 10:18:59 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/521337670@github.com> > I don't require you or anybody to do anything with the matter. All I want is a clear decision that this — restricting anonymous notes Reviewing PR and making decision is something that needs to be *done*. And especially with such policy decision - dealing with following complaints that are likely no matter what the decision will be made. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-521337670 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190814/7353de2d/attachment.html> From notifications at github.com Wed Aug 14 17:48:41 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 14 Aug 2019 10:48:41 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/review/275048591@github.com> tomhughes approved this pull request. This looks OK from a technical point of view so I think the only question that remains is the policy one of whether we want to do this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#pullrequestreview-275048591 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190814/e3e81214/attachment.html> From notifications at github.com Wed Aug 14 18:19:54 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 14 Aug 2019 11:19:54 -0700 Subject: [openstreetmap/openstreetmap-website] set <title> upon search (#2347) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2347@github.com> References: <openstreetmap/openstreetmap-website/pull/2347@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2347/issue_event/2557490025@github.com> Closed #2347 via 42345cb9b7ff32e477d69047a1b87dea6e649433. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2347#event-2557490025 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190814/b74e1d54/attachment.html> From notifications at github.com Wed Aug 14 18:19:54 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 14 Aug 2019 11:19:54 -0700 Subject: [openstreetmap/openstreetmap-website] Set <title> upon search (#2336) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2336@github.com> References: <openstreetmap/openstreetmap-website/issues/2336@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2336/issue_event/2557490012@github.com> Closed #2336 via 42345cb9b7ff32e477d69047a1b87dea6e649433. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2336#event-2557490012 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190814/b39ed021/attachment.html> From notifications at github.com Fri Aug 16 17:10:08 2019 From: notifications at github.com (Richlv) Date: Fri, 16 Aug 2019 10:10:08 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/522082694@github.com> Here's a valid anonymous comment... no wait, another user who got logged out :) https://www.openstreetmap.org/note/1729759 As for complaints, a few options: a) Send them all to me. I'll try to reply to all with a polite, canned response. b) Auto-suggest people complaining that they should survey and fix all anonymous notes first. Anonymous notes seem to have been of low value from the very beginning - https://help.openstreetmap.org/questions/23106/removing-anonymous-notes-from-map . -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-522082694 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190816/582ebfd3/attachment.html> From notifications at github.com Fri Aug 16 21:21:13 2019 From: notifications at github.com (Mateusz Konieczny) Date: Fri, 16 Aug 2019 14:21:13 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/522155239@github.com> > Anonymous notes seem to have been of low value from the very beginning Poland has many useful anonymous notes (with strong evidence that majority is really from people without accounts) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-522155239 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190816/4d980a1a/attachment.html> From notifications at github.com Fri Aug 16 21:25:11 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 16 Aug 2019 14:25:11 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/522156343@github.com> We're not talking about anonymous notes here, only about additional anonymous comments on existing notes. So the first comment can still be anonymous, just not later ones. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-522156343 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190816/eada484d/attachment.html> From notifications at github.com Sat Aug 17 08:30:22 2019 From: notifications at github.com (Carsten Hagemann) Date: Sat, 17 Aug 2019 01:30:22 -0700 Subject: [openstreetmap/openstreetmap-website] Tiles not loading properly when opening notes link on phone (#2349) Message-ID: <openstreetmap/openstreetmap-website/issues/2349@github.com> Hey, usually I do not have issues with the website, but the tiles, *never* load as they should on my phone. On my Mac, they loas fine. Using Chrome Beta on a One Plus 5 with Android 9. When loading the page, only the tiles at the left load. The right stays gray. Panning around the map does not load tiles. When going to another tab in chrome and then revisiting the OSM tab, all tiles load properly. Example: https://www.openstreetmap.org/note/1885992#map=14/38.5414/-0.1020 ![Screenshot_20190817-102808](https://user-images.githubusercontent.com/3776997/63208848-bba37a00-c0d9-11e9-9377-7797ba5e1320.jpg) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2349 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/ae8702bb/attachment.html> From notifications at github.com Sat Aug 17 08:34:42 2019 From: notifications at github.com (Carsten Hagemann) Date: Sat, 17 Aug 2019 01:34:42 -0700 Subject: [openstreetmap/openstreetmap-website] Email notification about closed notes should contain initial text (#2036) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2036@github.com> References: <openstreetmap/openstreetmap-website/issues/2036@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2036/522217343@github.com> Sounds pretty good. Is there any activity on this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2036#issuecomment-522217343 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/966942ea/attachment.html> From notifications at github.com Sat Aug 17 08:36:36 2019 From: notifications at github.com (Carsten Hagemann) Date: Sat, 17 Aug 2019 01:36:36 -0700 Subject: [openstreetmap/openstreetmap-website] "thank you" feature (#875) In-Reply-To: <openstreetmap/openstreetmap-website/issues/875@github.com> References: <openstreetmap/openstreetmap-website/issues/875@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/875/522217524@github.com> I'd also really like this and it's always missing (again and again I want to say thanks, but as the note is closed there's no way)! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/875#issuecomment-522217524 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/bd6b0928/attachment-0001.html> From notifications at github.com Sat Aug 17 08:37:38 2019 From: notifications at github.com (Carsten Hagemann) Date: Sat, 17 Aug 2019 01:37:38 -0700 Subject: [openstreetmap/openstreetmap-website] "notes" notification w/o https (#757) In-Reply-To: <openstreetmap/openstreetmap-website/issues/757@github.com> References: <openstreetmap/openstreetmap-website/issues/757@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/757/522217599@github.com> Can be closed as https mails are sent -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/757#issuecomment-522217599 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/c9a410fe/attachment.html> From notifications at github.com Sat Aug 17 10:15:57 2019 From: notifications at github.com (ltog) Date: Sat, 17 Aug 2019 03:15:57 -0700 Subject: [openstreetmap/openstreetmap-website] Email notification about closed notes should contain initial text (#2036) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2036@github.com> References: <openstreetmap/openstreetmap-website/issues/2036@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2036/522224707@github.com> @carstenhag : I don't have any knowledge of someone being working on it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2036#issuecomment-522224707 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/57664689/attachment.html> From notifications at github.com Sat Aug 17 10:44:36 2019 From: notifications at github.com (mmd) Date: Sat, 17 Aug 2019 03:44:36 -0700 Subject: [openstreetmap/openstreetmap-website] Tiles not loading properly when opening notes link on phone (#2349) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2349@github.com> References: <openstreetmap/openstreetmap-website/issues/2349@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2349/522226535@github.com> That's really duplicate of #2035. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2349#issuecomment-522226535 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/df8b2594/attachment.html> From notifications at github.com Sat Aug 17 11:54:30 2019 From: notifications at github.com (Frederik Ramm) Date: Sat, 17 Aug 2019 04:54:30 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/522230583@github.com> Are you sure this is the right place to design the JOSM user interface? Is that not something that should be left to the JOSM developers? There's a relationship of course, but I think that we should do this like we did it with the limitation of changeset sizes: The OSM API decides what is acceptable and rejects anything unacceptable with an error message, and it is then the duty of the editors to ideally guide their users so that this error condition is never triggered, or to deal with the error in a suitable fashion should it occur. Since I'm a JOSM user myself I could certainly sketch a number of possible JOSM UI approaches to get this right, but they would not necessarily apply to other editors that have different UIs - I think that approaching this from a UI perspective is the wrong approach for us in this repository. We should build a mechanism that lets us reject uploads of "too much in too short time", and we could initially set these limits very high and give editor writes the chance to experiment and adapt their UI if necessary, and then tighten the limits to something sensible. I think that trying to design good UIs for all editors is out of scope here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-522230583 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/aab052f0/attachment.html> From notifications at github.com Sat Aug 17 12:10:33 2019 From: notifications at github.com (dieterdreist) Date: Sat, 17 Aug 2019 05:10:33 -0700 Subject: [openstreetmap/openstreetmap-website] Highlighting objects on mobile (#1663) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1663@github.com> References: <openstreetmap/openstreetmap-website/issues/1663@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1663/522231564@github.com> Checking now, it works for notes on iOS (all tiles displayed). There is still an issue if you look at a specific object (/way/123) and close the details the whole map pans approximately one screen width to the left, so that the object you were looking at is off screen -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1663#issuecomment-522231564 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/f0f8643e/attachment.html> From notifications at github.com Sat Aug 17 13:40:02 2019 From: notifications at github.com (Adamant36) Date: Sat, 17 Aug 2019 06:40:02 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/522237793@github.com> I've gotten some useful anonymous responses before when asking what the name of some is or if a road goes through. That said, I'm not sure it balances out the bad. Maybe a way to do it would be to limit anonymous responses to two messages or something. Then the person could leave the intial message, respond if need be, but not spam the note system. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-522237793 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/61877569/attachment.html> From notifications at github.com Sat Aug 17 16:21:40 2019 From: notifications at github.com (Carsten Hagemann) Date: Sat, 17 Aug 2019 09:21:40 -0700 Subject: [openstreetmap/openstreetmap-website] Highlighting objects on mobile (#1663) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1663@github.com> References: <openstreetmap/openstreetmap-website/issues/1663@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1663/522250947@github.com> Broken on chrome beta 77 @ android. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1663#issuecomment-522250947 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/dc35e3ef/attachment.html> From notifications at github.com Sun Aug 18 03:15:41 2019 From: notifications at github.com (blackboxlogic) Date: Sat, 17 Aug 2019 20:15:41 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) Message-ID: <openstreetmap/openstreetmap-website/issues/2350@github.com> When calling Get /api/0.6/trackpoints?bbox=left,bottom,right,top&page=pageNumber The result `<?xml version="1.0" encoding="UTF-8"?> <gpx version="1.0" creator="OpenStreetMap.org" xmlns="http://www.topografix.com/GPX/1/0"> <trk>...` Is gpx version 1.0 which is "old" as of 2004. See https://www.topografix.com/gpx.asp Could the call take another optional parameter specifying the gpx version to return? (either 1.0 or 1.1 which is current) For backward compatibility, default to current behavior (1.0) if the value is ommited. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190817/6c395630/attachment.html> From notifications at github.com Sun Aug 18 07:31:42 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 18 Aug 2019 00:31:42 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522298663@github.com> I see no reason to make it configurable, but equally if we don't use any 1.1 features then I don't see any great reason to change it. Are there are incompatible differences between the two, or does 1.1 essentially just declare that that there are extra elements/attributes we might use? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522298663 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/067cc51a/attachment-0001.html> From notifications at github.com Sun Aug 18 07:32:58 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 18 Aug 2019 00:32:58 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522298746@github.com> Sadly the official site apparently only documents the current version so there is no way to tell what the changes are. I suspect most things never even look at the version to be honest. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522298746 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/44815dc4/attachment.html> From notifications at github.com Sun Aug 18 08:15:31 2019 From: notifications at github.com (mmd) Date: Sun, 18 Aug 2019 01:15:31 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522301272@github.com> Download both https://www.topografix.com/GPX/1/0/gpx.xsd and https://www.topografix.com/GPX/1/1/gpx.xsd and paste them one at a time into http://xsd2xml.com/ to generate a sample file for each version. Most of the elements are optional anyway, but here's a full blown sample for each version: ## Version 1.0 ```XML <?xml version="1.0" encoding="utf-8"?> <gpx version="1.0" creator="str1234"> <name>str1234</name> <desc>str1234</desc> <author>str1234</author> <email>str1234</email> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <time>2012-12-13T12:12:12</time> <keywords>str1234</keywords> <bounds minlat="123.45" minlon="123.45" maxlat="123.45" maxlon="123.45" /> <wpt lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> </wpt> <rte> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <number>33</number> <rtept lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> </rtept> </rte> <trk> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <number>33</number> <trkseg> <trkpt lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <course>123.45</course> <speed>123.45</speed> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <url>http://www.xsd2xml.com</url> <urlname>str1234</urlname> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> </trkpt> </trkseg> </trk> </gpx> ``` ## Version 1.1 ```XML <?xml version="1.0" encoding="utf-8"?> <gpx version="1.1" creator="str1234"> <metadata> <name>str1234</name> <desc>str1234</desc> <author> <name>str1234</name> <email id="str1234" domain="str1234" /> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> </author> <copyright author="str1234"> <year>1999</year> <license>http://www.xsd2xml.com</license> </copyright> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <time>2012-12-13T12:12:12</time> <keywords>str1234</keywords> <bounds minlat="123.45" minlon="123.45" maxlat="123.45" maxlon="123.45" /> <extensions /> </metadata> <wpt lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> <extensions /> </wpt> <rte> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <number>33</number> <type>str1234</type> <extensions /> <rtept lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> <extensions /> </rtept> </rte> <trk> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <number>33</number> <type>str1234</type> <extensions /> <trkseg> <trkpt lat="123.45" lon="123.45"> <ele>123.45</ele> <time>2012-12-13T12:12:12</time> <magvar>123.45</magvar> <geoidheight>123.45</geoidheight> <name>str1234</name> <cmt>str1234</cmt> <desc>str1234</desc> <src>str1234</src> <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> <sym>str1234</sym> <type>str1234</type> <fix>none</fix> <sat>33</sat> <hdop>123.45</hdop> <vdop>123.45</vdop> <pdop>123.45</pdop> <ageofdgpsdata>123.45</ageofdgpsdata> <dgpsid>1234</dgpsid> <extensions /> </trkpt> <extensions /> </trkseg> </trk> <extensions /> </gpx> ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522301272 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/45d5fcce/attachment-0001.html> From notifications at github.com Sun Aug 18 08:20:56 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 18 Aug 2019 01:20:56 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522301595@github.com> So there are a few metadata elements which have changed to be structured containers but I don't think we use any of those so 1.0 would appear to offer the greatest compatibiilty? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522301595 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/d84ee6e2/attachment.html> From notifications at github.com Sun Aug 18 08:26:36 2019 From: notifications at github.com (mmd) Date: Sun, 18 Aug 2019 01:26:36 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522301988@github.com> Right, we don't use the header fields in https://api.openstreetmap.org/api/0.6/trackpoints?bbox=0,51.5,0.25,51.75&page=0 I see a small incompatibility on the <trk> element: The previous <url> element has moved to a link element: ``` <link href="http://www.xsd2xml.com"> <text>str1234</text> <type>str1234</type> </link> ``` ```XML <trk> <name>2019_06_22.gpx.gz</name> <desc>Bike ride</desc> <url>https://api.openstreetmap.org/user/TomH/traces/3026889</url> <trkseg> <trkpt lat="51.7443750" lon="0.0000117"> <time>2019-06-22T14:56:39Z</time> </trkpt> <trkpt lat="51.7443833" lon="0.0000500"> ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522301988 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/b3c6aa27/attachment.html> From notifications at github.com Sun Aug 18 11:47:21 2019 From: notifications at github.com (blackboxlogic) Date: Sun, 18 Aug 2019 04:47:21 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2350/issue_event/2564417853@github.com> Closed #2350. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#event-2564417853 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/679afc44/attachment.html> From notifications at github.com Sun Aug 18 11:47:21 2019 From: notifications at github.com (blackboxlogic) Date: Sun, 18 Aug 2019 04:47:21 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522314679@github.com> The compatibility problem I hit was a gpx parsing tool which checks that xlms is the 1/1 version and refuses to parse it otherwise. I will pursue the issues with them or find a different tool. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522314679 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/552f21b4/attachment.html> From notifications at github.com Sun Aug 18 14:18:34 2019 From: notifications at github.com (Harel M) Date: Sun, 18 Aug 2019 07:18:34 -0700 Subject: [openstreetmap/openstreetmap-website] Api: Get /api/0.6/trackpoints returns gpx version 1.0 (#2350) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2350@github.com> References: <openstreetmap/openstreetmap-website/issues/2350@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2350/522326049@github.com> I still think using an outdated format is less than ideal, even if the new format doesn't provide any new capabilities that fact that OSM API returns and outdated GPX version causes other tools that relay on OSM to keep supporting this old format and keeping old code which is useless otherwise... +1 on moving to the new format. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2350#issuecomment-522326049 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190818/87425662/attachment.html> From notifications at github.com Mon Aug 19 14:20:28 2019 From: notifications at github.com (Andy Allan) Date: Mon, 19 Aug 2019 07:20:28 -0700 Subject: [openstreetmap/openstreetmap-website] "notes" notification w/o https (#757) In-Reply-To: <openstreetmap/openstreetmap-website/issues/757@github.com> References: <openstreetmap/openstreetmap-website/issues/757@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/757/issue_event/2566488282@github.com> Closed #757. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/757#event-2566488282 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190819/305c4414/attachment.html> From notifications at github.com Mon Aug 19 17:29:38 2019 From: notifications at github.com (Paolo Benvenuto) Date: Mon, 19 Aug 2019 10:29:38 -0700 Subject: [openstreetmap/openstreetmap-website] imperfect route (#2351) Message-ID: <openstreetmap/openstreetmap-website/issues/2351@github.com> https://www.openstreetmap.org/directions?engine=fossgis_osrm_car&route=44.41202%2C8.90013%3B44.41662%2C8.85427#map=15/44.4140/8.8773 makes me pass through roads with a lot of traffic. The correct route should use the "via Guido Rossa" (below), which is a highway, like in https://www.openstreetmap.org/directions?engine=fossgis_osrm_car&route=44.40836%2C8.90264%3B44.41524%2C8.85077#map=15/44.4122/8.8767 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2351 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190819/3de8fd5b/attachment.html> From notifications at github.com Mon Aug 19 18:26:23 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 19 Aug 2019 11:26:23 -0700 Subject: [openstreetmap/openstreetmap-website] highway not used for route (#2351) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2351@github.com> References: <openstreetmap/openstreetmap-website/issues/2351@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2351/issue_event/2567252197@github.com> Closed #2351. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2351#event-2567252197 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190819/61c0aa2c/attachment.html> From notifications at github.com Mon Aug 19 18:26:23 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 19 Aug 2019 11:26:23 -0700 Subject: [openstreetmap/openstreetmap-website] highway not used for route (#2351) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2351@github.com> References: <openstreetmap/openstreetmap-website/issues/2351@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2351/522698148@github.com> We don't run the routing engine so you would need to report this to the people that do (in this case hat appears to be https://routing.openstreetmap.de/). Most likely it's just an error in the data somewhere in which case sign up to edit the map and you can help fix it! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2351#issuecomment-522698148 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190819/0934dd9f/attachment.html> From notifications at github.com Wed Aug 21 08:40:29 2019 From: notifications at github.com (Andy Allan) Date: Wed, 21 Aug 2019 01:40:29 -0700 Subject: [openstreetmap/openstreetmap-website] Upgrade to Rails 6 (#2352) Message-ID: <openstreetmap/openstreetmap-website/issues/2352@github.com> Rails 6.0 [has been released](https://weblog.rubyonrails.org/2019/8/15/Rails-6-0-final-release/), and it contains some things that will be of interest to us: * Parallel testing - we have a lot of tests! * Multiple databases - this will allow us to split database read requests into their own connection, and route them to the database replicas. This is something cgimap already does and it will be great to have this here too. * Action Mailbox - this would be a lower priority, but it will allow us to use standard methods for processing incoming emails. It would be of most use to secondary deployments, who might have less control over receiving their emails than OSMF does. The major blocker for the upgrade is, as ever, the [`composite_primary_keys`](https://github.com/composite-primary-keys/composite_primary_keys) gem, which needs a 12.x release to support rails 6. We can wait on that, for now. I've looked through the rest of the [release notes](https://edgeguides.rubyonrails.org/6_0_release_notes.html) and the [upgrade guide](https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-5-2-to-rails-6-0), and nothing particularly sticks out to me. If there's anything else that will block our upgrade, or any other new feature that we should also take advantage of, add your comment here! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2352 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/bea912c1/attachment.html> From notifications at github.com Wed Aug 21 09:11:35 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 21 Aug 2019 02:11:35 -0700 Subject: [openstreetmap/openstreetmap-website] Upgrade to Rails 6 (#2352) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2352@github.com> References: <openstreetmap/openstreetmap-website/issues/2352@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2352/523370523@github.com> I started work on this last night ;-) First signs are good and I got to the point where the majority of tests pass - obviously the big blocker there is CPK as you say but also https://github.com/rails/actionpack-page_caching (believed to be ready but needs a release, https://github.com/rails/actionpack-page_caching/issues/58) and https://github.com/rails/record_tag_helper (also believed to be ready but needs a release, https://github.com/rails/record_tag_helper/pull/10#issuecomment-523135585). I think CPK is also reasonable shape - there have been a number rc releases during rails 6 devleopment so it probably just needs finishing off. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2352#issuecomment-523370523 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/991c8ccb/attachment.html> From notifications at github.com Wed Aug 21 14:48:23 2019 From: notifications at github.com (Andy Allan) Date: Wed, 21 Aug 2019 07:48:23 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) Message-ID: <openstreetmap/openstreetmap-website/pull/2353@github.com> I'd like to support multiple API versions, so that we can deploy API 0.7 in parallel to API 0.6. It's not something we've ever done before, but I think it's the only reasonable way to handle API version changes these days! I'm opening this PR just to receive any initial feedback on this proposed approach to the code changes. So far this approach demonstrates the basic concepts, including: * Supporting different scenarios, e.g. dropping old api calls, adding new api calls, api calls that are the same in each version, api calls that are similar but return different results (e.g. different response codes) * Optimised for the assumption that almost all api calls are the same between different versions. * Being able to choose which versions are deployed. This allows the codebase to support multiple API versions during development and when running the tests, and so it avoids long-running branches. * Only code that is different between api versions is in any way duplicated. Otherwise the same code is used for each api version. * Establishes a naming convention for controllers that behave differently in different API versions. The general idea is that old code lives in specific controllers, e.g. `API::V06::CapabilitiesController`, and new code lives in the normal place e.g. `API::CapabilitiesController`. This makes future upgrades easier, since the assumption is that new code will be used in version N+1 too. * It's all designed to allow multiple, non-contiguous versions. For example, if we yank a future version 0.8, it'll cope fine with e.g. deployed_versions = ["0.6", "0.7", "0.9"] If you are interested in seeing how it works, then the changes to "config/routes.rb" along with the output from "bundle exec rake routes" are the best way to see the overall idea. The biggest drawbacks so far are around the tests. First, I think it makes sense that every API version that the codebase knows about is fully tested, i.e. even if the result is expected to be the same, a given api test should run once for each api version. This leads to the indentation of all the tests changing, since we need to add a "all_api_versions" loop around almost every test. So the diffs and git blame are horrible. Secondly, the controller methods involve lots of changes like this: ```diff - get :show + get :show, :params => { :api_version => version } ``` It leads to a lot of extra `params => ...` to skim read, which isn't ideal. I've tried working around this but [the workarounds have their own drawbacks](https://github.com/gravitystorm/openstreetmap-website/issues/28#issuecomment-523427402). The tests don't all pass yet, so this is not yet in shape to be committed, but I hope to get it there soon. In the meantime, and before I make any further changes that you might not be happy with, any feedback is very welcome! You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2353 -- Commit Summary -- * Remove use of Settings.api_version in tests * Allow callers to set the api_version for xml document creation * Initial sketch for multiple API version support * Different capabilities responses for 0.6 and 0.7 * WIP changesets for all api versions and refactor tests * Allow diffReader callers to set the api version of the returned XML -- File Changes -- M app/assets/javascripts/osm.js.erb (2) M app/controllers/api/capabilities_controller.rb (5) M app/controllers/api/changesets_controller.rb (4) A app/controllers/api/v06/capabilities_controller.rb (13) M app/controllers/api/versions_controller.rb (4) M app/controllers/api_controller.rb (5) M app/views/api/capabilities/show.builder (3) M app/views/api/changesets/changeset.builder (2) M app/views/api/changesets/changesets.builder (2) M app/views/api/permissions/show.builder (2) A app/views/api/v06/capabilities/show.builder (22) A config/initializers/api_versions.rb (9) M config/initializers/config.rb (2) M config/routes.rb (69) M config/settings.yml (4) M config/settings/test.yml (2) M lib/diff_reader.rb (6) M lib/osm.rb (7) M test/controllers/api/capabilities_controller_test.rb (55) M test/controllers/api/changes_controller_test.rb (6) M test/controllers/api/changesets_controller_test.rb (3157) M test/controllers/api/map_controller_test.rb (8) M test/controllers/api/permissions_controller_test.rb (64) M test/controllers/api/relations_controller_test.rb (2) M test/controllers/api/versions_controller_test.rb (2) M test/integration/user_blocks_test.rb (10) M test/integration/user_terms_seen_test.rb (4) M test/test_helper.rb (8) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2353.patch https://github.com/openstreetmap/openstreetmap-website/pull/2353.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/44608c39/attachment.html> From notifications at github.com Wed Aug 21 15:26:49 2019 From: notifications at github.com (Andy Allan) Date: Wed, 21 Aug 2019 08:26:49 -0700 Subject: [openstreetmap/openstreetmap-website] Multi Fetch GET with /full option? (#2348) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2348@github.com> References: <openstreetmap/openstreetmap-website/issues/2348@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2348/523508442@github.com> Seems reasonable to me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2348#issuecomment-523508442 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/b69a1e8f/attachment.html> From notifications at github.com Wed Aug 21 16:36:46 2019 From: notifications at github.com (mmd) Date: Wed, 21 Aug 2019 09:36:46 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523541747@github.com> I haven't looked through all the details yet, so please bear with me. I was wondering a bit how you would handle evolutionary or even revolutionary changes to the data model. Typically this is one of the most troubling and complicated aspects of new API versions, and I think it would be good to have some basic concept in place as well here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523541747 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/8fc9c673/attachment.html> From notifications at github.com Wed Aug 21 19:05:09 2019 From: notifications at github.com (mmd) Date: Wed, 21 Aug 2019 12:05:09 -0700 Subject: [openstreetmap/openstreetmap-website] Overpass query bbox to use map precision (#2354) Message-ID: <openstreetmap/openstreetmap-website/pull/2354@github.com> 15 decimal places for bbox lat/lon values seemed a bit excessive. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2354 -- Commit Summary -- * Overpass query to use map precision -- File Changes -- M app/assets/javascripts/index/query.js (6) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2354.patch https://github.com/openstreetmap/openstreetmap-website/pull/2354.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2354 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/9312a78c/attachment-0001.html> From notifications at github.com Thu Aug 22 02:00:00 2019 From: notifications at github.com (whoisutsav) Date: Wed, 21 Aug 2019 19:00:00 -0700 Subject: [openstreetmap/openstreetmap-website] Numericality validation typo - should be `only_integer` instead of `integer_only` (#2355) Message-ID: <openstreetmap/openstreetmap-website/issues/2355@github.com> Hi, There are a number of fields in the models which are validated for numericality, using the flag `integer_only`: ``` [openstreetmap-website] $ grep -rin "integer_only" . ./app/models/old_node.rb:41: :numericality => { :integer_only => true } ./app/models/old_node.rb:43: :numericality => { :integer_only => true } ./app/models/note.rb:27: :numericality => { :on => :update, :integer_only => true } ./app/models/changeset_comment.rb:27: :numericality => { :on => :update, :integer_only => true } ./app/models/node.rb:50: :numericality => { :on => :update, :integer_only => true } ./app/models/node.rb:52: :numericality => { :integer_only => true } ./app/models/node.rb:54: :numericality => { :integer_only => true } ./app/models/node.rb:56: :numericality => { :integer_only => true } ./app/models/node.rb:58: :numericality => { :integer_only => true } ./app/models/way.rb:42: :numericality => { :on => :update, :integer_only => true } ./app/models/way.rb:44: :numericality => { :integer_only => true } ./app/models/way.rb:46: :numericality => { :integer_only => true } ./app/models/changeset.rb:46: :numericality => { :on => :update, :integer_only => true } ./app/models/changeset.rb:48: :numericality => { :integer_only => true } ./app/models/changeset.rb:50: :numericality => { :integer_only => true, ./app/models/changeset.rb:54: :numericality => { :integer_only => true } ./app/models/note_comment.rb:31: :numericality => { :on => :update, :integer_only => true } ./app/models/relation.rb:40: :numericality => { :on => :update, :integer_only => true } ./app/models/relation.rb:42: :numericality => { :integer_only => true } ./app/models/relation.rb:44: :numericality => { :integer_only => true } ``` However I believe the flag accepted by the Rails numericality API is `only_integer`, _not_ `integer_only`. See [here](https://github.com/rails/rails/blob/b9ca94caea2ca6a6cc09abaffaad67b447134079/activemodel/lib/active_model/validations/numericality.rb#L12). Perhaps the flag has changed since previous Rails versions? Nevertheless, the code linked above is from the app version of Rails (5.2.3), so it seems these numericality validations may now be silently ignored. Found this while analyzing the app as part of a research project. Happy to create a pull request if that's helpful (and others agree this is an issue). Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2355 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/cd722481/attachment.html> From notifications at github.com Thu Aug 22 05:02:13 2019 From: notifications at github.com (docljn) Date: Wed, 21 Aug 2019 22:02:13 -0700 Subject: [openstreetmap/openstreetmap-website] Edit dropdown is hard to use on touch devices. (#271) In-Reply-To: <openstreetmap/openstreetmap-website/issues/271@github.com> References: <openstreetmap/openstreetmap-website/issues/271@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/271/523748705@github.com> Hello the team. This is a particularly old issue (!) and I wondered if it was still open for a reason, or had been missed? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/271#issuecomment-523748705 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190821/6c13a9be/attachment.html> From notifications at github.com Thu Aug 22 09:10:07 2019 From: notifications at github.com (Andy Allan) Date: Thu, 22 Aug 2019 02:10:07 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523820493@github.com> > I was wondering a bit how you would handle evolutionary or even revolutionary changes to the data model. I can sum this up with the phrase "it depends"! * Different versions of the API can use different views, so if we added something to a future api (for example "node coordinate precision" or somesuch) it can be shown in the latest version and ignored in previous versions, or shown in a different way (e.g. as tags). * Different api versions can use different controllers too, as already demoed in this PR for the capabilities controller. This allows more subtantial changes in behaviour between api versions, and changes like fixing response codes. * We could use different models too. I'm not sure why we'd want to, but e.g. api/0.7/node/1 could call a node_controller that fetches data from the ShinyNewNode model. But it all really depends. I think the underlying question might be "how do we handle drastically non-backwards-compatible changes, like converting all closed ways into an area type (or if we introduce an area type into API N+1, how does that work with API N clients); or how would a change like removing segments work with two api versions running in parallel. I don't have an answer for these major structural changes, except to say that if it's logically possible at all to access the data between versions, the code approach in this PR will be able to handle it. And perhaps there'll be some change to the datastructure that prevents parallel API versions and it'll trigger a hard cutover between versions. But lets not get stuck on the biggest problem, and one that's not yet in hand. In the meantime, there's a ton of backwards-compatible but needs-API-bump changes that have been stuck for years, so we can at least sort out those ones :smile: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523820493 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/ae7e9023/attachment.html> From notifications at github.com Thu Aug 22 09:29:13 2019 From: notifications at github.com (Andy Allan) Date: Thu, 22 Aug 2019 02:29:13 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523827006@github.com> I should have said, if there's specific API changes that you're thinking about, even if they are just to illustrate a point, let me know and I'll see how they fit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523827006 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/4b0de6b5/attachment.html> From notifications at github.com Thu Aug 22 09:30:23 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 22 Aug 2019 02:30:23 -0700 Subject: [openstreetmap/openstreetmap-website] Edit dropdown is hard to use on touch devices. (#271) In-Reply-To: <openstreetmap/openstreetmap-website/issues/271@github.com> References: <openstreetmap/openstreetmap-website/issues/271@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/271/523827380@github.com> Because nobody has volunteered a fix. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/271#issuecomment-523827380 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/9cd014fa/attachment-0001.html> From notifications at github.com Thu Aug 22 09:32:45 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 22 Aug 2019 02:32:45 -0700 Subject: [openstreetmap/openstreetmap-website] Overpass query bbox to use map precision (#2354) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2354@github.com> References: <openstreetmap/openstreetmap-website/pull/2354@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2354/c523828245@github.com> Well sure there may not be any good reason to send 15 but is there any good reason not to? Does adding this extra code solve some technical issue? I don't believe that URL is visible anywhere so I don't think there's any UX concern here is there? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2354#issuecomment-523828245 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/1defda7c/attachment.html> From notifications at github.com Thu Aug 22 11:22:31 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 22 Aug 2019 04:22:31 -0700 Subject: [openstreetmap/openstreetmap-website] Numericality validation typo - should be `only_integer` instead of `integer_only` (#2355) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2355@github.com> References: <openstreetmap/openstreetmap-website/issues/2355@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2355/issue_event/2576114464@github.com> Closed #2355 via 135ec35a91bcca15637b6436dd7e546468c49690. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2355#event-2576114464 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/a4e36b0d/attachment.html> From notifications at github.com Thu Aug 22 11:43:51 2019 From: notifications at github.com (Simon Poole) Date: Thu, 22 Aug 2019 04:43:51 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523869662@github.com> > But lets not get stuck on the biggest problem, and one that's not yet in hand. In the meantime, there's a ton of backwards-compatible but needs-API-bump changes that have been stuck for years, so we can at least sort out those ones 😄 Likely making myself very unpopular: - where are all these "backward-compatible but needs-API-bump changes that have been stuck for years changes" documented? - in general I oppose all of this on the grounds that the GDPR related changes need to be implemented first and I'm actually surprised that "nice to have" API changes are even being given a seconds thought in the current situation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523869662 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/edbe66b4/attachment.html> From notifications at github.com Thu Aug 22 11:47:35 2019 From: notifications at github.com (mmd) Date: Thu, 22 Aug 2019 04:47:35 -0700 Subject: [openstreetmap/openstreetmap-website] Overpass query bbox to use map precision (#2354) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2354@github.com> References: <openstreetmap/openstreetmap-website/pull/2354@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2354/c523870774@github.com> It's really a matter of consistency, as we're already using a limited number of digits for `(around:xx,lat,lon)` in the same query. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2354#issuecomment-523870774 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/6068f004/attachment.html> From notifications at github.com Thu Aug 22 12:02:44 2019 From: notifications at github.com (Andy Allan) Date: Thu, 22 Aug 2019 05:02:44 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523875346@github.com> > * where are all these "backward-compatible but needs-API-bump changes that have been stuck for years changes" documented? Find your favourite API-0.7 wishlist, ignore the stuff about areas, and there's your list. :smile: Different people have created different lists over the years. I'm not intending to implement many changes, just the ones that I've been personally complaining about since API 0.6 was released over a decade ago (like incorrect http status codes, and plain-text responses, and stuff like that). > in general I oppose all of this on the grounds that the GDPR related changes need to be implemented first I know that you **want** them first, but that doesn't mean that they **need** to be done first. In particular, if the GDPR-related changes can be made without changing the API version then they can be implemented in parallel to this work, and so they are not interdependent. If they need to break API compatibility, then this work will need to come first anyway. So either way, they don't need to come first. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523875346 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/fe373697/attachment.html> From notifications at github.com Thu Aug 22 13:26:22 2019 From: notifications at github.com (Bryan Housel) Date: Thu, 22 Aug 2019 06:26:22 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523905450@github.com> > I should have said, if there's specific API changes that you're thinking about, even if they are just to illustrate a point, let me know and I'll see how they fit. Just off the top of my head, we'd see some immediate performance improvement on the iD side from: - JSON API (#2221) - Multi-fetch GET with /full (#2348) (these require some coordination from the CGImap side too, but I don't think that's a blocker) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523905450 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/83ff014b/attachment.html> From notifications at github.com Thu Aug 22 15:03:56 2019 From: notifications at github.com (Simon Poole) Date: Thu, 22 Aug 2019 08:03:56 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c523945326@github.com> Except, naturally, that neither of #2221 and #2348 depend on this PR. Without it (this PR) we would have simply added them as a 0.6 feature, as we have done so many times before and not doing that raises the whole question of versioning of the OSM API in general which is a rabbit hole of its own , -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-523945326 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/7adebe33/attachment-0001.html> From notifications at github.com Thu Aug 22 15:27:05 2019 From: notifications at github.com (mmd) Date: Thu, 22 Aug 2019 08:27:05 -0700 Subject: [openstreetmap/openstreetmap-website] Multi Fetch GET with /full option? (#2348) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2348@github.com> References: <openstreetmap/openstreetmap-website/issues/2348@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2348/523954804@github.com> As I mentioned in the linked issue, we still need to sort out, how the new "multi fetch with full option" is exposed via the API. Should we extend the existing endpoint (if so, how exactly should that look like?), or would it make more sense to define a new endpoint? That's more or less the same level of detail you would need to update the OSM API documentation in the WIki. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2348#issuecomment-523954804 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/84cd6688/attachment.html> From notifications at github.com Thu Aug 22 16:37:45 2019 From: notifications at github.com (docljn) Date: Thu, 22 Aug 2019 09:37:45 -0700 Subject: [openstreetmap/openstreetmap-website] Edit dropdown is hard to use on touch devices. (#271) In-Reply-To: <openstreetmap/openstreetmap-website/issues/271@github.com> References: <openstreetmap/openstreetmap-website/issues/271@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/271/523982192@github.com> Thanks @tomhughes : I wanted to make sure it was still a relevant issue that the team would like help with... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/271#issuecomment-523982192 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/8dce1e67/attachment.html> From notifications at github.com Thu Aug 22 18:11:27 2019 From: notifications at github.com (mmd) Date: Thu, 22 Aug 2019 11:11:27 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/524016999@github.com> I don't to go into details about the differences between UX and UI design, as it would be a bit beyond the scope of this issue. I'm 100% positive that you need to think this issue end-to-end starting from the editing app to the API to get some meaningful results, rather than just annoy users with arbitrary limits. This is mainly a JOSM issue. I clearly don't see any of the other editors anywhere close to creating a similar amount of data to upload (ignoring command line tools for a second). >From the API side, we can rather easily calculate both the number of changesets a user created during the last "n" hours, as well as as well as the total number of changes via some database statement. Number of changes would include any kind of operation (creating/updating/deleting) without knowing any further details. Those figures should be checked at the time when a new changeset is being created, rather than during the upload itself (I think the reasons are clear). A meaningful response should of course include the estimated waiting time, otherwise the error message won't make much sense to a user. I would consider anything that requires any sort of domain knowledge (e.g. counting "number of houses") to be out of scope for the API. If a user uploads tons of objects with rather uncommon tags, the editor app should take care of that. Still, the overall approach as it stands has a massive negative impact on people trying to clean up failed imports from other mappers or simply revert vandalism. I want to see a bit more discussion how those negative effects can be minimized, if not completely avoided. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-524016999 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/1aee79ce/attachment.html> From notifications at github.com Thu Aug 22 18:40:30 2019 From: notifications at github.com (Frederik Ramm) Date: Thu, 22 Aug 2019 11:40:30 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/524027394@github.com> I suggested in my initial message that there could be a mechanism whereby people could - perhaps temporarily - lift the limit in a self-service fashion. That would go a long way to ensure that if someone knows what they're doing they will not be hindered, but if someone does *not* know what they're doing they will be. I agree that all the API can do is count the number of modifications, not what exactly something is, and I never intended it to; I mentioned houses just as an example. If someone uploads a hundred thousand trees (or, also a popular option, a hundred thousand untagged objects), or *deletes* a hundred thousand houses, that's just as bad. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-524027394 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/7b3b41e0/attachment.html> From notifications at github.com Fri Aug 23 01:55:29 2019 From: notifications at github.com (Eliot Blennerhassett) Date: Thu, 22 Aug 2019 18:55:29 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) Message-ID: <openstreetmap/openstreetmap-website/issues/2356@github.com> In my experience, neither Search nor Directions prioritise nearby places. ## Search Example: I start here Christchurch City, New Zealand. https://www.openstreetmap.org/#map=12/-43.5315/172.5830 Search for "cashmere high school", which is in the view. The map jumps to Washington, USA. Desired result: Select the closest, order by distance. ## Directions Then select the correct (2nd) entry, click Directions arrow button, and put pin on the school.christchurch Enter "airport" into the destination box, click GO. Result: Destination filled in with "Airport, Access to Metro 'Aeroporto', Olivais, Santa Maria de Olivais, Lisbon, Grande Lisboa, Área Metropolitana de Lisboa, 1700-008, Portugal" Routing displays:"Couldn't find a route between those two places." Change destination to "Christchurch Airport", Result: Destination="Spence, B4234, Lydbrook, Forest of Dean, Gloucestershire, South West England, England, GL17 9NS, United Kingdom". Routing displays:"Couldn't find a route between those two places." Unlike the Search results, there is no list of found places to select from, the first one is always used. Desired result: Closest reachable destination used(?) or at least a selection of found places to choose from. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/9439bcff/attachment-0001.html> From notifications at github.com Fri Aug 23 06:07:15 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 22 Aug 2019 23:07:15 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2356/issue_event/2578624722@github.com> Closed #2356. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#event-2578624722 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/ea9f468d/attachment.html> From notifications at github.com Fri Aug 23 06:07:15 2019 From: notifications at github.com (Tom Hughes) Date: Thu, 22 Aug 2019 23:07:15 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2356/524185284@github.com> Search bugs need to be reported to https://github.com/openstreetmap/Nominatim/issues which is the tracker for our geocoding engine. We do prioritise nearby places though, or at least we pass the search engine the current viewport so that it can do so. I believe it doubles the size of that box and considers anything in that area as "near" rather than doing a full global sort by distance which may be the issue you are seeing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#issuecomment-524185284 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190822/6c51abe6/attachment.html> From notifications at github.com Fri Aug 23 08:07:49 2019 From: notifications at github.com (Eliot Blennerhassett) Date: Fri, 23 Aug 2019 01:07:49 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2356/524217771@github.com> OK, it is hard to tell whether the problem is with the front or back end. The 2nd part of my issue, about directions (always get first item, don't see other search results) could be a front-end (enhancement or bug, if you like) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#issuecomment-524217771 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/5df0a44d/attachment.html> From notifications at github.com Fri Aug 23 13:43:56 2019 From: notifications at github.com (=?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?=) Date: Fri, 23 Aug 2019 06:43:56 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) Message-ID: <openstreetmap/openstreetmap-website/issues/2357@github.com> One sees "Zoom in to query features." However often those features one wants to query disappear when one zooms in! Therefore consider always allowing the user to query any item he can see. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/83c4b097/attachment.html> From notifications at github.com Fri Aug 23 14:30:27 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 23 Aug 2019 07:30:27 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2357@github.com> References: <openstreetmap/openstreetmap-website/issues/2357@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2357/524337469@github.com> That limitation is not there for fun, it's there because too many things would be found, or more likely the overpass query that drives it would just time out. You need to be zoomed in far enough that there are likely to only be a relatively small number of features within the search radius. Sorry if that is sometimes annoying, but it's the best we can do I'm afraid. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357#issuecomment-524337469 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/dd36e12d/attachment.html> From notifications at github.com Fri Aug 23 14:30:27 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 23 Aug 2019 07:30:27 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2357@github.com> References: <openstreetmap/openstreetmap-website/issues/2357@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2357/issue_event/2579890766@github.com> Closed #2357. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357#event-2579890766 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/a0a78ec2/attachment.html> From notifications at github.com Sat Aug 24 01:51:36 2019 From: notifications at github.com (Brian DeRocher) Date: Fri, 23 Aug 2019 18:51:36 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) Message-ID: <openstreetmap/openstreetmap-website/pull/2358@github.com> If your database already has this user you'll need to promote the user to superuser. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2358 -- Commit Summary -- * promote yourself to superuser -- File Changes -- M INSTALL.md (11) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2358.patch https://github.com/openstreetmap/openstreetmap-website/pull/2358.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/686f7bfd/attachment.html> From notifications at github.com Sat Aug 24 06:37:09 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 23 Aug 2019 23:37:09 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/issue_event/2581266814@github.com> Closed #2358. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#event-2581266814 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/56e22ec6/attachment.html> From notifications at github.com Sat Aug 24 06:37:09 2019 From: notifications at github.com (Tom Hughes) Date: Fri, 23 Aug 2019 23:37:09 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524525724@github.com> No, deciding whether to promote your main development user to a database user is a personal decision that should be made with an understanding of the issues involved and not one we should encourage people to make unthinkingly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524525724 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190823/abfa93d7/attachment-0001.html> From notifications at github.com Sat Aug 24 16:34:55 2019 From: notifications at github.com (Frederik Ramm) Date: Sat, 24 Aug 2019 09:34:55 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524564125@github.com> Perhaps we should then at least write something like "note, some automated tests that try to execute CREATE EXTENSION commands on the database will fail when not run as a privileged database user"? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524564125 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190824/ad7c5f39/attachment.html> From notifications at github.com Sat Aug 24 16:36:03 2019 From: notifications at github.com (Tom Hughes) Date: Sat, 24 Aug 2019 09:36:03 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524564209@github.com> Well we need to quantify the actual problem before we can formulate a solution - in other words under what circumstances in the permission required. There probably aren't any good solutions sadly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524564209 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190824/dde83044/attachment.html> From notifications at github.com Sun Aug 25 08:00:35 2019 From: notifications at github.com (Will White) Date: Sun, 25 Aug 2019 01:00:35 -0700 Subject: [openstreetmap/openstreetmap-website] No search button visible on mobile site (#1271) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1271@github.com> References: <openstreetmap/openstreetmap-website/issues/1271@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1271/524609864@github.com> I think search should have at least the same visibility as say, sharing the map. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1271#issuecomment-524609864 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/645d1736/attachment.html> From notifications at github.com Sun Aug 25 11:29:11 2019 From: notifications at github.com (=?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?=) Date: Sun, 25 Aug 2019 04:29:11 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2357@github.com> References: <openstreetmap/openstreetmap-website/issues/2357@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2357/524622516@github.com> Actually one would think a workaround would be just a select a different layer . However different layers , other than the standard layer, don't have those features in the first place. Example: https://www.openstreetmap.org/#map=9/24.2932/121.1177 Anyway, sometimes one really does want to find out what is causing a certain item to appear at lower Zoom values, but there's no way to find out. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357#issuecomment-524622516 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/fea12895/attachment.html> From notifications at github.com Sun Aug 25 15:43:45 2019 From: notifications at github.com (Brian DeRocher) Date: Sun, 25 Aug 2019 08:43:45 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524640102@github.com> Before I take a second stab at this can you tell me what you mean by "your current user". For me that's brian at localhost on a debian system. The problem was when I ran automated tests, they failed with the CREATE EXTENSION command. Perhaps the issue is with these words "your current user". Instead it should be "a newly created user that will own the openstreetmap database". Thoughts? Side note, you don't need superuser "so that we can create more databases". That can be granted to a user. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524640102 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/d8ba883d/attachment.html> From notifications at github.com Sun Aug 25 15:46:43 2019 From: notifications at github.com (Tom Hughes) Date: Sun, 25 Aug 2019 08:46:43 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524640344@github.com> Well the general point is that you shouldn't be throwing around postgres superuser privileges without understanding what you are doing. Ideally there would be a single step that you could execute as the postgres user but as I say I'm not sure if that's actually possible. It may be that we should recommend an initial run of `rake test:db` as a database superuser to populate the test database but as I say it needs some research to see if that is good enough or under what circumstances rails may try and recreate the test database from scratch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524640344 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/ccfad700/attachment.html> From notifications at github.com Sun Aug 25 16:35:46 2019 From: notifications at github.com (Brian DeRocher) Date: Sun, 25 Aug 2019 09:35:46 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524644074@github.com> I found a way around this issue. It's to use a template database. PG 9.5 add the IS_TEMPLATE option to CREATE DATABASE. If true, anyone with CREATEDB privilege can clone it. If the template has the btree_gist extension, the new database will also have it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524644074 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/23958cd3/attachment.html> From notifications at github.com Sun Aug 25 16:51:48 2019 From: notifications at github.com (Brian DeRocher) Date: Sun, 25 Aug 2019 09:51:48 -0700 Subject: [openstreetmap/openstreetmap-website] promote yourself to superuser (#2358) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2358@github.com> References: <openstreetmap/openstreetmap-website/pull/2358@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2358/c524645290@github.com> I've done just a little research and found that rails does have some support for this. See activerecord-5.2.3/lib/active_record/connection_adapters/postgresql/schema_statements.rb, line 30. Though I'm not sure how easy this is to use. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2358#issuecomment-524645290 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/dd227055/attachment.html> From notifications at github.com Sun Aug 25 16:58:35 2019 From: notifications at github.com (Brian DeRocher) Date: Sun, 25 Aug 2019 09:58:35 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installations are unmaintained (#2344) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2344@github.com> References: <openstreetmap/openstreetmap-website/issues/2344@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2344/524645738@github.com> I'd prefer to develop in a docker environment. I can work on creating a new Dockerfile. Do you have any requirements? My plan is to create 2 images, one for db and one for rails. For me this may have to wait until after SotM US. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomment-524645738 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/e9922e2e/attachment-0001.html> From notifications at github.com Sun Aug 25 17:32:17 2019 From: notifications at github.com (Holger Jeromin) Date: Sun, 25 Aug 2019 10:32:17 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2357@github.com> References: <openstreetmap/openstreetmap-website/issues/2357@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2357/524648160@github.com> > Anyway, sometimes one really does want to find out what is causing a certain item to appear at lower Zoom values, but there's no way to find out. This is a problem, but that could be a large osm landuse which is nowhere near the label point you want to analyse. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357#issuecomment-524648160 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190825/a4295745/attachment.html> From notifications at github.com Mon Aug 26 09:22:13 2019 From: notifications at github.com (mmd) Date: Mon, 26 Aug 2019 02:22:13 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installations are unmaintained (#2344) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2344@github.com> References: <openstreetmap/openstreetmap-website/issues/2344@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2344/524788726@github.com> @openbrian : see https://github.com/openstreetmap/openstreetmap-website/pull/2272 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomment-524788726 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/0eb83307/attachment.html> From notifications at github.com Mon Aug 26 09:26:21 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 26 Aug 2019 02:26:21 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installations are unmaintained (#2344) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2344@github.com> References: <openstreetmap/openstreetmap-website/issues/2344@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2344/524790024@github.com> Yes this ticket is probably a bit confusing because I opened it thinking we already had a docker config but apparently my memory was faulty... Though it's definitely true that it would be good to have it tested to stop it breaking. That's something that I think travis can do, unlike vagrant. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomment-524790024 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/08eba276/attachment.html> From notifications at github.com Mon Aug 26 10:32:55 2019 From: notifications at github.com (Richard Fairhurst) Date: Mon, 26 Aug 2019 03:32:55 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2356/524810039@github.com> The intention (certainly from my POV when I did the initial coding on the directions feature) was ultimately for the JS client to call the geocoding sources directly, rather than having geocoder_controller.rb call and agglomerate them. This would then enable refactoring so that the directions could use the same code as the standard placename search. It'd be a good project for a JS developer to work on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#issuecomment-524810039 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/2769cf63/attachment.html> From notifications at github.com Mon Aug 26 10:34:48 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 26 Aug 2019 03:34:48 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2356/524810543@github.com> I was looking to move the geocoding search to the client side but @gravitystorm was against it I think. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#issuecomment-524810543 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/80d210bf/attachment.html> From notifications at github.com Mon Aug 26 12:40:09 2019 From: notifications at github.com (=?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?=) Date: Mon, 26 Aug 2019 05:40:09 -0700 Subject: [openstreetmap/openstreetmap-website] "Zoom in to query features" -- that disappear when one zooms in! (#2357) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2357@github.com> References: <openstreetmap/openstreetmap-website/issues/2357@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2357/524844187@github.com> OK. https://help.openstreetmap.org/questions/70512/how-to-query-features-without-zooming has some workarounds. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2357#issuecomment-524844187 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/05d47298/attachment.html> From notifications at github.com Mon Aug 26 18:19:23 2019 From: notifications at github.com (Bryan Housel) Date: Mon, 26 Aug 2019 11:19:23 -0700 Subject: [openstreetmap/openstreetmap-website] Update to iD v2.15.5 (#2359) Message-ID: <openstreetmap/openstreetmap-website/pull/2359@github.com> # 2.15.5 ##### 2019-Aug-26 #### :boom: Breaking Changes * Remove support for Node 6 (Node 8 or higher is now required) * :warning: If you are building the iD project, you will need to upgrade your node version. #### :sparkles: Usability * Make the UI more navigable by tabbing ([#6701], thanks [@Abbe98]) * Render Sidewalks in a different color than Foot Paths ([#6522]) * List the user's language and common nearby languages first in the Multilingual Name language list ([#6712]) * Add more language options to the Multilingual Name list * Enable searching fields by tag and keyword ([#5763]) * Accept relation IDs in the "Choose a parent relation" dropdown ([#3487]) * Highlight relations in the map when hovering over them in the "Choose a parent relation" dropdown ([#2946]) * Show addable presets specified by the `presets` URL parameter in the default preset list ([#6703]) * Interpret the `º` and `˚` characters as degrees when searching coordinates * Make the post-upload changeset number clickable ([#6644]) * Allow selecting and copying tags from Custom Map Data ([#6710]) * Select points after dragging them ([#5747]) [#2946]: https://github.com/openstreetmap/iD/issues/2946 [#3487]: https://github.com/openstreetmap/iD/issues/3487 [#5747]: https://github.com/openstreetmap/iD/issues/5747 [#5763]: https://github.com/openstreetmap/iD/issues/5763 [#6522]: https://github.com/openstreetmap/iD/issues/6522 [#6644]: https://github.com/openstreetmap/iD/issues/6644 [#6701]: https://github.com/openstreetmap/iD/issues/6701 [#6703]: https://github.com/openstreetmap/iD/issues/6703 [#6710]: https://github.com/openstreetmap/iD/issues/6710 [#6712]: https://github.com/openstreetmap/iD/issues/6712 [@Abbe98]: https://github.com/Abbe98 #### :white_check_mark: Validation * Don't flag known brands for having generic names ([#6761], [#6754], thanks [@SilentSpike]) * Clarify that connecting a waterway crossing a highway will add a ford ([#6734]) * Lock the Name field of features with a `name:etymology:wikidata` tag ([#6683]) * Don't offer to add `highway=service` to demolished roads with `service` tags ([#6775]) * Upgrade `crossing=island` to `crossing:island=yes` ([#6748]) * Upgrade `diaper` to `changing_table` ([#6529]) * Upgrade `access=public` to `access=yes` ([#6716]) * Deprecate `tower:type=anchor` and `tower:type=suspension` ([#6762]) * Deprecate `landuse=garden` ([#6758]) * Deprecate `roof:shape=half_hipped` ([#6704]) [#6529]: https://github.com/openstreetmap/iD/issues/6529 [#6683]: https://github.com/openstreetmap/iD/issues/6683 [#6704]: https://github.com/openstreetmap/iD/issues/6704 [#6716]: https://github.com/openstreetmap/iD/issues/6716 [#6734]: https://github.com/openstreetmap/iD/issues/6734 [#6748]: https://github.com/openstreetmap/iD/issues/6748 [#6754]: https://github.com/openstreetmap/iD/issues/6754 [#6758]: https://github.com/openstreetmap/iD/issues/6758 [#6761]: https://github.com/openstreetmap/iD/issues/6761 [#6762]: https://github.com/openstreetmap/iD/issues/6762 [#6775]: https://github.com/openstreetmap/iD/issues/6775 [@SilentSpike]: https://github.com/SilentSpike #### :bug: Bugfixes * Boost preset matching score if match occurs in addTags ([#6802]) * Fix error upon changing the Unsquare Building threshold ([#6690]) * Don't hide all multilingual names upon deleting one ([#6491]) * Correctly populate the Bike Lanes field with existing values ([#6141]) * Show the correct location for coordinates in the `N DD° MM.MMM' W DD° MM.MMM'` format without a commma separator ([#6582]) * Don't treat platforms with a `kerb` tag as primarily curbs ([#6742]) * Remove deleted features from the map immediately when undoing or redoing ([#6480]) * Properly resize Mapillary and Bing Streetside photos when resizing the viewer ([#6286]) * Fix issue where the Background Offset field could not be focused ([#6698]) [#6141]: https://github.com/openstreetmap/iD/issues/6141 [#6286]: https://github.com/openstreetmap/iD/issues/6286 [#6480]: https://github.com/openstreetmap/iD/issues/6480 [#6491]: https://github.com/openstreetmap/iD/issues/6491 [#6582]: https://github.com/openstreetmap/iD/issues/6582 [#6690]: https://github.com/openstreetmap/iD/issues/6690 [#6698]: https://github.com/openstreetmap/iD/issues/6698 [#6742]: https://github.com/openstreetmap/iD/issues/6742 [#6802]: https://github.com/openstreetmap/iD/issues/6802 #### :earth_asia: Localization * Display the languages for the Multilingual Name field in the user's language, if available ([#2457], [#6702]) * Translate language names in the post-upload community list ([#4990]) [#2457]: https://github.com/openstreetmap/iD/issues/2457 [#4990]: https://github.com/openstreetmap/iD/issues/4990 [#6702]: https://github.com/openstreetmap/iD/issues/6702 #### :rocket: Presets * Add Rental Shop preset * Remove standalone Tactile Paving preset ([#6490], [#6791]) * Add Bottle Return Machine preset ([#6725], thanks [@ENT8R]) * Add Letter Box preset with Delivery Address field ([#6718]) * Add Post Sorting Office preset ([#6773]) * Add E-Waste Container preset ([#6777]) * Add Obelisk preset ([#6790]) * Add Flowerbed and Green Waste Container presets * Add Line Attachment field to Power Pole and Power Tower ([#6762]) * Add Species Wikidata field to Animal Enclosure and Tree ([#6652]) * Add Fee Amount an Toll Amount fields ([#6722]) * Add Stroller Access field ([#6739]) * Add Refuge Island field to crossings ([#6748]) * Add Incorrect Names field for common naming mistakes ([#6411]) * Update icons for Power Pole, Power Tower, and Power Line ([#6786]) * Update icon for cycle paths, crossings, and tracks * Only allow `power=transformer` on nodes ([#6779]) [#6411]: https://github.com/openstreetmap/iD/issues/6411 [#6490]: https://github.com/openstreetmap/iD/issues/6490 [#6652]: https://github.com/openstreetmap/iD/issues/6652 [#6718]: https://github.com/openstreetmap/iD/issues/6718 [#6722]: https://github.com/openstreetmap/iD/issues/6722 [#6725]: https://github.com/openstreetmap/iD/issues/6725 [#6739]: https://github.com/openstreetmap/iD/issues/6739 [#6748]: https://github.com/openstreetmap/iD/issues/6748 [#6762]: https://github.com/openstreetmap/iD/issues/6762 [#6773]: https://github.com/openstreetmap/iD/issues/6773 [#6777]: https://github.com/openstreetmap/iD/issues/6777 [#6779]: https://github.com/openstreetmap/iD/issues/6779 [#6786]: https://github.com/openstreetmap/iD/issues/6786 [#6790]: https://github.com/openstreetmap/iD/issues/6790 [#6791]: https://github.com/openstreetmap/iD/issues/6791 [@ENT8R]: https://github.com/ENT8R You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2359 -- Commit Summary -- * Update to iD v2.15.5 -- File Changes -- M vendor/assets/iD/iD.css.erb (31) M vendor/assets/iD/iD.js (1332) M vendor/assets/iD/iD/img/fa-sprite.svg (2) M vendor/assets/iD/iD/img/temaki-sprite.svg (2) M vendor/assets/iD/iD/locales/ar.json (25) M vendor/assets/iD/iD/locales/ast.json (6) M vendor/assets/iD/iD/locales/be.json (22) M vendor/assets/iD/iD/locales/bg.json (3) M vendor/assets/iD/iD/locales/bn.json (3) M vendor/assets/iD/iD/locales/bs.json (4) M vendor/assets/iD/iD/locales/ca.json (7) M vendor/assets/iD/iD/locales/ckb.json (170) M vendor/assets/iD/iD/locales/cs.json (19) M vendor/assets/iD/iD/locales/da.json (25) M vendor/assets/iD/iD/locales/de.json (506) M vendor/assets/iD/iD/locales/el.json (41) M vendor/assets/iD/iD/locales/en-AU.json (3) M vendor/assets/iD/iD/locales/en-GB.json (6) M vendor/assets/iD/iD/locales/en.json (1089) M vendor/assets/iD/iD/locales/eo.json (52) M vendor/assets/iD/iD/locales/es.json (488) M vendor/assets/iD/iD/locales/et.json (8) M vendor/assets/iD/iD/locales/eu.json (3) M vendor/assets/iD/iD/locales/fa.json (32) M vendor/assets/iD/iD/locales/fi.json (314) M vendor/assets/iD/iD/locales/fr.json (94) M vendor/assets/iD/iD/locales/gl.json (18) M vendor/assets/iD/iD/locales/he.json (137) M vendor/assets/iD/iD/locales/hr.json (60) M vendor/assets/iD/iD/locales/hu.json (1521) M vendor/assets/iD/iD/locales/id.json (3) M vendor/assets/iD/iD/locales/is.json (6) M vendor/assets/iD/iD/locales/it.json (128) M vendor/assets/iD/iD/locales/ja.json (476) M vendor/assets/iD/iD/locales/ko.json (14) M vendor/assets/iD/iD/locales/lt.json (7) M vendor/assets/iD/iD/locales/lv.json (7) A vendor/assets/iD/iD/locales/mi.json (35) M vendor/assets/iD/iD/locales/mk.json (447) M vendor/assets/iD/iD/locales/ms.json (6) M vendor/assets/iD/iD/locales/nl.json (15) M vendor/assets/iD/iD/locales/nn.json (593) M vendor/assets/iD/iD/locales/no.json (3) M vendor/assets/iD/iD/locales/pl.json (648) M vendor/assets/iD/iD/locales/pt-BR.json (163) M vendor/assets/iD/iD/locales/pt.json (22) M vendor/assets/iD/iD/locales/ro.json (3) M vendor/assets/iD/iD/locales/ru.json (177) M vendor/assets/iD/iD/locales/sk.json (7) M vendor/assets/iD/iD/locales/sl.json (7) M vendor/assets/iD/iD/locales/sr.json (6) M vendor/assets/iD/iD/locales/sv.json (492) M vendor/assets/iD/iD/locales/ta.json (3) M vendor/assets/iD/iD/locales/tr.json (7) M vendor/assets/iD/iD/locales/uk.json (162) M vendor/assets/iD/iD/locales/vi.json (13) M vendor/assets/iD/iD/locales/yue.json (7) M vendor/assets/iD/iD/locales/zh-CN.json (107) M vendor/assets/iD/iD/locales/zh-HK.json (7) M vendor/assets/iD/iD/locales/zh-TW.json (191) M vendor/assets/iD/iD/locales/zh.json (11) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2359.patch https://github.com/openstreetmap/openstreetmap-website/pull/2359.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2359 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/d0ed8796/attachment-0001.html> From notifications at github.com Mon Aug 26 22:57:08 2019 From: notifications at github.com (Eliot Blennerhassett) Date: Mon, 26 Aug 2019 15:57:08 -0700 Subject: [openstreetmap/openstreetmap-website] Search or Directions doesn't prioritise nearby locations (#2356) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2356@github.com> References: <openstreetmap/openstreetmap-website/issues/2356@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2356/525064805@github.com> Any chance of opening this issue again. Change title to "Directions doesn't allow choosing from search results" or something. I think this is a web UI issue rather than Nominatim. I've opened a separate Nominatim issue about the actual search results. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2356#issuecomment-525064805 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/124f91e5/attachment.html> From notifications at github.com Tue Aug 27 02:19:26 2019 From: notifications at github.com (dependabot[bot]) Date: Mon, 26 Aug 2019 19:19:26 -0700 Subject: [openstreetmap/openstreetmap-website] Bump eslint-utils from 1.3.1 to 1.4.2 (#2360) Message-ID: <openstreetmap/openstreetmap-website/pull/2360@github.com> Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.2. <details> <summary>Commits</summary> - [`4e1bc07`](https://github.com/mysticatea/eslint-utils/commit/4e1bc077c2a6bb00538d66b69a63c24de3463bed) 1.4.2 - [`e4cb014`](https://github.com/mysticatea/eslint-utils/commit/e4cb01498df6096b66edb0c78965ee6f47d3ac77) 🐛 add null test - [`230a4e2`](https://github.com/mysticatea/eslint-utils/commit/230a4e2275cde169cbfbb95cd2e4de2152fae0a2) 1.4.1 - [`08158db`](https://github.com/mysticatea/eslint-utils/commit/08158db1c98fd71cf0f32ddefbc147e2620e724c) 🐛 fix getStaticValue security issue - [`587cca2`](https://github.com/mysticatea/eslint-utils/commit/587cca2f82c245f5fc4a8b9fb2cf6b35c0d02552) 🐛 fix getStringIfConstant to handle literals correctly - [`c119e83`](https://github.com/mysticatea/eslint-utils/commit/c119e832952c8c653bd4f21e39eb9f7ce48e5947) 🐛 fix getStaticValue to handle bigint correctly - [`531b16f`](https://github.com/mysticatea/eslint-utils/commit/531b16fa686b80a8cc450eb87525115233ce6064) 🔖 1.4.0 - [`276303d`](https://github.com/mysticatea/eslint-utils/commit/276303d826bf94b9e6d6cdf5697cb1feb54c89ca) ⚒ upgrade rollup - [`cb518c7`](https://github.com/mysticatea/eslint-utils/commit/cb518c70ee037722f802d808bbbe93da83f07fb3) 🐛 fix hasSideEffect false negative - [`aac472e`](https://github.com/mysticatea/eslint-utils/commit/aac472e815551688d23cc8fd88f9044dbf276804) 🐛 fix isParenthesized had false positive on ImportExpression (fixes [#1](https://github-redirect.dependabot.com/mysticatea/eslint-utils/issues/1)) - Additional commits viewable in [compare view](https://github.com/mysticatea/eslint-utils/compare/v1.3.1...v1.4.2) </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eslint-utils&package-manager=npm_and_yarn&previous-version=1.3.1&new-version=1.4.2)](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/openstreetmap/openstreetmap-website/network/alerts). </details> You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2360 -- Commit Summary -- * Bump eslint-utils from 1.3.1 to 1.4.2 -- File Changes -- M yarn.lock (14) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2360.patch https://github.com/openstreetmap/openstreetmap-website/pull/2360.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2360 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/196fe3c3/attachment.html> From notifications at github.com Tue Aug 27 05:02:39 2019 From: notifications at github.com (Noctis Lucis Sora (Qais)) Date: Mon, 26 Aug 2019 22:02:39 -0700 Subject: [openstreetmap/openstreetmap-website] [Feature Request] Progressive Web App Support (#2361) Message-ID: <openstreetmap/openstreetmap-website/issues/2361@github.com> Please Add PWA Support In OpenStreetMap Web Site -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2361 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/b35d6e9b/attachment.html> From notifications at github.com Tue Aug 27 06:07:21 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 26 Aug 2019 23:07:21 -0700 Subject: [openstreetmap/openstreetmap-website] Progressive Web App Support (#2361) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2361@github.com> References: <openstreetmap/openstreetmap-website/issues/2361@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2361/525152913@github.com> Well it might be more likely if you explained what "PWA support" is exactly... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2361#issuecomment-525152913 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/67d62aec/attachment.html> From notifications at github.com Tue Aug 27 06:07:41 2019 From: notifications at github.com (Tom Hughes) Date: Mon, 26 Aug 2019 23:07:41 -0700 Subject: [openstreetmap/openstreetmap-website] Bump eslint-utils from 1.3.1 to 1.4.2 (#2360) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2360@github.com> References: <openstreetmap/openstreetmap-website/pull/2360@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2360/issue_event/2585848834@github.com> Closed #2360. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2360#event-2585848834 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/dde3642e/attachment-0001.html> From notifications at github.com Tue Aug 27 06:07:43 2019 From: notifications at github.com (dependabot[bot]) Date: Mon, 26 Aug 2019 23:07:43 -0700 Subject: [openstreetmap/openstreetmap-website] Bump eslint-utils from 1.3.1 to 1.4.2 (#2360) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2360@github.com> References: <openstreetmap/openstreetmap-website/pull/2360@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2360/c525152997@github.com> OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2360#issuecomment-525152997 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190826/a067afea/attachment.html> From notifications at github.com Tue Aug 27 07:00:24 2019 From: notifications at github.com (Noctis Lucis Sora (Qais)) Date: Tue, 27 Aug 2019 00:00:24 -0700 Subject: [openstreetmap/openstreetmap-website] Progressive Web App Support (#2361) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2361@github.com> References: <openstreetmap/openstreetmap-website/issues/2361@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2361/525168012@github.com> Progressive web applications (PWAs) are a type of mobile app delivered through the web, built using common web technologies including HTML, CSS and JavaScript. They are intended to work on any platform that uses a standards-compliant browser. Functionality includes working offline, push notifications, and device hardware access, enabling creating user experiences similar to native applications on mobile devices. Since they are a type of webpage or website known as a web application, there is no requirement for developers or users to install the web apps via digital distribution systems like Apple App Store or Google Play. While web applications have been available for mobile devices for as long as mobile devices have existed, they generally lag behind native apps in terms of speed, features, and user adoption, especially on mobile devices. Among other features, the ability to work offline, previously only available to native apps, allows PWAs to perform much faster and to provide more features to help close the gap with native apps. PWAs do not require separate bundling or distribution. Publication of a progressive web app is as it would be for any other web page. PWAs work in any browser, but "app-like" features such as being independent of connectivity, install to home screen and push messaging depend on browser support. As of April 2018, those features are supported to varying degrees by the Microsoft Edge, Google Chrome, Mozilla Firefox and Apple Safari browsers, but more browsers may support the features needed in the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2361#issuecomment-525168012 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190827/5c5ccb6f/attachment.html> From notifications at github.com Tue Aug 27 07:28:28 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 27 Aug 2019 00:28:28 -0700 Subject: [openstreetmap/openstreetmap-website] Progressive Web App Support (#2361) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2361@github.com> References: <openstreetmap/openstreetmap-website/issues/2361@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2361/525176890@github.com> Right, but that's a pretty vague description - marketing hype for the most part. Is there some concrete change you are looking for? I mean taking the broad list of functionality there we have: * Works on any platform that uses a standards-compliant browser, which is already pretty much the case. * Works offline, which doesn't make much sense in the case of OpenStreetMap. * Push notifications, which are extremely contentious in any case, but we can certainly look at that if you have a concrete proposal for where they would be useful. * Device hardware access, which we do where it makes sense, like accessing device location on request, but again if you have concrete suggestions for changes we can consider them. I think in summary this ticket is too vague to be useful, but if you have concrete suggestions for specific changes then please do raise them. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2361#issuecomment-525176890 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190827/b4747a9f/attachment.html> From notifications at github.com Tue Aug 27 07:28:29 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 27 Aug 2019 00:28:29 -0700 Subject: [openstreetmap/openstreetmap-website] Progressive Web App Support (#2361) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2361@github.com> References: <openstreetmap/openstreetmap-website/issues/2361@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2361/issue_event/2586037578@github.com> Closed #2361. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2361#event-2586037578 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190827/198d6f45/attachment.html> From notifications at github.com Tue Aug 27 14:29:27 2019 From: notifications at github.com (Tom Hughes) Date: Tue, 27 Aug 2019 07:29:27 -0700 Subject: [openstreetmap/openstreetmap-website] Update to iD v2.15.5 (#2359) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2359@github.com> References: <openstreetmap/openstreetmap-website/pull/2359@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2359/issue_event/2587305554@github.com> Merged #2359 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2359#event-2587305554 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190827/c451e301/attachment.html> From notifications at github.com Wed Aug 28 09:06:39 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 02:06:39 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/push/3970879915@github.com> @gravitystorm pushed 4 commits. 821ec5b5a3f1d22e3c9aea1130a5515d12d08788 Back out changes to changeset_comments routes for now 6ddad60a3e2a5f59f0a1432c9a82244d037156f8 Add a latest_api_version and use it on the browse pages 9622f1609ee872c91515d681652f37eb20690491 Hardcode some links to the 0.6 api, for now 841c75429fb0cf31193542fe03a75a4c2665170a Rework some relations tests that rely on creating changesets -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353/files/f1d91c8aa910792fad84bde770076b87b4c4e609..841c75429fb0cf31193542fe03a75a4c2665170a -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/43efb8f2/attachment.html> From notifications at github.com Wed Aug 28 09:19:00 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 02:19:00 -0700 Subject: [openstreetmap/openstreetmap-website] [WIP] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/push/3970929703@github.com> @gravitystorm pushed 1 commit. b8c3944f2c8aa5340c83799180685a8d0175e47d Ignore block length in tests -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353/files/841c75429fb0cf31193542fe03a75a4c2665170a..b8c3944f2c8aa5340c83799180685a8d0175e47d -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/03cf564c/attachment.html> From notifications at github.com Wed Aug 28 09:29:10 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 02:29:10 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c525662489@github.com> I've updated this PR so that the test suite passes, and it's now ready for review. Currently only a few routes have been adapted for multiple API version support, namely: * capabilities * permissions * changesets I intend to work on the rest of the routes in subsequent PRs. The settings in this PR ensure that only 0.6 is deployed by default, so it can be merged without any side effects. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-525662489 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/869a1346/attachment.html> From notifications at github.com Wed Aug 28 09:33:31 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 02:33:31 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c525664048@github.com> > I think the only question that remains is the policy one of whether we want to do this. I think it should be merged. The evidence presented is convincing to me. It's also a reversible change - if worst comes to worst and there's a compelling reason later on to allow anonymous comments again, we can easily do that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-525664048 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/bfc6104b/attachment.html> From notifications at github.com Wed Aug 28 09:51:42 2019 From: notifications at github.com (Simon Poole) Date: Wed, 28 Aug 2019 02:51:42 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c525670609@github.com> Could we get it on the sandbox first? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-525670609 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/3c630975/attachment-0001.html> From notifications at github.com Wed Aug 28 10:03:00 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 03:03:00 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c525674875@github.com> > Could we get it on the sandbox first? First? Do you mean before code review? Or if you want it before merging, to what end? So far this PR is just internal code refactoring, there's no changes to the API (other than dropping one line from the api/0.7/capabilities response) and even if this is merged there will still be no changes since 0.7 is disabled. So we can ask Tom to set up a sandbox "first", but I'm not sure what you would want to do with it? Of course, it'll be worth having a sandbox available later on, but I don't think it's worthwhile effort at this stage. If you still have concerns, let me know what I can do to help. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-525674875 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/e8d0913a/attachment.html> From notifications at github.com Wed Aug 28 10:32:53 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 03:32:53 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/push/3971223671@github.com> @gravitystorm pushed 169 commits. 17e6e69c39072d8e6cb316b75b311e89c92cca45 Move generation of gpx_file XML from model to builder 363155a2a86796d27ee9161f1ee9b74d6fa307e5 Move xml gen. into view for (old) nodes, ways, relations, map 2142ff02c2442d28580ff99080bc1219c2bfe59f Allow moderators to hide diary entries and comments 26cbdcf71a68d5515c91bf9cb4ec958ce90c2647 Fix importing of GPX traces with a leading byte order marker 7f61fc22de8d46bfcdcce44edcfdc912d951070e Allow indexing of diary entries again 7a91da329dca7b7338384a4d738ae56d16812ab7 Allow indexing of diary entries again 42269d91fee778f28af4c8fb60bba5dcd6a886b3 Localisation updates from https://translatewiki.net. 7ee554ed64d67cee025e3a5c80ba9404b01b407f Update to iD v2.15.2 7fb85f1ca6417f4f0e20b8e33ed92d5d531897e9 Pass through `photo_overlay` parameter 657ed03d8b2e262bc965cc38e8af190624c3295b Update bundle 31edc7dff6f4305366d0f93d35ba3fb1956bb71f Merge remote-tracking branch 'upstream/pull/2226' 74af87d9d1006a5c664398de19da31ad9c29776c Add translations for distance_in_time_ago 1cf8fec58d2e32d431aaee51213d738241e39e66 Rename Friend model to Friendship 2169c503efbbeb45c3842e9fa5eef6cc01e8e27b Rename user.friend_users to user.friends d33b1f6b29651c7e8a021ab37f8659054df4881f Pass the models, not the ids, when dealing with friendships cbb3c2bdf0843ad1fb0095cb5c4cefd83eb5507a Use user models, not ids, in assertions 1298d80549e428d4907a474a176805a11c969714 Use the distance_in_words_ago scope for trace display df560bd71dea9c222fcb233a36a906c2e08ebe30 Use the distance_in_words_ago scope for diary comments pages 50d469a74a95a26645fc0f8dbe2ad71b0de24e29 Use distance_in_words_ago scope for issues display 47e653ffe021339ff19b767cfa0c87a508687781 Use scope for time_ago when viewing users 00f75c175e432e51c7c80eff02384dc35294d760 Use scope for common details and changeset display in browse pages 54e0c7afb2b380a869097a3df826bb860248bb47 Use distance_in_words_ago scope for user blocks f284d57c6236327b50c8d4a2ac0545105d1d03cc Add a friendly_date_ago helper cd5e28406b93439465ef43ad0413720a60398f15 Use friendy_date_ago helper for notes 5e068152143a27fbf34ed6c90773f46b59039c70 Use friendly_date_ago helper for user_blocks 3167e6b4bbbf01c2b69d9e67117a734ff0544b6a Use friendly_date_ago helper for chnagesets 75bf96c4f3472a21163032a25ff7700d3c692225 Use friendly_date_ago helper for changeset comments e5d8bd539f045db1870a4722290f75b11cf4d2e0 Use friendly_date_ago for user blocks 220ad927662dcc3e93a7cee337ddc385e19cd386 Use friendly_date_ago for notes display 23dfc4d3bde49ef907de08ee2efbece0d4ce261d Update note comments to use friendly_date_ago helper 6b6345ecdba2589df96489b259651adb4c764362 Merge remote-tracking branch 'upstream/pull/2269' 80427b3e5e5ebeecbc0a57a1549a2a33e0c92199 Merge remote-tracking branch 'upstream/pull/2270' 16cbc2eb798ed3de360574c874049225641b3d76 Merge remote-tracking branch 'upstream/pull/2267' 81d6d6a6a353e1ba8cc448f40fba17a03cf2620f Localisation updates from https://translatewiki.net. dd281a19c48f0324ac617f490275dcbd52a6dd60 Update Potlatch 2 to 2.5-83-g28c84372 build fc67e63589536b0d8fa3a92aa7eff57ebeceb3a6 Block indexing of diary entries d2d5d48f2993f2ffca415362a40b8a02127bd4a8 Allow signups to be blocked by MX host 4440730c9b1014d81688655f4c3fca92b5a3225c Localisation updates from https://translatewiki.net. 1817032c87bf960fedbd8136fb2a974e56af9c4c Update bundle 5b4636d5213de2e699769821031c37663ab71557 Fix text direction for traditional chinese 16c3c533022d90cbfafecd17349d09fcbb7abed9 Merge remote-tracking branch 'upstream/pull/2271' c24b0e93997bcd6bcad475d9ba0adfe86fa01ea6 Rework to ensure views are named after the controller method name 3914050fcc24c8727c485412a69b12292bbf213d Simplify partial rendering when the partial is named after the model 0211141c085da26cd26001ae4ba0e0446b6ddd4e Simplify render calls for changesets f280dcb2d798b3dfd4aad345a1ab7efa10d8bbe4 Merge remote-tracking branch 'upstream/pull/2278' f77d4dc4f71b15af58ee6e5b5d63c436482e7b19 Avoid stating the action to render when it just matches the current action 899fc66a62b036adcfd59f5da80c7fc6f30cd3a8 Merge remote-tracking branch 'upstream/pull/2279' cbea796ef412840af9a3ec2fd26bf08657fc4cd3 Merge remote-tracking branch 'upstream/pull/2207' 2398614349e3ff5605868fea82e013d2a9a16ef9 Add support for an unversioned 'versions' API call 0dbb33016f77eef7d150044f06fc7ce86cde4d59 Rename @edits variable to @changesets, for clarity fd61706e4cc2d6909d424a1d0b147fc688ebd005 Split some extremely long strings over multiple lines using squiggly heredocs 89f8f7af3539588c234496dd769f9042199bd248 Merge remote-tracking branch 'upstream/pull/2281' b25f10eb56b1b2864d3a9eeff535caea119e55cc Merge remote-tracking branch 'upstream/pull/2282' a66c34991acfff398fbc83c921dfce18a835ee26 Merge remote-tracking branch 'upstream/pull/2280' 45e7c9a32e08446fd087580d84b2e11eadc1683d Avoid using @variables in partials d0de9967b9bd21c8e7c03e060626c4486b149fb2 Simplify partial rendering cf3cf5216fa3697ad2e3c060fced6a7bbb16f4a4 Avoid unnecessary arrays c1c277186ef0c519bed5b07e1b67ab8681010f15 Localisation updates from https://translatewiki.net. b9ae40d9784725b75e5b52f55659c80326656d8f Remove non functioning changeset_cache, user_display_name_cache 8ad1ce97983a5d4fb86ccb8ee4cd640a76f95255 Refactoring 11cc4a5e601dd288d601e6e35a72d159062f18b5 Merge branch 'master' into patch/view_migration 4e3527f5197449da89a78ac502d02cea6dec9f33 Fix text direction for traditional chinese 2bfb976b8e42f6ab0e87c053e91b2bc88538dba6 Revert XML default for routes fb953006a1a8fe2949f376e167dda963dfd784bd Replace respond_to with render xml format 84faaaf7950e61b5f87019398aeda0ead8d41c2c Rubocop 78ecc76067e434856358e609fa883619d316ffc4 Update list of dependencies to install 390c7d762429539627734dbd6142746a2ad9ca18 Fix spellings from aggree to agree b75cf73a5480600b2d53cceec2a230122f61b8fa Merge remote-tracking branch 'upstream/pull/2293' 12cdc58688e372b69abaea98cdc0090716ff0d36 Update to iD v2.15.3 55844044128d1ca8350884877ec822bb251cdd7e Merge remote-tracking branch 'upstream/pull/2294' a0660c009c554b19c77297aa1afb38291485adef Localisation updates from https://translatewiki.net. ea2c790a42cbb4ed6582646b8f45af5050ba472c Fix text direction for traditional chinese 37966859da6fe8419f2d80d05d259cd2c751099d Revert "Block indexing of diary entries" ee8ed3c682699e78fa5952b1ad554a09db546638 Add missing space f9109b7a75f91c208a7b5f68cc64ba253a9041c5 Fix styling of email notifications in RTL languages e8e44dbb9f9ed0fbd058f017cf6b5d668282cd37 More tweaks for RTL email 9299f8ca23d7cd7a1cb2f080bf6bd440140d3637 Include bundler in packages to install on Ubuntu f39ea70083b8556c7bf6e9a4b682ebb2cab9eb01 Ubuntu 18.04 is now required. Add apt-get update f2ceda52963491156d94e45f430cc5b626c35b0c Localisation updates from https://translatewiki.net. d021bdf5cf57f6020279043ac276f96f5bf6352c Merge remote-tracking branch 'upstream/pull/2223' d7f92e163e332036b7af195e4d1d2030bdcde250 Update bundle 6f9b0c2f6b187a1787e195cd0d768c5fca1cd839 Fix rubocop warnings d0201f4487fbf4a81abfb9206a25c27b4be9dec6 Update wiki page data cec5e4999c1529d0716d83639ac4f23b0c84dd26 Localisation updates from https://translatewiki.net. ba627420a3e183fcee7ce38b2f68a0ff7663c647 Add support for Active Storage attachments 6c202448ade514cd5ecca7175555011c851735e9 Move user images to Active Storage with paperclip as a fallback 77026ee0398dfb5d049dbc0d3359b2c7b3d9309e Add support for using S3 as the object store 77ee8c1a53f4124e36012b01801ab801f36dd58d Monkey patch Active Storage to set content type when uploading to S3 75e60acf661e39f3ab01d486ed17616bab036f73 Allow configuration of storage server URL for security policy 8c1a5d62f8b2f5491f7d476cdcbd0d4121903079 Ignore the class length of test files 4111388674b1278d768ea2b251475f37c7eece05 Localisation updates from https://translatewiki.net. d63beb80805bec2155c961f15a4e45ef3bf7921d make link in documentation clickable 64f70a7cb0f13cf9adf552051dc2dd9db111fd46 Merge remote-tracking branch 'upstream/pull/2305' 27078aa7803c0e38a83805f80d3660608190084d Update eslint 807750023aa02896117a1d5d67a750eccd31d90b Fix eslint warning c4c0e8105a8edc35205add749f461ec7be689aef Enforce consistent indentation in javascript code 492a6405306092c39c26b4f6cc8b2e793ee22d43 Enable a few more eslint checks c162c065c6f6db5dc584599f5639b296b627a165 Merge remote-tracking branch 'upstream/pull/2296' 550fa0c8e46c9d4e09e30f7940bcb63f84f0ac41 It's to_sym not to_symbol cd4ac6ac2dfaea3f2c7419d8b6d5e0a9490e286a Revert accidental schema changes a47c0a4411825f48e447641094678b15df3b2f74 Update querystring references 6da536e5c8870cb30594a7397e074803080e2708 Add a rake task to move user avatars to Active Storage 11c4aa7d73f212d1dfba920e3853b9b6d6cbd197 Skip uploading images for users that have a new style avatar cc5688a6ded7913e1956326e2b40333e99962048 Localisation updates from https://translatewiki.net. 6dd451c7ee48663d6b0753bfe8b4da2060c4cf60 Stop creating a shared global querystring variable d2d3f2c9fdb76eb8193eaa079868504b8b9906c5 Fix rubocop warning 5cb96cd1a2964463dfcb6083da95badecccb7f98 Send trace import result notification immediately c5fc9f0e7e93088c599ae0d8540ee0117f277d6d Run any Active Storage jobs in the storage queue e3f37bb30cc77f0ffa1e8132f99ed59854641ca0 Allow BMP images to be transformed f5977808222bacf30ad56dfd7ccf764bcc46aa11 Increase expiry for Active Storage URLs 905a7eadb622761b3c752a113ca878faa316a37a Defer deletion of avatars to a background job cea0ba51377a1ac356a58df591092e7b28825f2d Merge remote-tracking branch 'upstream/pull/2313' b911b45961165d64fba577d4cb87740d89ec6784 Return absolute URLs for user images 3cfffc2258621558e1147ceaf63980a7f6ed414b Update gravatar methods to check for Active Storage images 91a37235ac748df7dc241b215790d6cbecd652f3 Remove support for old style user images 40ac2aa5280f46c0c8cf3676596334269ec2f696 Use the configured host name for user image URLs 0444187cb6eccee4f77596c1a575d32e6c96192d Update annotations after 91a37235ac748df7dc241b215790d6cbecd652f3 6ebb21b66020ba845abd9fda408bb204d326e0de Avoid using live models in old migrations d130db9fa84da832a6a0cb0333982725fdc480c7 Avoid more models in old migrations a254efb5ec6b30601aeb82cf6380ace02d71c4e8 Set server_url to test.host in test environments add6f9643b8c14ec29c607b8ca3adfa83ff8754c Rework help page text 43b0d4236300e65c5fa9f9c49f348e95f96bcc16 Merge remote-tracking branch 'upstream/pull/2322' 8750405bf7cc44ef53ea2387c5315925175de169 Merge remote-tracking branch 'upstream/pull/2320' 227c402ad10059ec35394f2a960a620e5cda73af Don't try and add fingerprints for user images 826b70fdc5f44ab2f6bde94b8ab67bf98ee43981 Replace migrations that rely on models with rake tasks 8a39c6b4a223160d47b293bc07d57d4e77685746 Drop old user image columns 5a54cb52f8b46283ddb6059e53f0d49886983ccf Drop paperclip bc37f1d8518bf1b4c892c53355c7b71e32ec1346 Localisation updates from https://translatewiki.net. 0af8b95b7d8b1c633bb3d021f099c90d65df69c6 Update bundle 1f880528bd834bd59465b51ea8eccfe9fbd1715a Fix new rubocop warnings 64b605a8208d267752c37227cceb8af93a1d67dd Localisation updates from https://translatewiki.net. 4ff60670339b7d9191d20876aaf54ac78a62f597 Fix text direction for Japanese 81f1e7982a4fd9904ef709ef2a4822ce5de031e4 Localisation updates from https://translatewiki.net. 61faea262a5b75ddca7035daa68239a1f0c54d05 Pass viewbox to Nominatim when geocoding routing endpoints 241f12df40a5c2c536cbd15177bd39e55d4fb75c Update to iD v2.15.4 cfb9d537a69df486f9fd4e7d5532a69c2990bf62 Remove file unrelated to iD 2.15.4 release 02e5a93dc529c491afafa76b281238463ac0afc5 Merge remote-tracking branch 'upstream/pull/2330' 9581fc24f8141fc50bcb450fc910d64faf98db73 Localisation updates from https://translatewiki.net. 1addc078c0809ef591057980a7ab6cdab9891e44 Avoid trying to resize non-resizable images 44839bee8b869e24292cd8705177d7597828e2ea Localisation updates from https://translatewiki.net. f32baeceb478a714c0490d90bffb3b411655b8d9 Localisation updates from https://translatewiki.net. 083375b3c33f6aae6d81b17f12318e80e5c992db Update polyfills bc883cb9269c12cd9ccad0707e498daa2863ae27 Patch broken polyfill feature test 754e566f454f8083e6baebdcc9eebc06e7cda333 Exclude phantomjs from generic webkit as it's ancient 4efe7cdc109013fa77d3e5356454d305a3726335 Fix vagrant provisioning script 2a9346adb0477e895dca1083c0f675f690dcdf75 Make sure phantomjs is installed dc5cdebc29927933a815a9c65cc8dd2116f87b31 Create config/settings.local.yml in Vagrant provisioning script 21a3a69d1006247abd27ea404559a964a8ddba84 Localisation updates from https://translatewiki.net. cdae792e36effd22d05bfd579c9822f27fb4c9a7 Localisation updates from https://translatewiki.net. 42345cb9b7ff32e477d69047a1b87dea6e649433 Include any current search terms in the page title 389fee0151d4b7f3b4a77e38143e6990a00d2362 Revert "Always look to the global scope for the GPX module" 18f5f1d499178bfbeaceb450a4a8e0a2863b3d96 Explicitly require gpx in the trace model tests dcea5c68838d89761ba8510e76acbcabbe1de61c Update bundle 4b646e17a8c8246d1638bcece5d59369d78424e1 Fix rubocop warnings 0264b865e36c6ed25cb48e833653461aab3e5a00 Update rubocop todo 34c9d9cc6b5008886218e9e6154cb84bc87aeba7 Increase poltergeist timeout 06957c3479a752c7f94ed33729c5030ed3de4033 Localisation updates from https://translatewiki.net. de973d08cacda5a78707c6c24c44d1efe1f1f798 Localisation updates from https://translatewiki.net. 135ec35a91bcca15637b6436dd7e546468c49690 Fix numericality validation to use correct integer only constraint a973ca794f3f54395bcc758b4316d09c5014ebab Localisation updates from https://translatewiki.net. 94033b3a088e3871f55fe6dad4e030b8af8b885a Localisation updates from https://translatewiki.net. 39896c76f8b4d4b80cca29980a54b4061f848d4a Update to iD v2.15.5 e1f2390d282a153422eaed2bcc12d43b9186bc97 Merge remote-tracking branch 'upstream/pull/2359' bfd4f4993a35e0ef73a33291aacc3096580fb463 Update yarn bundle d515e1b0e4b60c486cb1ed0b4e94607dfb365805 Update bundle 8d102e2dc5827ecc497ad51c4396ad92a83a8f47 Drop ancient imported daemon generator bf1b9a9b6038c9e906133e9a981cc91b9512237d Exclude all vendored code from rubocop checking 0cebec000081f8a779bcd244222af6162096d256 Merge branch 'patch/secscan' of https://github.com/mmd-osm/openstreetmap-website into mmd-osm-patch/secscan 2343ca8dde7b03d4db8c6d869ae6ba1adcc24a17 Ignore current Brakeman warnings -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229/files/759d1a1a5245854d524cd64056d8ef02de36975a..2343ca8dde7b03d4db8c6d869ae6ba1adcc24a17 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/f78b3354/attachment-0001.html> From notifications at github.com Wed Aug 28 10:43:05 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 03:43:05 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/push/3971260524@github.com> @gravitystorm pushed 1 commit. 4d5818abe493fba21eef320970ac3750b3b09895 Ignore current Brakeman warnings -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229/files/b18b490e81428f0a77b50e5151692fb09f6564ef..4d5818abe493fba21eef320970ac3750b3b09895 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/ec584c09/attachment.html> From notifications at github.com Wed Aug 28 10:55:57 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 03:55:57 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/c525692662@github.com> OK, lets stick with Brakeman. I've also figured out how to ignore the current issues using a config file, so I believe this is now ready to merge. (Sorry for the force-pushing, I was aiming to preserve the original commit while also resolving conflicts and adding the new config file to this existing PR.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229#issuecomment-525692662 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/206be056/attachment.html> From notifications at github.com Wed Aug 28 11:16:21 2019 From: notifications at github.com (Simon Poole) Date: Wed, 28 Aug 2019 04:16:21 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c525699136@github.com> > > > > Could we get it on the sandbox first? > > First? Do you mean before code review? Before deployment, which in our case implies before merger. > > Or if you want it before merging, to what end? So far this PR is just internal code refactoring, there's no changes to the API (other than dropping one line from the api/0.7/capabilities response) and even if this is merged there will still be no changes since 0.7 is disabled. Famous last words. In reality there are always things that might break, for example as when the authorisation refactoring was deployed. Being to test against a deployment, while not a panacea, at least gives us a fighting chance to ferret out any assumptions that no longer hold true and so on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-525699136 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/5874b349/attachment.html> From notifications at github.com Wed Aug 28 12:30:44 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 05:30:44 -0700 Subject: [openstreetmap/openstreetmap-website] Vagrant and Docker installations are unmaintained (#2344) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2344@github.com> References: <openstreetmap/openstreetmap-website/issues/2344@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2344/525723559@github.com> So I don't think we really need the vagrant/virtualbox bit tested, so much as the rest of the setup script i.e the contents of [/script/vagrant/setup/provision.sh](https://github.com/openstreetmap/openstreetmap-website/blob/master/script/vagrant/setup/provision.sh). Could that be tested on travis? Of course, both the travis config and the vagrant setup (and the Docker setup) cover a lot of the same ground - installing postgres, bundle install, etc. So if there's a way to refactor things to share some code, that would be great too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomment-525723559 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/7fddf188/attachment.html> From notifications at github.com Wed Aug 28 13:20:24 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 06:20:24 -0700 Subject: [openstreetmap/openstreetmap-website] Add user_<uid> class to diary entry div (#2266) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2266@github.com> References: <openstreetmap/openstreetmap-website/pull/2266@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2266/issue_event/2590508661@github.com> Merged #2266 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2266#event-2590508661 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/a8ca0cea/attachment.html> From notifications at github.com Wed Aug 28 13:24:14 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 06:24:14 -0700 Subject: [openstreetmap/openstreetmap-website] Add user_<uid> class to diary entry div (#2266) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2266@github.com> References: <openstreetmap/openstreetmap-website/pull/2266@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2266/c525743518@github.com> I've ummed and aahhhed about this for weeks, since I both object to it ([for the same reasons as @tomhughes](https://github.com/openstreetmap/openstreetmap-website/pull/2266#issuecomment-502678401)) and also support it since it's pretty trivial and [nobody's going to mind if we break it in future](https://github.com/openstreetmap/openstreetmap-website/pull/2266#issuecomment-502684786). But it's not worth me considering it for any longer. So it just comes down to having a slight bias for change. But if this gets stripped out again in a future refactoring, so be it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2266#issuecomment-525743518 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/031ba488/attachment.html> From notifications at github.com Wed Aug 28 13:38:02 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 06:38:02 -0700 Subject: [openstreetmap/openstreetmap-website] Update Austrian copyright statement (EN). (#1480) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1480@github.com> References: <openstreetmap/openstreetmap-website/pull/1480@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1480/c525749046@github.com> I've checked the status of this particular dataset, and it appears that the attribution is complete on the wiki page, and the waiver stored there states the wiki as sufficient. Given the wishes expressed in this PR to avoid expanding the list at /copyright, then I think it's best to leave this PR unmerged. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1480#issuecomment-525749046 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/566007e9/attachment.html> From notifications at github.com Wed Aug 28 13:38:04 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 06:38:04 -0700 Subject: [openstreetmap/openstreetmap-website] Update Austrian copyright statement (EN). (#1480) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1480@github.com> References: <openstreetmap/openstreetmap-website/pull/1480@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1480/issue_event/2590570773@github.com> Closed #1480. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1480#event-2590570773 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/23612abe/attachment-0001.html> From notifications at github.com Wed Aug 28 14:12:16 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 07:12:16 -0700 Subject: [openstreetmap/openstreetmap-website] Make the logo on the error pages clickable (#2362) Message-ID: <openstreetmap/openstreetmap-website/pull/2362@github.com> When reviewing #1550 I realised that the logo isn't clickable, whereas elsewhere on this site the logo in the top left links to the front page. It's a reasonable convention so one I that I feel is worth implementing. I've used the same srcset/picture code as in the main header. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/2362 -- Commit Summary -- * Make the logo on the error page clickable -- File Changes -- M app/views/layouts/error.html.erb (7) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/2362.patch https://github.com/openstreetmap/openstreetmap-website/pull/2362.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2362 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/0d22f549/attachment.html> From notifications at github.com Wed Aug 28 14:17:18 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 07:17:18 -0700 Subject: [openstreetmap/openstreetmap-website] Beautify 404 page (#1550) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1550@github.com> References: <openstreetmap/openstreetmap-website/pull/1550@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1550/issue_event/2590712311@github.com> Closed #1550. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1550#event-2590712311 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/cd74edb8/attachment.html> From notifications at github.com Wed Aug 28 14:17:17 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 07:17:17 -0700 Subject: [openstreetmap/openstreetmap-website] Beautify 404 page (#1550) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1550@github.com> References: <openstreetmap/openstreetmap-website/pull/1550@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1550/c525766131@github.com> I like in particular the idea that you should be able to click from the error page and get back to the home page. I've extracted this idea into [a separate PR](#2362), which just makes the logo clickable, rather than adding more words, and avoids hardcoding the URL. There's a few other things that I would suggest changing on this PR, in particular the ASCII smiley, which is unlikely to translate well into other languages, and the CSS too. However I think that would mean there's not much left here to work with. So I'm going to close this in favour of the other PR. Thanks for the proposals, in particular the concept of linking back to the home page, which I agree would be an improvement. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1550#issuecomment-525766131 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/a7878e4c/attachment.html> From notifications at github.com Wed Aug 28 14:19:20 2019 From: notifications at github.com (blackboxlogic) Date: Wed, 28 Aug 2019 07:19:20 -0700 Subject: [openstreetmap/openstreetmap-website] GET User's current ratelimit quota (#2363) Message-ID: <openstreetmap/openstreetmap-website/issues/2363@github.com> Just a nice to have... There is no way to know how much is left in your API rate-limit quota. There could be an endpoint /user/quota or every response from the API could have a quota header. Would be nice to know: - if the quota is by account or by IP - how much has been used - how much is remaining - rate that the quota regenerates -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2363 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/c7d6a3e7/attachment.html> From notifications at github.com Wed Aug 28 14:23:02 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 07:23:02 -0700 Subject: [openstreetmap/openstreetmap-website] Moving wiki to a more accessible position (#1397) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1397@github.com> References: <openstreetmap/openstreetmap-website/pull/1397@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1397/issue_event/2590733482@github.com> Closed #1397. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1397#event-2590733482 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/280ee9d8/attachment.html> From notifications at github.com Wed Aug 28 14:23:02 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 07:23:02 -0700 Subject: [openstreetmap/openstreetmap-website] Moving wiki to a more accessible position (#1397) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1397@github.com> References: <openstreetmap/openstreetmap-website/pull/1397@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1397/c525768634@github.com> Thanks for the suggestion to rearrange these links. However, I don't agree that it's "hidden", and I'm happy with the current order of the links. There's certainly room for more substantial changes to that page though! See e.g. #2321 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1397#issuecomment-525768634 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/6afed443/attachment-0001.html> From notifications at github.com Wed Aug 28 14:30:02 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 07:30:02 -0700 Subject: [openstreetmap/openstreetmap-website] GET User's current ratelimit quota (#2363) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2363@github.com> References: <openstreetmap/openstreetmap-website/issues/2363@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/2363/issue_event/2590759932@github.com> Closed #2363. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2363#event-2590759932 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/781867fe/attachment.html> From notifications at github.com Wed Aug 28 14:30:00 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 07:30:00 -0700 Subject: [openstreetmap/openstreetmap-website] GET User's current ratelimit quota (#2363) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2363@github.com> References: <openstreetmap/openstreetmap-website/issues/2363@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2363/525771893@github.com> With one exception there is no quota - that exception is the download of existing data. The quota is set at a level where nobody is expected to hit it in normal use, and we don't like to advertise the details too much because it will just encourage people to find ways to game it. It's nothing to do with this repository anyway - the quota is implemented in [cgimap](https://github.com/zerebubuth/openstreetmap-cgimap) and configured by our [chef](https://github.com/openstreetmap/chef/) recipes. The rails implementation of the API doesn't actually enforce any quotas at all. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2363#issuecomment-525771893 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/772360a8/attachment.html> From notifications at github.com Wed Aug 28 14:32:36 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 07:32:36 -0700 Subject: [openstreetmap/openstreetmap-website] GET User's current ratelimit quota (#2363) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2363@github.com> References: <openstreetmap/openstreetmap-website/issues/2363@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2363/525773040@github.com> Oh to answer one of your questions it is by account if you authenticate the request (which is optional when fetching map data) and by IP if you do not. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2363#issuecomment-525773040 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/89b69e47/attachment.html> From notifications at github.com Wed Aug 28 15:25:43 2019 From: notifications at github.com (Andy Allan) Date: Wed, 28 Aug 2019 08:25:43 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/c525796005@github.com> I've been reviewing this PR today, and despite my [unresolved objections](https://github.com/gravitystorm) I'm willing to go ahead and accept this PR. However, in the intervening time the PR has bit-rotted and now has conflicts, mainly due to the [split of browse_helper and browse_tags_helper](https://github.com/openstreetmap/openstreetmap-website/commit/74d2c4336bab2efe44c6bdadf688d26b18e320b3) last year. @stefanb if you're willing to rebase this onto a recent master, that would be helpful. If not, no worries, I can do that in a few weeks time. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779#issuecomment-525796005 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/db599906/attachment.html> From notifications at github.com Wed Aug 28 16:48:17 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 09:48:17 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/issue_event/2591230421@github.com> Merged #1926 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#event-2591230421 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/6b846260/attachment.html> From notifications at github.com Wed Aug 28 16:58:37 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 09:58:37 -0700 Subject: [openstreetmap/openstreetmap-website] Make the logo on the error pages clickable (#2362) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2362@github.com> References: <openstreetmap/openstreetmap-website/pull/2362@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2362/issue_event/2591262025@github.com> Merged #2362 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2362#event-2591262025 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/13a3cc40/attachment-0001.html> From notifications at github.com Wed Aug 28 17:02:21 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 10:02:21 -0700 Subject: [openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2229@github.com> References: <openstreetmap/openstreetmap-website/pull/2229@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2229/c525833803@github.com> Is there no better way of suppressing warnings than that monstrosity of a JSON file that lists each one in excruciating detail? I mean ideally we want to suppress whole classes of warning until we decide what we want to do about that rather than suppressing specific examples, which means that new code will still trigger complaints about things that we may well not be interested in fixing. In other words we want something more like the way rubocop works... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2229#issuecomment-525833803 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/6d3c89a3/attachment.html> From notifications at github.com Wed Aug 28 17:52:29 2019 From: notifications at github.com (Simon Poole) Date: Wed, 28 Aug 2019 10:52:29 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c525852878@github.com> And ..... what about announcing a significant behaviour change of the website? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-525852878 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/8195a074/attachment.html> From notifications at github.com Wed Aug 28 17:54:14 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 10:54:14 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c525853671@github.com> It's not live yet. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-525853671 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/41aae121/attachment.html> From notifications at github.com Wed Aug 28 18:04:38 2019 From: notifications at github.com (Tom Hughes) Date: Wed, 28 Aug 2019 11:04:38 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c525857752@github.com> That said we will obviously want to put it live soon so if people feel a communication strategy is necessary then now is the time to arrange it. I'm not sure how many of the people impacted such a strategy might reach though - in reality I doubt many people other than deliberate abusers are going to be impacted at all. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-525857752 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/840f63bb/attachment.html> From notifications at github.com Wed Aug 28 18:26:30 2019 From: notifications at github.com (Simon Poole) Date: Wed, 28 Aug 2019 11:26:30 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c525866228@github.com> I was more considering the "normal" OSM contributors as an audience for an announcement @harry-wood -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-525866228 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190828/49ea0dbb/attachment.html> From notifications at github.com Thu Aug 29 07:52:46 2019 From: notifications at github.com (Ilya Zverev) Date: Thu, 29 Aug 2019 00:52:46 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c526070371@github.com> Awesome, thank you Andy and Tom! I will announce the change to the Russian part of the community at least :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-526070371 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/3b20d39b/attachment.html> From notifications at github.com Thu Aug 29 18:24:32 2019 From: notifications at github.com (mmd) Date: Thu, 29 Aug 2019 11:24:32 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/526305108@github.com> (adding https://github.com/bryceco/GoMap/issues/113#issuecomment-384604159 as an example of an app creating 800 empty changesets in 3 minutes). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-526305108 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/14063370/attachment.html> From notifications at github.com Thu Aug 29 18:32:22 2019 From: notifications at github.com (Tobias Zwick) Date: Thu, 29 Aug 2019 11:32:22 -0700 Subject: [openstreetmap/openstreetmap-website] Hide header image on registration form on mobile (#2288) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2288@github.com> References: <openstreetmap/openstreetmap-website/issues/2288@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2288/526308034@github.com> I have a Sony Xperia Z1 Compact and it looks like this on my phone (Firefox) **Landscape** <img height="300px" src="https://user-images.githubusercontent.com/4661658/63966563-d42d7000-ca9b-11e9-8fb7-70028af206aa.png"/> **Portrait** <img width="300px" src="https://user-images.githubusercontent.com/4661658/63966570-d7c0f700-ca9b-11e9-96e4-7f9de8ab2552.png"/> -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2288#issuecomment-526308034 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/ee1b5064/attachment.html> From notifications at github.com Thu Aug 29 18:33:16 2019 From: notifications at github.com (Richlv) Date: Thu, 29 Aug 2019 11:33:16 -0700 Subject: [openstreetmap/openstreetmap-website] Limit number of edits per user and day (#2342) In-Reply-To: <openstreetmap/openstreetmap-website/issues/2342@github.com> References: <openstreetmap/openstreetmap-website/issues/2342@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/2342/526308373@github.com> @mmd-osm, thank you for the link. This emphasises the need to have the limits in the API - even if we could get all editors to implement internal limits (plenty hard), a simple bug (perhaps in the limiting code itself...) could still cause a changeset storm. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-526308373 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/5164d082/attachment.html> From notifications at github.com Thu Aug 29 20:24:28 2019 From: notifications at github.com (Grant) Date: Thu, 29 Aug 2019 13:24:28 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issue/1543/issue_event/2595234414@github.com> Closed #1543. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#event-2595234414 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/44b4c88a/attachment.html> From notifications at github.com Thu Aug 29 20:59:33 2019 From: notifications at github.com (blackboxlogic) Date: Thu, 29 Aug 2019 13:59:33 -0700 Subject: [openstreetmap/openstreetmap-website] Merge remote-tracking branch 'upstream/pull/1926' (783b5e3) In-Reply-To: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906@github.com> References: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906@github.com> Message-ID: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906/34888034@github.com> Was there a reason/discussion for requiring authentication when commenting on a note? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906#commitcomment-34888034 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/c3fcca26/attachment.html> From notifications at github.com Thu Aug 29 21:15:29 2019 From: notifications at github.com (mmd) Date: Thu, 29 Aug 2019 14:15:29 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c526364959@github.com> Should we add a small one liner explanation that "you need to log on to comment on this note"? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-526364959 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/bb187ebe/attachment-0001.html> From notifications at github.com Thu Aug 29 21:34:55 2019 From: notifications at github.com (Frederik Ramm) Date: Thu, 29 Aug 2019 14:34:55 -0700 Subject: [openstreetmap/openstreetmap-website] Merge remote-tracking branch 'upstream/pull/1926' (783b5e3) In-Reply-To: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906@github.com> References: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906@github.com> Message-ID: <openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906/34888385@github.com> Discussion in https://github.com/openstreetmap/openstreetmap-website/issues/1543 and https://github.com/openstreetmap/openstreetmap-website/pull/1926 - documentation update in https://wiki.openstreetmap.org/w/index.php?title=API_v0.6&type=revision&diff=1896312&oldid=1893630 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/commit/783b5e3729228908d7404ae7404af1023501a906#commitcomment-34888385 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/608954aa/attachment.html> From notifications at github.com Thu Aug 29 21:36:11 2019 From: notifications at github.com (Mateusz Konieczny) Date: Thu, 29 Aug 2019 14:36:11 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c526371782@github.com> With "log on" being a link? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-526371782 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/58b70873/attachment.html> From notifications at github.com Thu Aug 29 23:02:54 2019 From: notifications at github.com (Igmu) Date: Thu, 29 Aug 2019 16:02:54 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/526393006@github.com> First, the irony of having to login and discuss whether the bed to log in to make a comment. Imagining for anonymous participation: Political restriction to access current information. "Open" should be open to all and errors should be reduced by population of contributors. Save on storage? More contributors vs user info? Against anonymous without a Turing Test nor logging with credentials: Trolls. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-526393006 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190829/e1494540/attachment.html> From notifications at github.com Fri Aug 30 09:45:56 2019 From: notifications at github.com (mmd) Date: Fri, 30 Aug 2019 02:45:56 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526538362@github.com> > I'm not intending to implement many changes, just the ones that I've been personally complaining about since API 0.6 was released over a decade ago (like incorrect http status codes, and plain-text responses, and stuff like that). That's the bit I least like about the current multiple API version idea: it seems to focus on something I would describe as _cosmetic changes_ only. That's ok, except for it only adds work to consumers of the API while offering no real value to them at all. Since they already have a working API integration, they would need to spend extra development time and effort to get back to a status quo. Isn't there anything more compelling to do that would give API consumers more of an incentive to move to the latest and greatest version? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526538362 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/c7886c87/attachment.html> From notifications at github.com Fri Aug 30 09:50:40 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Fri, 30 Aug 2019 02:50:40 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/c526539947@github.com> @gravitystorm thanks for picking this up, I can check it once i restore my OSM dev environment on a rainy day :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779#issuecomment-526539947 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/7f312025/attachment.html> From notifications at github.com Fri Aug 30 10:05:45 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 03:05:45 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526544681@github.com> > adds work to consumers of the API *existing* consumers of the API. Some of these headaches and quirks need to be solved by every API consumer, and the total number of future API consumers yet to be written vastly exceeds the ones written so far. So the sooner we fix them, the better, and it's a shame they've been known about and unfixed for so long already. > Isn't there anything more compelling to do that would give API consumers more of an incentive to move to the latest and greatest version? Maybe we will want to put some of the more compelling things in v0.8, or v0.9, or something. But I'm determined to avoid getting into the same situation as has happened over, and over, and over again, where the scope of v0.7 expands inexorably until it collapses under its own weight! I'd rather break up the logjam and work on smaller, more frequent improvements (e.g. every 18-36 months, rather than 10+ years and counting) to the API. And I'd rather keep the API changes small so that a developer can upgrade their app with a small amount of code changes that's feasible in a weekend of hacking, rather than some significant API upgrade that puts them off doing any of it and leaves them stuck on v0.6. And making life easier for the developers is the whole point of adding multiple version support, so that they can upgrade when it suits them best. Anyway, let's talk about this further in a future issue, since we're burying the point of this PR ("is this the best code approach to multiple version support? Can you see a better way of coding the tests?") in wider discussions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526544681 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/fb71039b/attachment-0001.html> From notifications at github.com Fri Aug 30 10:33:36 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 03:33:36 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526552554@github.com> @gravitystorm you might want to consider making a statement as to versioning of the API (for example if it follow semver semantics going forward), or will we have to continue to assume that every version change is breaking as it is now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526552554 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/5b46d23a/attachment.html> From notifications at github.com Fri Aug 30 10:39:28 2019 From: notifications at github.com (mmd) Date: Fri, 30 Aug 2019 03:39:28 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281953476@github.com> mmd-osm commented on this pull request. > @@ -7,27 +7,54 @@ class CapabilitiesControllerTest < ActionController::TestCase def test_routes assert_routing( { :path => "/api/capabilities", :method => :get }, - { :controller => "api/capabilities", :action => "show" } + { :controller => "api/v06/capabilities", :action => "show", :api_version => "0.6" } Say we want to use semantic versioning like 1.2.0, how would this be reflected specifically in directory names like `v06`? > @@ -10,7 +10,7 @@ OSM = { MAX_REQUEST_AREA: <%= Settings.max_request_area.to_json %>, SERVER_PROTOCOL: <%= Settings.server_protocol.to_json %>, SERVER_URL: <%= Settings.server_url.to_json %>, - API_VERSION: <%= Settings.api_version.to_json %>, + API_VERSION: <%= Settings.api_versions.min_by(&:to_f).to_json %>, Why is this value set to "min_by", and what are the implications of it? Does `&:to_f` play nice with semver (e.g. 1.2.0)? > @@ -1,24 +1,58 @@ OpenStreetMap::Application.routes.draw do + # Our api versions are decimals, but controllers cannot start with a number + # or contain punctuation + def v_string(version) + "v#{version.delete('.')}" Thinking of semver again, would it be better to replace "." by "_" maybe, so it's `v0_7 ` and `v1_2 `? How about patch version number? Ignore or include? > - <member type='relation' role='some' ref='#{relation.id}'/> - </relation> - </create> - </osmChange> + all_api_versions.each do |api_version| + user = create(:user) + changeset = create(:changeset, :user => user) + node = create(:node) + way = create(:way_with_nodes, :nodes_count => 2) + relation = create(:relation) + + basic_authorization user.email, "test" + + # simple diff to create a node way and relation using placeholders + diff = <<CHANGESET.strip_heredoc + <osmChange> At one point we'd also need to include a version number in `<osmChange>` (maybe not now) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#pullrequestreview-281953476 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/a0928c07/attachment.html> From notifications at github.com Fri Aug 30 10:43:00 2019 From: notifications at github.com (mmd) Date: Fri, 30 Aug 2019 03:43:00 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526554989@github.com> > I'd rather break up the logjam and work on smaller, more frequent improvements (e.g. every 18-36 months, rather than 10+ years and counting) to the API. This brings up the topic how long you want to support previous API versions. Effectively, we need a Versioning Policy and a clear messaging to API consumers about EOL dates for each version well ahead of time. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526554989 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/e6948b3d/attachment.html> From notifications at github.com Fri Aug 30 10:56:07 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 03:56:07 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281964563@github.com> simonpoole commented on this pull request. > @@ -7,27 +7,54 @@ class CapabilitiesControllerTest < ActionController::TestCase def test_routes assert_routing( { :path => "/api/capabilities", :method => :get }, - { :controller => "api/capabilities", :action => "show" } + { :controller => "api/v06/capabilities", :action => "show", :api_version => "0.6" } @mmd-osm a reasonable assumption IMHO would be to only actually have different "directory" names for major versions (aka breaking changes), the client can then determine from the capabilities which minor version is actually supported and from that determine which backwards compatible features are present. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319461616 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/766aed5d/attachment.html> From notifications at github.com Fri Aug 30 11:05:19 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 04:05:19 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526560669@github.com> > every version change is breaking as it is now That will always be the case. If it's not breaking, then there's no need to change the API version in the first place. I'm sure you're aware that the current abilities of API 0.6 are quite expanded from the initial version back in 2009, but so far it's had to be backwards compatible to avoid breaking clients (with some minor exceptions, like the swf endpoint). Because we've only (been able to|chosen to) deploy backwards-compatible changes, we haven't incremented the version number. https://stackoverflow.com/questions/27901549/semantic-versioning-of-rest-apis explains it clearly - if we moved to semantic versioning, then only the major number is of interest to API consumers. So that's what we'd use in the URLs. If we wanted to move to semantic versioning for the next version of the API, then I would suggest calling it "API v7". We'd never need to have an endpoint like `/api/v7.1.0/node/1` since, by the definition of semantic versioning, any call to that would be backwards-compatible with any other API 7.x endpoint. If it wasn't compatible, we'd be on API v8, not v7.1. I'd be happy to move to using integers instead of what we have now, but I suggest we park this for the release-after-next. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526560669 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/2d8c7a85/attachment.html> From notifications at github.com Fri Aug 30 11:08:24 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 04:08:24 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281969386@github.com> gravitystorm commented on this pull request. > @@ -10,7 +10,7 @@ OSM = { MAX_REQUEST_AREA: <%= Settings.max_request_area.to_json %>, SERVER_PROTOCOL: <%= Settings.server_protocol.to_json %>, SERVER_URL: <%= Settings.server_url.to_json %>, - API_VERSION: <%= Settings.api_version.to_json %>, + API_VERSION: <%= Settings.api_versions.min_by(&:to_f).to_json %>, It's mainly just min_by to keep everything working for now, since it will pick 0.6 unless the site operator chooses to only deploy 0.7. It's used for the bits of the website that talk to the API, like notes and changeset comments. Since there's no changes yet, it's more of a "pick either" situation. On a wider point, I'd rather work on refactoring those bits of the site to just be regular webpages like diary entry comments, but that's a different project! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319465144 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/26c21d10/attachment.html> From notifications at github.com Fri Aug 30 11:09:19 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 04:09:19 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281969719@github.com> gravitystorm commented on this pull request. > @@ -1,24 +1,58 @@ OpenStreetMap::Application.routes.draw do + # Our api versions are decimals, but controllers cannot start with a number + # or contain punctuation + def v_string(version) + "v#{version.delete('.')}" As discussed in the comments, semver would only use major version numbers here. So e.g. `v7` or `v124`. But it's a great point to raise, thank you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319465393 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/fec20f6b/attachment.html> From notifications at github.com Fri Aug 30 11:10:10 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 04:10:10 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281970010@github.com> gravitystorm commented on this pull request. > - <member type='relation' role='some' ref='#{relation.id}'/> - </relation> - </create> - </osmChange> + all_api_versions.each do |api_version| + user = create(:user) + changeset = create(:changeset, :user => user) + node = create(:node) + way = create(:way_with_nodes, :nodes_count => 2) + relation = create(:relation) + + basic_authorization user.email, "test" + + # simple diff to create a node way and relation using placeholders + diff = <<CHANGESET.strip_heredoc + <osmChange> Yeah, I noticed that during the refactoring, but lets leave that for now since we're not planning any changes to the osmchange format (afaik). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319465644 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/00bc2590/attachment.html> From notifications at github.com Fri Aug 30 11:13:10 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 04:13:10 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526562660@github.com> @mmd-osm Thanks for looking at the code! That's really helpful and I appreciate it. If you have any suggestions or more feedback I'd love to hear it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526562660 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/a7323531/attachment-0001.html> From notifications at github.com Fri Aug 30 11:26:09 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 04:26:09 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526565899@github.com> > > > > every version change is breaking as it is now > > That will always be the case. If it's not breaking, then there's no need to change the API version in the first place. > > I'm sure you're aware that the current abilities of API 0.6 are quite expanded from the initial version back in 2009, but so far it's had to be backwards compatible to avoid breaking clients (with some minor exceptions, like the swf endpoint). Because we've only (been able to|chosen to) deploy backwards-compatible changes, we haven't incremented the version number. > > https://stackoverflow.com/questions/27901549/semantic-versioning-of-rest-apis explains it clearly - if we moved to semantic versioning, then only the major number is of interest to API consumers. So that's what we'd use in the URLs. If we wanted to move to semantic versioning for the next version of the API, then I would suggest calling it "API v7". > Neither the original semver definition nor the SO article say that. We agree that in the calls, only the major version needs to be used, but, because semver allows backwards compatible additions you still need some way of determining what version you -exactly- have in front of you to know if a specific minor version addition is present or not. In the case of the OSM API that is easily achieved by returning the actual semver (so if I want to use feature X any minor version higher than the one it was introduced in are OK). That we can't do that currently with 0.6 is the major issue with all the additions that have happened over the years. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526565899 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/9d83f084/attachment.html> From notifications at github.com Fri Aug 30 11:27:58 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 04:27:58 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281976751@github.com> simonpoole commented on this pull request. > - <member type='relation' role='some' ref='#{relation.id}'/> - </relation> - </create> - </osmChange> + all_api_versions.each do |api_version| + user = create(:user) + changeset = create(:changeset, :user => user) + node = create(:node) + way = create(:way_with_nodes, :nodes_count => 2) + relation = create(:relation) + + basic_authorization user.email, "test" + + # simple diff to create a node way and relation using placeholders + diff = <<CHANGESET.strip_heredoc + <osmChange> As I pointed out above, we return the data model version in all kinds of places, not just in OSC format. That needs to be decoupled from the API version. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319470752 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/fe3feb9c/attachment.html> From notifications at github.com Fri Aug 30 11:34:27 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 04:34:27 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/review/281979252@github.com> simonpoole commented on this pull request. This will change the data model version in sync with the API version. Which a) normally wouldn't be the case, b) will lead to all kind of breakage in the XML parsers. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#pullrequestreview-281979252 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/17728318/attachment.html> From notifications at github.com Fri Aug 30 12:56:26 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 05:56:26 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526591337@github.com> > you still need some way of determining what version you -exactly- have in front of you So let's take a feature like "notes" which was added in during the 0.6 era. I think your use-case is along the lines of "I'm an editor developer, and I want to know if notes are available on this endpoint, which might be osm.org or might be some other deployment that is running an older codebase that doesn't have notes yet, so that I can show/hide the relevant UI". If I've misunderstood let me know. You're suggesting that we should therefore introduce the minor API version in responses. I suspect you don't need to know the minor version in every response (e.g. `/api/X/ways/1` -> `<osm version="7.9" ...`), but you need a response from the server to let you know what the server is capable of doing. So maybe just in the `/api/X/capabilities` call? And then you can show/hide notes functionality depending on whether X.Y is greater than the version number where notes were introduced. But then, why bother with lists of features and their corresponding minor version numbers? That's a bit indirect, since we could just put the additional features into the `capabilities` response e.g. `<feature name="notes" />` to indicate that the endpoint now supports notes. Would that work? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526591337 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/f48dbd83/attachment.html> From notifications at github.com Fri Aug 30 12:56:59 2019 From: notifications at github.com (Andy Allan) Date: Fri, 30 Aug 2019 05:56:59 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526591537@github.com> > This will change the data model version in sync with the API version. Which a) normally wouldn't be the case, b) will lead to all kind of breakage in the XML parsers. I've read this a few times, but I don't understand what you mean. Could you give an example? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526591537 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/ce09a618/attachment-0001.html> From notifications at github.com Fri Aug 30 13:39:01 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 06:39:01 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526605238@github.com> Consider for example the output of https://api.openstreetmap.org/api/0.6/map?bbox=-122.083819,37.4217991,-122.0834335,37.4222209 Which starts with `<osm version="0.6" generator="CGImap 0.7.5 (14135 thorn-03.openstreetmap.org)" copyright="OpenStreetMap and contributors" attribution="http://www.openstreetmap.org/copyright" license="http://opendatacommons.org/licenses/odbl/1-0/"> <bounds minlat="37.4217991" minlon="-122.0838190" maxlat="37.4222209" maxlon="-122.0834335"/> ` Giving the version of the OSM XML document as 0.6, as this is the only indication of the format in use and OSM does not refer to any external schema docs, you will find that a lot of stuff will bork if you change that 0.6 to 0.7 or whatever. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526605238 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/7ff43493/attachment.html> From notifications at github.com Fri Aug 30 17:02:46 2019 From: notifications at github.com (mmd) Date: Fri, 30 Aug 2019 10:02:46 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526675818@github.com> I tend to agree that we have multiple lifecycles/versioning depending on what you look at. One the one hand, we add features over time to the API in an incremental/non breaking way by either extending existing endpoints or adding new ones. The downside of the current approach is that we have no mechanism to communicate those changes to the outside world. I think this would be a good ft for some semantic versioning, and now would be a good time to seriously think about it, rather than introducing some 0.7 version with some fuzzy requirements. Now, regarding the XML documents: everything that has been done in the recent years mostly left those unchanged. Some minor tweaks like adding an `if-unused` attribute in the OsmChange message happened on a message that isn't versioned anyway. For the OSM XML format, I think we never did any changes (?!), and any proposed changes (apart from introducing an area model) don't seem to force us to create a new version of the OSM XML format. Re. the future OSM JSON format (which will be using the Overpass API JSON format), I'm not sure what the best approach would be. Technically, it's still using the same OSM API 0.6 data model underneath, so we might just call that 0.6 as well? I think it would be good to establish an independent versioning for the different parts. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526675818 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/32c68218/attachment.html> From notifications at github.com Fri Aug 30 17:09:13 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 10:09:13 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526677721@github.com> @mmd-osm well the only data model change that is in a stage of serious consideration (changing way geometry representation), would require a complete switch over (as a backwards compatibility would be very very difficult to provide), so IMHO not worth considering in the context of this PR. With other words the version in the documents could just as well be hardwired to 0.6 for now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526677721 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/0c220acb/attachment.html> From notifications at github.com Fri Aug 30 17:09:54 2019 From: notifications at github.com (Bryan Housel) Date: Fri, 30 Aug 2019 10:09:54 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526677923@github.com> Probably worth mentioning that semantic versioning guidelines [explicitly allow a 0.x major version](https://semver.org/#spec-item-5) as a signal that anything can change at any time. > Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable. So we are, in a sense, already doing semver the way it's intended. If the OSM API ever gets to v1 then we need to start thinking more about backward compatibility and breakage. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526677923 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/b7af9b1b/attachment.html> From notifications at github.com Fri Aug 30 17:12:46 2019 From: notifications at github.com (Philippe Verdy) Date: Fri, 30 Aug 2019 10:12:46 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/526678838@github.com> classic bahesian spam detection can help: if the bahesian score is too low, discard it directly from anonymous users. If it's in a middle range (possibly frequent, but also in comments sent by logged in users), consider using a captcha to confirm it (and inform the user that he could avoid the captcha by creating an account and logging in). If the comment is long enough (giving details, or a non intrusive link e.g. to a photo site where users must be logged in, or to wellknown peer-reviewed data sources, consider adding it reasonnably so that these details can be reevaluated, or explaining a situation like local changes not currently visible in the aerial, or recent works/damages, or a press article) it can be kept (as long as the link itself is not in a banned spamming domain) Bahesian score filters work quite well for emails, why couldn't they be used for comments ? There are already good datasources for evaluating mail contents if we don't want to host out own local database for Bahesian evaluation (e.g. Wikimedia uses several parsers to autodetect and evaluate edits in articles, plus some whitelists and blacklists, and other sources like DNSBL providers) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-526678838 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/b5cecf1b/attachment-0001.html> From notifications at github.com Fri Aug 30 17:17:41 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 10:17:41 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526680346@github.com> At the time the 0.6 api was released semver was still two years away. Trying to retroactively apply senver semantics doesn't really work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526680346 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/034c9078/attachment.html> From notifications at github.com Fri Aug 30 17:18:55 2019 From: notifications at github.com (Bryan Housel) Date: Fri, 30 Aug 2019 10:18:55 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526680769@github.com> > trying to retroactively apply senver semantics doesn't really work. It's a number. it either works or it doesn't. (in this case, it does) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526680769 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/df5ff7aa/attachment.html> From notifications at github.com Fri Aug 30 17:25:15 2019 From: notifications at github.com (Philippe Verdy) Date: Fri, 30 Aug 2019 10:25:15 -0700 Subject: [openstreetmap/openstreetmap-website] Forbid anonymous comments for notes (#1543) In-Reply-To: <openstreetmap/openstreetmap-website/issues/1543@github.com> References: <openstreetmap/openstreetmap-website/issues/1543@github.com> Message-ID: <openstreetmap/openstreetmap-website/issues/1543/526682655@github.com> Another way would also be to limit the frequency of comments by "anon" IP (e.g. 1 per hour, then a captcha will be presented). If the IP is known to be in an open proxy, the threshold could be adjusted to 1 per 4 hours before the captcha is presented). Open proxies are not always bad, they are sometimes the only way to connect (from shared internet accesses in developing countries) and to help preserving users's privacy (or avoid local political/social/religious troubles for some mapped topics), or when people are traveling abroad and cannot use their regular ISP without excessive costs. There are also open wifi hotspots in hotels, restaurants, cafés, transportations, whose IP is always changing and reused by many unrelated users, sometimes from very different locations, and some mobile ISPs that never provide any stable IPv4 address but connect them with non routable temporary IPv4 that changes at each request, they are proxies by the ISP (not every mobile ISP provide IPv6 connectivity to allow unique and stable IPv6 instead of an unstable proxied IPv4). Let's not cut the route for the exploding number of mobile users. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1543#issuecomment-526682655 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/7e6768e8/attachment.html> From notifications at github.com Fri Aug 30 17:56:03 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 10:56:03 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526692533@github.com> > > > > trying to retroactively apply senver semantics doesn't really work. > > It's a number. it either works or it doesn't. (in this case, it does) You were implying to that the *number" gives us licence to break everything at will, not only is that not supported by the facts (as said the "number" predates the concept of semver), it relveals a very hostile attitude toward other developers, -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526692533 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/3bc4f45a/attachment.html> From notifications at github.com Fri Aug 30 18:19:05 2019 From: notifications at github.com (mmd) Date: Fri, 30 Aug 2019 11:19:05 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526699774@github.com> > You were implying to that the *number" gives us licence to break everything at will, It may be a red flag to other developers that things _may_ change, and we _could_ break things at our own discretion. In fact our Terms of Usage even support that approach. _IX Disclaimer_ says: > We may add, change, replace, remove, or discontinue the features and functions of the Services, including APIs. It is your responsibility to ensure that calls or requests you make to the Services are compatible with then-current APIs and authentication methods, and that you handle responses properly. Of course, we're trying to be nice, but we're in no way _obliged_ to do so. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526699774 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/f5104bc0/attachment.html> From notifications at github.com Fri Aug 30 20:29:39 2019 From: notifications at github.com (Simon Poole) Date: Fri, 30 Aug 2019 13:29:39 -0700 Subject: [openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353) In-Reply-To: <openstreetmap/openstreetmap-website/pull/2353@github.com> References: <openstreetmap/openstreetmap-website/pull/2353@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/2353/c526739148@github.com> @mmd-osm given that I'm one of the authors of that text, I can assure you that it simply is designed to limit the liability of the OSMF if we or somebody else screws up. It is completely orthogonal to any ethical, moral and professional obligation to behave reasonably. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/2353#issuecomment-526739148 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/18194033/attachment-0001.html> From notifications at github.com Sat Aug 31 08:37:57 2019 From: notifications at github.com (RicoElectrico) Date: Sat, 31 Aug 2019 01:37:57 -0700 Subject: [openstreetmap/openstreetmap-website] do not allow anonymous users to comment on notes (#1926) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1926@github.com> References: <openstreetmap/openstreetmap-website/pull/1926@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1926/c526812545@github.com> > Should we add a small one liner explanation that "you need to log on to comment on this note"? As well as "log in to receive notifications about note status" if creating a note. While we're at it, it'd be nice to link to the https://wiki.openstreetmap.org/wiki/Notes pages in the note creation view as well Something like: "Learn more about Notes". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1926#issuecomment-526812545 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/d11d6587/attachment.html> From notifications at github.com Sat Aug 31 09:45:49 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Sat, 31 Aug 2019 02:45:49 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/push/3983270114@github.com> @stefanb pushed 2 commits. e731dd71a77ad4ad1e9db22535e89444bb98e5d9 Merge branch 'master' into tag-colour-preview-rebase fe2bd1ee1a4e2cf7cf3cadf6a5314979f6414ba3 Colour preview moved into new browse_tags_helper -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779/files/26b47fdd188d126bef2e5829d5cc460bad530e2a..fe2bd1ee1a4e2cf7cf3cadf6a5314979f6414ba3 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/592e117d/attachment.html> From notifications at github.com Sat Aug 31 09:59:57 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Sat, 31 Aug 2019 02:59:57 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/push/3983285755@github.com> @stefanb pushed 1 commit. e968ad038a4b08960283735fcd191b937dde6d44 Fixed 2 new eslint errors -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779/files/fe2bd1ee1a4e2cf7cf3cadf6a5314979f6414ba3..e968ad038a4b08960283735fcd191b937dde6d44 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/d50a19a0/attachment.html> From notifications at github.com Sat Aug 31 10:10:44 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Sat, 31 Aug 2019 03:10:44 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/push/3983298013@github.com> @stefanb pushed 1 commit. c47bd173ff655bbcdb97c269b421d93b601c7b0a fixed some rubocop violations -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779/files/e968ad038a4b08960283735fcd191b937dde6d44..c47bd173ff655bbcdb97c269b421d93b601c7b0a -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/33c2af15/attachment.html> From notifications at github.com Sat Aug 31 11:27:38 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Sat, 31 Aug 2019 04:27:38 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/push/3983377594@github.com> @stefanb pushed 1 commit. 379401d76ccf9125240a030390d51983f9530f59 fixed line lengths -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779/files/c47bd173ff655bbcdb97c269b421d93b601c7b0a..379401d76ccf9125240a030390d51983f9530f59 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/df71f49f/attachment.html> From notifications at github.com Sat Aug 31 11:44:07 2019 From: notifications at github.com (=?UTF-8?B?xaB0ZWZhbiBCYWVibGVy?=) Date: Sat, 31 Aug 2019 04:44:07 -0700 Subject: [openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779) In-Reply-To: <openstreetmap/openstreetmap-website/pull/1779@github.com> References: <openstreetmap/openstreetmap-website/pull/1779@github.com> Message-ID: <openstreetmap/openstreetmap-website/pull/1779/c526823906@github.com> @gravitystorm, I have resolved the conflicts and fixed the code style problem that appeared wit more strict linting during the building process. Please review and test it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/1779#issuecomment-526823906 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190831/76efe427/attachment.html>