[openstreetmap/openstreetmap-website] Use parameters for various colours (#2459)

Andy Allan notifications at github.com
Wed Dec 11 15:53:50 UTC 2019


While working on some bootstrap-related stuff I noticed that we have multiple similar colours for off-white backgrounds, and then I noticed we have a lot of places where grey colours are hard-coded and either match or are slightly different from the grey colour parameters.

This PR refactors many of the explicit colours to use the colour parameters instead. Both off-whites have been unified and the lighter is now used. For the greens, I chickened out and kept the more vibrant ones separate from the standard ones, for now at least. Perhaps they can be unified with some colour functions like lighten. Also the greys have been combined into the three different greys from the palette, which cuts down on the number of different `1px solid X` variations.

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2459

-- Commit Summary --

  * Combine the two different offwhite background colours, and use the lighter one
  * Use paramatered colours for greys
  * Use a new colour name for the vibrant greens

-- File Changes --

    M app/assets/stylesheets/common.scss (125)
    M app/assets/stylesheets/parameters.scss (3)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2459.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2459.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2459
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191211/23cc29e1/attachment.html>


More information about the rails-dev mailing list