[openstreetmap/openstreetmap-website] RFC Use Bootstrap components for styling (#2452)

Tom Hughes notifications at github.com
Wed Dec 18 15:30:21 UTC 2019


tomhughes commented on this pull request.



> @@ -0,0 +1,44 @@
+/*!
+ * Bootstrap v4.3.1 (https://getbootstrap.com/)
+ * Copyright 2011-2019 The Bootstrap Authors
+ * Copyright 2011-2019 Twitter, Inc.
+ * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
+ */

If this is upstream code shouldn't it be in `vendor` instead of `app`? I guess in truth it's a kind of halfway house in that this is a template that you're expected to edit?

Is this expected to go away once we are able to just enable the whole thing?

> @@ -1,4 +1,5 @@
 @import "parameters";
+ at import "bootstrap-custom";

How does this find the other file when the file starts with an underscore? Is there some rule where the scss preprocessor searches for files with the underscore?

What's the logic behind preferring a CSS level `@import` over a sprockets level require? Then again we already seem to have a mix of both and I'm not sure how the split was decided...

> @@ -1,5 +1,5 @@
 /*
  *= require ltr/common
- *= require bootstrap
+ *= require bootstrap-tooltips

Presumably a fairly short term goal will be to replace the existing vendored tooltip and dropdown support with something based on the bootstrap gem instead? I assume you've tested that there isn't any issue with mixing the two in the short term...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2452#pullrequestreview-334050859
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191218/ad53cac9/attachment.html>


More information about the rails-dev mailing list