[openstreetmap/openstreetmap-website] Travis build failing on erblint (#2472)

Andy Allan notifications at github.com
Sun Dec 22 10:53:20 UTC 2019


Ah, I was testing on an outdated master branch locally, that explains the discrepancy.

https://github.com/openstreetmap/openstreetmap-website/commit/aa7256d617748e94d1b6295debc58a14819f0eae included an update to rubocop 0.78, which [changes unrecognised cops from a warning to an error](https://github.com/rubocop-hq/rubocop/commit/ff811f0ca7971a6d121e53882130ee9fdee6d705). So a quick workaround would be to pin rubocop to 0.77 for now (and revert https://github.com/openstreetmap/openstreetmap-website/commit/09defac787a33f94579bb8afb43fd7dfda4ed311 for the moment too).

The deeper problem is that erblint doesn't appear to recognise the `Rails/*` and `Performance/*` directives. This is probably a consequence of them being moved out into separate projects. I suspect, but haven't yet tested, that erblint doesn't process [the 'require' directives in the rubocop config](https://github.com/openstreetmap/openstreetmap-website/blob/281d7992f857e7e7c64947a06470898c35035bb6/.rubocop.yml#L3-L5).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2472#issuecomment-568251426
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191222/ed0f3d00/attachment-0001.html>


More information about the rails-dev mailing list