[openstreetmap/openstreetmap-website] Add In-Reply-To, References headers to email (#2462)

Tom Hughes notifications at github.com
Mon Dec 30 21:49:50 UTC 2019


tomhughes commented on this pull request.



>        @author = @from_user
 
       attach_user_avatar(comment.user)
 
+      headers["In-Reply-To"] = @ref
+      headers["References"]  = @ref

I think we could reduce the amount of duplication here by having a `set_references` helper function and then just doing `set_references("diary", comment.diary_entry)` etc in each of the three methods?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2462#pullrequestreview-337248720
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191230/d6074619/attachment.html>


More information about the rails-dev mailing list