[openstreetmap/openstreetmap-website] Adjust testing instructions for change from rcov to simplecov (#2066)

Andy Allan notifications at github.com
Wed Feb 6 17:23:50 UTC 2019


I think I've figured out a way to get both to work at the same time. Reading through the coveralls code, it [sets its own formatter](https://github.com/lemurheavy/coveralls-ruby/blob/8121b40c691821b919846bf17346511459caee57/lib/coveralls.rb#L50) when you run `Coveralls.wear!`. So the multiformatter stuff needs to come after that point.

Here's my proposed solution:

https://github.com/gravitystorm/openstreetmap-website/commit/d43315f738a415823c42e4b7d3df83c1d3aa9263

@krubokrubo does this also work for you?

If so, then I propose that we run both local simplecov generation, and the coveralls stuff, by default. 

However, since local code coverage statistics are not of much interest to most people, I would like to try to silence the simplecov summary output when the tests are run (probably by making a custom formatter and/or overriding the [output_message](https://github.com/colszowka/simplecov-html/blob/a9fe0369d62e95fb9cc838c912346e483b4f4a30/lib/simplecov-html.rb#L28-L30) method). If there's a simple way to suppress this message, then I can make a pull request.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2066#issuecomment-461110051
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190206/b66f9fc6/attachment.html>


More information about the rails-dev mailing list