[openstreetmap/openstreetmap-website] Remove require_terms_seen and require_terms_agreed constants (#2097)

[Andy Allan]

We have two constants - [`require_terms_seen` and `require_terms_agreed`](https://github.com/openstreetmap/openstreetmap-website/blob/4b0fed0aa43651026fb4efa39c0409171942e608/config/example.application.yml#L86-L89) - that make significant changes to the way that sign in works, along with other implications for permissions. They are off by default for new deployments, and off for our tests too, but they've been enabled on osm.org for at least the last six years.

I propose removing the constants, to simplify the code and remove one more head-scratcher for new developers. It will probably involve reworking some tests, since most of the tests assume both are off.

As far as I can understand, it won't make a huge difference for custom deployments, since any user created in a custom deployment in the last six+ years will have seen the terms as part of the signup (and most likely accepted them during signup).  It would only affect custom deployments where users were created, without agreeing terms. Which I think is a small likelihood. To be clear, it won't affect osm.org since those constants are [already set in production](https://github.com/openstreetmap/chef/blob/7c28124864b39960cdf89b1b47c16a279fc04022/cookbooks/web/resources/rails_port.rb#L273-L274) to on.

If there is agreement here, or at least no objections, then a PR can be created in order to remove the constants.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2097
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190102/c82be81e/attachment.html>