[openstreetmap/openstreetmap-website] Switch user images to use Active Storage (#2296)

[Andy Allan]

Great! All looks good to me. Hopefully mini_magick doesn't cause as many installation problems as RMagick used to.

Only thing is around cleanups after the tests. The way the tests are currently written the ActiveStorage files get purged, since in the same test after attaching an avatar we switch to gravatar. But if the test was re-written (which it should, really) or new tests added, we could easily end up with files left over on disk, accumulating after test runs.

The [rails docs](https://edgeguides.rubyonrails.org/active_storage_overview.html#discarding-files-stored-during-system-tests) don't have an example for controller tests unfortunately, but going by the others it's not something taken care of automatically.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2296#issuecomment-508094202
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190703/d70ace22/attachment.html>