[openstreetmap/openstreetmap-website] Animated images for traces (#2204)

mmd notifications at github.com
Tue Jun 11 20:56:29 UTC 2019


I think we have one more issue with the points_per_frame calculation, which is visible in the following trace: https://www.openstreetmap.org/user/Waclaw1/traces/3014390
Parts of the trace are newer shown with black with thickness 3.

![3014390](https://user-images.githubusercontent.com/5842757/59306203-1664c380-8c9c-11e9-90aa-b5a26a067baf.gif)


 The issue here is probably that the current points_per_frame logic only applies integer division, so that some points towards the end of a trace might be omitted. Could we change this to something like:

```
      points_per_frame = (num_points / nframes.to_f).ceil
```

Result looks better then:

![136](https://user-images.githubusercontent.com/5842757/59305840-511a2c00-8c9b-11e9-80a6-2bd446083633.gif)






-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2204#issuecomment-501019691
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190611/cdc1a115/attachment.html>


More information about the rails-dev mailing list