[openstreetmap/openstreetmap-website] Adjust submit labels to use built-in i18n handling (#2257)

Andy Allan notifications at github.com
Wed Jun 12 18:45:22 UTC 2019

gravitystorm commented on this pull request.

> @@ -18,4 +18,10 @@ def initialize(*args)
       .to_return(:status => 404)
+  # Phantomjs can pick up browser Accept-Language preferences from your desktop environment.
+  # We don't want this to happen during the tests!
+  setup do
+    page.driver.add_headers("Accept-Language" => "en")
+  end

It was deliberately in this commit, since the change to the issue comments submit button exposed the problem with the language handling in the system tests. So I thought it was useful to put them both in the same commit to fully illustrate why I was doing it and what sort of test it affects - but I can break it into two commits if you prefer.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190612/4d74753f/attachment.html>

More information about the rails-dev mailing list