Re: [openstreetmap/openstreetmap-website] [WIP] XML generation: nodes, ways, relations, map controller → view (#2223)

mmd notifications at github.com
Wed Jun 26 19:49:10 UTC 2019


> Do you really need || "" in all these render calls? I suspect (but haven't tested) that most calls will work without them.

If you take `/map` as an example, the call might actually fail with "_API threw unexpected ActionView::Template::Error exception: no implicit conversion of nil into String_", in case there are only nodes and ways, but no relations in the bbox, and you don't supply ` || "" ` as a fallback.

Pretty much the same applies to /nodes, /ways, and /relations, which could return some empty result. HIstory and version calls might not return anything in case of redacted object versions. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2223#issuecomment-506019631
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190626/e0772afc/attachment.html>


More information about the rails-dev mailing list