[openstreetmap/openstreetmap-website] Update coveralls.io settings (#2178)

Andy Allan notifications at github.com
Thu Mar 14 11:44:10 UTC 2019


We use coveralls on our pull requests, and any reduction in test coverage marks that pull request as failed. However, for small changes in coverage (like 0.07%) we generally ignore this and merge the PR anyway. That can lead to ignoring larger changes in coverage, and it's unhelpful for new developers to see their PRs marked as failed for tiny coverage changes.

I've been digging around and there are two settings on coveralls.io that we can change (and that it turns out I have access to change, yay!).

* Coverage Threshold for failure (currently blank)
* Coverage Decrease Threshold for failure (currently blank)

Our current coverage is around 88%. I propose:

* Coverage Threshold for failure: 85%
* Coverage Decrease Threshold for failure: 0.5%

Any thoughts on this?




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2178
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190314/1acc957e/attachment.html>


More information about the rails-dev mailing list