[openstreetmap/openstreetmap-website] Various Erblint fixes (#2187)

[Andy Allan]

This PR contains various fixes highlighted by erblint. I've only done part of the string literals fixes today, since there's quite a few more to go, to put it mildly.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2187

-- Commit Summary --

  * erblint: use hash rocket syntax
  * erblint: Add or remove curly braces around hash parameters as required
  * Exclude most views from string literal checks
  * erblint: prefer double quoted strings
  * erblint: avoid parentheses for method calls with no arguments

-- File Changes --

    M .erb-lint.yml (25)
    M app/views/browse/_common_details.html.erb (2)
    M app/views/browse/_node.html.erb (2)
    M app/views/browse/_relation_member.html.erb (2)
    M app/views/browse/_way.html.erb (4)
    M app/views/browse/changeset.html.erb (6)
    M app/views/diary_entries/comments.html.erb (4)
    M app/views/diary_entries/index.html.erb (4)
    M app/views/issues/_comments.html.erb (2)
    M app/views/issues/index.html.erb (2)
    M app/views/issues/show.html.erb (6)
    M app/views/layouts/_head.html.erb (18)
    M app/views/layouts/_search.html.erb (8)
    M app/views/layouts/notifier.html.erb (2)
    M app/views/messages/_message_summary.html.erb (6)
    M app/views/messages/_sent_message_summary.html.erb (2)
    M app/views/notes/_notes_paging_nav.html.erb (4)
    M app/views/notifier/_message_body.html.erb (10)
    M app/views/reports/new.html.erb (2)
    M app/views/site/about.html.erb (8)
    M app/views/site/copyright.html.erb (38)
    M app/views/site/edit.html.erb (10)
    M app/views/site/export.html.erb (44)
    M app/views/site/fixthemap.html.erb (2)
    M app/views/site/help.html.erb (2)
    M app/views/site/id.html.erb (4)
    M app/views/site/index.html.erb (2)
    M app/views/site/key.html.erb (2)
    M app/views/site/offline.html.erb (4)
    M app/views/traces/_trace.html.erb (2)
    M app/views/traces/_trace_paging_nav.html.erb (4)
    M app/views/traces/show.html.erb (4)
    M app/views/user_blocks/_blocks.html.erb (4)
    M app/views/user_blocks/show.html.erb (2)
    M app/views/users/account.html.erb (4)
    M app/views/users/login.html.erb (4)
    M app/views/users/lost_password.html.erb (2)
    M app/views/users/new.html.erb (14)
    M app/views/users/reset_password.html.erb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2187.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2187.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2187
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190327/d14d81d0/attachment.html>