[openstreetmap/openstreetmap-website] Give the changesets_count in changeset metadata (#2224)

[Andy Allan]

iD adds a "changesets_count" tag to every changeset it creates. This can be used by QA tools, and is intended as a hint to other mappers when dealing with mistakes.

I'm in favour of the concept (of providing additional context to the changeset), but I'm not keen on the current implementation. It is not additional data, it's just using the changeset tags to display information that is already held elsewhere in the database. It's a close equivalent of adding a "latitude" tag to a node.

So we should show the changesets_count in the changeset metadata, and avoid having to store all these additional tags in the database. Doing so centrally will also mean that the information is available for every changeset, and avoids every other editor from having to duplicate the logic from iD.

We could do this in two different ways:
* With a sufficiently smart SQL query that, for a given changeset, works out which changeset this is for the given user, or
* Adding a changeset_count bigint to the changesets table

The second one seems like it's also duplicating data, but at least it would be a lot less overhead to store an extra integer per changeset than an extra changeset_tag record!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2224
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190513/30398421/attachment.html>