[openstreetmap/openstreetmap-website] Remove SWF gpx trackpoints feature for Potlatch1 (#2228)

mmd notifications at github.com
Sun May 19 13:25:16 UTC 2019


This pull request removes the SWF gpx trackpoints feature which is only used to fetch gpx trackpoints in Potlatch 1. The code showed up in a static code check tool, and I was able to trigger segfaults.

Due to its limited use today, I didn't see much reason to even try and fix it. Potlatch1 would still continue to function, e.g. for people using with the Undelete function. However, the "G" (for gpx background) will cease to work. I think that's totally acceptable given the alternatives available.

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2228

-- Commit Summary --

  * Remove SWF gpx trackpoints feature for Potlatch1

-- File Changes --

    M app/abilities/api_ability.rb (1)
    D app/controllers/api/swf_controller.rb (218)
    M config/routes.rb (1)
    D test/controllers/api/swf_controller_test.rb (46)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2228.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2228.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2228
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190519/ae873002/attachment.html>


More information about the rails-dev mailing list