[openstreetmap/openstreetmap-website] Ignore the users.nearby column (#2432)

Andy Allan notifications at github.com
Thu Nov 14 12:57:57 UTC 2019


> Well if you really want to pander to `strong_migrations` extremist nonsense...

I'm surprised by your attitude here @tomhughes, it's not very helpful. 

Without doing this, if we just ran the migration to drop the column, then anyone in the middle of doing anything with a User object (i.e. already read from the database and then writing to the database) can receive an error. Creating a user, updating their preferences, etc. So you run the migration, and people see errors. I want to avoid that.

I don't consider this to be "pandering to ... extremist nonsense" and it's a) a  pretty trivial solution and b) not something that I'm burdening you with.

If I haven't yet convinced you that `strong_migrations` is useful, then fine, you don't have to agree. But I find it useful, and I like doing migrations properly, so I'll continue to use it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2432#issuecomment-553876590
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191114/078a0553/attachment.html>


More information about the rails-dev mailing list