[openstreetmap/openstreetmap-website] Switch to using jbuilder for JSON templates (#2434)
Tom Hughes
notifications at github.com
Thu Nov 14 19:42:56 UTC 2019
It looks like `jsonify-rails` is pretty dead upstream while `jbuilder` is much more alive and is the suggested solution added to all new rails projects by default.
It does use a slightly different format for timestamps which I have currently accepted for the notes API but maybe we should force the old format?
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/2434
-- Commit Summary --
* Switch to using jbuilder for JSON templates
-- File Changes --
M Gemfile (3)
M Gemfile.lock (9)
R app/views/api/notes/_note.json.jbuilder (0)
R app/views/api/notes/index.json.jbuilder (2)
A app/views/api/notes/show.json.jbuilder (1)
D app/views/api/notes/show.json.jsonify (1)
R app/views/messages/destroy.json.jbuilder (0)
R app/views/messages/mark.json.jbuilder (0)
M test/controllers/api/notes_controller_test.rb (2)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/2434.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2434.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2434
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191114/39553055/attachment.html>
More information about the rails-dev
mailing list