[openstreetmap/openstreetmap-website] WIP Parallel tests (#2448)

[Andy Allan]

I spent some time trying to get the parallel tests to work. The main problem is surrounding the trace tests, since they make assumptions about removing files during the teardown stage. Since all the tests share the same directory, this causes test failures when one test is tearing down while the other is still using the dir.

I've reworked it so that the tests each get their own unique directory, using Dir.mktmpdir.

 However, this appears to introduce some flakeyness to the test suite, and I'm not sure why. I'm sharing this WIP to see if other people also see the flakey tests, see what Travis says, and see if anyone has any better ideas!
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2448

-- Commit Summary --

  * Use the settings for the destination of the gpx fixture symlinks
  * Use unique test directories for each trace test
  * Enable parallel tests

-- File Changes --

    M test/controllers/api/traces_controller_test.rb (15)
    M test/controllers/traces_controller_test.rb (15)
    M test/factories/traces.rb (6)
    M test/models/trace_test.rb (15)
    M test/test_helper.rb (3)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2448.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2448.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2448
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191127/8848707f/attachment.html>