[openstreetmap/openstreetmap-website] Sort and order notes (#2381)

Tom Hughes notifications at github.com
Thu Oct 3 14:24:26 UTC 2019

There's no need to expose raw field names or SQL terms in the API like that - just use `order=newest` and `order=oldest` or something.

Also try to avoid text interpolation into queries like that unless it's absolutely necessary - yes I know it's safe here, but I'd rather just see a conditional block that chains on the right order statement to the query for each possible sort order.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191003/6ef13631/attachment.html>

More information about the rails-dev mailing list