[openstreetmap/openstreetmap-website] web_timeout needs to handle layout=false (#2399)
notifications at github.com
Wed Oct 16 13:28:36 UTC 2019
We surround certain web requests with a timeout handler. (API requests are handled separately). However, it returns a full web page with layout, which can lead to unexpected results when an html fragment was expected.
For example, `app/controllers/changesets_controller.rb#index` normally does a
render :action => :index, :layout => false
But when it times out you get a mess like this:
![Screenshot from 2019-10-16 12-13-34](https://user-images.githubusercontent.com/360803/66922716-e5b8e000-f027-11e9-9311-cd79c0595af7.png)
It might be possible to solve with refactoring in the controllers, so e.g. using 'layout false' at the class level instead of on individual `render` calls.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the rails-dev