[openstreetmap/openstreetmap-website] Make 'back' button not look disabled. (#2386)

Andy Allan notifications at github.com
Wed Oct 16 15:46:45 UTC 2019


So that was the general point, but I want to make specific comments about this situation. In general, it's a very bad idea to have things that look like buttons but aren't really buttons i.e. they don't change state. The "Back" link in question is really just a link, and so it shouldn't be a button in the first place, never mind discussing whether it's emphasised or not.

Of course, from a design point of view it's nice if they all line up, have the same margins, and so on. It's very common at the bottom of a form to have a cancel "button", even when it's not a form submission, to make life easy and make things look consistent. (OSM sadly lacks these in most places).

Going back to bootstrap - they have a standard "link" button. It works well in my experience, and it's what we need here, if you ask me. 

So we should create a button styling that works in the same way as bootstrap's "btn btn-lnk", and use it here. Meanwhile we should change the "demphasized" button type to avoid making it look like a disabled button too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2386#issuecomment-542766426
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191016/fe02695a/attachment.html>


More information about the rails-dev mailing list