[openstreetmap/openstreetmap-website] Fix installation instructions for Mac OS X (#2403)
notifications at github.com
Mon Oct 21 09:45:15 UTC 2019
> I just wanted to check from everyone, including @gravitystorm, that everyone agrees that the usability trade-off is worth it.
No, I don't agree that the trade-off is worth it. Our codebase has a minimum version of ruby, but no particular needs for that specific version (i.e. 2.6 is fine, 2.7 will be fine, etc). Modern bundler sorts out making sure all the gems are in order (i.e. not running a copy of a gem compiled against a different ruby version), so that major feature of rbenv is unnecessary too.
I haven't run any kind of ruby manager since the whole ruby1.8 / 1.9 / 2.0 mess, and I work on plenty of different projects with different minimum ruby versions!
Of course, if someone prefers rbenv, be my guest. But like non-standard postgresql configs, I don't think we should confuse our installation notes with non-standard ruby setups or setups that require multiple optional steps.
> 2\. `sudo gem2.5 install bundler` is what the install docs currently recommend on Ubuntu.
This needs a review. I'm not sure why we're installing the bundler package and then installing bundler again via rubygems - maybe for hysterical raisins? If the Xenial version of bundler is too old (not sure that it is) then we shouldn't be installing it anyway - but if it's fine, there's no need for the gem install version.
> Also updated the instructions for `phantomjs` -- do we even use this anymore?
Yes, in the [system tests](https://github.com/openstreetmap/openstreetmap-website/blob/master/test/application_system_test_case.rb). But migrating to one of the headless webdriver things is another topic worth working on.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the rails-dev