[openstreetmap/openstreetmap-website] Add static code checks in Travis CI (#2229)

Andy Allan notifications at github.com
Wed Oct 30 10:56:26 UTC 2019


> Is there no better way of suppressing warnings than that monstrosity of a JSON file that lists each one in excruciating detail?

I've investigated the alternative options. Brakeman only supports one config file at a time - so even though it reads `./config/brakeman.yml` by default, if you pass another one on the command line, the original file is ignored. This makes it impossible to work the way we have with rubocop, where we have separate files for TODO and 'permanent' ignores. But the config file is yml, which supports comments, so we can split it into two sections using comments if required.

In 6e62531b68ff0ff62eb0a944f0c6d35054b13c27 I removed the ignore json file, and ignored all the checks that are currently causing warnings, but marked them as todo using a comment. Again, it's not as flexible as rubocop, so there's no way to disable a class of warning just for specific files, so this approach runs the risk of introducing similar bugs in new commits while the check is globally disabled.

What do you think? I'm happy with either option.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2229#issuecomment-547844975
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191030/98c54158/attachment-0001.html>


More information about the rails-dev mailing list