[openstreetmap/openstreetmap-website] Add link to my messages to users/show navigation (#2373)

Tobias notifications at github.com
Sun Sep 22 17:51:52 UTC 2019


The my messages page can be accessed via the user dropdown, but not via the user navigation on my logged in user-profile page. This adds the link when logged in to have a consistent access to all my sub-pages.

# Current header

<img width="958" alt="Bildschirmfoto 2019-09-22 um 19 47 49" src="https://user-images.githubusercontent.com/111561/65392162-ee443080-dd71-11e9-8d3e-7d9e4f766da8.png">

# New header

<img width="932" alt="Bildschirmfoto 2019-09-22 um 19 47 57" src="https://user-images.githubusercontent.com/111561/65392169-f7cd9880-dd71-11e9-8438-5f36f4dfcb2f.png">

--- 

# Open questions

- [ ] The new navi uses the same translation string as the dropdown (as do all those links). The german translation for the `.my messages` only says "Nachrichten" (EN: Messages). This is consistent in the dropdown, but not on the user-page. Suggestion: Duplicate the translations in all languages so the dropdown can have it's own variation. Right now the dropdown forces the translation with `<%= t("users.show.my messages") %>`

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2373

-- Commit Summary --

  * Add link to my messages to users/show navigation

-- File Changes --

    M app/views/users/show.html.erb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2373.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2373.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2373
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190922/a502a72a/attachment.html>


More information about the rails-dev mailing list