[openstreetmap/openstreetmap-website] Ensure that urls are only valid if the entire string is a url (#2579)

Andy Allan notifications at github.com
Wed Apr 1 15:59:01 UTC 2020


Replacement PR for #2570 and #2578 

This replaces our homegrown regexps (that didn't quite work) with ruby built-in regexps, and uses the termination anchor to ensure that the entire string, not just the first part, is validated.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2579

-- Commit Summary --

  * Ensure that urls are only valid if the entire string is a url

-- File Changes --

    M app/models/client_application.rb (6)
    M test/models/client_application_test.rb (6)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2579.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2579.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2579
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200401/83ea33ee/attachment.htm>


More information about the rails-dev mailing list