[openstreetmap/openstreetmap-website] Refactor more controller tests (#2605)

[Andy Allan]

For the changesets_controller_test, I introduced a few more route aliases. I'm not super keen on some of them (like api_node) but that's to distinguish them from the non-api method that already has the name. Refactoring the routes is left for the future.

The two new helper methods will replace the existing ones, we only need both sets during the transition.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2605

-- Commit Summary --

  * Refactor more controller tests
  * Refactor changesets_controller_test

-- File Changes --

    M config/routes.rb (8)
    M test/controllers/api/capabilities_controller_test.rb (4)
    M test/controllers/api/changes_controller_test.rb (18)
    M test/controllers/api/changesets_controller_test.rb (361)
    M test/test_helper.rb (10)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2605.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2605.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2605
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200429/40a329cc/attachment.htm>