[openstreetmap/openstreetmap-website] Bootstrap forms (#2782)

Andy Allan notifications at github.com
Wed Aug 19 13:07:23 UTC 2020


This refactors the reports, issues and client_application forms to use Bootstrap form components.

The bootstrap_form `collection_radio_buttons` helper expects a group of objects that respond to methods, so we can't use the array of report category strings directly. I think the helper method is the best approach to this, since it leaves the form itself easy to read.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2782

-- Commit Summary --

  * Refactor reports form to use bootstrap
  * Rework issue search form to use Bootstrap form layout
  * Avoid showing table header when there are no results
  * Refactor client application pages to use bootstrap forms

-- File Changes --

    M app/helpers/reports_helper.rb (9)
    M app/views/issues/index.html.erb (105)
    M app/views/oauth_clients/_form.html.erb (38)
    M app/views/oauth_clients/edit.html.erb (3)
    M app/views/oauth_clients/new.html.erb (9)
    M app/views/oauth_clients/show.html.erb (48)
    M app/views/reports/new.html.erb (35)
    M config/locales/en.yml (38)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2782.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2782.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2782
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200819/d0cd1aa7/attachment.htm>


More information about the rails-dev mailing list