[openstreetmap/openstreetmap-website] Improve guessing of labels for Nominatim results (#2989)

Sarah Hoffmann notifications at github.com
Tue Dec 1 22:12:29 UTC 2020


This adapts to two changes in place handling by Nominatim:

* Place links that are computed by Nominatim are now found in extratags['linked_places']. Keep the check for extratags['place']
  as this may contain an explicitly mapped place label.
* Use address rank for guessing the boundary type. This gets normalised by Nominatim with respect to country-specific use of admin_level.

Also adds additional labels for admin levels, so that we now have complete coverage for all levels that are in use in OSM.

I would have liked to avoid the long line but rubocop insisted on using a modifier if.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2989

-- Commit Summary --

  * Improve guessing of labels for Nominatim results

-- File Changes --

    M app/controllers/geocoder_controller.rb (4)
    M config/locales/en.yml (3)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2989.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2989.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2989
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201201/5d38079a/attachment.htm>


More information about the rails-dev mailing list