[openstreetmap/openstreetmap-website] Add Docker Compose Support for Development Environment (#2409)
Andy Allan
notifications at github.com
Thu Dec 17 16:35:55 UTC 2020
Ah, sorry, perhaps I wasn't clear. I wasn't referring to any CI-related matters. I mean that when you use this Docker configuration to set up a local development environment, you need to have multiple databases:
* A development database, called `openstreetmap`, that I know is created by the env vars
* One or more (probably more) test databases, so that you can run the test suite (or parts of it) locally before committing changes.
So my concern is that they way this has been written, where the env vars set up only one database, and they `openstreetmap` postgres role is not a super user, means that the test suite will not run on your laptop.
For our INSTALL.md and Vagrant approaches, the postgres role used in the test configuration has enough permissions to create whichever databases are required when the test suite runs
> As an occasional contributor, I never run the test suite locally and rely on the CI to do it for me.
Well I hope that this will be made easier by having a Docker-based development environment for you :smile: As per the notes, running `docker-compose run --rm web bundle exec rake test:db` should be enough.
To be double-clear, I'm not asking that the full test suite runs in Docker as part of the CI system. I'm not interested in that. But I'm asking that the test suite works when I run the above command on my laptop.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2409#issuecomment-747554493
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201217/f3adf40b/attachment-0001.htm>
More information about the rails-dev
mailing list