[openstreetmap/openstreetmap-website] Add button styles to edit-diary-entry-button (#3019)

Andy Allan notifications at github.com
Mon Dec 28 11:49:43 UTC 2020


@gravitystorm commented on this pull request.

This seems like a straightforward PR, but unfortunately it opens a can of worms.

As @mmd-osm notes, this proposal breaks the diary list pages, which uses the same partial. I'm not sure what the best solution is here, since I'm happy to move from links to buttons to denote 'actions' (and trying to edit a diary entry seems like an 'action' to me). Perhaps one solution is to use two different partials, and make the diary list a "summary" of each entry (e.g. with a max word limit) rather than including the entire entry. Or alternatively, perhaps we keep the partial just for the summaries, and move the "full display" directly into the view.

Beyond that, one more minor point:
* The need for pt-3 and mt-3 is not clear. I think the pt-3 is because the location partial is "bare", i.e. text not wrapped in a paragraph, and so I would look into changing the html first, to avoid needing any explicit padding/margins.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3019#pullrequestreview-559112711
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201228/ec5077a6/attachment.htm>


More information about the rails-dev mailing list