[openstreetmap/openstreetmap-website] fix welcome message (#2537)

Anton notifications at github.com
Fri Feb 14 14:52:47 UTC 2020


> We're trying to move away from having custom css, and in particular custom header sizes, so I'm not keen on this solution.

OK.


> How does this message compare with the other sidebars that have a header and a close icon? 
Does the same problem appear there? 

not testing.

> Should the positioning of the close icon be improved or use a different approach?

need use different position type, all elements need one flow, and remove all position absolute
https://getbootstrap.com/docs/4.0/components/modal/#modal-components good example 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2537#issuecomment-586321301
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200214/2db0e554/attachment.htm>


More information about the rails-dev mailing list