[openstreetmap/openstreetmap-website] Make email values a link in object detail mode (#1689)

Boubacar notifications at github.com
Sun Feb 16 11:10:09 UTC 2020


Are there no still pull requests or people working on this at the moment?

I found the implementation of phone value linking in [app/helpers/browse_tags_helper.rb](https://github.com/openstreetmap/openstreetmap-website/blob/master/app/helpers/browse_tags_helper.rb) and wrote a quick function there for emails to see if it would do what I thought, and it seems to achieve what you meant.

I have to look more into email validation so I can figure out how restrictive to make the email regex match. I also need to clean up and of course add tests, but I'd like to make a pull request for this.

 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1689#issuecomment-586693745
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200216/4c28521b/attachment.htm>


More information about the rails-dev mailing list