[openstreetmap/openstreetmap-website] Show mailto: links for an email or emails separated by ; (#2542)

Andy Allan notifications at github.com
Tue Feb 18 10:04:50 UTC 2020


Generally I prefer to avoid adding lots of code, and gigantic regexps count as lots and lots of code!

Ruby has a built-in regexp for email validation, namely `URI::MailTo::EMAIL_REGEXP` which is recommended for most situations. That way, someone else can be in charge of maintaining and debugging the regexp.

https://stackoverflow.com/questions/22993545/ruby-email-validation-with-regex

I'm not sure if that will work with the semi-colon delineated approach, but it's worth seeing if it can be made to work since I think it's much simpler, easier to read, and less to maintain.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2542#issuecomment-587379357
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200218/3b120a88/attachment-0001.htm>


More information about the rails-dev mailing list