[openstreetmap/openstreetmap-website] Add dark theme for OSM site and ID editor, depending on color theme (#2532)

Andy Allan notifications at github.com
Wed Feb 19 11:02:13 UTC 2020


Thanks for the PR, but I'm going to decline this approach. This approach, of having lots of overrides and !important flags and so on is fine when a user style is the only available option. But that's not a good approach when we have full control over the CSS sent to the user.

Also, 1630 lines of CSS is not something I want to maintain. To implement a dark mode, I would ideally like to see out-of-the-box support from bootstrap itself. If that's not available, then maybe 10-20 lines of code to set some colour variables, but little more than that. Anything more complex will be too much to maintain for a low-priority feature like this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2532#issuecomment-588163551
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200219/2070dbf4/attachment.htm>


More information about the rails-dev mailing list