[openstreetmap/openstreetmap-website] JSON output nodes, ways, relations, map (#2485)

Tom Hughes notifications at github.com
Wed Feb 26 15:34:45 UTC 2020


I assume @gravitystorm has looked at the actual JSON being generated and is happy with that so I'm not going to do into that in any detail, and the basics of the changes to the controllers mostly look sensible enough.

My real concerns are around `set_default_request_format` both from the point of view of having to call it in all the controllers and also the actual code that is in it - there really ought to be a better solution and I was planning to do some investigation of the problem but it will require some serious deep diving in the rails code I suspect.

At the very least I want to go through what is there with a fine toothed comb and make sure I understand what it is doing before we think about deploying this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2485#issuecomment-591487981
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200226/481e05e2/attachment.htm>


More information about the rails-dev mailing list