[openstreetmap/openstreetmap-website] add box shadow for header in mobile (#2535)
notifications at github.com
Wed Feb 26 17:28:59 UTC 2020
gravitystorm requested changes on this pull request.
I think the shadow is a great idea, since it's really visually confusing with the header and the "sidebar" (e.g. search results) blending together, particularly when the sidebar is scrolled.
However, I have two requests:
* We should use a border shadow of the same colour and (ideally) size as [those available in bootstrap](https://getbootstrap.com/docs/4.4/utilities/shadows/). I tested with the bootstrap border-sm and it looks like the best option. This way, if we introduce shadows in other parts of the site in future, they will be consistent.
* As implemented, the shadow appears on all pages. This looks unnecessary when the header scrolls away with the content (e.g. on the copyright page). It's also unnecessary on the front page when there's no sidebar shown. So I'd like to see if it works better by only showing the shadow when a) the sidebar is shown on the front page and/or b) the menu is open on the front page. That would mean the shadow is only shown when some content is hidden behind it, which I think makes the most sense. If there's nothing hidden behind it (either the top bar, or the open menu) then there's no need for the shadow.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the rails-dev