[openstreetmap/openstreetmap-website] Avoid double-escaping display names through the translation system (#2500)

Andy Allan notifications at github.com
Wed Jan 8 18:15:01 UTC 2020


They are escaped properly without the h() call, and doing that just double-escapes them.

As part of #2494 I set my local users to have all kinds of weird usernames, and today I spotted some places where they are being double-escaped. I suspect that almost all our uses of h() have been redundant since rails 3.x, but I haven't checked the rest.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2500

-- Commit Summary --

  * Avoid double-escaping display names when sent through the translation system

-- File Changes --

    M app/views/diary_entries/show.html.erb (2)
    M app/views/messages/new.html.erb (2)
    M app/views/user_blocks/blocks_by.html.erb (4)
    M app/views/user_blocks/edit.html.erb (4)
    M app/views/user_blocks/new.html.erb (2)
    M app/views/users/no_such_user.html.erb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2500.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2500.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2500
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200108/7a114e35/attachment.htm>


More information about the rails-dev mailing list