[openstreetmap/openstreetmap-website] Cleanup custom CSS (#2508)

[Andy Allan]

This PR contains some changes that clean up our custom CSS rules.

* Rename form-row to standard-form-row, since form-row clashes with a class in the bootstrap forms component (and so things go badly awry when enabling the forms component).
* Rework lists to assume that they have margin+discs by default. It's easier to override them in the few cases that we don't want that to happen (e.g. forms, nav links) and the number of overrides is likely to decrease anyway as we use more bootstrap components
* Remove the custom reset code. Bootstrap contains its own reset, so there's nothing to be gained by resetting things again.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2508

-- Commit Summary --

  * Rename form-row to standard-form-row to avoid clashing with a bootstrap class
  * Remove list style reset, and add overrides where necessary
  * Remove some reset styles and clearfix
  * Remove more reset styles that are handled by bootstrap
  * Remove last custom reset styles

-- File Changes --

    M app/assets/javascripts/leaflet.share.js (14)
    M app/assets/stylesheets/common.scss (140)
    M app/views/browse/changeset.html.erb (6)
    M app/views/diary_entries/_form.html.erb (8)
    M app/views/issues/show.html.erb (2)
    M app/views/messages/new.html.erb (4)
    M app/views/oauth_clients/_form.html.erb (10)
    M app/views/reports/new.html.erb (14)
    M app/views/traces/edit.html.erb (16)
    M app/views/traces/new.html.erb (8)
    M app/views/users/account.html.erb (28)
    M app/views/users/login.html.erb (6)
    M app/views/users/new.html.erb (14)
    M app/views/users/terms.html.erb (10)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2508.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2508.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2508
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200115/c0d7419b/attachment.htm>