[openstreetmap/openstreetmap-website] Use bootstrap for dropdowns and tooltips (#2524)

[Andy Allan]

This PR switches to using bootstrap for dropdowns and tooltips. It allows us to drop the CSS and Javascript files that we've vendored.

I wanted to do these as two steps, but they both depend on the same javascript files and so it was easier to do them together. Additionally, there was a bit of rework required for the button groups and dropdowns, both because of differing html requirements between the two versions, and also a bit of CSS overrides since our main navigation uses different colours than the rest of the site. Also, three menus are tricky to get right at the same time, particularly when playing with screen widths!

Anyway, I covered every edge case that I could find, and it all seems to be working as intended. After this, I think we can enable the rest of the bootstrap components without any conflicts.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2524

-- Commit Summary --

  * Switch to bootstrap for dropdowns and tooltips
  * Tweak positioning of inbox count on the user menu button
  * Styling for disabled edit button
  * Don't highlight border when hovering on user-menu button
  * Further tweaks to the navigation dropdown button colours
  * Tweak the dropdown menu hover and active colours

-- File Changes --

    M app/assets/javascripts/application.js (4)
    M app/assets/stylesheets/_bootstrap-custom.scss (12)
    D app/assets/stylesheets/bootstrap-tooltips.css (83)
    M app/assets/stylesheets/common.scss (298)
    M app/assets/stylesheets/screen-ltr.css (1)
    M app/assets/stylesheets/screen-rtl.css (1)
    M app/assets/stylesheets/small.scss (16)
    M app/views/layouts/_header.html.erb (109)
    M app/views/layouts/map.html.erb (2)
    D vendor/assets/bootstrap/bootstrap.dropdown.js (161)
    D vendor/assets/bootstrap/bootstrap.tooltip.js (472)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2524.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2524.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2524
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200129/b695e90d/attachment.htm>