[openstreetmap/openstreetmap-website] Use bootstrap for dropdowns and tooltips (#2524)

Andy Allan notifications at github.com
Thu Jan 30 09:17:23 UTC 2020


> I think it wasn't clear to me if _"I covered every edge case that I could find, and it all seems to be working as intended"_ would imply that the styling didn't change as much.

So the edge cases were things like "If I click on the edit menu dropdown, then the border colour reverts to blue" and "If I click on the edit menu dropdown, then with the dropdown open I click outside the browser area, then the dropdown button background reverts to blue" - those are things that were clearly ugly and are the types of edge cases that found and fixed. 

Other things like the colour scheme for tooltips or exactly how grey a background colour is on the signup button - those kind of changes I would call 'semi-deliberate'. By that I mean, they are changes to the defaults that I'm aware of and that I'm happy to accept since I think they look fine.

I'm always happy to hear feedback on these things though, there's so many edge cases (particularly with dropdowns) that I'm sure some styling bugs will slip through now and then.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2524#issuecomment-580158449
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200130/4cac7311/attachment.htm>


More information about the rails-dev mailing list