[openstreetmap/openstreetmap-website] Add microcosms to the website (#2390)

Andy Allan notifications at github.com
Fri Jan 31 14:42:40 UTC 2020


Great to see more progress on this @openbrian !

I saw some things that caught my eye in the last few updates, for example:

* hardcoding webdriver stuff in the travis config, vs e.g. https://github.com/titusfortner/webdrivers 
* even more cucumber tests being added, vs using our existing test suites
* lots of CSS and hardcoded layout stuff, vs using bootstrap for responsive layouts
* other stuff we've discussed previously, like hardcoded values in factories

I want to try to nudge you towards making this PR something that we can discuss and merge, rather than it ever-expanding project that is seemingly not approaching a merge-able state! Basically I have worries that this is following the same path as the GSoC Moderation branch, where it took me 11 months of work on the PR after the original contributor had moved on, and I don't want the same thing to happen again here.

What do you think? What can I do to help?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2390#issuecomment-580761189
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200131/c90e67b2/attachment.htm>


More information about the rails-dev mailing list